[PATCH] D94820: Support for instrumenting only selected files or functions

phosek created this revision. phosek added reviewers: davidxl, vsk, gulfem. Herald added subscribers: dexonsmith, wenlei, dang, jdoerfert, steven_wu, hiraditya, mgorny. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl added a comment. In D85223#2452363 , @JonChesterfield wrote: > I concede that making the variables external, and trying to give them unique > names, does work around static variables not working. I believe static > variables are subjected to

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

kuhar added a comment. Wow, this is fantastic. When I first started working on the domtree updater back in 2017, SimplifyGFG seemed like one of the most difficult passes to handle, and I wasn't sure if we ever get there. Very impressive work, @lebedev.ri! Repository: rG LLVM Github

[clang] a1be47b - [CodeView][DebugInfo] Add test case to show that linkage names are not

Author: Amy Huang Date: 2021-01-15T12:05:33-08:00 New Revision: a1be47b4771467998d7549dcd1b9f9cebdaa9af9 URL: https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9 DIFF: https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9.diff

[PATCH] D94825: [NewPM]i[Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin created this revision. mtrofin added a reviewer: aeubanks. Herald added subscribers: hiraditya, eraman. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Expanding from D94808

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.org/D94829 ___

[PATCH] D94825: [NewPM]i[Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin updated this revision to Diff 317085. mtrofin added a comment. patched tests other than Other/ ones. We want to rationalize emitting remarks, see also D94334 ; I'd prefer first landing the always inlining refactoring, because that would impact the

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} Is it possible to check that we imported four fold

[clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Author: Christopher Di Bella Date: 2021-01-15T21:38:47Z New Revision: 4a47da2cf440c2f2006d9b04acfef4292de1e263 URL: https://github.com/llvm/llvm-project/commit/4a47da2cf440c2f2006d9b04acfef4292de1e263 DIFF:

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Couple of optional pieces. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit =

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks added a comment. *ping* And I don't have a better name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 ___ cfe-commits mailing list

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin marked 2 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always ==

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. A concern I have is that the round-tripping might be too low level since it requires each group of options to opt-in somehow. Having something at the top-level that doesn't have to be touched again would be easier to validate / understand, and might better serve the

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

lebedev.ri created this revision. lebedev.ri added reviewers: fhahn, jdoerfert, arsenm, mkazantsev, kuhar, brzycki, nikic. lebedev.ri added projects: LLVM, AMDGPU. Herald added subscribers: wenlei, kerbowa, steven_wu, hiraditya, nhaehnle, jvesely. lebedev.ri requested review of this revision.

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks added a comment. In D93986#2495561 , @MyDeveloperDay wrote: > I think I would remove the code examples from the "AlignConsecutive style" to > avoid confusion (that would be the first change) > > then perhaps regenerate and update the

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

justice_adams created this revision. justice_adams added reviewers: nigelp-xmos, aaron.ballman. justice_adams added a project: clang. justice_adams requested review of this revision. This test will fail with any toolchains that don't default to C11. Adding this switch to the clang invocation in

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks added a comment. overall looks good, just a couple small comments Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always ==

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit = Loc.isValid() ? getOrCreateFile(Loc) : nullptr; + const unsigned Line = getLineNumber(Loc);

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin updated this revision to Diff 317133. mtrofin added a comment. Herald added subscribers: wenlei, steven_wu. updated with all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94825/new/ https://reviews.llvm.org/D94825 Files:

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple created this revision. varungandhi-apple added reviewers: aschwaighofer, rjmccall. Herald added a subscriber: jfb. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes rdar://72999296. Repository:

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple added a comment. I don't know how to test this on the LLVM-side (is there a way to do it?). Here's the Swift side test which trips over right now (but is fixed with this patch) by attempting a zext from an i8 to an i1 in Swift's `NativeConventionSchema::mapIntoNative`. +++

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a comment. > This patch also refactors OverlayFileSystem's directory iterator > implementation (OverlayFSDirIterImpl) and VFSFromYamlDirIterImpl into a > single implementation, addressing a FIXME about their conceptual similarity. Can the `OverlayFSDirIterImpl` part be split

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan added a comment. In D91466#2395297 , @pcc wrote: > How does Zircon handle tagged addresses in syscalls? Are they handled > equivalently to Linux's tagged address ABI? Woops, accidentally let this slide. I'm guessing you saw this in the

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 317157. nathawes edited the summary of this revision. nathawes added a comment. Moved the change combining OverlayFSDirIterImpl and VFSFromYamlDirIterImpl in a single implementation into a separate NFC patch (https://reviews.llvm.org/D94857) CHANGES

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94808/new/ https://reviews.llvm.org/D94808 ___ cfe-commits

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 ___ cfe-commits

[clang] be68c92 - [NFC] Add -std=c11 to attr-availability.c

Author: Douglas Yung Date: 2021-01-15T21:05:49-08:00 New Revision: be68c9222b85815612e6bd8bc606a87e3111a0fb URL: https://github.com/llvm/llvm-project/commit/be68c9222b85815612e6bd8bc606a87e3111a0fb DIFF: https://github.com/llvm/llvm-project/commit/be68c9222b85815612e6bd8bc606a87e3111a0fb.diff

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe68c9222b85: [NFC] Add -std=c11 to attr-availability.c (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin marked 2 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always ==

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes created this revision. nathawes added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. nathawes requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously file entries in the

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 317118. leonardchan added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. Locally I'm able to build and run the `bringup.arm64` config (that is launch the shell and run some commands). Repository: rG

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

rjmccall added a comment. Hmm. The way you'd test it on the Clang side would be to just write a test case that passes such an aggregate and tests that it's passed as an `i8`. But I'm not sure it's at all unreasonable to pass this as an `i1` rather than an `i8`; seems like something that

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes planned changes to this revision. nathawes added a comment. Yeah, certainly. Let me put that up separately and update this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94844/new/ https://reviews.llvm.org/D94844

[clang] e8049dc - [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

Author: Mircea Trofin Date: 2021-01-15T17:59:38-08:00 New Revision: e8049dc3c8a46ccd75ce2a4f438d695d20feb660 URL: https://github.com/llvm/llvm-project/commit/e8049dc3c8a46ccd75ce2a4f438d695d20feb660 DIFF: https://github.com/llvm/llvm-project/commit/e8049dc3c8a46ccd75ce2a4f438d695d20feb660.diff

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8049dc3c8a4: [NewPM][Inliner] Move the always inliner case in the same CGSCC pass as… (authored by mtrofin). Repository: rG LLVM Github Monorepo

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

justice_adams added a comment. @dyung I don't have commit access, would you mind commiting this for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.org/D94829 ___

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit = Loc.isValid() ? getOrCreateFile(Loc) : nullptr; + const unsigned Line = getLineNumber(Loc);

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

MaskRay updated this revision to Diff 317112. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94735/new/ https://reviews.llvm.org/D94735 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a reviewer: dexonsmith. dexonsmith added a comment. In D94844#2502725 , @nathawes wrote: > Yeah, certainly. Let me put that up separately and update this diff. Thanks! (Optionally, you can link them using the "edit related revisions"

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

pcc added a comment. This causes us to reject the following (reduced from AOSP): int sprintf(char* __s, const char* __fmt, ...) __attribute__((__format__(printf, 2, 3))) ; int sprintf(char* dest, const char* format) __attribute__((overloadable))

[clang] c495dfe - [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

Author: Jan Svoboda Date: 2021-01-15T08:41:50+01:00 New Revision: c495dfe0268bc2be8737725d657411baa1399e9d URL: https://github.com/llvm/llvm-project/commit/c495dfe0268bc2be8737725d657411baa1399e9d DIFF: https://github.com/llvm/llvm-project/commit/c495dfe0268bc2be8737725d657411baa1399e9d.diff

[PATCH] D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rGc495dfe0268b: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1a49944 - [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters

Author: Jan Svoboda Date: 2021-01-15T08:42:30+01:00 New Revision: 1a49944b59dbbfd62bd860b564919087f274a5bf URL: https://github.com/llvm/llvm-project/commit/1a49944b59dbbfd62bd860b564919087f274a5bf DIFF: https://github.com/llvm/llvm-project/commit/1a49944b59dbbfd62bd860b564919087f274a5bf.diff

[PATCH] D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a49944b59db: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94724: [clangd] Remove the recovery-ast options.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me. I have left an explicit setting in our internal client (so this will break the build during the integration), I'll remove them. Repository: rG LLVM Github

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

hokein added a comment. the code looks good to me, but we need to be a bit careful on landing this -- as we have an internal client setting this flag. Comment at: clang-tools-extra/clangd/ClangdServer.h:147 -bool SuggestMissingIncludes = false; - our

[clang] 168be42 - [Clang] Mutate long-double math builtins into f128 under IEEE-quad

Author: Qiu Chaofan Date: 2021-01-15T16:56:20+08:00 New Revision: 168be4208304e36d3bb156b5c413b340a391383e URL: https://github.com/llvm/llvm-project/commit/168be4208304e36d3bb156b5c413b340a391383e DIFF: https://github.com/llvm/llvm-project/commit/168be4208304e36d3bb156b5c413b340a391383e.diff

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

This revision was automatically updated to reflect the committed changes. Closed by commit rG168be4208304: [Clang] Mutate long-double math builtins into f128 under IEEE-quad (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal updated this revision to Diff 316861. steakhal edited the summary of this revision. steakhal set the repository for this revision to rG LLVM Github Monorepo. steakhal added a comment. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

vsavchenko added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:186 - /// Determine the original source location in the original TU for an - /// imported source location. + /// Returns the MacroExpansionContext for the imported TU to which

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for the fix, a small comment about testing though. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:532 TEST(DocumentSymbols, InHeaderFile)

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:191 + /// source-location, empty is returned. + /// \note Macro expansion tracking for imported TUs are not implemented yet. + /// It returns empty unconditionally.

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked 3 inline comments as done. lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:104 + // so that we don't insert `fp` manipulation code into functions that do not + // require it. + const MachineFrameInfo = MF.getFrameInfo();

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko updated this revision to Diff 316877. ilya-golovenko added a comment. Update existing test and remove redundant one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94753/new/ https://reviews.llvm.org/D94753 Files:

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko added a comment. @kadircet Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94753/new/ https://reviews.llvm.org/D94753 ___ cfe-commits mailing list

[PATCH] D94755: [clangd] Fix division by zero when computing scores

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. NameMatch could be a float close to zero,

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

kadircet added a comment. btw, do you have commit access or should i land this for you ? (if so please provide your email) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94753/new/ https://reviews.llvm.org/D94753

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, thanks for the review! fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. Eugene.Zelenko, thanks for the review! fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko added a comment. In D94753#2500535 , @kadircet wrote: > btw, do you have commit access or should i land this for you ? (if so please > provide your email) I've got commit access some time ago. Thanks again! Repository: rG LLVM Github

[clang-tools-extra] 9cc221b - [clangd] exclude symbols from document outline which do not originate from the main file

Author: Ilya Golovenko Date: 2021-01-15T13:23:12+03:00 New Revision: 9cc221b99becf20397d935981eeb48cba5be7faf URL: https://github.com/llvm/llvm-project/commit/9cc221b99becf20397d935981eeb48cba5be7faf DIFF:

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cc221b99bec: [clangd] exclude symbols from document outline which do not originate from the… (authored by ilya-golovenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496 + std::condition_variable CV; + std::atomic ShouldStop = {false}; // Must notify CV after writing. + std::deque Queue; nit: we already hold the lock within

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At dialect

uweigand added a comment. In D82862#2500038 , @pengfei wrote: >> What is the reason for treating this differently in LLVM? > > I'm not sure if it is related to this. I think one difference is that LLVM is > supporting MS inline assembly. Although it uses

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj closed this revision. kawashima-fj added a comment. Herald added subscribers: dexonsmith, danielkiss. In D75594#1927988 , @ikitayama wrote: > In D75594#1927959 , @kawashima-fj > wrote: > >> Yes,

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At dialect

hans added a subscriber: rnk. hans added a comment. > In D82862#2498785 , @hans wrote: > >> The motivation for my change was really just to make ThinLTO compiles work >> the same as non-ThinLTO ones. >> >> Maybe the fact that -x86-asm-syntax=intel doesn't

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:515 + E.setFractionNameInContext( + Relevance.ContextWords ? NumMatch * 1.0 / Relevance.ContextWords->size() +

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94127/new/ https://reviews.llvm.org/D94127 ___ cfe-commits mailing list

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1994 + return None; +return FD->getNumParams() > 0 ? UO_PostInc : UO_PreInc; +

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor NFC improvements. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:957 + + void getArgKinds(ASTNodeKind ThisKind, unsigned

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:38 +!- +! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 316908. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Add include-module test Update the regression test to check the behaviour of -I with an INCLUDE line in the source code. Also add a regression test to check the behaviour

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the `auto` usage. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5346 +AST_POLYMORPHIC_SUPPORTED_TYPES(BinaryOperator,

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Quality.cpp:349 + }; + DeriveASTSignals(); // Declarations are scoped, others (like macros) are assumed global. Maybe it's just me, but using a lambda like this seems quite confusing. I

[clang-tools-extra] aeaeb9e - [clangd] Make ExpandAutoType not available on template params.

Author: Adam Czachorowski Date: 2021-01-15T14:19:05+01:00 New Revision: aeaeb9e6bdc90d9c4b839ac0e4edc6255021cced URL: https://github.com/llvm/llvm-project/commit/aeaeb9e6bdc90d9c4b839ac0e4edc6255021cced DIFF:

[PATCH] D94719: [clangd] Make ExpandAutoType not available on template params.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeaeb9e6bdc9: [clangd] Make ExpandAutoType not available on template params. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94719/new/

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. Thanks for this, I think it's looking more promising! I'd still like to see some test coverage for the changes so long as it doesn't turn into a slog. Tests like `clang\test\AST\ast-dump-color.cpp` show roughly how it's done in the frontend. If it turns out that

[clang-tools-extra] c77c3d1 - [clangd] Set correct CWD when using compile_flags.txt

Author: Adam Czachorowski Date: 2021-01-15T14:26:24+01:00 New Revision: c77c3d1d18cdd58989f9d35bbf6c31f5fda0a125 URL: https://github.com/llvm/llvm-project/commit/c77c3d1d18cdd58989f9d35bbf6c31f5fda0a125 DIFF:

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77c3d1d18cd: [clangd] Set correct CWD when using compile_flags.txt (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94699/new/

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri added a comment. Tests missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2500829 , @lebedev.ri wrote: > Tests missing I mistakenly missed that file in the last commit. I'll add it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added a comment. This patch contains very useful improvements to the design along with the behavioral fixes. I see that it opens more opportunities to bring the implementation in line with the conventional flow and therefore simplify the further development of new functionality. More

[clang] d1862a1 - [OpenCL][Docs] Fixed malformed table in OpenCLSupport

Author: Anastasia Stulova Date: 2021-01-15T14:27:26Z New Revision: d1862a16310379179a40b309a9721318ae7e3254 URL: https://github.com/llvm/llvm-project/commit/d1862a16310379179a40b309a9721318ae7e3254 DIFF: https://github.com/llvm/llvm-project/commit/d1862a16310379179a40b309a9721318ae7e3254.diff

[clang] 791634b - [clang][cli] Parse & generate options necessary for LangOptions defaults manually

Author: Jan Svoboda Date: 2021-01-15T15:38:43+01:00 New Revision: 791634b999e33e029aeeda91eeb5fae13757dcdc URL: https://github.com/llvm/llvm-project/commit/791634b999e33e029aeeda91eeb5fae13757dcdc DIFF: https://github.com/llvm/llvm-project/commit/791634b999e33e029aeeda91eeb5fae13757dcdc.diff

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG791634b999e3: [clang][cli] Parse generate options necessary for LangOptions defaults… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ created this revision. Herald added a subscriber: rogfer01. malharJ requested review of this revision. Herald added subscribers: cfe-commits, vkmr. Herald added a project: clang. This ensures that the Clang loop pragma vectorize_predicate([enable|disable]) is ignored when

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316944. Herald added a subscriber: martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316945. tbaeder added a comment. Sorry about the last change, that was the wrong patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:102 + +// CHECK-NEXT: ![[LOOP7]] = distinct !{![[LOOP7]], [[MP]], [[GEN8]], [[GEN11:![0-9]+]], [[GEN3]]} +// CHECK-NEXT: [[GEN11]] = !{!"llvm.loop.vectorize.width", i32 4}

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:102 + +// CHECK-NEXT: ![[LOOP7]] = distinct !{![[LOOP7]], [[MP]], [[GEN8]], [[GEN11:![0-9]+]], [[GEN3]]} +// CHECK-NEXT: [[GEN11]] = !{!"llvm.loop.vectorize.width", i32 4}

[clang] 3832629 - [clang][cli] NFC: Add PIE parsing for precompiled input and IR

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: 383262933045e1c138362105be4ee4d1b62ab4cc URL: https://github.com/llvm/llvm-project/commit/383262933045e1c138362105be4ee4d1b62ab4cc DIFF: https://github.com/llvm/llvm-project/commit/383262933045e1c138362105be4ee4d1b62ab4cc.diff

[clang] a7dcd3a - [clang][cli] NFC: Parse some LangOpts after the defaults are set

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa URL: https://github.com/llvm/llvm-project/commit/a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa DIFF: https://github.com/llvm/llvm-project/commit/a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa.diff

[clang] 1744f4c - [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: 1744f4c676411ebd2e38afd5a6b56e5dd533c6ac URL: https://github.com/llvm/llvm-project/commit/1744f4c676411ebd2e38afd5a6b56e5dd533c6ac DIFF: https://github.com/llvm/llvm-project/commit/1744f4c676411ebd2e38afd5a6b56e5dd533c6ac.diff

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG383262933045: [clang][cli] NFC: Add PIE parsing for precompiled input and IR (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcd3aeb0fb: [clang][cli] NFC: Parse some LangOpts after the defaults are set (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1744f4c67641: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

pengfei added a comment. > This doesn't add metadata to llvm intrinsics that are not constrained. Oh, right. I misunderstood what's doing in these patches and thought we can add metadata to any intrinsics by CGFPOptionsRAII now. :-) > If a relevant #pragma is used then without this change the

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Previously we did not record local class declarations. Now with features like

  1   2   >