[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { inclyc wrote: >

[PATCH] D125946: Handles failing driver tests of clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG168d4e2945a9: Handles failing driver tests of clang (authored by Purva-Chaudhari). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 168d4e2 - Handles failing driver tests of clang

Author: Purva-Chaudhari Date: 2022-08-02T12:29:26+05:30 New Revision: 168d4e2945a9d3ba2aa88aad65e0a15bddcf7e58 URL: https://github.com/llvm/llvm-project/commit/168d4e2945a9d3ba2aa88aad65e0a15bddcf7e58 DIFF:

[PATCH] D130827: [clang] Fixed a number of typos

h-vetinari added a comment. Thanks for chasing these down! Comment at: clang/include/clang/Basic/SourceManager.h:1922 +/// SourceManager and necessary dependencies (e.g. VFS, FileManager) for a +/// single in-memorty file. class SourceManagerForFile { Even

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/test/Sema/format-strings-scanf.c:236 + scanf(1 ? "%s" : "%d", i); // expected-warning{{format specifies type 'char *'}} \ + // expected-note{{format string is defined here}} scanf(0 ? "%d %d" :

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449191. inclyc added a comment. Make if statements concise and add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 449188. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { tbaeder wrote: > I

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449195. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

MaskRay added a comment. When a module with `"indirect_branch_cs_prefix"` and another without the module flag are merged, what the result should be? If 0, we should use `Min` instead of `Override`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix))

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu reopened this revision. rtrieu added a comment. This revision is now accepted and ready to land. This warning is now flagging some code which I believe is a false positive. In particular, when template arguments are involved, their values can be calculated during template instantiation,

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

kito-cheng added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; craig.topper wrote: > reames wrote: > > craig.topper wrote: >

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 449199. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D130969: [clang] [HLSL] Fix GCC warnings about virtual methods that are hidden

mstorsjo created this revision. mstorsjo added a reviewer: beanz. Herald added a subscriber: Anastasia. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This fixes the following warnings produced by GCC 9: [...] Building CXX object

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added a comment. In D130847#3690977 , @aaron.ballman wrote: > > Given that this code is on the hot path, should it be the caller's > responsibility to have already validated the `FileID` that's passed in so > that the fake entry can

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. Sorry for the late update. I hope you can take the time to continue reviewing, @rjmccall . I'm not sure if I understand you correctly. Now if the `-mextend-small-integers=default` is used, compiler will report error. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:901 const SrcMgr::SLocEntry = getLoadedSLocEntry(MiddleIndex); if (E.getOffset() == 0) return FileID(); // invalid entry. FYI: the same check is used for the rest

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

ChuanqiXu planned changes to this revision. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D130864#3693019 , @ilya-biryukov wrote: > Thanks for working on this. I have a few major concerns here: > > - Do we know that it's a

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { inclyc wrote: >

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449236. inclyc added a comment. update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

mgabka added a comment. I noticed that this patch is causing now an assertion failure for cases like : class A{ void a() { #pragma omp parallel a(b); } }; The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed." while

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3692394 , @thakis wrote: > This change caused a ton of churn, for what I understand fix the diag in C > mode when assert.h is not included. Which is not that uncommon of a scenario:

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { tbaeder wrote: >

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 449261. ivanmurashko added a comment. Fix for wrong LastFileIDLookup assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files:

[PATCH] D130984: [clang][AArch64][SVE] Add unary +/- operators for SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

pengfei added a comment. Add to `ReleaseNotes.rst` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130964/new/ https://reviews.llvm.org/D130964 ___ cfe-commits mailing list

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

dang updated this revision to Diff 449228. dang added a comment. Remove doc comments in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130918/new/ https://reviews.llvm.org/D130918 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. In D130863#3693135 , @ilya-biryukov wrote: > Otherwise, I would personally still put `.cache/clangd` into the global > `.gitignore` or `.git/info/exclude`. IMO `.cache/clangd` should not be in the > VCS history at all, even

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 updated this revision to Diff 449230. LiuChen3 added a comment. rebase and address rjmccall's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435 Files:

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

tbaeder added a comment. Getting a review usually takes far longer than just a few hours, so don't ping too early. I also want an opinion from at least one other reviewer. Comment at: clang/lib/Sema/SemaChecking.cpp:8505 + // maybe this expression can be evaluated at

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

ilya-biryukov added a comment. Thanks for working on this. I have a few major concerns here: - Do we know that it's a bottleneck in practice? E.g. if the module name have different sizes, comparing strings is actually fast. If the module names are short, we are also in a pretty good situation.

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

iains added a comment. In D130864#3693022 , @ChuanqiXu wrote: > In D130864#3693019 , @ilya-biryukov > wrote: > >> Thanks for working on this. I have a few major concerns here: >> >> - Do we know that it's a

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

kadircet added a comment. no worries, as discussed offline this LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 ___ cfe-commits mailing list

[PATCH] D130863: [clangd] Make git ignore index directories

ilya-biryukov added a comment. I'm with Kadir on this one, but maybe I'm too attached to my `.git/info/exclude`s. I somehow don't feel it's a big burden specific to clangd. I have to configure `.gitignore` for my projects and `.git/info/excludes` for other projects I work on because of many

[clang] afb785f - [Driver] Remove Separate form for XRay options

Author: Fangrui Song Date: 2022-08-02T00:47:37-07:00 New Revision: afb785f51161b78b9af7d9ecd3ce7632160efee9 URL: https://github.com/llvm/llvm-project/commit/afb785f51161b78b9af7d9ecd3ce7632160efee9 DIFF: https://github.com/llvm/llvm-project/commit/afb785f51161b78b9af7d9ecd3ce7632160efee9.diff

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

asb added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:232 +bool RISCVISAInfo::hasVInstructions() const { + return hasExtension("zve32x"); +} Given the other sub-thread showed that hasExtennsion("zve32x") == hasVInstructions isn't completely

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 449226. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. In D124435#3515541 , @jyknight wrote: > I find the option names you have a bit confusing. I'd like to suggest calling > them, instead: > > caller: Extend a small integer parameter in the caller; callee will assume it > has

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

alok updated this revision to Diff 449239. alok added a comment. Re-based and updated to incorporate comments from @dblaikie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D130863: [clangd] Make git ignore index directories

ilya-biryukov added a comment. In D130863#3693293 , @sammccall wrote: > In D130863#3693135 , @ilya-biryukov > wrote: > >> Otherwise, I would personally still put `.cache/clangd` into the global >> `.gitignore`

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. In D130510#3692654 , @rtrieu wrote: > This warning is now flagging some code which I believe is a false positive. > In particular, when template arguments are involved, their values can be > calculated during template

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong added a comment. In D130705#3685299 , @balazske wrote: > It is still not perfect, analysis of qtbase is not better than before and > some of the unreachable assertions were encountered. Does it mean you plan some updates on this patch?

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske added a comment. Yes, I plan to add improvements but the current code remains mostly. I found other type of error (in project //qtbase//) that are not directly related, too (infinite import loop of deduction guide without auto return value, one of the function arguments is involved),

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. @nlopes we will update all undef to poison in follow up patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126745/new/ https://reviews.llvm.org/D126745 ___ cfe-commits

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I've reverted in c783ca0de1e1e00f364cf4745b8444a020ddd29b . Marking as requesting changes to make

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Hmm... I'm a little shocked that didn't error before, while we did the 2nd pass through the destructor. A little shocking this made it this far... The fix looks fine to me, I wish I

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 449303. steplong added a comment. - Add necessary includes to use EXPECT_THAT and MatchesRegex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files:

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130918/new/ https://reviews.llvm.org/D130918 ___

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > lld has tests for --reproduce already. Even if I added an environment > variable to crash lld, the test would depend on lld being built, adding a big > dependency to clang's tests. Do we think that's worth it? There is now cross-project-tests which would seem to be

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added a comment. In D127803#3693660 , @ABataev wrote: > In D127803#3693655 , @jyu2 wrote: > >> In D127803#3693301 , @mgabka wrote: >> >>> I noticed that this patch

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 449299. pscoro marked 3 inline comments as done. pscoro added a comment. Fixed test cases and AIX implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016

[clang] c783ca0 - Revert "Missing tautological compare warnings due to unary operators"

Author: Aaron Ballman Date: 2022-08-02T09:39:36-04:00 New Revision: c783ca0de1e1e00f364cf4745b8444a020ddd29b URL: https://github.com/llvm/llvm-project/commit/c783ca0de1e1e00f364cf4745b8444a020ddd29b DIFF: https://github.com/llvm/llvm-project/commit/c783ca0de1e1e00f364cf4745b8444a020ddd29b.diff

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added a comment. In D127803#3693655 , @jyu2 wrote: > In D127803#3693301 , @mgabka wrote: > >> I noticed that this patch is causing now an assertion failure for cases like >> : >> >> class A{ >> >> void

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

aaron.ballman added a comment. These changes look reasonable, but I verified that the precommit CI failures are valid -- it looks like this change broke a test somehow; perhaps a caller was relying on the old behavior and needs to be reworked? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added a comment. In D130847#3693668 , @aaron.ballman wrote: > These changes look reasonable, but I verified that the precommit CI failures > are valid -- it looks like this change broke a test somehow; perhaps a caller > was relying on

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro marked 8 inline comments as done. pscoro added inline comments. Comment at: llvm/test/CodeGen/PowerPC/kill-canary-intrinsic.ll:11 + +; RUN: llc -verify-machineinstrs -mtriple=powerpc-unknown-aix -ppc-vsr-nums-as-vr \ +; RUN: -mcpu=pwr8 --ppc-asm-full-reg-names < %s |

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ec6ea3dfded: [clang][OpenMP][DebugInfo] Mark OpenMP generated functions as artificial (authored by alok). Repository: rG LLVM Github Monorepo

[PATCH] D35379: Add documentation for @available

thakis accepted this revision. thakis marked an inline comment as done. thakis added a comment. This revision is now accepted and ready to land. Herald added a reviewer: aaron.ballman. Herald added a project: All. landed long ago in 11cafc82b72a80fb9a7266bbda7fc7a0cc1b51a0 /

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added a comment. In D127803#3693301 , @mgabka wrote: > I noticed that this patch is causing now an assertion failure for cases like : > > class A{ > > void a() { > #pragma omp parallel > a(b); > } > > }; > > The failed assertion is:

[clang] 5ec6ea3 - [clang][OpenMP][DebugInfo] Mark OpenMP generated functions as artificial

Author: Alok Kumar Sharma Date: 2022-08-02T21:24:46+05:30 New Revision: 5ec6ea3dfded028de775eb165ce0bae6f1e6c2bf URL: https://github.com/llvm/llvm-project/commit/5ec6ea3dfded028de775eb165ce0bae6f1e6c2bf DIFF:

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. Oh, I noticed that g++ already does this: test.cpp:27:21: error: static assertion failed 27 | static_assert(foo() < 4); | ~~^~~ test.cpp:27:21: note: the comparison reduces to ‘(10 < 4)’ CHANGES SINCE LAST ACTION

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei updated this revision to Diff 449275. pengfei marked an inline comment as done. pengfei added a comment. Add CC1 option test. > When a module with "`indirect_branch_cs_prefix`" and another without the > module flag are merged, what the result should be? If 0, we should use `Min` >

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

mgabka added a comment. In D127803#3693700 , @jyu2 wrote: > In D127803#3693660 , @ABataev wrote: > >> In D127803#3693655 , @jyu2 wrote: >> >>> In D127803#3693301

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I agree that test coverage for the performance issue is basically impossible with our testing system. I was thinking "well good, add a test with a huge initializer to make

[PATCH] D126746: [RISCV][Clang] Support policy functions for Vector Comparison Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caf2cc05c02: [RISCV][Clang] Support policy functions for Vector Comparison (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdffdca85ec2d: [RISCV][Clang] Support policy functions for Vector Reduction (authored by khchen). Changed prior to commit:

[clang] dffdca8 - [RISCV][Clang] Support policy functions for Vector Reduction

Author: Zakk Chen Date: 2022-08-02T17:27:56Z New Revision: dffdca85ec2d17ce751adca1a851bc4458973e57 URL: https://github.com/llvm/llvm-project/commit/dffdca85ec2d17ce751adca1a851bc4458973e57 DIFF: https://github.com/llvm/llvm-project/commit/dffdca85ec2d17ce751adca1a851bc4458973e57.diff LOG:

[clang] bb99d4b - [RISCV][Clang] Support policy functions for Vector Mask Instructions.

Author: Zakk Chen Date: 2022-08-02T17:27:57Z New Revision: bb99d4b11d84ae178d9ea3ea2c9da4d4c2e1eafc URL: https://github.com/llvm/llvm-project/commit/bb99d4b11d84ae178d9ea3ea2c9da4d4c2e1eafc DIFF: https://github.com/llvm/llvm-project/commit/bb99d4b11d84ae178d9ea3ea2c9da4d4c2e1eafc.diff LOG:

[clang] 7eddeb9 - [RISCV][Clang] Support policy functions for vmerge, vfmerge and

Author: Zakk Chen Date: 2022-08-02T17:27:55Z New Revision: 7eddeb9e99f36d907295a2ed75244d39e1e41e33 URL: https://github.com/llvm/llvm-project/commit/7eddeb9e99f36d907295a2ed75244d39e1e41e33 DIFF: https://github.com/llvm/llvm-project/commit/7eddeb9e99f36d907295a2ed75244d39e1e41e33.diff LOG:

[clang] 9caf2cc - [RISCV][Clang] Support policy functions for Vector Comparison

Author: Zakk Chen Date: 2022-08-02T17:27:56Z New Revision: 9caf2cc05c02300c06e2405ff3606d5aa8cf773d URL: https://github.com/llvm/llvm-project/commit/9caf2cc05c02300c06e2405ff3606d5aa8cf773d DIFF: https://github.com/llvm/llvm-project/commit/9caf2cc05c02300c06e2405ff3606d5aa8cf773d.diff LOG:

[PATCH] D126749: [RISCV][Clang] Support policy functions for Vector Mask Instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb99d4b11d84: [RISCV][Clang] Support policy functions for Vector Mask Instructions. (authored by khchen). Repository: rG LLVM Github Monorepo

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eddeb9e99f3: [RISCV][Clang] Support policy functions for vmerge, vfmerge and (authored by khchen). Changed prior to commit:

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449355. ckissane added a comment. - make a zlib corruption check specific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; erichkeane wrote: > I don't think this is the correct answer. Even though the other use of this > seems to 'work',

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[clang] 92c1bc6 - [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

Author: Yuanfang Chen Date: 2022-08-02T11:49:01-07:00 New Revision: 92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0 URL: https://github.com/llvm/llvm-project/commit/92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0 DIFF: https://github.com/llvm/llvm-project/commit/92c1bc61586c9d6c7bf0c36b1005fe00b4f48cc0.diff

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG92c1bc61586c: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449375. ckissane added a comment. - CompressionKind: clean up param names to == op Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. In D130516#3694151 , @MaskRay wrote: > In D130516#3688236 , @dblaikie > wrote: > >> In D130516#3688123 , @MaskRay >> wrote: >> >>> I'd like to

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added a comment. It looks like you haven't implemented the target-specific logic for this yet. I cannot let you commit until you do that, because you will be breaking the ABI on Apple platforms. Comment at: clang/include/clang/Basic/CodeGenOptions.h:150 +

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

rjmccall added a comment. How are you actually implementing `__bf16` on these targets? There isn't even hardware support for conversions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130964/new/ https://reviews.llvm.org/D130964

[PATCH] D131012: No longer place const volatile global variables in a read only section

erichkeane added a comment. The code changes look perfectly fine to me, but I'm hopeful someone else has something to say about how acceptable/ABI related this is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131012/new/

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; erichkeane wrote: > shafik wrote: > > erichkeane wrote: > > > I don't think this is the correct answer. Even though the other

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM once nits are fixed (take or leave them). Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND:

[PATCH] D131017: Fix use-after-free in clang-apply-replacements

benlangmuir created this revision. benlangmuir added reviewers: bnbarham, fmayer. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Accidentally introduced a dangling StringRef in

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

benlangmuir added a comment. @fmayer thanks, fix is: https://reviews.llvm.org/D131017 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934 ___ cfe-commits mailing

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aaron.ballman added subscribers: mikerice, ABataev. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1638 +llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments(); +ArgList.push_back(Saver.save(Twine{"--reproduce="} + TmpName).data()); +

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

royjacobson updated this revision to Diff 449344. royjacobson edited the summary of this revision. royjacobson added a comment. Add newline and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130936/new/

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449346. ckissane added a comment. - feat compression "enum" with methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D131004: [clang] Add FileEntryRef::getNameAsRequested()

benlangmuir created this revision. benlangmuir added a reviewer: bnbarham. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As progress towards having FileManager::getFileRef() return the path

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. The current code here still seems more complicated than I'd prefer - looks like currently the size/speed/default levels are currently unused, so maybe we can omit those for now, knowing they will be added? And the CompressionKind with all its operator overloads seems

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:37 -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L #define __DELETE =delete tra wrote: > Are there actual use cases where CUDA headers are

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:400-401 +CXX20_KEYWORD(concept , 0) +CXX20_KEYWORD(requires , 0) // Not a CXX20_KEYWORD because it is disabled by -fno-char8_t. KEYWORD(char8_t

[PATCH] D131012: No longer place const volatile global variables in a read only section

aaron.ballman updated this revision to Diff 449405. aaron.ballman added a comment. Rebased to get precommit CI to look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131012/new/ https://reviews.llvm.org/D131012 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane updated this revision to Diff 449404. erichkeane added a comment. Add underlying type to TokenKey, plus did all of Aaron's review comments. In general, I think we dont' have a good definition of Extension vs Enabled here, and someone should probably think that through. I'll review

  1   2   >