[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a created this revision. bolshakov-a added reviewers: erichkeane, rnk. Herald added a project: All. bolshakov-a requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Several issues have been discovered and (hopefully) fixed here: -

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 9d042ed - [clangd] Fix test failure in SemanticHighlighting.GetsCorrectTokens

Author: Nathan Ridge Date: 2023-03-19T04:43:24-04:00 New Revision: 9d042ed1a4f4eaf99eb8d349e5c489a60afb7e50 URL: https://github.com/llvm/llvm-project/commit/9d042ed1a4f4eaf99eb8d349e5c489a60afb7e50 DIFF: https://github.com/llvm/llvm-project/commit/9d042ed1a4f4eaf99eb8d349e5c489a60afb7e50.diff

[PATCH] D146364: [Driver] Fix naming conflicts of getStatsFileName when using LTO

dtcxzyw updated this revision to Diff 506387. dtcxzyw removed subscribers: MaskRay, cfe-commits, inglorion. dtcxzyw added a comment. Fix test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146364/new/ https://reviews.llvm.org/D146364

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

mamrami added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + sunshaoce wrote: > mamrami wrote: > > sunshaoce wrote: > > > awarzynski wrote: > > > > mamrami wrote: > > > > > Hi :) > > > > > It seems like the

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 506398. PiotrZSL added a comment. Update documentation, changed default check configuration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files:

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:353 + if (IsSystem || + IncludeDelimiter == Config::IncludeDelimiterPolicy::AlwaysBrackets) Suggested = "<" + Suggested + ">"; I couldn't tell looking at other code in

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 created this revision. Ruturaj4 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. Ruturaj4 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. enums and structs declared inside typedefs have

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL updated this revision to Diff 506399. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Review comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 Files:

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

mamrami added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + sunshaoce wrote: > awarzynski wrote: > > mamrami wrote: > > > Hi :) > > > It seems like the test fails: > > >

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce added a subscriber: DavidSpickett. sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + mamrami wrote: > sunshaoce wrote: > > awarzynski wrote: > > > mamrami wrote: > > > > Hi :) > > > > It

[PATCH] D145886: [C++2x][Modules] Amend module purview constant linkage [P2788R0].

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62a16d5e2069: [C++2x][Modules] Amend module purview constant linkage [P2788R0]. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES

[clang] 62a16d5 - [C++2x][Modules] Amend module purview constant linkage [P2788R0].

Author: Iain Sandoe Date: 2023-03-19T16:25:56Z New Revision: 62a16d5e2069542351c164aa0e3b216dc8e153c4 URL: https://github.com/llvm/llvm-project/commit/62a16d5e2069542351c164aa0e3b216dc8e153c4 DIFF: https://github.com/llvm/llvm-project/commit/62a16d5e2069542351c164aa0e3b216dc8e153c4.diff LOG:

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster updated this revision to Diff 506409. ADKaster added a comment. Change from a boolean parameter to an enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145843/new/ https://reviews.llvm.org/D145843 Files:

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 506413. bolshakov-a added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 Files: clang/lib/AST/MicrosoftMangle.cpp

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:22 + bool operator()(const internal::BoundNodesMap ) const { +auto *Other = Nodes.getNode(ID).get(); +if (!Other) `const

[PATCH] D146377: [clangd] Remove reundant use of getSpellingLoc()

nridge created this revision. nridge added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 506358. hazohelet added a comment. Address comments from @shafik and @tbaeder CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

thakis added a comment. This breaks tests: http://45.33.8.238/linux/102084/step_9.txt Please take a look and revert for now if it takes a while to fix. Did you not run tests before commiting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

owenpan added a comment. Should we add tests to TokenAnnotatorTest.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146284/new/ https://reviews.llvm.org/D146284 ___ cfe-commits mailing list

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel updated this revision to Diff 506370. rymiel added a comment. Annotator tests (copied from format tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146284/new/ https://reviews.llvm.org/D146284 Files:

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. > The style guide doesn't mention indenting designated initializers with 2 > spaces? That is a fair point. I will get it updated because the author and maintainer of that style guide is the one requesting this change since, in practice, codebases following this style

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tschuett added a comment. You can either pass parameters to passes or use different pass pipelines for different optimisation levels (in MLIR territory). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143 auto Targets = Resolver->resolveUsingValueDecl(UUVD); -if (!Targets.empty()) { +if (!Targets.empty() && Targets[0] != UUVD) { return kindForDecl(Targets[0],

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added a comment. I will go ahead and merge this partial fix because it is an improvement over the current state. @sammccall I'm still curious to know your thoughts on the approach for fixing the mutually-recursive case. Is there something more general than adding a recursion guard like

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added a comment. My apologies. I did run tests locally but on a slightly older tree. I'll post a fix momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134827/new/ https://reviews.llvm.org/D134827

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

recallmenot added a comment. Hi, I'm working on CH32V003 for rust and it uses RV32EC core. I tried replacing my distros llvm and clang with a patched version of this like this: git clone https://aur.archlinux.org/llvm-git.git cd llvm-git mkdir src cd src git clone

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

owenpan added a comment. Looks like this patch doesn't put the opening brace at the outerscope for some of the examples from the linked github issues: $ cat .clang-format AllowShortLambdasOnASingleLine: None BraceWrapping: BeforeLambdaBody: true BreakBeforeBraces: Custom

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. That remaining failing unit test (`Flang.Driver::code-gen-rv64.f90`) appears to be independent of my diff, as it appears in other pipelines as well, compare

[PATCH] D137397: [Sanitizer] [Scudo] Add riscv64 support for scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rG2538e550420f: [Sanitizer] [Scudo] Add riscv64 support for scudo (authored by joshua-arch1, committed by AdityaK 1894981+hiradi...@users.noreply.github.com). Herald added projects: clang, Sanitizers.

[clang] 2538e55 - [Sanitizer] [Scudo] Add riscv64 support for scudo

Author: Jun Sha (Joshua) Date: 2023-03-18T23:37:46-07:00 New Revision: 2538e550420fed5036d224fd93e9145c845f0ffe URL: https://github.com/llvm/llvm-project/commit/2538e550420fed5036d224fd93e9145c845f0ffe DIFF:

[clang-tools-extra] d4cb6c2 - [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

Author: Alexis Murzeau Date: 2023-03-19T06:22:16Z New Revision: d4cb6c208231b36ef44871f4f3d0167f8b206a5e URL: https://github.com/llvm/llvm-project/commit/d4cb6c208231b36ef44871f4f3d0167f8b206a5e DIFF: https://github.com/llvm/llvm-project/commit/d4cb6c208231b36ef44871f4f3d0167f8b206a5e.diff

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4cb6c208231: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C (authored by amurzeau, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some simple messages where an expansion isn't

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Looks like you're just removing the output altogether, so that won't work. Try running `ninja check-clang-semacxx` and see all the test failures you (should) get. For a proper patch, it would also be good if you add a test case for the case you're fixing. Repository:

[PATCH] D145886: [C++2x][Modules] Amend module purview constant linkage [P2788R0].

iains updated this revision to Diff 506380. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145886/new/ https://reviews.llvm.org/D145886 Files: clang/lib/AST/Decl.cpp

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added a comment. "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject 'foo'", but that's just a suggestion and I'll wait for a native spearker to chime in on this. Comment at: clang/lib/AST/Interp/Interp.cpp:373 +

[clang-tools-extra] 7138e75 - [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

Author: Nathan Ridge Date: 2023-03-19T04:30:33-04:00 New Revision: 7138e75d1bb5008b9278359dc83f05c668e104c2 URL: https://github.com/llvm/llvm-project/commit/7138e75d1bb5008b9278359dc83f05c668e104c2 DIFF: https://github.com/llvm/llvm-project/commit/7138e75d1bb5008b9278359dc83f05c668e104c2.diff

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7138e75d1bb5: [clangd] Avoid recursion on

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added a comment. Should be fixed in https://reviews.llvm.org/rG9d042ed1a4f4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134827/new/ https://reviews.llvm.org/D134827 ___ cfe-commits mailing

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Update documentation, and config examples, add "Traditional Tokens Representation" section. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:159 +

[PATCH] D141811: [clang-format] Allow trailing return types in macros

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7989-7990 + verifyFormat("#define MAKE_DEF(NAME) " + "\\\n" + " auto NAME()

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. In D146042#4204513 , @owenpan wrote: > Looks like this patch doesn't put the opening brace at the outerscope for > some of the examples from the linked github issues: > > $ cat .clang-format > AllowShortLambdasOnASingleLine:

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145841/new/ https://reviews.llvm.org/D145841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145860: [clang][Interp] Fix initializing fields after base class members

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145860/new/ https://reviews.llvm.org/D145860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 506357. bersbersbers added a comment. Fix unit tests, add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D146377: [clangd] Remove reundant use of getSpellingLoc()

nridge added a comment. No functional changes intended, this redundancy is just something I noticed while I was learning about these functions during my review of D144074 and looking at other usages of them in clnagd. Repository: rG LLVM Github Monorepo

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge updated this revision to Diff 506359. nridge added a comment. add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134827/new/ https://reviews.llvm.org/D134827 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added a comment. In D146101#4201842 , @jp4a50 wrote: > I understand the added complexity and maintenance burden of a new option but > we do meet the 3 criteria listed in your link. > > - it is part of the KJ style guide which is used by the capn

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel added a comment. Yes, good point, I will do that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146284/new/ https://reviews.llvm.org/D146284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 506428. bolshakov-a added a comment. Add USR generation and a couple of minor fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D146393: [Clang] Support free positioning of labels inside compound statements in C

Izaron added a comment. A big TODO: rename `ext_c_label_end_of_compound_statement` to something like `ext_c_label_free_positioning`. Since we found out it is more complete than just the end of statements. Comment at: clang/lib/Parse/ParseStmt.cpp:695-697 - // The

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

sstwcw updated this revision to Diff 506457. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146403/new/ https://reviews.llvm.org/D146403 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestVerilog.cpp Index:

[PATCH] D146393: [Clang] Support free positioning of labels inside compound statements in C

Izaron created this revision. Izaron added reviewers: aaron.ballman, cor3ntin. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implements part of paper P2324R2

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 506429. bolshakov-a added a comment. Finalize renaming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[clang] b688b58 - [clang-format] Fix non-case colons in Verilog case lines

Author: sstwcw Date: 2023-03-19T21:41:14Z New Revision: b688b58f83ceb48dbe185be95372e45de1d51401 URL: https://github.com/llvm/llvm-project/commit/b688b58f83ceb48dbe185be95372e45de1d51401 DIFF: https://github.com/llvm/llvm-project/commit/b688b58f83ceb48dbe185be95372e45de1d51401.diff LOG:

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb688b58f83ce: [clang-format] Fix non-case colons in Verilog case lines (authored by sstwcw). Changed prior to commit:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 506434. calebzulawski added a comment. Corrected docs and updated upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/docs/UsersManual.rst

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3271 +4 - to nearest, ties away from zero +The effect of passing some other value to this builtin is implementation-defined. + This comment belongs with the other builtin. I would

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. The debian build is failing because of this https://github.com/google/llvm-premerge-checks/issues/436 The windows build is failing because of https://github.com/llvm/llvm-project/issues/61519, i see that the fix

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. `-K` is a linker option on AIX, that is used to align the header, text, data, and loader sections of the output

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. The issue addressed by this patch is attracting a steady stream of user interest (two recent examples are https://github.com/clangd/clangd/issues/1545 and https://github.com/clangd/vscode-clangd/issues/469). A review would be appreciated :) Repository: rG LLVM

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 506426. bolshakov-a added a comment. Rename `UncommonValue` to `StructuralValue` and add "TODO" about it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu added a comment. > Ugh, that does sort of change the calculus for whether we do or don't claim > support on Windows. If removing the definition of that macro on Windows > causes significant code breakage, that would be a reason we should leave it > defined. But do we have evidence of

[clang] d2639ff - [NFC] [C++20] [Modules] Add test for #pragma once

Author: Chuanqi Xu Date: 2023-03-20T11:37:09+08:00 New Revision: d26392673c39885400c45c317afd4e2c9f8d URL: https://github.com/llvm/llvm-project/commit/d26392673c39885400c45c317afd4e2c9f8d DIFF: https://github.com/llvm/llvm-project/commit/d26392673c39885400c45c317afd4e2c9f8d.diff

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3295 +support this builtin. Since this builtin changes default floating-point +environment, ``#pragma STDC FENV_ACCESS ON`` is required. + rjmccall wrote: > sepavloff wrote: > > Not

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1670 + case TemplateArgument::UncommonValue: +if (ValueDecl *D = getAsArrayToPointerDecayedDecl( +TA.getUncommonValueType(), TA.getAsUncommonValue())) { erichkeane

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 506430. bolshakov-a added a comment. Finalize renaming one more time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506439. francii added a comment. Allow user-specified -L and -l options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An escaped identifier always needs a space

[PATCH] D146402: [clang-format] Handle Verilog assign statements

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. before: (opcode *>o1) = 6.1; a inside{b,

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. In D70401#4204511 , @recallmenot wrote: > Hi, I'm working on CH32V003 for rust and it uses RV32EC core. > I tried replacing my distros llvm and clang with a patched version of this > like this: > > git clone

[PATCH] D146396: [clang-tidy] Use checks dependences for Analyzer checks

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506447. francii added a comment. nit: spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 506460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146188/new/ https://reviews.llvm.org/D146188 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3288 +This builtin is restrcted to work on x86 and arm targets currently. When support +for the builtin is added for new targets, the manual should be updated accordingly. + This