[clang] 038536a - [Driver] Support response file on baremetal driver

Author: Petr Hosek Date: 2023-04-20T02:45:26Z New Revision: 038536acaf271cb614fd2248becf1cc2c5e700c7 URL: https://github.com/llvm/llvm-project/commit/038536acaf271cb614fd2248becf1cc2c5e700c7 DIFF: https://github.com/llvm/llvm-project/commit/038536acaf271cb614fd2248becf1cc2c5e700c7.diff LOG:

[PATCH] D148760: [Driver] Support response file on baremetal driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG038536acaf27: [Driver] Support response file on baremetal driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai created this revision. vsapsai added reviewers: EricWF, aprantl, chapuni. Herald added subscribers: ributzka, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: deadalnix. Herald added a project: All. vsapsai requested review of this revision. Herald added

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai updated this revision to Diff 515194. vsapsai added a comment. Don't touch HeaderSearch.cpp as the actual change in header search will be a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148776/new/

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 515196. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic in a better way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, dim, enh. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/62247 D131057

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

MaskRay updated this revision to Diff 515205. MaskRay added a comment. update test/Sema/format-strings-fixit.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148779/new/ https://reviews.llvm.org/D148779 Files: clang/lib/AST/FormatString.cpp

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148556/new/ https://reviews.llvm.org/D148556

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

rymiel added a comment. (looks like you linked the same issue twice in the summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/ https://reviews.llvm.org/D148777 ___ cfe-commits mailing

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148751/new/ https://reviews.llvm.org/D148751 ___ cfe-commits mailing list

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

owenpan added a comment. In D148777#4282574 , @rymiel wrote: > (looks like you linked the same issue twice in the summary) Thanks. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

ikudrin updated this revision to Diff 515215. ikudrin marked an inline comment as done. ikudrin added a comment. - `WIN32` -> `MSVC` Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148751/new/ https://reviews.llvm.org/D148751 Files: clang/CMakeLists.txt Index:

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:358-373 +#if ALLOW_SUBDIRECTORY_MODULE_MAP_SEARCH // If we've already performed the exhaustive search for module maps in this // search directory, don't do it again. if

[PATCH] D148383: [driver] Enable response file when using lld on baremetal targets

phosek abandoned this revision. phosek added a comment. Addressed by D148760 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148383/new/ https://reviews.llvm.org/D148383

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

mstorsjo added inline comments. Comment at: clang/CMakeLists.txt:616 -DDYLD_LIBRARY_PATH=${LLVM_LIBRARY_OUTPUT_INTDIR}) -elseif(NOT WIN32) +elseif(WIN32) + add_dependencies(clang-bootstrap-deps llvm-lib) I think I’d prefer to have the

[PATCH] D148387: remove Demangle/StringView.h

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/ https://reviews.llvm.org/D148387

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/62228 and

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D148315: [RISCV] Modify arch string parsing order according to latest riscv spec

asb added a comment. I'm starting to think we should just remove the ordering rules for z/s/x altogether when parsing arch strings I see that gcc 12.2.0 actually requires s and then z: [asb@purge ~]$ riscv64-linux-gnu-gcc -march=rv64imafdc_svinval_zicbom t.c -c [asb@purge ~]$

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:46 + +multiclass RVVVCIXBuiltinSet range, string prototype, + list intrinsic_types, bit EncodeVtype, We might consider breaking this

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } It's weird that the above two statements warn about using `__FUNCTION__` and the return statement doesn't. Repository: rG LLVM

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AFAIK this is just used to suppress warnings, so

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 514849. IncludeGuardian added a comment. Replace `ResetReadToken` with `SetReadToken` to avoid a conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files:

[clang] 107b307 - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T09:32:09+01:00 New Revision: 107b307bd61e51aa66ea41f1a2c92c1459b39c7e URL: https://github.com/llvm/llvm-project/commit/107b307bd61e51aa66ea41f1a2c92c1459b39c7e DIFF: https://github.com/llvm/llvm-project/commit/107b307bd61e51aa66ea41f1a2c92c1459b39c7e.diff LOG:

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks everyone for begin patient with this one. I've just pushed again after landing D148536 . I am hoping that's the last issue... I am watching the buildbots and chromium build page. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514842. xgupta marked an inline comment as done. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files:

[PATCH] D148315: [RISCV] Modify arch string parsing order according to latest riscv spec

joshua-arch1 added a comment. In D148315#4279486 , @asb wrote: > I'm starting to think we should just remove the ordering rules for z/s/x > altogether when parsing arch strings I see that gcc 12.2.0 actually requires > s and then z: > > [asb@purge

[clang] 70ba243 - [clang][Interp][NFC] Small State.cpp refactoring

Author: Timm Bäder Date: 2023-04-19T08:13:16+02:00 New Revision: 70ba243c6a6ed645efa20443026c520c2d62ff72 URL: https://github.com/llvm/llvm-project/commit/70ba243c6a6ed645efa20443026c520c2d62ff72 DIFF: https://github.com/llvm/llvm-project/commit/70ba243c6a6ed645efa20443026c520c2d62ff72.diff

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4279334 , @tbaeder wrote: > I am not 100% sure about the semantics of passing multiple prefixes, i.e. if > the error is emitted for all prefixes individually or if it's only emitted if > no `expected` line for

[PATCH] D148614: [clang][Interp] Add frame depth checking

tbaeder updated this revision to Diff 514826. tbaeder added a comment. Move things around a bit and add some `+ 1`s to get matching diagnostic output with the current interpreter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148614/new/ https://reviews.llvm.org/D148614 Files:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:233 + if (!Entry) { +errs() << "clang-rename: input file does not exist.\n"; +return 1; kbobyrev wrote: > It is worth including the filename in the error

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

PiotrZSL added a comment. Few issues, first we should have single check for a single cppcoreguidelines rule. And due to that I'm not fan of merging these things, because for example If I would enable this check in my project I woudn't like to enforce noexcept default constructor or destructor.

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes , + llvm::ArrayRef Providers); kadircet

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514911. ipriyanshi1708 added a comment. Removed spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGbf47c1ed8556: [dataflow] Extract arena for Value/StorageLocation out of… (authored by sammccall).

[clang] bf47c1e - [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

Author: Sam McCall Date: 2023-04-19T14:32:13+02:00 New Revision: bf47c1ed855605324efcca4af92517026c7e53e5 URL: https://github.com/llvm/llvm-project/commit/bf47c1ed855605324efcca4af92517026c7e53e5 DIFF: https://github.com/llvm/llvm-project/commit/bf47c1ed855605324efcca4af92517026c7e53e5.diff

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining accepted this revision. SixWeining added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy added a comment. @steakhal Thanks for the background information! I didn't know about D86874 so I indeed ended up with something very similar to it. I reviewed D88359 and I knew that it's a completely general

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. There is more to this than meets the eye.. what we have so far, from existing `AfterFunction` use and the propsed here `AfterCSharpProperty` is... public Foo {<--- controlled by **AfterFunction **(rightly or wrongly) get {

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 514901. VitaNuo added a comment. Extract a test for th firstMatchedProvider method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514909. ipriyanshi1708 added a comment. Updated the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514931. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added subscribers: jdoerfert, kristof.beyls, dschuff. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514908. AMS21 added a comment. Minor code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ SixWeining wrote: > Better to use “loongarch64” when talking about debian? Refer >

[clang] 5f605e2 - [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

Author: Marco Elver Date: 2023-04-19T14:49:56+02:00 New Revision: 5f605e254a0f81a41fd69025c572d597f3059ebc URL: https://github.com/llvm/llvm-project/commit/5f605e254a0f81a41fd69025c572d597f3059ebc DIFF: https://github.com/llvm/llvm-project/commit/5f605e254a0f81a41fd69025c572d597f3059ebc.diff

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f605e254a0f: [SanitizerBinaryMetadata] Respect no_sanitize(thread) function attribute (authored by melver). Repository: rG LLVM Github Monorepo

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5051 +return 5; + else +return 4; Instead of returning 4 here, I think it's best to just delegate to the other `GetDiagnosticTypeSpecifierID` function. That way, if the

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: ipriyanshi1708 wrote: > jrtc27 wrote: > > Why not just always pass the full DeclSpec and handle the class case here, > > maybe

[clang] 7674ae7 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T10:03:32+01:00 New Revision: 7674ae7231c4e286b93eb399e475765630666f8b URL: https://github.com/llvm/llvm-project/commit/7674ae7231c4e286b93eb399e475765630666f8b DIFF: https://github.com/llvm/llvm-project/commit/7674ae7231c4e286b93eb399e475765630666f8b.diff LOG:

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

melver created this revision. melver added a reviewer: dvyukov. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. To avoid false positives,

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

melver updated this revision to Diff 514871. melver added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148694/new/ https://reviews.llvm.org/D148694 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC but uploading for review for the pre-commit CI and maybe some actual

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

rsandifo-arm added a comment. See https://reviews.llvm.org/D139028 for previous discussion on this topic. https://reviews.llvm.org/D148700 contains the Attr.td support (and the main rationale) while https://reviews.llvm.org/D148702 contains the main Parse & Sema support. Repository: rG

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ Better to use “loongarch64” when talking about debian? Refer

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a subscriber: tomasz-kaminski-sonarsource. steakhal added a comment. In D148355#4279866 , @donat.nagy wrote: > @steakhal Thanks for the background information! > > I didn't know about D86874 so I indeed

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Nice improvement! I only have minor nitpicks and some recommendations for the taint API. Comment at:

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder updated this revision to Diff 514878. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148696/new/ https://reviews.llvm.org/D148696 Files: clang/include/clang/AST/DeclarationName.h clang/include/clang/Sema/Sema.h clang/lib/AST/DeclarationName.cpp clang/lib/Sema/Sema.cpp

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added subscribers: kristof.beyls, dschuff. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch retroactively classified all existing keyword

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @aaron.ballman ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:398 + )cpp", + {include_cleaner::Header{"bar.h"},

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1053 - for (auto I : CleanedState->get()) { + for (const auto : CleanedState->get()) { if (SymbolRef Sym = I.second.getAsSymbol()) I think this is supposed to be

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a subscriber: cfe-commits. chapuni added a comment. Seems this doesn't satisfy buildkite. Could anyone rework? BRANCHES main Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6 ___ cfe-commits mailing list

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a comment. I missed the failure since I am using newer version of bazel. BRANCHES main /utils/bazel/llvm-project-overlay/clang/BUILD.bazel:861 It should be moved into "dats" Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6

[clang] fbc63e5 - [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

Author: Jun Sha (Joshua) Date: 2023-04-20T10:19:14+08:00 New Revision: fbc63e5658f67036d4ea57940459074d9ecdd2d8 URL: https://github.com/llvm/llvm-project/commit/fbc63e5658f67036d4ea57940459074d9ecdd2d8 DIFF:

[clang] 914b38a - Revert '[RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual'

Author: Jun Sha (Joshua) Date: 2023-04-20T10:27:02+08:00 New Revision: 914b38aa4b9afe5001b0e3d5bc5125af0a5529f2 URL: https://github.com/llvm/llvm-project/commit/914b38aa4b9afe5001b0e3d5bc5125af0a5529f2 DIFF:

[clang] 3f81d25 - [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

Author: Jun Sha (Joshua) Date: 2023-04-20T10:32:24+08:00 New Revision: 3f81d25cee7065a4a7888bbe9ad7138081dcd4cf URL: https://github.com/llvm/llvm-project/commit/3f81d25cee7065a4a7888bbe9ad7138081dcd4cf DIFF:

[PATCH] D148617: [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f81d25cee70: [RISCV] Remove sx when parsing arch string to match the latest ISA manual (authored by joshua-arch1). Herald added a project: clang.

[PATCH] D148763: [Driver] Support response file in Fuchsia driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba3a2280398: [Driver] Support response file in Fuchsia driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9ba3a22 - [Driver] Support response file in Fuchsia driver

Author: Petr Hosek Date: 2023-04-20T02:44:40Z New Revision: 9ba3a22803980c1b32aa4371d87fff4d144ff3d0 URL: https://github.com/llvm/llvm-project/commit/9ba3a22803980c1b32aa4371d87fff4d144ff3d0 DIFF: https://github.com/llvm/llvm-project/commit/9ba3a22803980c1b32aa4371d87fff4d144ff3d0.diff LOG:

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I don't mind the changes in this stack, though this doing a little bit of a 'backdoor' way of getting the arm-streaming attribute in rubs me the wrong way. I'm not a huge fan that the solution we've got here only solves THIS problem, and doesn't extend to

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

erichkeane added a comment. I see a lot of other attributes are being marked with this CustomKeyword syntax, I find myself thinking tests should be written in terms of them, rather than a 'new'/'incomplete' attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. In D146591#4278074 , @xazax.hun wrote: > I am a bit overloaded at the moment, feel free to commit. I can still add > comments later that could be addressed in a follow up. Thanks! Happy to address as they come up.

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Thanks for the reviews! In D148702#4280392 , @erichkeane wrote: > So I don't mind the changes in this stack, though this doing a little bit of > a 'backdoor' way of getting

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 514954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options.td

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 514973. dkrupp marked an inline comment as done. dkrupp added a comment. - Implemented early return in getTaintedSymbols() when it is called by isTainted() for efficiency - Fixed test incompatibility on Windows CHANGES SINCE LAST ACTION

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 514976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang/include/clang/Basic/Module.h clang/lib/Basic/Module.cpp clang/lib/CodeGen/CodeGenModule.cpp

[clang] 89d2785 - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T14:15:58+01:00 New Revision: 89d27854ec7f5e8bd83e72fa574740bf3d06355b URL: https://github.com/llvm/llvm-project/commit/89d27854ec7f5e8bd83e72fa574740bf3d06355b DIFF: https://github.com/llvm/llvm-project/commit/89d27854ec7f5e8bd83e72fa574740bf3d06355b.diff LOG:

[clang] a443b3d - [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

Author: Sam McCall Date: 2023-04-19T15:37:06+02:00 New Revision: a443b3d18ef4d01e767994845b3f2819480a7b48 URL: https://github.com/llvm/llvm-project/commit/a443b3d18ef4d01e767994845b3f2819480a7b48 DIFF: https://github.com/llvm/llvm-project/commit/a443b3d18ef4d01e767994845b3f2819480a7b48.diff

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:106 +#include "clang/Basic/AttrTokenKinds.inc" +#undef KEYWORD + ); Does AttrTokenKinds.inc not do this undef for you? Most of our tablegen'ed/.td files tend to... Edit now

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

serge-sans-paille added a comment. In D147307#4279337 , @jyu2 wrote: > This change seems cause assert: > > https://godbolt.org/z/z9G87Wr37 I can reproduce, investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Febbe added a comment. Actually, I already wanted to add an enum, controlling this behavior. But even with an enum, this check should only remove includes in consecutive blocks, which could be relocated (are not split by `#defines` or a comment) Or I should add the options to

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Sorry I haven't been able to help yet, I'm STILL dealing with IT issues with the server I work on. I appreciate your patience! I have no comments, this all looks fine to me. Does this fix 62110 as well? Is there anythign to hold this up from landing? Repository:

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder updated this revision to Diff 514933. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148696/new/ https://reviews.llvm.org/D148696 Files: clang/include/clang/AST/DeclarationName.h

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

erichkeane added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } tbaeder wrote: > It's weird that the above two statements warn about using `__FUNCTION__` and > the return statement doesn't.

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

carlosgalvezp added a comment. First of all thank you for the contribution! I had just a quick look so here's some very preliminary comments, will have more time to deeply review during the weekend: - Unfortunately we cannot simply rename a check like this, since it breaks backwards

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/noexcept-special-functions.rst:10 +`performance-noexcept-special-functions <../performance/noexcept-special-functions.html>`_ +for more information.

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } erichkeane wrote: > tbaeder wrote: > > It's weird that the above two statements warn about using `__FUNCTION__` > > and the return

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. expr.prim.lambda.capture p5 says: If an identifier in a capture appears as the declarator-id of a parameter of the

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa443b3d18ef4: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state (authored by sammccall). Changed prior to commit:

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. With moving the signature before the function entry this looks good to me. I'm not so familiar with the code in https://reviews.llvm.org/D148665 would ideally find someone a bit

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon abandoned this revision. agozillon added a comment. Herald added a subscriber: bviyer. Closing this patch now that each individual component is upstreamed via seperate phabricator patches! Thank you to all the reviewers for your time and help. Repository: rG LLVM Github Monorepo

[clang] bbffa8b - [dataflow] add missing clangLex dep after a443b3d18ef4d01e7

Author: Sam McCall Date: 2023-04-19T16:12:42+02:00 New Revision: bbffa8bd75fdaca8029e9719fa96923a3b15e2fd URL: https://github.com/llvm/llvm-project/commit/bbffa8bd75fdaca8029e9719fa96923a3b15e2fd DIFF: https://github.com/llvm/llvm-project/commit/bbffa8bd75fdaca8029e9719fa96923a3b15e2fd.diff

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp marked an inline comment as done. dkrupp added a comment. @steakhal thanks for your review. All your remarks have been fixed. Comment at: clang/lib/StaticAnalyzer/Checkers/Taint.cpp:147-150 bool taint::isTainted(ProgramStateRef State, const Stmt *S,

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson added inline comments. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the processor to exit the pending state. /// goldstein.w.n wrote: > interrupts too.

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD)

  1   2   >