[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 522064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/include/clang/Basic/BuiltinsARM.def

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added a comment. I have polished the implementation about the fix-all for missing-include diagnostics, please take a look on the new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/ https://reviews.llvm.org/D149437

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource added a comment. In D150258#4337880 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like used for patch attribution? Thanks a lot! And yes, I would

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522075. mboehme added a comment. Set `-fnodelayed-template-parsing` again. This is needed to make tests pass on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149733/new/ https://reviews.llvm.org/D149733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added a comment. In D150282#4341060 , @Jake-Egan wrote: > Hi, this fails on AIX. It looks like it still produces the > `/tmp/lit-tmp-*/[ab]-*.json` format. Can you take a look please? > >

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. Rebased on main, and removed dependence on the SME attributes patch as per https://reviews.llvm.org/D127910?vs=522039=522064#inline-1451681. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2537 -TEST(TransferTest, DerefDependentPtr) { std::string Code = R"( mboehme wrote: > gribozavr2 wrote: > > This `DerefDependentPtr` test was originally added

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4341052 , @uabelho wrote: > Compiling with clang 15.0.5 I get the following warning/error with this patch: > > ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly > defaulted move assignment

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments! Comment at: clang/lib/Driver/ToolChains/AIX.cpp:132 +// possible. Then `-bforceimprw` changes such sections to

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522083. kuganv added a comment. Fixed tests clangd/unittests/TUSchedulerTests.cpp require re-warite due to delayed onPreambleAST callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

rjmccall added a comment. This memory is supposed to be initialized when we copy the `TypeLoc`. Are you observing that not happening? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. In D150499#4341115 , @rjmccall wrote: > This memory is supposed to be initialized when we copy the `TypeLoc`. Are > you observing that not happening? Yes. There is the msan report in the description. Repository: rG LLVM

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/62679.

[clang] 2f99932 - [Driver][test] Add -fintegrated-as after D150282

Author: Fangrui Song Date: 2023-05-14T23:09:31-07:00 New Revision: 2f999327534f7cc660d2747ce294f50184dc1f97 URL: https://github.com/llvm/llvm-project/commit/2f999327534f7cc660d2747ce294f50184dc1f97 DIFF: https://github.com/llvm/llvm-project/commit/2f999327534f7cc660d2747ce294f50184dc1f97.diff

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein updated this revision to Diff 522067. hokein marked 3 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. address comments and polish implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this. The code in question was dead before as far as I can tell, since the `Ranges` list was always empty. I can't add this without regressing any of the existing tests. CHANGES SINCE LAST ACTION

[PATCH] D150548: [clangd] Deduplicate diagnostic codeaction fixes when the codeaction fixes multiple diagnostics

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. If it would be possible to get some poor reviewers precious time on this I would greatly appreciate it! Thank you very much ahead of time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/

[clang] 1a42f79 - [clang][dataflow] Don't analyze templated declarations.

Author: Martin Braenne Date: 2023-05-15T11:04:51Z New Revision: 1a42f795587b9d57291d009989aace6efd0a7a7f URL: https://github.com/llvm/llvm-project/commit/1a42f795587b9d57291d009989aace6efd0a7a7f DIFF: https://github.com/llvm/llvm-project/commit/1a42f795587b9d57291d009989aace6efd0a7a7f.diff

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a42f795587b: [clang][dataflow] Dont analyze templated declarations. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman created this revision. jobnoorman added reviewers: chandlerc, grosbach, andreadb, MaskRay, craig.topper. Herald added subscribers: bviyer, asb, luke, Moerafaat, zero9178, bzcheeseman, pmatos, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov,

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. To enable specific EEW for specific insturction in instruction selection, I will create some parent revisions. Here is the first one. https://reviews.llvm.org/D150550 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan added a comment. @Bigcheese, @ChuanqiXu, could you please take a look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850 ___ cfe-commits

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Sorry for misleading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850 ___ cfe-commits

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522096. mboehme added a comment. Spell `-fno-delayed-template-parsing` correctly (it was missing a hyphen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files:

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. @aaron.ballman this won;t get approve by core un In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

mkmvzlb created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mkmvzlb requested review of this

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGb321738f7125: [clang][parser] Fix namespace dropping after malformed declarations (authored by alejandro-alvarez-sonarsource, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[clang] b321738 - [clang][parser] Fix namespace dropping after malformed declarations

Author: Alejandro Álvarez Ayllón Date: 2023-05-15T07:39:58-04:00 New Revision: b321738f71259d138c9b2002944eb65f099ec2a6 URL: https://github.com/llvm/llvm-project/commit/b321738f71259d138c9b2002944eb65f099ec2a6 DIFF:

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149997#4338897 , @mstorsjo wrote: > Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda > ugly way of checking for an MSVC-like environment specifically

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D149276#4341552 , @cor3ntin wrote: > @aaron.ballman this won;t get approve by core un > > In D149276#4302700

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions We shouldn't call it `ISO C++ 2026` until it's published by

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 522136. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev updated this revision to Diff 522140. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added a comment. i think something went wrong with the diff, you don't seem to update PreambleCallbacks to trigger indexing on a different thread at all (and also there are certain lifetime issues). is this the final version of the patch or did I bump into a WIP version unknowingly ?

[clang] 292a6c1 - Fix build error caused by https://reviews.llvm.org/D149718

Author: Manna, Soumi Date: 2023-05-15T06:03:47-07:00 New Revision: 292a6c1c2395f990bbde8d968825243e4fe9b954 URL: https://github.com/llvm/llvm-project/commit/292a6c1c2395f990bbde8d968825243e4fe9b954 DIFF: https://github.com/llvm/llvm-project/commit/292a6c1c2395f990bbde8d968825243e4fe9b954.diff

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. Thank you very much @kiranchandramohan! More than happy to wait a day incase anyone else wishes to do a final review. I'll add the Nits where possible when I commit the patch upstream and it should hopefully update the review with the alterations! Repository: rG

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. @krisb is out of office for some time, so she asked to retake and wrap up this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006

[clang-tools-extra] d0e8911 - [clangd] Fix fixAll not shown when there is only one unused-include and missing-include diagnostics.

Author: Haojian Wu Date: 2023-05-15T14:02:20+02:00 New Revision: d0e89116aff224ac2d8d3f88029ae44e12c9b6cc URL: https://github.com/llvm/llvm-project/commit/d0e89116aff224ac2d8d3f88029ae44e12c9b6cc DIFF: https://github.com/llvm/llvm-project/commit/d0e89116aff224ac2d8d3f88029ae44e12c9b6cc.diff

[PATCH] D149822: [clangd] Fix fixAll not shown when there is only one unused-include and missing-include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0e89116aff2: [clangd] Fix fixAll not shown when there is only one unused-include and missing… (authored by hokein). Repository: rG LLVM Github

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 522132. qiongsiwu1 added a comment. Thanks so much @hubert.reinterpretcast !! The comments are addressed. I will land the patch when the pre-commit CI finishes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522138. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGenCXX/debug-info-namespace.cpp

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman added a comment. In D149733#4321610 , @kadircet wrote: >> However, I'm not keen on us playing whack-a-mole with the kinds of checks >> from this review. For starters, that's going to have a long-tail that makes >> it hard to know if we've

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/analyzer/checkers.rst:2457 If the user disables the checker then the argument violation warning is suppressed. However, the

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis marked 3 inline comments as done. TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

jankuehle created this revision. jankuehle added projects: clang, clang-format. Herald added a project: All. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jankuehle requested review of this revision.

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Please wait a day before submitting. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:455-468 + auto Buf =

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150563/new/ https://reviews.llvm.org/D150563

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. > I think we probably should have a broader discussion before moving forward > here. It's not that this isn't incremental progress fixing an issue, but it's > more that this same justification works to add the workaround 200 more times > without ever addressing the

[PATCH] D150566: [clang] Provide source range to 'invalid subexpr in const expr' diags

tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150566

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske updated this revision to Diff 522192. balazske added a comment. Applied review suggestions, removed the list of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149447/new/ https://reviews.llvm.org/D149447 Files:

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

amyk added a comment. Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots. In particular, the `const-str-array-decay.cl` appears to be failing. The failing build can be seen in:

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 522201. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst

[PATCH] D89046: [AST] Build recovery expression by default for all language.

shafik added a comment. Herald added a project: All. Hello folks, it looks like this PR is linked to a crash bug: https://github.com/llvm/llvm-project/issues/62711 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 created this revision. xry111 added reviewers: thesamesam, MaskRay, uabelho. Herald added subscribers: kadircet, arphaman. Herald added a project: All. xry111 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra.

[clang] 0d1be98 - [clang][USR] Prevent crashes on incomplete FunctionDecls

Author: Kadir Cetinkaya Date: 2023-05-15T18:05:48+02:00 New Revision: 0d1be98a67e29b70ccfab23d86a2bea13de117d7 URL: https://github.com/llvm/llvm-project/commit/0d1be98a67e29b70ccfab23d86a2bea13de117d7 DIFF:

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d1be98a67e2: [clang][USR] Prevent crashes on incomplete FunctionDecls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2490-2523 +**List of checked functions** + +``fgetc``, ``fread``, ``fwrite``, ``getc``, ``getchar``, ``getdelim``, +``getenv``, ``getline``, ``isalnum``,

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147621/new/ https://reviews.llvm.org/D147621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

uabelho added a comment. Hello, ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: error: 'build' is deprecated: Use the version that takes a const Decl & instead [-Werror,-Wdeprecated-declarations] ControlFlowContext::build(, *FuncDecl.getBody(),

[PATCH] D150450: Add C++26 compile flags.

erichkeane marked 8 inline comments as done. erichkeane added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions aaron.ballman

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522199. erichkeane added a comment. Aarons comments, split 23 changes into a separate patch and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster created this revision. VoltrexMaster added reviewers: Amir, samsonov, STL_MSFT, jordan_rose, rsmith. Herald added a reviewer: bollu. Herald added subscribers: Enna1, wenlei, jvesely, arphaman. Herald added a project: All. VoltrexMaster requested review of this revision. Herald added

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522214. erichkeane added a comment. change __cplusplus to match GCC's plan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst clang/docs/ReleaseNotes.rst

[clang] b763d6a - Add C++26 compile flags.

Author: Erich Keane Date: 2023-05-15T08:56:16-07:00 New Revision: b763d6a4ed4650c74c6846d743156468563b0e31 URL: https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31 DIFF: https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31.diff

[PATCH] D150450: Add C++26 compile flags.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb763d6a4ed46: Add C++26 compile flags. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin marked 2 inline comments as done. yronglin added a comment. In D150528#4342600 , @aaron.ballman wrote: > In D150528#4342535 , @yronglin > wrote: > >> Thanks a lot for your review @aaron.ballman ! BTW,

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.cpp:15 -#undef __cplusplus +#undef __cplusplus // expected-warning {{undefining builtin macro}} #define __cplusplus Why do we diagnose the undef but not the define?

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added a comment. > Is there more context on why Android enables the frame pointer? From what i gathered, this is more of an effort to have parity such that existing build flag overrides continue to be consistent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder abandoned this revision. tbaeder added a comment. I've already abandoned this locally, pretty sure I'll end up taking another approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/ https://reviews.llvm.org/D137706 ___

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrList.inc. We use if-else statements + // to classify each of them. I think this is something we need to just do the right way, right

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin marked 3 inline comments as done. yronglin added a comment. Thanks a lot for your review @aaron.ballman ! BTW, does the most good approach is that we just add a new `ParsedAttribute` with `TypeSourceInfo` but not an `UnaryExprOrTypeTraitExpr`? Comment at:

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrList.inc. We use if-else statements + // to classify each of them. erichkeane wrote: > I think this is something we need to just

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4342516 , @aaron.ballman wrote: > In D150226#4340166 , @manojgupta > wrote: > >> https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h >> >> gdb only

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. In D139586#4342868 , @rZhBoYao wrote: > In D139586#4324857 , @cor3ntin > wrote: > >> @rZhBoYao are you still working on this? Thanks! > > No. Sorry that I don't have the capacity to

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added a comment. Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added to ubsan_minimal_runtime if this is supported in the minimal runtime? Comment at: clang/lib/CodeGen/CGExpr.cpp:5382 + getPointerAlign()); llvm::Value

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

yaxunl added a comment. In D147732#4343146 , @jrbyrnes wrote: > Hi @yaxunl thanks for the comment. > > I looked into AutoUpgrade, and it catches upgrades of this type (unmangled -> > mangled) by default (via remangleIntrinsicFunction). I've included

[clang] eff52b1 - Fix test from b763d6a4ed4650c74c6846d743156468563b0e31

Author: Erich Keane Date: 2023-05-15T09:43:25-07:00 New Revision: eff52b1fca2b61fe3aa904026b5ce10d055dfe1d URL: https://github.com/llvm/llvm-project/commit/eff52b1fca2b61fe3aa904026b5ce10d055dfe1d DIFF: https://github.com/llvm/llvm-project/commit/eff52b1fca2b61fe3aa904026b5ce10d055dfe1d.diff

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522257. dzhidzhoev added a comment. Fixed split-dwarf-local-import*.ll tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files:

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D150528#4342646 , @yronglin wrote: > In D150528#4342600 , @aaron.ballman > wrote: > >> In D150528#4342535

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added a comment. In D150490#4343128 , @hiraditya wrote: >> Is there more context on why Android enables the frame pointer? > > From what i gathered, this is more of an effort to have parity such that > existing build flag overrides continue to be

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150040: [clang][Interp] Call invalid destructors

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150040/new/ https://reviews.llvm.org/D150040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150450: Add C++26 compile flags.

Mordante added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions erichkeane wrote: > aaron.ballman wrote: > > We shouldn't call it

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you Erich! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; junaire wrote: > v.g.vassilev

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham, MaskRay, cebowleratibm. qiongsiwu1 added a project: clang. Herald added subscribers: kristof.beyls, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 added a comment. I can revise the case and add it as a backend/llc test case if we would like to keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150586/new/ https://reviews.llvm.org/D150586

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

RKSimon added a comment. @pengfei Any objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf98698714e2e: Enable frame pointer for all non-leaf functions on riscv64 Android (authored by AdityaK 1894981+hiradi...@users.noreply.github.com).

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 522252. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[clang] 8097d01 - Revert "[AIX][tests] XFAIL -ftime-trace test for now"

Author: Jake Egan Date: 2023-05-15T13:50:21-04:00 New Revision: 8097d01260fc251c613e848607db1d7dbddaa22c URL: https://github.com/llvm/llvm-project/commit/8097d01260fc251c613e848607db1d7dbddaa22c DIFF: https://github.com/llvm/llvm-project/commit/8097d01260fc251c613e848607db1d7dbddaa22c.diff

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103 + bool IsEligibleForCompilation = + FuncDecl->isConstexpr() || + (isa(FuncDecl) && + cast(FuncDecl)->isLambdaStaticInvoker()); I don't like the

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result,

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Patch to remove the problematic test case. https://reviews.llvm.org/D150586 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150520#4342429 , @amyk wrote: > Hi, I just wanted to give a heads up that it appears that this patch is > causing failures on some of the PPC buildbots. > In particular, the `const-str-array-decay.cl` appears to be

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias marked 3 inline comments as done. galenelias added a comment. Thanks for the review and feedback. Sorry about the unfortunate timing between @sstwcw and my fix - we submitted our fixes less than 24 hours apart. I didn't think there would be another simultaneous fix for this 5 year

  1   2   3   >