[clang] 35a0079 - [RISCV] Add Zvfhmin extension for clang.

Author: Jianjian GUAN Date: 2023-05-31T14:31:11+08:00 New Revision: 35a0079238ce9fc36cdc8c6a2895eb5538bf7b4a URL: https://github.com/llvm/llvm-project/commit/35a0079238ce9fc36cdc8c6a2895eb5538bf7b4a DIFF: https://github.com/llvm/llvm-project/commit/35a0079238ce9fc36cdc8c6a2895eb5538bf7b4a.diff

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35a0079238ce: [RISCV] Add Zvfhmin extension for clang. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bb6c036 - [clang][Diagnostics][NFC] Use getFileID() directly

Author: Timm Bäder Date: 2023-05-31T09:57:16+02:00 New Revision: bb6c036ef378de321d5b7fc0ada317f91c88570d URL: https://github.com/llvm/llvm-project/commit/bb6c036ef378de321d5b7fc0ada317f91c88570d DIFF: https://github.com/llvm/llvm-project/commit/bb6c036ef378de321d5b7fc0ada317f91c88570d.diff

[clang] 543c929 - [clang][Diagnostics][NFC] Remove unused Indentation parameter

Author: Timm Bäder Date: 2023-05-31T10:17:03+02:00 New Revision: 543c92969ba867434af6688808998b82496e9dc1 URL: https://github.com/llvm/llvm-project/commit/543c92969ba867434af6688808998b82496e9dc1 DIFF: https://github.com/llvm/llvm-project/commit/543c92969ba867434af6688808998b82496e9dc1.diff

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 526936. rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Rebase to account for a diagnostic that has moved. No other changes from the previous version. I'll wait for the build results before pushing. Thanks for the review!

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

mstorsjo added a comment. Thanks! +1 from me, this does clear up all the issues I've had - it supersedes D151662 and makes the external patch to avoid doing `-U__STRICT_ANSI__` unnecessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151286: [clang][Diagnostics][NFC] Don't create oversized CaretLine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01578153ee82: [clang][Diagnostics][NFC] Dont create oversized CaretLine (authored by tbaeder). Changed prior to commit:

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

Fznamznon added reviewers: erichkeane, shafik. Fznamznon added a comment. The change looks reasonable for me, though I'm not experienced in related code. Have you checked that it fixes the non-reduced original example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 526915. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp

[clang-tools-extra] b0bab14 - [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

Author: Balázs Kéri Date: 2023-05-31T09:55:01+02:00 New Revision: b0bab14b8b5305ddcb4e8b4d8a0e64004fc5425e URL: https://github.com/llvm/llvm-project/commit/b0bab14b8b5305ddcb4e8b4d8a0e64004fc5425e DIFF: https://github.com/llvm/llvm-project/commit/b0bab14b8b5305ddcb4e8b4d8a0e64004fc5425e.diff

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0bab14b8b53: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/

[PATCH] D151100: [clang][Diagnostics] Merge byte/column mapping functions into one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f0b8d219cb: [clang][Diagnostics][NFC] Merge byte/column mapping functions into one. (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 50f0b8d - [clang][Diagnostics][NFC] Merge byte/column mapping functions into one.

Author: Timm Bäder Date: 2023-05-31T10:00:08+02:00 New Revision: 50f0b8d219cb1557625ce768ea78670d13671e1d URL: https://github.com/llvm/llvm-project/commit/50f0b8d219cb1557625ce768ea78670d13671e1d DIFF: https://github.com/llvm/llvm-project/commit/50f0b8d219cb1557625ce768ea78670d13671e1d.diff

[PATCH] D151789: [test] Add llc to the list of known tools for clang tests (NFCI)

barannikov88 created this revision. Herald added a project: All. barannikov88 added a reviewer: erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some tests such as CodeGen/2005-09-24-AsmUserPrefix.c use llc. This

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4380786 , @MaskRay wrote: > If we are certain this will not be reverted and cause churn, making the > header switch in one single patch looks fine to me... Great. I'm not sure if we can ever be a 100% certain it

[clang] a806b3f - [clang][Diagnostics][NFC] Remove unnecessary StringRef

Author: Timm Bäder Date: 2023-05-31T10:21:24+02:00 New Revision: a806b3f49667f3aa0800572b84f91b77654e29fd URL: https://github.com/llvm/llvm-project/commit/a806b3f49667f3aa0800572b84f91b77654e29fd DIFF: https://github.com/llvm/llvm-project/commit/a806b3f49667f3aa0800572b84f91b77654e29fd.diff

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa806b3f49667: [clang][Diagnostics][NFC] Remove unnecessary StringRef (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151300/new/

[PATCH] D151634: [clang] Add test for CWG253

Endill added a comment. @shafik Thank you for letting me know! Now I wonder if it was possible to realize by myself without prior knowledge of CWG 2536, because I feel like some cross-references are missing. Can we proceed if I strip CWG 78 out, leaving only CWG 253? Repository: rG LLVM

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

hokein added a comment. It looks good overall. I left some comments around the interfaces. Let me know if I miss/misunderstand something. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:88 +class IncludeSpeller { +public:

[PATCH] D151786: [Tooling] Remove unused function setRestoreWorkingDir

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 146ec74a8382dc820809d0a2bf4b918d0b5e6603 Author: Jan Svoboda Date: Fri Sep 10

[clang] 1c76548 - [clang][Diagnostics] Use llvm::raw_ostream::indent()

Author: Timm Bäder Date: 2023-05-31T09:40:24+02:00 New Revision: 1c765483fd34efe3ff7f71a9d2d5781bdf3d4517 URL: https://github.com/llvm/llvm-project/commit/1c765483fd34efe3ff7f71a9d2d5781bdf3d4517 DIFF: https://github.com/llvm/llvm-project/commit/1c765483fd34efe3ff7f71a9d2d5781bdf3d4517.diff

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c765483fd34: [clang][Diagnostics] Use llvm::raw_ostream::indent() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Before F27754400: before.png After F27754403: after.png (Sorry for posting screenshots directly and bringing any inconvenience for email users.) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 526965. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp

[PATCH] D151783: [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

serge-sans-paille created this revision. serge-sans-paille added a reviewer: mstorsjo. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up to https://reviews.llvm.org/D148723

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske updated this revision to Diff 526927. balazske added a comment. removed check name in documentation code comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/ https://reviews.llvm.org/D151431 Files:

[clang] ddff70c - [clang][Interp][NFC] Make InterpFrame::describe() more const-correct

Author: Timm Bäder Date: 2023-05-31T09:01:57+02:00 New Revision: ddff70cb4b0017489d98bf301a5bcc4f9fa4afab URL: https://github.com/llvm/llvm-project/commit/ddff70cb4b0017489d98bf301a5bcc4f9fa4afab DIFF: https://github.com/llvm/llvm-project/commit/ddff70cb4b0017489d98bf301a5bcc4f9fa4afab.diff

[PATCH] D151704: [clang] Add test for CWG873

This revision was automatically updated to reflect the committed changes. Closed by commit rG238f15820e71: [clang] Add test for CWG873 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151704/new/ https://reviews.llvm.org/D151704

[clang] 238f158 - [clang] Add test for CWG873

Author: Vlad Serebrennikov Date: 2023-05-31T10:17:27+03:00 New Revision: 238f15820e71080b0bbc7d6ee95303fdb430d6fa URL: https://github.com/llvm/llvm-project/commit/238f15820e71080b0bbc7d6ee95303fdb430d6fa DIFF:

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

rsandifo-arm updated this revision to Diff 526944. rsandifo-arm added a comment. Update base commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148699/new/ https://reviews.llvm.org/D148699 Files: clang/include/clang/Basic/Attr.td Index:

[PATCH] D151783: [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'm not familiar with the code in question to know whether this really is the right thing to do etc, but this fixes my testcase (both the reduced one and the full one).

[clang] 39f4bd2 - [clang][Interp][NFC] Simplify dump() indentation

Author: Timm Bäder Date: 2023-05-31T09:01:57+02:00 New Revision: 39f4bd214f1be248283fb7e35bc2610c19169252 URL: https://github.com/llvm/llvm-project/commit/39f4bd214f1be248283fb7e35bc2610c19169252 DIFF: https://github.com/llvm/llvm-project/commit/39f4bd214f1be248283fb7e35bc2610c19169252.diff

[clang] a0ea9f6 - [clang] Fix 39f4bd214f1be248283fb7e35bc2610c19169252 on win builders

Author: Timm Bäder Date: 2023-05-31T09:13:48+02:00 New Revision: a0ea9f63c25b1cd4cb7747ea611596bb5e2db8a3 URL: https://github.com/llvm/llvm-project/commit/a0ea9f63c25b1cd4cb7747ea611596bb5e2db8a3 DIFF: https://github.com/llvm/llvm-project/commit/a0ea9f63c25b1cd4cb7747ea611596bb5e2db8a3.diff

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek updated this revision to Diff 526948. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 Files: bolt/CMakeLists.txt

[clang] b5c7892 - [clang][Diagnostics][NFC] Move Buf{Start,End} out of the loop

Author: Timm Bäder Date: 2023-05-31T10:21:24+02:00 New Revision: b5c7892d54f8d415e3e0198e067886c825f26e0c URL: https://github.com/llvm/llvm-project/commit/b5c7892d54f8d415e3e0198e067886c825f26e0c DIFF: https://github.com/llvm/llvm-project/commit/b5c7892d54f8d415e3e0198e067886c825f26e0c.diff

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:45 + SourceLocation SymRefLocation; + std::string MissingHeaderSpelling; +}; storing a string instance for header per system reference is expensive (we might

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu added a comment. Please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151608/new/ https://reviews.llvm.org/D151608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 526963. vikramRH added a comment. Handled most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Basic/TargetOptions.h

[clang] b7e5cb1 - [clang][NFC] Refactor emitSnippet()

Author: Timm Bäder Date: 2023-05-31T09:21:23+02:00 New Revision: b7e5cb1f9a3a5226f22bb81c865214be81dce940 URL: https://github.com/llvm/llvm-project/commit/b7e5cb1f9a3a5226f22bb81c865214be81dce940 DIFF: https://github.com/llvm/llvm-project/commit/b7e5cb1f9a3a5226f22bb81c865214be81dce940.diff

[PATCH] D150840: [clang][NFC] Refactor emitSnippet()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e5cb1f9a3a: [clang][NFC] Refactor emitSnippet() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch alleviates

[clang] c113cbb - [clang][Diagnostic][NFC] Simplify emitDiagnosticLoc

Author: Timm Bäder Date: 2023-05-31T09:40:24+02:00 New Revision: c113cbb51005108d1380a4b9d501ddeb1366a406 URL: https://github.com/llvm/llvm-project/commit/c113cbb51005108d1380a4b9d501ddeb1366a406 DIFF: https://github.com/llvm/llvm-project/commit/c113cbb51005108d1380a4b9d501ddeb1366a406.diff

[PATCH] D151093: [clang][Diagnostic] Simplify emitDiagnosticLoc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc113cbb51005: [clang][Diagnostic][NFC] Simplify emitDiagnosticLoc (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 895b555 - [clang][Diagnostics][NFC] Move variable decl into if statement

Author: Timm Bäder Date: 2023-05-31T10:49:06+02:00 New Revision: 895b55537870cdaf6e4c304a09f4bf01954ccbd6 URL: https://github.com/llvm/llvm-project/commit/895b55537870cdaf6e4c304a09f4bf01954ccbd6 DIFF: https://github.com/llvm/llvm-project/commit/895b55537870cdaf6e4c304a09f4bf01954ccbd6.diff

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. Companion patch that fixes the issue reported by @mstorsjo : https://reviews.llvm.org/D151783 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723

[clang] 49843c5 - [clang][Diagnostics] Simplify emitSnippet()

Author: Timm Bäder Date: 2023-05-31T09:40:24+02:00 New Revision: 49843c5036847a8e2f83852c8a515c2784a1645e URL: https://github.com/llvm/llvm-project/commit/49843c5036847a8e2f83852c8a515c2784a1645e DIFF: https://github.com/llvm/llvm-project/commit/49843c5036847a8e2f83852c8a515c2784a1645e.diff

[PATCH] D151075: [clang][Diagnostics] Simplify emitSnippet()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49843c503684: [clang][Diagnostics] Simplify emitSnippet() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0157815 - [clang][Diagnostics][NFC] Don't create oversized CaretLine

Author: Timm Bäder Date: 2023-05-31T10:21:24+02:00 New Revision: 01578153ee8228562d0f64d3847e7fc91573da36 URL: https://github.com/llvm/llvm-project/commit/01578153ee8228562d0f64d3847e7fc91573da36 DIFF: https://github.com/llvm/llvm-project/commit/01578153ee8228562d0f64d3847e7fc91573da36.diff

[clang] 3184fb9 - [clang][Diagnostics] Print empty lines in multiline snippets

Author: Timm Bäder Date: 2023-05-31T10:21:24+02:00 New Revision: 3184fb958091f6b119c878e2eab894d799432686 URL: https://github.com/llvm/llvm-project/commit/3184fb958091f6b119c878e2eab894d799432686 DIFF: https://github.com/llvm/llvm-project/commit/3184fb958091f6b119c878e2eab894d799432686.diff

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3184fb958091: [clang][Diagnostics] Print empty lines in multiline snippets (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH marked 11 inline comments as done. vikramRH added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:64 +// CHECK-NEXT:[[PRINTBUFFNEXTPTR4:%.*]] = getelementptr inbounds i8, ptr addrspace(1) [[PRINTBUFFNEXTPTR3]], i64 [[TMP13]] +//

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH marked 2 inline comments as done. vikramRH added inline comments. Comment at: clang/include/clang/Driver/Options.td:1030 NegFlag>; +def mprintf_kind_EQ : Joined<["-"], "mprintf-kind=">, Group, + HelpText<"Specify the printf lowering scheme (AMDGPU only), allowed

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4375881 , @hctim wrote: > Hey, found another error that occurs when building Android that looks to be > different from @maskray's revert. > ... Thanks for the report and the tiny reproducer! I've written D151795

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/CMakeLists.txt:5 -# Dependencies should be minimal to avoid long dep paths in the build graph. -# It does use clangBasic headers (tok::TokenKind), but linking is not needed. -# We have no

[PATCH] D148614: [clang][Interp] Add frame depth checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGda836b36bc35: [clang][Interp] Track frame depth (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148614/new/

[clang] da836b3 - [clang][Interp] Track frame depth

Author: Timm Bäder Date: 2023-05-31T12:08:03+02:00 New Revision: da836b36bc3540d21c947a95474d2bb6cc458951 URL: https://github.com/llvm/llvm-project/commit/da836b36bc3540d21c947a95474d2bb6cc458951 DIFF: https://github.com/llvm/llvm-project/commit/da836b36bc3540d21c947a95474d2bb6cc458951.diff

[clang] 81522a0 - [clang][Interp] Optionally cast comparison result to non-bool

Author: Timm Bäder Date: 2023-05-31T13:01:01+02:00 New Revision: 81522a012accfcc6bbf4dfa21a793aea6e4e532a URL: https://github.com/llvm/llvm-project/commit/81522a012accfcc6bbf4dfa21a793aea6e4e532a DIFF: https://github.com/llvm/llvm-project/commit/81522a012accfcc6bbf4dfa21a793aea6e4e532a.diff

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81522a012acc: [clang][Interp] Optionally cast comparison result to non-bool (authored by tbaeder). Changed prior to commit:

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added a comment. In D151553#4380667 , @erichkeane wrote: > Like @cor3ntin I'm concerned about removing the transform call. I'm just as > concerned that it caused no regressions... > > If we have to transform the arguments, then this can be a

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added a comment. @steakhal should the release notes page be updated to add this? I think this could be beneficial for the users to be aware of that change. If yes, who is responsible for doing that? Developers? (me) or someone else is taking care of reviewing the list of changes

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

CarolineConcatto marked 2 inline comments as done. CarolineConcatto added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:56 // P: boolean +// Qa: svcount // U: unsigned hassnaa-arm wrote: > sdesmalen wrote: > > The typespec modifier in this

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527024. john.brawn added a comment. Add more testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c Index:

[PATCH] D151730: [WIP][RISCV] Support target attribute for function

BeMg updated this revision to Diff 526988. BeMg added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150910/new/ https://reviews.llvm.org/D150910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e5399f1 - [Headers][doc] Add shuffle-like intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-05-31T06:33:18-07:00 New Revision: e5399f1d7cabfca90030ca03f52818e892aa389f URL: https://github.com/llvm/llvm-project/commit/e5399f1d7cabfca90030ca03f52818e892aa389f DIFF: https://github.com/llvm/llvm-project/commit/e5399f1d7cabfca90030ca03f52818e892aa389f.diff

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5399f1d7cab: [Headers][doc] Add shuffle-like intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang.

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. TBH we don't really have processes there. And its a bit of a mess, regarding CSA. Usually we forgot to update the release notes, and at best we aggregate the changes just prior a release for the release notes. But we haven't done it for the last two releases for

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah added inline comments. Comment at: flang/include/flang/Frontend/FrontendOptions.h:42 + /// resulting FIR + EmitHLFIRToFIR, + awarzynski wrote: > To me having `EmitFIR` and `EmitHLFIR` would make more sense. With 2 > dialects, `EmitMLIR` becomes rather

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

nikic added a comment. Can you please drop all wasm related tests and instead add an InstCombine test for the fsh+and pattern? It would also be good to have a test where we can fold one side to a constant, but that constant is not zero. We should then consider whether that is profitable or

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:56 // P: boolean +// Qa: svcount // U: unsigned sdesmalen wrote: > The typespec modifier in this file can remain `Q` rather than `Qa`. Can you > change it back? what if there

[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

yronglin added a comment. ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151121/new/ https://reviews.llvm.org/D151121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 527027. tomasz-kaminski-sonarsource added a comment. Added function to query stack frame for temporary object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl updated this revision to Diff 527034. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150985/new/ https://reviews.llvm.org/D150985 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:170-175 +diag(Inc.SymRefLocation, "missing include %0") +<< Inc.MissingHeaderSpelling +<< FixItHint::CreateInsertion( +

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

thakis added subscribers: sammccall, thakis. thakis added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/CMakeLists.txt:5 -# Dependencies should be minimal to avoid long dep paths in the build graph. -# It does use clangBasic headers (tok::TokenKind), but

[clang] ce97312 - Implement BufferOverlap check for sprint/snprintf

Author: Arnaud Bienner Date: 2023-05-31T14:43:16+02:00 New Revision: ce97312d109b21acb97d3ea243e214f20bd87cfc URL: https://github.com/llvm/llvm-project/commit/ce97312d109b21acb97d3ea243e214f20bd87cfc DIFF:

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

This revision was automatically updated to reflect the committed changes. Closed by commit rGce97312d109b: Implement BufferOverlap check for sprint/snprintf (authored by ArnaudBienner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

MaskRay added inline comments. Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: FileCheck -allow-empty --check-prefix

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

MaskRay added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:195 +if (!hasV6MOps()) + llvm_unreachable("Cannot generate execute-only code for this target"); } If this code path is actually reachable, a proper error reporting will

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:163-172 + // C defines macros starting with __STDC, and C++ defines macros starting with + // __STDCPP + if (MacroName.startswith("__STDC")) +return

[clang] 40c26ec - [clang][Interp] Fix diagnosing uninitialized ctor record arrays

Author: Timm Bäder Date: 2023-05-31T11:39:40+02:00 New Revision: 40c26ec48c8a8ec3c72dde912d3d7118917c8e71 URL: https://github.com/llvm/llvm-project/commit/40c26ec48c8a8ec3c72dde912d3d7118917c8e71 DIFF: https://github.com/llvm/llvm-project/commit/40c26ec48c8a8ec3c72dde912d3d7118917c8e71.diff

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c26ec48c8a: [clang][Interp] Fix diagnosing uninitialized ctor record arrays (authored by tbaeder). Changed prior to commit:

[clang] 722fc7e - [clang][Interp] Add missing static_assert messages

Author: Timm Bäder Date: 2023-05-31T12:28:22+02:00 New Revision: 722fc7e7ff8672d9b6b1493a28b850775082948e URL: https://github.com/llvm/llvm-project/commit/722fc7e7ff8672d9b6b1493a28b850775082948e DIFF: https://github.com/llvm/llvm-project/commit/722fc7e7ff8672d9b6b1493a28b850775082948e.diff

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

erichkeane added a comment. In D151683#4382408 , @philnik wrote: > In D151683#4380877 , @erichkeane > wrote: > >> What is the justification for this? > > What exactly are you asking for? Why I'd like to back

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

erichkeane added a comment. In D151537#4382811 , @LuoYuanke wrote: > In D151537#4380763 , @erichkeane > wrote: > >> I don't really see the justification here? Why do this change? If the >> intent is to just

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

CarolineConcatto updated this revision to Diff 527021. CarolineConcatto added a comment. - Remove Qa from arm_sve.td and its dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150953/new/ https://reviews.llvm.org/D150953 Files:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:186 +- New :doc:`misc-include-cleaner + ` check. Please keep alphabetical order (by check name) in this section. Comment at:

[clang] 33ee5c4 - [clang] Add Parse and Sema support for RegularKeyword attributes

Author: Richard Sandiford Date: 2023-05-31T10:43:10+01:00 New Revision: 33ee5c4663465022ffe288817968e90064d88a09 URL: https://github.com/llvm/llvm-project/commit/33ee5c4663465022ffe288817968e90064d88a09 DIFF:

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG301eb6b68f30: [clang] Add support for “regular” keyword attributes (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG33ee5c466346: [clang] Add Parse and Sema support for RegularKeyword attributes (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 301eb6b - [clang] Add support for “regular” keyword attributes

Author: Richard Sandiford Date: 2023-05-31T10:43:10+01:00 New Revision: 301eb6b68f30074ee3a90e2dfbd11dfd87076323 URL: https://github.com/llvm/llvm-project/commit/301eb6b68f30074ee3a90e2dfbd11dfd87076323 DIFF:

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

This revision was automatically updated to reflect the committed changes. Closed by commit rGac5c996d5aaa: [clang] Mark keywords that have their own parsing rules (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148699/new/

[clang] ac5c996 - [clang] Mark keywords that have their own parsing rules

Author: Richard Sandiford Date: 2023-05-31T10:43:10+01:00 New Revision: ac5c996d5aaab5f4508531e815e7ee408284e968 URL: https://github.com/llvm/llvm-project/commit/ac5c996d5aaab5f4508531e815e7ee408284e968 DIFF:

[clang] 2e676fa - Revert "[clang][Interp] Optionally cast comparison result to non-bool"

Author: Timm Bäder Date: 2023-05-31T13:07:40+02:00 New Revision: 2e676fad2620a2ee41b7a00b27770fcfcb16f912 URL: https://github.com/llvm/llvm-project/commit/2e676fad2620a2ee41b7a00b27770fcfcb16f912 DIFF: https://github.com/llvm/llvm-project/commit/2e676fad2620a2ee41b7a00b27770fcfcb16f912.diff

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527001. VitaNuo marked 25 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:86 + llvm::SmallVector MainFileDecls; + for (auto *D : Result.Nodes.getNodeAs("top")->decls()) { +SourceLocation Loc = D->getLocation();

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:56 // P: boolean +// Qa: svcount // U: unsigned The typespec modifier in this file can remain `Q` rather than `Qa`. Can you change it back? Repository: rG LLVM Github

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added a comment. Thanks @steakhal for the proposal :) but I pushed it myself: https://github.com/llvm/llvm-project/commit/ce97312d109b21acb97d3ea243e214f20bd87cfc I used to have svn access, and Chris kindly give me write access to the git repository. Repository: rG LLVM

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 ___ cfe-commits mailing list

[clang] 5437056 - [Headers][doc] Fix typo in avx2intrin.h doc

Author: Paul Robinson Date: 2023-05-31T06:43:38-07:00 New Revision: 543705641adb1d3533be141947264ca1b7b04479 URL: https://github.com/llvm/llvm-project/commit/543705641adb1d3533be141947264ca1b7b04479 DIFF: https://github.com/llvm/llvm-project/commit/543705641adb1d3533be141947264ca1b7b04479.diff

  1   2   3   >