[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL326383: [libcxx] Fix last_write_time test for filesystems that don't support very small… (authored by vsapsai, committed b

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added a comment. I am going to commit this change as I've addressed the review comments. If anybody has anything else to add, we can discuss that in post-commit review. https://reviews.llvm.org/D42755 ___ cfe-commits mailing list cfe-commit

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai updated this revision to Diff 135003. vsapsai added a comment. Herald added a subscriber: christof. - Add back existing test but run it only when file system supports min time. https://reviews.llvm.org/D42755 Files: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

EricWF added inline comments. Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -ec = GetTestEC(); -last_write_time(p, Clock::now()); vsapsai wrote: > EricWF wrote: > > I would really lov

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added inline comments. Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -ec = GetTestEC(); -last_write_time(p, Clock::now()); EricWF wrote: > I would really love to keep this tes

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

EricWF added a comment. LGTM except the removal of the test. I think it's probably valuable to keep around on platforms that allow it. What do you think? Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

Hahnfeld resigned from this revision. Hahnfeld added a comment. In https://reviews.llvm.org/D42755#995593, @vsapsai wrote: > Good suggestion for explaining the problem with `file_time_type::min()` in > more detail. Also PR35990 has > some details on

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added a comment. In https://reviews.llvm.org/D42755#994775, @Hahnfeld wrote: > Can you please add a summary that describes which filesystem this problem can > be seen with? I think outside people can't access rdar tickets, so I can only > guess that it's related to APFS? Further guessin

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. Can you please add a summary that describes which filesystem this problem can be seen with? I think outside people can't access rdar tickets, so I can only guess that it's relate

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added a comment. Don't like removing `new_time = file_time_type::min() + MicroSec(1);` part of the `test_write_min_time` but it escapes `file_time_type::min()` check. If somebody can explain the purpose of this test, I'd be glad to preserve it for filesystems that support very small tim

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai created this revision. vsapsai added reviewers: EricWF, Hahnfeld. Herald added a subscriber: jkorous-apple. rdar://problem/35865151 https://reviews.llvm.org/D42755 Files: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Index: libc