zturner added a comment.
I had to revert this for now. It breaks the asan bots which expect column
info. That fix is easy, but it also breaks a random linux bots which I don't
have the ability to debug at the moment because my linux machine is not
working. Hopefully I can get that resolved s
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326113: Emit proper CodeView when -gcodeview is passed
without the cl driver. (authored by zturner, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43700?vs=135723&id=135932#toc
Repo
zturner added a comment.
In https://reviews.llvm.org/D43700#1019533, @smeenai wrote:
> The `-g` meaning `-gcodeview` for MSVC environments change should be a
> separate diff though, right?
Yes I'm not doing that in this patch. Just wanted to clarify what he meant.
I'm writing a test for thi
smeenai added a comment.
The `-g` meaning `-gcodeview` for MSVC environments change should be a separate
diff though, right?
https://reviews.llvm.org/D43700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
colden added a comment.
In https://reviews.llvm.org/D43700#1019506, @zturner wrote:
> @rnk by "in an MSVC environment" do you mean "when -fms-compatibility is
> present"?
It looks like other places in this file are using
`Triple.isWindowsMSVCEnvironment()`, which I think would make sense to u
colden added a comment.
In https://reviews.llvm.org/D43700#1019505, @aganea wrote:
> Thanks for fixing this @zturner. I simply want to back-up what @probinson
> says above - most of the games we do at Ubisoft are currently using a
> different compilation toolchains for each platform (we ship at
zturner added a comment.
@rnk by "in an MSVC environment" do you mean "when -fms-compatibility is
present"?
https://reviews.llvm.org/D43700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
aganea added a comment.
Thanks for fixing this @zturner. I simply want to back-up what @probinson says
above - most of the games we do at Ubisoft are currently using a different
compilation toolchains for each platform (we ship at least 4-5 platforms for
each top game). It can be clang or it ca
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Lgtm
We should go farther, IMO. `clang -g` should default to emitting codeview in an
MSVC environment.
https://reviews.llvm.org/D43700
___
cfe-commit
smeenai added a comment.
We were affected by this too. Thanks for fixing!
(We're actually using CodeView + DWARF, since we have a bunch of tooling built
around DWARF. We use the gcc-style driver for legacy reasons.)
https://reviews.llvm.org/D43700
___
probinson added a comment.
Being a cross-compiler I think it's generally a good thing to have more
combinations be less broken.
Note that PS4's compiler is hosted on Windows and uses the gcc-style driver;
it's convenient sometimes to be able to target Windows without having to learn
a new drive
colden added a comment.
In https://reviews.llvm.org/D43700#1018087, @zturner wrote:
> In https://reviews.llvm.org/D43700#1018042, @colden wrote:
>
> > Seems good to me! I'll give it a test on my end.
> >
> > One alternate implementation idea though, what if you defaulted
> > EmitCodeView to the
zturner added a comment.
In https://reviews.llvm.org/D43700#1018042, @colden wrote:
> Seems good to me! I'll give it a test on my end.
>
> One alternate implementation idea though, what if you defaulted EmitCodeView
> to the hasArg check instead of false, then removed the `else *EmitCodeView =
colden added a comment.
Seems good to me! I'll give it a test on my end.
One alternate implementation idea though, what if you defaulted EmitCodeView to
the hasArg check instead of false, then removed the `else *EmitCodeView =
false;` block on line 4999?
https://reviews.llvm.org/D43700
___
zturner created this revision.
zturner added a reviewer: rnk.
Although the supported way of invoking clang on Windows is via the cl driver,
some people may wish to use the g++ driver. and manually specify `-gcodeview`.
This codepath is currently broken, as it will cause column information to be
15 matches
Mail list logo
