Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

I don't know much about who owns this sort of code, nor Vassil's work/responsibility in this area - but if he's OK with it/feels able to sign off on it, that'd be sufficient/fine by me (& others closer to it can pipe up if he seems like not the right person to approve). Thanks! - Dave On Mon,

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

Reverted by 290130. I have new comments from Aleksei in https://reviews.llvm.org/D27180 . I'll apply those and update the patch. Sean > On Dec 19, 2016, at 9:48 AM, Sean Callanan wrote: > > David, > > thanks for keeping an eye on this

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

David, thanks for keeping an eye on this and sorry for the breach of process. Would having Vassil approve the changelist (https://reviews.llvm.org/D27180 ) be appropriate? Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On 19/12/16 17:55, David Blaikie wrote: On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits > wrote: spyffe updated this revision to Diff 81661. spyffe marked 2 inline comments as done.

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe updated this revision to Diff 81661. > spyffe marked 2 inline comments as done. > spyffe added a comment. > Herald added a subscriber: jgosnell. > > Applied Vassil and