Thanks for your fast reply!
When you made your changes, did you start with a new project, or did
you edit the Chromium browser itself?
I was considering just modifying the browser. My concern was that if I
wanted to update the Chromium trunk, I would need to redo my various
changes to the
SVN usually manages to merge the changes you have made with the changes from
trunk, unless they have changed that same bit of code you have and then, it
says there is a conflict and lets you look at the differences. I modified
things in the actual Chromium source, not in a new project.
There was
I wasn't aware that SVN manages changes within the content of a file.
I am relatively new to open source code, and have only ever used SVN
to download the Chromium trunk. I also did not realize that it was
possible to upload changes back to the Google servers.
I will have to read up on how SVN
If anyone out there from Mozilla is reading, or someone knows where to
redirect this bug, that would be really helpful:
https://bugzilla.mozilla.org/show_bug.cgi?id=504301
Thanks
On Tue, Jul 14, 2009 at 8:23 PM, Dean McNameede...@chromium.org wrote:
My point was the behavior before the patch
dev.chromium.org has a lot of info (Getting around the source code is an
example).But in your case, you want it to start up without switches, you
just want it to be your version from the beginning with no special attention
(besides compiling).
You cannot exactly 'upload the changes back to the
I'm playing around fixing the rough edges of the Mac theme implementation
and I'm hitting areas where it doesn't seem to be implemented for any
platform.
First, you said that you were going to make it so that when you install one
theme it uninstalls all others. Is that coming soon?
I ask because
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
I'm playing around fixing the rough edges of the Mac theme implementation
and I'm hitting areas where it doesn't seem to be implemented for any
platform.
First, you said that you were going to make it so that when you
On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
First, you said that you were going to make it so that when you install
one theme it uninstalls all others. Is that coming soon?
I don't know if
I cc'd vlad.-Darin
On Wed, Jul 15, 2009 at 4:00 AM, Dean McNamee de...@chromium.org wrote:
If anyone out there from Mozilla is reading, or someone knows where to
redirect this bug, that would be really helpful:
https://bugzilla.mozilla.org/show_bug.cgi?id=504301
Thanks
On Tue, Jul 14,
There is no theme management - there is a 'reset to default' button in
options, and that's it. 'Management' is done by using the themes site
and reinstalling from there. Users should never see the word
'extension' if all they care about is themes, at least for 3.0.
On Wed, Jul 15, 2009 at 8:15
Ahh... So there needs to be a reset button in prefs. I can look it up, but
does it just uninstall all theme extensions?
Deleting a theme from the extensions page does leave stuff behind.
Avi
On Wed, Jul 15, 2009 at 12:03 PM, Glen Murphy g...@chromium.org wrote:
There is no theme management -
On Wed, Jul 15, 2009 at 4:21 PM, Michaelmichael.monr...@gmail.com wrote:
It's correctly set to User and I have since done a complete clean
rebuild of the tree, still no joy...
Please make sure that you sync = 20718. As Joel pointed out, I typoed
a #define.
AGL
On Jul 15, 6:31 pm, Adam Langley a...@chromium.org wrote:
Please make sure that you sync = 20718. As Joel pointed out, I typoed
a #define.
AGL
Sure...
svn info | grep Revision
Revision: 20728
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
Oh... I am building Release configuration, maybe this is not yet
working there?
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
You should look at what the windows impl does. It probably goes
directly to the themes system and tells it to reset, without involving
extensions.
However
Glen, now that we have extension uninstall implemented, I feel like we
should integrate these two better. There should be (low-priority)
On Wed, Jul 15, 2009 at 2:11 AM, Adam Langleya...@google.com wrote:
* Edit build/common.gypi and change linux_suid_sandbox_restrictions
from Path to User
(missed a step)
* re-GYP: cd .. ./depot_tools/gclient runhooks --force cd src
should probably do it.
AGL
You should look at what the windows impl does. It probably goes
directly to the themes system and tells it to reset, without involving
extensions.
That's right, it calls BrowserThemeProvider::UseDefaultTheme
Glen, now that we have extension uninstall implemented, I feel like we
should
I looked yesterday at storing the entire extension state, including
its manifest in the preferences. This is desirable because it will
reduce disk IO at startup and eliminate some kinds of races that we
have today.
I decided not to do this now because it ended up being orthogonal to
the feature
On Jul 15, 4:51 pm, Adam Langley a...@chromium.org wrote:
* re-GYP: cd .. ./depot_tools/gclient runhooks --force cd src
should probably do it.
Ah... sure!
Still wondering if this is working as intended... ps shows me:
28704 pts/2Z+ 0:00 [chrome-devel-sa] defunct
28706 pts/2Z+
On Wed, Jul 15, 2009 at 5:07 PM, Michaelmichael.monr...@gmail.com wrote:
Ah... sure!
Still wondering if this is working as intended... ps shows me:
Zombies not intended, but it's not reducing the browser to an
unworkable mess either so it's behind the bugs which are.
Cheers
AGL
Multiple developers have asked for a way to execute content scripts
programmatically, and it seems reasonable enough.
Hence:
http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/executecontentscript-propoal
Comments desired.
- a
On Wed, Jul 15, 2009 at 9:59 AM, Aaron Boodman a...@chromium.org wrote:
a) I think it is important to not break the extension system with this
mod, so that means that for awhile (1 or 2 dev channel releases?) we
will both write the entire manifest to the prefs and load from disk
normally.
On Wed, Jul 15, 2009 at 11:22 AM, Aaron Boodmana...@chromium.org wrote:
Hence:
http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/executecontentscript-propoal
Typo. Should have been:
One pie-in-the-sky idea I have is to pre-compile content scripts.
Restricting the API to static JS files would allow us to do such a thing.
On Wed, Jul 15, 2009 at 11:41 AM, Jói joi.sigurds...@gmail.com wrote:
This seems very useful to me.
Perhaps it would be useful to also let extensions
Frames: [we talked in person, but to summarize]
This won't allow injection into subframes that are not of the same
origin as the outermost frame. This is maybe too small a use case to
worry about for now, but it's good to at least call it out.
Content to inject:
What do I do if I have a string
On Wed, Jul 15, 2009 at 11:30 AM, Matt Perrympcompl...@chromium.org wrote:
On Wed, Jul 15, 2009 at 9:59 AM, Aaron Boodman a...@chromium.org wrote:
a) I think it is important to not break the extension system with this
mod, so that means that for awhile (1 or 2 dev channel releases?) we
will
Thanks everyone for the quick feedback. I've modified the proposal to
support also executing strings of JavaScript. Detailed comments
inline.
On Wed, Jul 15, 2009 at 11:41 AM, Jóijoi.sigurds...@gmail.com wrote:
This seems very useful to me.
Thanks!
On Wed, Jul 15, 2009 at 11:41 AM,
We currently have the ability to get a list of references to all the
DOMWindows in your own extension via chrome.extension.getViews().
But there have been requests to be able to get just the toolstrips, or
just the background page. Additionally, I've heard requests for
getting just the
On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth aba...@chromium.org wrote:
Thanks to some recent work by Dimitri, Victor, and others, hacking on
WebKit is now easier than ever. If you work on WebKit and Chromium, I
recommend using a hybrid source tree:
On Wed, Jul 15, 2009 at 12:44 PM, Peter Kastingpkast...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth aba...@chromium.org wrote:
Thanks to some recent work by Dimitri, Victor, and others, hacking on
WebKit is now easier than ever. If you work on WebKit and Chromium, I
On Wed, Jul 15, 2009 at 12:50 PM, Adam Barth aba...@chromium.org wrote:
I think gclient uses the depot_tools one to update the files, but the
WebKitTools/Scripts use the svn in your path (for me, the Cygwin one)
for svn status, diff, commit, etc.
Yes, this is true. This is why I was asking.
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org wrote:
I am still confused.
I recommend the experimental method. If you have trouble, we can try
to figure out what's different between your setup and my setup.
Adam
--~--~-~--~~~---~--~~
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org
wrote:
I am still confused.
I recommend the experimental method. If you have trouble, we can try
to figure out what's different between your setup
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kastingpkast...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org
wrote:
I am still confused.
I recommend the experimental method. If you
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kastingpkast...@chromium.org
wrote:
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kastingpkast...@chromium.org
wrote:
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth aba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kastingpkast...@chromium.org
On Wed, Jul 15, 2009 at 1:53 PM, Peter Kastingpkast...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth aba...@chromium.org wrote:
Maybe try removing those directories from your .gclient_entries file?
This fixed things. Updated the directions. Also noted that people should
On Wed, Jul 15, 2009 at 1:55 PM, Adam Barthaba...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:53 PM, Peter Kastingpkast...@chromium.org wrote:
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth aba...@chromium.org wrote:
Maybe try removing those directories from your .gclient_entries file?
This
These instructions turn src/third_party/WebKit into a full-fledged WebKit
checkout
Hallelujah... thank you for writing this up!
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting pkast...@chromium.orgwrote:
This is my concern. A number of WebKit things at least used to only work
with a Cygwin SVN checkout.
Sadly, it looks as if this is still the case. Using Adam's instructions on
Windows results in a WebKit checkout
On Jul 14, 7:26 pm, Adam Langley a...@chromium.org wrote:
On Tue, Jul 14, 2009 at 7:18 PM, Jeremy Orlowjor...@chromium.org wrote:
Wait...so is this something every linux Chromium developer is going to have
to do forever?
You only need to do it once and, if you don't, you just run without a
On Wed, Jul 15, 2009 at 3:08 PM, Erik Kayerik...@google.com wrote:
On Wed, Jul 15, 2009 at 12:04 PM, Aaron Boodman a...@chromium.org wrote:
On Wed, Jul 15, 2009 at 11:30 AM, Matt Perrympcompl...@chromium.org
wrote:
On Wed, Jul 15, 2009 at 9:59 AM, Aaron Boodman a...@chromium.org wrote:
On Wed, Jul 15, 2009 at 10:14 PM, Chris Evanscev...@chromium.org wrote:
What will replace it and why?
seccomp sandbox:
* none of this admin crap
* restricts the network
* restricts access to worrying syscalls (vsplice etc)
probably other reasons too.
AGL
This is really great!
One naming thought for you. I wonder if the methods should be named
loadScript and loadCSS? I know that this is effectively the same thing
with JS, but execute sounds like it's just running something temporarily
(maybe in the page's context) and forgetting about it, while
one more time
On Wed, Jul 15, 2009 at 3:35 PM, Erik Kay erik...@google.com wrote:
Very cool.
One quick question is about race conditions at load time. Will this handle
the case where a background page asks for its toolstrips right away (or vice
versa)?
Erik
On Wed, Jul 15, 2009 at
nit: I'd prefer getTabs instead of getTabContents.
On Wed, Jul 15, 2009 at 12:41 PM, Aaron Boodman a...@chromium.org wrote:
We currently have the ability to get a list of references to all the
DOMWindows in your own extension via chrome.extension.getViews().
But there have been requests to
Hi,
I download the source of chromium and build successfully on MacOSX.
When I start the TestShell.app, it launches successfully and I can
load a page (www.cnn.com)
But when I start the Chromium.app, i see the Chromium appears on the
Dock for 1-2 seconds and then it kills itself.
Can you
On Wed, Jul 15, 2009 at 3:20 PM, Aaron Boodman a...@chromium.org wrote:
On Wed, Jul 15, 2009 at 3:08 PM, Erik Kayerik...@google.com wrote:
On Wed, Jul 15, 2009 at 12:04 PM, Aaron Boodman a...@chromium.org wrote:
On Wed, Jul 15, 2009 at 11:30 AM, Matt Perrympcompl...@chromium.org
wrote:
Since you built it, you should be able to fire it up in a debugger and see
where it's dying. That's what I'd try first.
-A
On Wed, Jul 15, 2009 at 3:47 PM, n179911 n179...@gmail.com wrote:
Hi,
I download the source of chromium and build successfully on MacOSX.
When I start the
Also, for most of our APIs, not specifying a windowId generally means my
current window, while this means all windows. It might be better to be
consistent with those APIs here. We could introduce a special windowId
constant like kAllWindows to satisfy the other case.
On Wed, Jul 15, 2009 at
On Wed, Jul 15, 2009 at 3:35 PM, Erik Kayerik...@google.com wrote:
One quick question is about race conditions at load time. Will this handle
the case where a background page asks for its toolstrips right away (or vice
versa)?
I think this is more an implementation issue, but you're right
On Jul 15, 2009, at 3:50 PM, Albert J. Wong (王重傑) wrote:
Since you built it, you should be able to fire it up in a debugger
and see where it's dying. That's what I'd try first.
More precisely:
* Open chrome.xcodeproj
* Make sure the chrome executable is active
* Choose Run Activate
What do you think about creating a new flag for bugs about flaky
tests? Something like Flakiness.
It would be nice to have it as an official flag, so we don't end up
with few variants of the flag.
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
On Wed, Jul 15, 2009 at 2:49 PM, Peter Kasting pkast...@chromium.orgwrote:
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting pkast...@chromium.orgwrote:
This is my concern. A number of WebKit things at least used to only work
with a Cygwin SVN checkout.
Sadly, it looks as if this is still
On Wed, Jul 15, 2009 at 4:18 PM, Jens Alfkes...@google.com wrote:
On Jul 15, 2009, at 3:50 PM, Albert J. Wong (王重傑) wrote:
Since you built it, you should be able to fire it up in a debugger and see
where it's dying. That's what I'd try first.
More precisely:
* Open chrome.xcodeproj
*
Done. I named it FlakyTest since Flakiness seems like it could apply to
other things besides just tests.
-Darin
On Wed, Jul 15, 2009 at 5:22 PM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
What do you think about creating a new flag for bugs about flaky
tests? Something like Flakiness.
Is safe to try this option? Nothing will be broken?
Where I can set this variable?
On Jun 4, 3:40 pm, Bradley Nelson bradnel...@google.com wrote:
Hi All,
If you don't have Visual Studio 2008 installed you can stop reading.
As many of you have no doubt noticed, gyp emits something
Right click on my computer, select properties.Select advanced tab.
Click on Environment Variables.
Add a GYP_MSVS_VERSION variable set to 2008.
Last I had heard the 2008 build is working, but it is less stable as we
don't yet have a builder setup to validate it. And most folks are using
2005.
(Oh and for the folks that added in boost, I'll be adding in an
MSVS_VERSION variable you'll be able to use at gyp time so you can have
different behaviors).
Good to know. BTW, boost got removed about 3 weeks ago after zhanyong broke
the dependency from gmock to boost and tr1 (yay!). So no
59 matches
Mail list logo
