Re: [chromium-dev] FYI ... you might find some issues missing in issue_tracker

2009-11-19 Thread Paweł Hajdan Jr .
Not sure if that's related, but bugdroid started to behave strangely. I see new comments for commits from before a week. On Wed, Nov 18, 2009 at 20:27, Dirk Pranke dpra...@chromium.org wrote: Hi all, Just a heads' up ... we've discovered a bug in Issue Tracker that has caused a few of our

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
That might be worth considering. The reason they're gypi's instead of regular gyp files is because xcode presents only whole gyp's to the developer. Putting them in gypi's was a compromise which keep the final xcodeproj in one piece. If we move the gypi's to subdirectories, paths in them will

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
It's been brought to my attention that this change might cause merge pain for folks trying to pull their changes into the M4 branch. I can wait to do this until a later date, or I suppose bring the change over to M4? Anybody feel super strongly? -BradN On Thu, Nov 19, 2009 at 9:57 AM, Bradley

Re: [chromium-dev] [GTTF] running tests that fail most often early in the queue

2009-11-19 Thread Nicolas Sylvain
On Thu, Nov 19, 2009 at 10:48 AM, Paweł Hajdan jr phajdan...@gmail.comwrote: Nicolas, what do you think about applying the reordering to our bots? we should do it. On Thu, Nov 12, 2009 at 20:10, Pam Greene p...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:52 AM, Paweł Hajdan Jr.

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
I've talked it over with laforge. I'm gonna revert this for now, until m4 is out of the way. We'll try it again in ~2 weeks. Maybe I'll get those includes done the right way in gyp in the meantime. -BradN On Thu, Nov 19, 2009 at 10:02 AM, Bradley Nelson bradnel...@google.comwrote: It's been

[chromium-dev] heads up: Rietveld reply by email isn't working

2009-11-19 Thread John Abd-El-Malek
There is a bug in App Engine with some new APIs that we're using. I'm working on a workaround with another outside contributor which will hopefully land in a day or two. Until then, if you care about your reply showing up on Rietveld, don't reply by email. -- Chromium Developers mailing list:

[chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Paweł Hajdan Jr .
It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support for git-cl because there is already a watchlists.py file, but then there are some questions: - should the watchlists.py file (from depot_tools) be copied to

Re: [chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Evan Martin
On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support for git-cl because there is already a watchlists.py file, but then there

Re: [chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Marc-Antoine Ruel
On Thu, Nov 19, 2009 at 4:46 PM, Evan Martin e...@chromium.org wrote: On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread Tony Chang
For reasons unknown to me, this line jumped back up. It seems it's because of Matt's revert: http://src.chromium.org/viewvc/chrome?view=revrevision=32524 This is a startup test, so it basically times how long it takes for LaunchApp to return. Maybe the methodology here is a bit off? On Wed, Nov

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread John Abd-El-Malek
On Thu, Nov 19, 2009 at 1:57 PM, Tony Chang t...@chromium.org wrote: For reasons unknown to me, this line jumped back up. It seems it's because of Matt's revert: http://src.chromium.org/viewvc/chrome?view=revrevision=32524 This is a startup test, so it basically times how long it takes for

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread Matt Perry
Yeah, I'm sure it's my revert. We're now starting the extension processes in parallel with the UI loop (on the launcher thread), rather than always deferred until the next pass through the UI loop. It probably won't make much difference in practice, so I'm torn on whether to undo that change. On

[chromium-dev] user-contributed translations

2009-11-19 Thread Evan Martin
I persistently get questions from users wanting to provide localization for Chrome. I believe our answer is that we don't accept user-contributed translations. Is there a FAQ somewhere I can link these users to? Where would such a FAQ belong? Also, another option for these users is to write

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread Matt Perry
On Thu, Nov 19, 2009 at 2:14 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 19, 2009 at 1:57 PM, Tony Chang t...@chromium.org wrote: For reasons unknown to me, this line jumped back up. It seems it's because of Matt's revert:

[chromium-dev] Anyone understand how V8 GC works?

2009-11-19 Thread Drew Wilson
I'm investigating a leak in the MessagePort/MessageChannel code. Basically, if I have a page that looks like this: script new MessageChannel(); /script We leak two MessagePorts every time we reload the page. The WebCore::MessageChannel impl object has two RefPtrs to two MessagePort objects.

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread John Abd-El-Malek
On Thu, Nov 19, 2009 at 2:17 PM, Matt Perry mpcompl...@chromium.org wrote: On Thu, Nov 19, 2009 at 2:14 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 19, 2009 at 1:57 PM, Tony Chang t...@chromium.org wrote: For reasons unknown to me, this line jumped back up. It seems it's

Re: [chromium-dev] user-contributed translations

2009-11-19 Thread Mohamed Mansour
I always link them to this page: http://dev.chromium.org/developers/design-documents/ui-localization http://dev.chromium.org/developers/design-documents/ui-localizationIt would be hassle for users to manage their own translations, it has to be updated daily, maybe if we had some web tool that

Re: [chromium-dev] user-contributed translations

2009-11-19 Thread Peter Kasting
On Thu, Nov 19, 2009 at 2:17 PM, Evan Martin e...@chromium.org wrote: Also, another option for these users is to write their own translations and let downstream (Chromium distributors) ship them. I do think it would be nice to document somewhere how someone could build a Chromium with their

Re: [chromium-dev] Heads up: safely ignored regression on Linux Startup perf test

2009-11-19 Thread Matt Perry
On Thu, Nov 19, 2009 at 2:20 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 19, 2009 at 2:17 PM, Matt Perry mpcompl...@chromium.orgwrote: On Thu, Nov 19, 2009 at 2:14 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 19, 2009 at 1:57 PM, Tony Chang t...@chromium.org

Re: [chromium-dev] Anyone understand how V8 GC works?

2009-11-19 Thread Drew Wilson
There's no bug on this yet - I ran across this when I ran out of memory in my SharedWorkers soak test I was running (turns out that this bug may be unrelated to the SharedWorkers bug). It's quite possible that this is related to the V8GCController code - I'd forgotten about that. In fact, it's

Re: [chromium-dev] FYI ... you might find some issues missing in issue_tracker

2009-11-19 Thread Dirk Pranke
I suspect this is an unrelated issue (but I've seen this one, too). -- Dirk On Thu, Nov 19, 2009 at 8:49 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Not sure if that's related, but bugdroid started to behave strangely. I see new comments for commits from before a week. On Wed, Nov

[chromium-dev] Some people still making new toolstrip-based extensions

2009-11-19 Thread Aaron Boodman
We're going to have to explain again when we actually remove toolstrips, because some people won't have seen the first announcement (understandably): http://www.guyvider.com/2009/11/i-love-chrome-extensions.html - a -- Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] CGAccessSessionSkipBytes

2009-11-19 Thread Nico Weber
Hi, my new ToT chrome mac build logs this on the console: Thu Nov 19 22:39:53 thakis-macbookpro.local Chromium Helper[35086] Error: The function `CGAccessSessionSkipBytes' is obsolete and will be removed in an upcoming update. Unfortunately, this application, or a library it uses, is using this

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Mark Mentovai
Bradley Nelson wrote: If we move the gypi's to subdirectories, paths in them will still be relative to src/chrome, which might be confusing. I would prefer if gypi's didn't have this behavior, and plan to fix it: http://code.google.com/p/gyp/issues/detail?id=116 That bug only refers to the

[chromium-dev] StringPrintf and friends are now checked

2009-11-19 Thread Evan Martin
GCC-compiled code (Mac/Linux) will now warn / fail to compile if you pass the wrong types to our printf-like functions (StringPrintf, etc.). This would have caught at least two bugs I've seen in the past. There is one twist to be aware of if you haven't seen it before. The % format specifiers