[chromium-dev] Purify - instrumentation fails on XP Unit (purify) bot

2009-07-16 Thread Sverrir Á . Berg
http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) Any insights would be appreciated... Sverrir (sheriff) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options,

[chromium-dev] RenderViewTest with subframe content

2009-06-29 Thread Sverrir Á . Berg
I'm trying to create a unit test to verify change I'm doing to print out frames.I haven't been able to figure out how to load content into a subframe. I've tried to create an iframe with src property and catch the RequestResource message and also tried to write into the frame using something like

[chromium-dev] Icelandic dictionary for Chrome

2009-06-19 Thread Sverrir Á . Berg
I'm hoping to be able to add Icelandic spelling check to Chrome Before I invest a lot of time I have some quick questions/observations: I found an myspell/aspell dictionary for Open Office here: http://wiki.services.openoffice.org/wiki/Dictionaries#Icelandic_.28Iceland.29 and converted it to

[chromium-dev] Re: Gmock compilation errors on VS2008SP1

2009-06-15 Thread Sverrir Á . Berg
I'm hitting the exact same issue as nakro. I did a sync this morning (tree was green) and did a clean build of chrome.exe. I'm at this point officially giving up on Visual Studio 2008 and going back to VS2005. Sverrir On Mon, Jun 15, 2009 at 11:48 AM, Albert J. Wong (王重傑)

[chromium-dev] Re: some trival details

2009-06-15 Thread Sverrir Á . Berg
5.mini_installer.exe and setup.exe? I can't execute them. What're they used for?Try reading the source code - it has actually a lot of useful comments. Such as mini_installer.cc has comments on how mini_installer and setup relate. If you can't run them you might be hitting an issue some of us

[chromium-dev] Re: Question about BrowserRenderProcessHost::OnPageContents() method

2009-06-08 Thread Sverrir Á . Berg
FYI: I just recently added WebFrame::GetFullPageHtml() for print selection support. This could come in handy for debugging. But Brett is right you need to be in the renderer process for that. The alternate is simply to select everything on the page and do a copy. You can do that from the

[chromium-dev] Re: Is there any way to know if a web page is fully loaded from the Browser object

2009-06-08 Thread Sverrir Á . Berg
Hi Mohamed,This overlaps with the work I've been doing so please sync with me before starting any major work. What I've found out so far is that if you have an create a page (using WebView::Create) and have it load a page using html that fully describes the page. For my tests I've been using

[chromium-dev] Re: setup.exe doesn't run work for me

2009-06-03 Thread Sverrir Á . Berg
No problem. Are you using Visual Studio 2008? Since the official builders are on VS2005 I suspect there are some incompatibilities between the toolchains on those two. Sverrir On Wed, Jun 3, 2009 at 8:06 AM, nakro yoav.zilberb...@gmail.com wrote: Sverir, thank you very much for your reply,

[chromium-dev] Re: setup.exe doesn't run work for me

2009-06-02 Thread Sverrir Á . Berg
I had a similar issue with my build a while back and I ended up finding out that something in our build chain was corrupting the manifest (the manifest had two different xml namespaces referring to two different versions of the manifest versions if I recall correctly).The solution for me was to

[chromium-dev] Re: Please use BUG and TEST in changelists

2009-04-23 Thread Sverrir Á . Berg
I fully support this. We have been using similar procedure in Google Desktop for a while (and probably others within Google). The benefit is easier traceability and long term time saving. We have extended this in some ways:A) Made the BUG field required - you need to explicitly say BUG=0 if

[chromium-dev] Re: Turned on tcmalloc

2009-04-23 Thread Sverrir Á . Berg
creates this library (prep_libc.sh) * chrome.dll now ignores libcmt.lib and manually links its own libcmt. Mike On Wed, Apr 22, 2009 at 7:25 AM, Sverrir Á. Berg sver...@chromium.orgwrote: Even after doing the clobber runhooks raindance I'm getting linker errors: 143tcmalloc.lib

[chromium-dev] Re: Turned on tcmalloc

2009-04-23 Thread Sverrir Á . Berg
BTW: You will need to rebuild tcmalloc (e.g. touch one of the .cc files) Sverrir On Thu, Apr 23, 2009 at 11:52 AM, Sverrir Á. Berg sver...@chromium.orgwrote: Commited 17 hours and 20 minutes ago: http://src.chromium.org/viewvc/chrome?view=revrevision=14257 Sverrir On Thu, Apr 23, 2009

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Sverrir Á . Berg
Even after doing the clobber runhooks raindance I'm getting linker errors: 143tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined in libcmt.lib(malloc.obj) 143tcmalloc.lib(override_functions.obj) : error LNK2005: _free already defined in libcmt.lib(free.obj)

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Sverrir Á . Berg
Even after doing the clobber runhooks raindance I'm getting linker errors: 143tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined in libcmt.lib(malloc.obj) 143tcmalloc.lib(override_functions.obj) : error LNK2005: _free already defined in libcmt.lib(free.obj)

[chromium-dev] Layout test and font stroking issue - help wanted

2009-01-16 Thread Sverrir Á . Berg
I'm running these tests: http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking-decorations.html http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking.html It seems that our font rendering path uses UniScribe/ScriptTextOut because of the accent (this means

[chromium-dev] Re: Modal dialogs in Chrome

2008-12-18 Thread Sverrir Á . Berg
I personally like the idea of page-modal dialogs. I also understand this has usability issues and they are not easy to solve. If one page in i a tab group displays a javascript initiated page-modal dialog others in the same group could display a page modal dialog that would say something like: