On Wed, Aug 19, 2009 at 10:56 PM, Brett Wilson bre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
On Thu, Aug 20, 2009 at 2:00 AM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while and hope it eventually converges to something better.
Sort of a
On Thu, Aug 20, 2009 at 6:21 AM, Ben Goodger (Google)b...@chromium.org wrote:
I don't know much about the technical details at play here, but a
couple of high level notes:
- I am sympathetic to concerns around codebase cleanliness. Many
people (like Brett) have spent very many months
On Wed, Aug 19, 2009 at 10:18 PM, Marc-Antoine Ruelmar...@google.com wrote:
I don't mind as long it's documented on dev.chromium.org.
Ben, ping me if you want to setup a freebsd slave on fyi. As long as you
want to babysit it. :)
Cool - I haven't got that far yet, but when it builds, I'll be
On Thu, Aug 20, 2009 at 6:56 AM, Brett Wilsonbre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
On Thu, Aug 20, 2009 at 6:06 AM, Ben Laurieb...@chromium.org wrote:
I'd be happy to do that. When I do, there's something that's already
puzzling me, and that's OS_POSIX.
I don't have a copy of the POSIX standard, at least not a recent one,
so its hard to know what is or isn't POSIX, and I
On Thu, Aug 20, 2009 at 2:26 PM, Evan Martine...@chromium.org wrote:
On Thu, Aug 20, 2009 at 3:06 AM, Ben Laurieb...@chromium.org wrote:
I'd be happy to do that. When I do, there's something that's already
puzzling me, and that's OS_POSIX.
I don't have a copy of the POSIX standard, at least
On Thu, Aug 20, 2009 at 7:32 PM, Evan Martine...@chromium.org wrote:
On Thu, Aug 20, 2009 at 11:15 AM, Ben Laurieb...@chromium.org wrote:
On Thu, Aug 20, 2009 at 2:26 PM, Evan Martine...@chromium.org wrote:
On Thu, Aug 20, 2009 at 3:06 AM, Ben Laurieb...@chromium.org wrote:
I'd be happy to do
On Thu, Aug 20, 2009 at 11:15 AM, Ben Laurieb...@chromium.org wrote:
On Thu, Aug 20, 2009 at 2:26 PM, Evan Martine...@chromium.org wrote:
On Thu, Aug 20, 2009 at 3:06 AM, Ben Laurieb...@chromium.org wrote:
I'd be happy to do that. When I do, there's something that's already
puzzling me, and
On Wed, Aug 19, 2009 at 11:43 AM, Ben Laurieb...@chromium.org wrote:
#if defined(OS_LINUX) || defined(OS_FREEBSD)
and this is ugly.
It doesn't deeply worry me, except when NetBSD, OpenBSD come along.
Could you use OS_BSD instead? I know that some may assume that OS X
would be included, but I
we could go with like _nix or something, and consider OSX to not be
unix (which is kinda isn't). Really, in theory, we should have more
granular ifdefs ./configure style, but that is also really a pain in
my opinion.
On Wed, Aug 19, 2009 at 1:00 PM, Adam Langley a...@chromium.org wrote:
On
Rad that you're doing this!
I think that we shouldn't have any linux-specific directories except
for one or two cases where it's *really* Linux-specific (like crash
dumping or ). So the same should be true for you.
It seems the configurations we'll see most frequently in code are:
1) POSIX
On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin e...@chromium.org wrote:
Rad that you're doing this!
I think that we shouldn't have any linux-specific directories except
for one or two cases where it's *really* Linux-specific (like crash
dumping or ). So the same should be true for you.
It
On Wed, Aug 19, 2009 at 1:23 PM, Darin Fisherda...@chromium.org wrote:
On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin e...@chromium.org wrote:
Rad that you're doing this!
I think that we shouldn't have any linux-specific directories except
for one or two cases where it's *really*
Ben Laurie wrote:
The observation is that many places that are currently:
#if defined(OS_LINUX)
are going to become:
#if defined(OS_LINUX) || defined(OS_FREEBSD)
and this is ugly.
I think that these would generally be proper as defined(OS_POSIX)
!defined(OS_MACOSX). If people think that's
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while and hope it eventually converges to something better.
Sort of a non-answer, but I'd be happy to see this running on a BSD
first, and then we can
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while and hope it eventually converges to something better.
The changes in
I don't know much about the technical details at play here, but a
couple of high level notes:
- I am sympathetic to concerns around codebase cleanliness. Many
people (like Brett) have spent very many months maintaining and
improving the hygiene of Chrome code. Sometimes it feels like an
uphill
On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while
19 matches
Mail list logo
