[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Никита Офицеров
I'm sorry for the late response, I've been quite busy last week. 2009/4/27 Amanda Walker ama...@chromium.org: Hacky is fairly subjective: are there particular things about the existing implementation that bother you? Currently they are different for each OS because each OS has its own issues

[chromium-dev] Re: Setting Default Search Engine

2009-05-05 Thread Scott Violet
On Fri, May 1, 2009 at 11:41 PM, stylo~ scootrs@gmail.com wrote: Also, the name it defaults to for the added search engine is wrong. It uses the url, not the name in the xml file. That is by design. tab-to-search keys off url. Also, doesn't seem a very good system even if it does work.

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Amanda Walker
Thanks for elaborating. So if we look at it another way, there are several different problems that ProcessSingleton is currently used to solve: - Prevent multiple instances of Chromium from referring to the same profile/user data directory. In the general sense, what we need here is a way to

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Scott Hess
I agree with the earlier argument about not larding startup with things like writing new files to id the coming-up Chrome to late-coming instances. An alternative might be to acquire a lock to protect the profile, and write an id asynchronously after startup. The late-coming instance would see

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Marc-Andre Decoste
Salut, I've been trying to locally collect performance data to confirm whether this was a good enough improvement or not and I can't seem to get consistent enough results on my machine to draw a conclusion... Some things look faster, and others look slower, but I sometimes get faster results

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Mike Pinkerton
I was able to get very consistent results before with just TestShell on Mac running the mozilla page-cycler test locally. Would using TestShell instead of Chromium help, or do you want me to try your patch on Mac? Let me know. On Tue, May 5, 2009 at 2:08 PM, Marc-Andre Decoste m...@chromium.org

[chromium-dev] Tab-modal dialogs on the Mac

2009-05-05 Thread Avi Drissman
Having signed up for the login dialog, I'm seeing that it's a pretty interesting subject. If you try out a page with HTTP auth, you'll see that you get what looks like a dialog for the username and password. But if you click around, you find that you can switch tabs, and that the dialog is

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Amanda Walker
I'd be worried about flashing/jankiness using a real sheet, but a child window pinned to the top edge of the tab with the right transitions might work nicely. There's also some stuff Jeremy was doing in Gears that involved doing interesting things with login prompts that may (or may not) be

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Evan Martin
One question that's been on my mind is how important it is for the dialog to be draggable. We can't simultaneously do (normal window title bar) and (constrained to a tab) on Linux. A Mac-style sheet would be consistent with other tab-related UI like the find bar. On Tue, May 5, 2009 at 2:40 PM,

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Glen Murphy
I don't think it's important. It actually feels a little weird that it is. On Tue, May 5, 2009 at 2:46 PM, Evan Martin e...@chromium.org wrote: One question that's been on my mind is how important it is for the dialog to be draggable. We can't simultaneously do (normal window title bar) and

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Avi Drissman
I don't think that's important. Avi On Tue, May 5, 2009 at 2:46 PM, Evan Martin e...@chromium.org wrote: One question that's been on my mind is how important it is for the dialog to be draggable. We can't simultaneously do (normal window title bar) and (constrained to a tab) on Linux. A

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Avi Drissman
I need to play with this. It's pretty obvious how this would have been done in Carbon (where you can attach/detach sheets with abandon) but it's less obvious how to do this in Cocoa, where -[NSWindow attachedSheet] implies just one sheet per window, and it's not obvious how to attach a sheet to a

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Marc-Andre Decoste
That would be awsome... I just uploaded the patch here: http://codereview.chromium.org/108040 BYE MAD On Tue, May 5, 2009 at 5:14 PM, Mike Pinkerton pinker...@chromium.orgwrote: I was able to get very consistent results before with just TestShell on Mac running the mozilla page-cycler test

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Adam Langley
On Tue, May 5, 2009 at 3:00 PM, Marc-Andre Decoste m...@chromium.org wrote: That would be awsome... I just uploaded the patch here: http://codereview.chromium.org/108040 At a high level, you're using one TransportDIB per rectangle, but it should be one per message (with multiple rects worth

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Ben Goodger (Google)
The sheet approach sounds fine to me for Mac dialogs. Note also that anything you do should not become app-modal when the tab is selected. -Ben On Tue, May 5, 2009 at 2:40 PM, Avi Drissman a...@google.com wrote: Having signed up for the login dialog, I'm seeing that it's a pretty interesting

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Mark Mentovai
The sheet approach or the sheet-look approach? I like the sheet-look approach, but Cocoa sheets are window-modal, which I don't think is all that cool given how we use tabs (or want to use tabs). Mark Ben Goodger (Google) wrote: The sheet approach sounds fine to me for Mac dialogs. Note also

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Marc-Andre Decoste
OK, I'll make the change... Interestingly, this was my original idea, but I misunderstood your initial suggestions thinking you preferred an array of bitmaps too... I'll send a notice once I uploaded a new patch... Thanks! BYE MAD On Tue, May 5, 2009 at 6:08 PM, Adam Langley a...@chromium.org

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Ben Goodger (Google)
I remember Nicholas saying he thought it'd be possible to fabricate a non-modal sheet like thing. -Ben On Tue, May 5, 2009 at 3:25 PM, Mark Mentovai m...@chromium.org wrote: The sheet approach or the sheet-look approach? I like the sheet-look approach, but Cocoa sheets are window-modal,

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Mark Mentovai
Yeah, that'd be awesome. Ben Goodger wrote: I remember Nicholas saying he thought it'd be possible to fabricate a non-modal sheet like thing. -Ben On Tue, May 5, 2009 at 3:25 PM, Mark Mentovai m...@chromium.org wrote: The sheet approach or the sheet-look approach? I like the sheet-look

[chromium-dev] custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread chrome
Hi all, I trid to get the chrome source code via the gclient tools. Due to low-bandwidth, i did not want to sync the layout_tests code and added the filter line src/webkit/data/layout_tests: None, into the .gclient file. But it seems does not work, it still sync

[chromium-dev] what class should I derive from if i want to create an invisible proxy windows?

2009-05-05 Thread Leith
what class should I derive from if i want to create an invisible proxy windows? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread Evan Martin
On Mon, May 4, 2009 at 1:45 AM, chrome chromeorfire...@gmail.com wrote: Hi all,      I trid to get the chrome source code via the gclient tools.     Due to low-bandwidth, i did not want to sync the  layout_tests code and added the filter line          src/webkit/data/layout_tests: None,  

[chromium-dev] Re: Windows 7 thumbnail previews for tabs (+ other new features)

2009-05-05 Thread Peter Kasting
On Mon, May 4, 2009 at 5:25 PM, Leith le...@leithalweapon.geek.nz wrote: Has anyone started work on integrating Chrome with the new thumbnail previews in Windows 7? You should probably search the bug tracker for relevant bugs for this. Any information would presumably be there. PK

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread Aaron Boodman
On Mon, May 4, 2009 at 11:08 AM, jack js2...@gmail.com wrote: Dear experts, I am recently playing around Chrome extension development Sweet! does chrome has an add-on preference system? I think a preference system is an essential component for an add-on ecosystem. What I mean is

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread Peter Kasting
On Tue, May 5, 2009 at 4:43 PM, Aaron Boodman a...@chromium.org wrote: Note that using cookies, as Peter suggests, won't work either. The lesson is, never listen to me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread cpu
On May 5, 10:44 am, Scott Hess sh...@chromium.org wrote: I agree with the earlier argument about not larding startup with things like writing new files to id the coming-up Chrome to late-coming instances.  An alternative might be to acquire a lock to protect the profile, and write an id

[chromium-dev] Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Andrew Scherkus
WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in a GraphicsContext: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup We currently forward the MediaPlayerPrivate::paint(GraphicsContext* p, const

[chromium-dev] Re: custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread Tony Chang
Be aware that it's not possible to just pick any directory and have it not synced. It only works on directories that are pulled from a different repository like src/webkit/data/layout_tests/LayoutTests. Our main repository in src/ has a lot of layout test result files in

[chromium-dev] Re: Does chrome have an add-on preference system?

2009-05-05 Thread Stanley Jack
Thanks for all of your inputs. My previous example (gmail addon) might be misleading. Let's say the popular ad block. Ad block should be working on all web sites, and a user should be able to add/edit/delete any specified ad sources. Such information need to be stored locally, and accessible from

[chromium-dev] Speed up linking

2009-05-05 Thread Leith Bade
Does anyone have any tips on how to speed up the linking of chrome.dll? It takes 15min on my 2GB Core 2 1.83GHz laptop, and gets anoying when I want to test a 1-2 line change in some file. Thanks, Leith Bade le...@leithalweapon.geek.nz --~--~-~--~~~---~--~~

[chromium-dev] Re: Speed up linking

2009-05-05 Thread Mohamed Mansour
15 minutes on a clean build is pretty good ... For testing 1 -2 line change it needs to link, so expect a 3-6 minute linkage (depending if it depends another module) You can read the section Building Chromium http://dev.chromium.org/developers/how-tos/build-instructions-windows there is a

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Brett Wilson
On Wed, May 6, 2009 at 8:40 AM, Andrew Scherkus scher...@chromium.org wrote: WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in a GraphicsContext: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup

[chromium-dev] Re: custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread Evan Stade
check src/DEPS to see the directories you can ignore. On Tue, May 5, 2009 at 5:41 PM, Tony Chang t...@chromium.org wrote: Be aware that it's not possible to just pick any directory and have it not synced.  It only works on directories that are pulled from a different repository like

[chromium-dev] Re: Speed up linking

2009-05-05 Thread Mohamed Mansour
Those are what, 10K systems :) /me jealous On Tue, May 5, 2009 at 10:11 PM, Ben Goodger (Google) b...@chromium.orgwrote: Better hardware really helps. Sadly the Core 2 systems just don't cut it. A Nehalem based system will build chrome_exe from scratch in 4 minutes and 50 seconds (I have

[chromium-dev] Re: custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread Glen Murphy
I had this problem last week, see the svn-ignore stuff on: http://groups.google.com/group/chromium-dev/browse_thread/thread/1fa32f170aa749af Your client will still take ages to sync (I believe the list of 200,000 files still gets passed around), however. On Mon, May 4, 2009 at 1:45 AM, chrome

[chromium-dev] Re: Speed up linking

2009-05-05 Thread Ben Goodger (Google)
The i7-920 system that Glen and I built can be built for ~$1800 by using newegg.com :-) -Ben On Tue, May 5, 2009 at 7:28 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Those are what, 10K systems :) /me jealous On Tue, May 5, 2009 at 10:11 PM, Ben Goodger (Google) b...@chromium.org

[chromium-dev] Re: Speed up linking

2009-05-05 Thread Glen Murphy
You can build an i7 machine (OC4Ghz/12GB/SSD) that will build Chrome in that time for $1500 (box only). It is what Ben and I use. On Tue, May 5, 2009 at 7:28 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Those are what, 10K systems :) /me jealous On Tue, May 5, 2009 at 10:11 PM, Ben

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
That would be pretty clean--or perhaps wrap it in a PlatformCanvas instead of a bare PlatformGraphicsContext? I haven't looked at the media code yet, so I'm not familiar with what it's actually trying to do. --Amanda On Tue, May 5, 2009 at 10:08 PM, Brett Wilson bre...@chromium.org wrote: On

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread 王重傑
If there was a nice way to get a PlatformCanvas out of a PlatformGraphicsContext when PLATFORM(CG), that'd be awesome. Brett, I'm not quite sure how you mean to do that. Do you mean that in the glue code, we should instantiate a byte buffer that we ask the rendered to fill in, then use webkit's

[chromium-dev] Re: depot_tools is moving!

2009-05-05 Thread Marc-Antoine Ruel
[Sorry, I should have replied earlier.] For both steps, you need to svn up depot_tools first or gclient help since I just cheked in the changes. *Forcing the installation of depot_tools version of svn and python* Run depot_tools\bootstrap\win_tools.bat force to force the installation of python

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread PhistucK
Then... no way for now? :( I built a little instant messaging notifier with the extensions. :) ☆PhistucK On Wed, May 6, 2009 at 02:45, Peter Kasting pkast...@google.com wrote: On Tue, May 5, 2009 at 4:43 PM, Aaron Boodman a...@chromium.org wrote: Note that using cookies, as Peter suggests,

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread Aaron Boodman
No good way. If you were feeling especially hacky, you could use the Bookmark system (http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/bookmarks-api) as a temporary data store until LocalStorage is implemented. Not recommended, but it works, we've done it for

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
Ah, I see. Hmm, going in that direction (from a GraphicsContext back up to the PlatformCanvas that wraps it) is an interesting question (the rest of our rendering code goes in the other direction). And as Brett can attest, this isn't the first time that PLATFORM(CG) has caused a headache--we

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread 王重傑
On Tue, May 5, 2009 at 9:38 PM, Amanda Walker ama...@chromium.org wrote: Ah, I see. Hmm, going in that direction (from a GraphicsContext back up to the PlatformCanvas that wraps it) is an interesting question (the rest of our rendering code goes in the other direction). And as Brett can

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread PhistucK
Yeah, I actually thought about it but never got into implementing it, since my project is kind of secret (to the surroundings) and I am afraid to create a slightly comprehensible bookmark entry with identifiable details. (Too much details, hehe. Forget it. :)) ☆PhistucK 2009/5/6 Aaron Boodman

[chromium-dev] Re: Speed up linking

2009-05-05 Thread Evan Martin
I apologize for flogging this horse, but echo 'int extra_variable_to_cause_ccache_miss = 3;' chrome/browser/browser.cc followed by rebuilding chrome just took about 10 seconds on my old laptop, which is a 1.8ghz core duo with 2gb. The secret is linking using shared libraries, which means my