[chromium-dev] Re: Mac Chrome launch speed = the awesome

2009-09-10 Thread Shinnawy
Would like to add my many thanks to the chrome team for the amazingly blazingly fast Chromium on Mac :) Awesome work you guys! On Sep 8, 8:11 am, Adam Barth aba...@chromium.org wrote: Dear Mac folks: Thanks for making Mac Chrome launch ridiculously fast.  I really enjoy that, on my laptop,

[chromium-dev] Re: autolinking BUG= lines in Rietveld

2009-09-10 Thread John Abd-El-Malek
This is just for Rietveld issues. We can possibly do the same to the commit log in gcl/git scripts, again patches welcome :) Thanks Mohamed for the patch, I committed it and made it live with two minor changes. On Wed, Sep 9, 2009 at 10:04 PM, PhistucK phist...@gmail.com wrote: Are we only

[chromium-dev] What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
Hi, Recently I'm working on an automated test of autocomplete edit view, see CL: http://codereview.chromium.org/177052. It's an in process browser test. It tests the functionalities of autocomplete edit view (omnibox) by simulating key events. It's supposed to run on both Linux and Windows, and

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread Marc-Antoine Ruel
Random guess: timing issues? Since the try slaves are VMs under heavy load, they tend to show race conditions more often, which is a Good Thing™. On Thu, Sep 10, 2009 at 6:15 AM, James Susu...@chromium.org wrote: Hi,   Recently I'm working on an automated test of autocomplete edit view, see

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread Erik Kay
Another issue to be aware of is that on the bots, they're running without an active desktop. This can lead to a few things behaving slightly differently than your local machine. For example, there will be no active window, so a call like BrowserList::GetLastActiveWithProfile(...) will always

[chromium-dev] Chromium core principles and multiplatform development?

2009-09-10 Thread Dan Kegel
An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what windows developers are for.) He said that none of the doc at

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
On Thu, Sep 10, 2009 at 1:03 PM, Dan Kegel d...@kegel.com wrote: An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Paweł Hajdan Jr .
For me it was obvious, but if people are surprised by this, then improving the documentation is probably a good idea. Just curious... the change has been submitted to trybots before landing, hasn't it? On Thu, Sep 10, 2009 at 10:03, Dan Kegel d...@kegel.com wrote: An external contributor was

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Dan Kegel
OK, we should probably improve http://dev.chromium.org/developers/contributing-code similarly, then. In this case, the code may have been submitted by a committer without using the trybots (tsk, tsk). We don't currently mention the trybots on dev.chromium.org. Is it time to? On Thu, Sep 10,

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread James Su
Good news. I'll try it tomorrow. Will interactive_ui_tests runs on trybot (maybe in the future) ? Regards James Su 2009/9/11 Jay Campan jcam...@google.com Oh, I found it. So I'm wondering why not just move browser_focus_uitest into browser_tests? Is it because the trybot limitation (no

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Paweł Hajdan Jr .
On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote: In this case, the code may have been submitted by a committer without using the trybots (tsk, tsk). We don't currently mention the trybots on dev.chromium.org. Is it time to? Submitting without trybots and breaking the

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Nico Weber
An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what windows developers are for.) [...] Anyone think we need

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
I blogged about that when we kicked off the additional platform efforts, though it's probably a good idea to say something about it on the site as well. --Amanda On Thu, Sep 10, 2009 at 1:20 PM, Nico Weber tha...@chromium.org wrote: An external contributor was recently surprised that a

[chromium-dev] Re: found corrupted db

2009-09-10 Thread cpu
The plot thickens, the main history db is also corrupted: D:\test\corruptdbsqlite3.exe zzz\User Data\Default\History SQLite version 3.6.17 Enter .help for instructions Enter SQL statements terminated with a ; sqlite PRAGMA integrity_check; rowid 40017 missing from index visits_time_index rowid

[chromium-dev] Re: What shall I do if a test runs on local Windows machine but fails on trybot?

2009-09-10 Thread Marc-Antoine Ruel
On Thu, Sep 10, 2009 at 1:19 PM, James Susu...@chromium.org wrote: Good news. I'll try it tomorrow. Will interactive_ui_tests runs on trybot (maybe in the future) ? No. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: found corrupted db

2009-09-10 Thread Peter Kasting
On Wed, Sep 9, 2009 at 9:21 PM, Scott Hess sh...@chromium.org wrote: What's puzzling is how I know this, but we still see the crash. I'm pretty sure we fixed something or other around this. That was a year or more back, though, so maybe I'm not remembering right. Regardless, best-case

[chromium-dev] Re: Are we going to support active FTP?

2009-09-10 Thread Peter Kasting
On Wed, Sep 9, 2009 at 10:01 PM, Darin Fisher da...@chromium.org wrote: For reference, this is https://bugzilla.mozilla.org/show_bug.cgi?id=465. A 3 digit Mozilla bug! Personally, I don't think we should spend much time on active mode FTP. It doesn't seem that valuable given that it is not

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
Sure. I'd run anything I write up past Ben, brian, etc. first before posting anything. --Amanda On Thu, Sep 10, 2009 at 3:07 PM, Peter Kasting pkast...@google.com wrote: On Thu, Sep 10, 2009 at 10:20 AM, Nico Weber tha...@chromium.org wrote: While you're on it, could you add something like

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Darin Fisher
On Thu, Sep 10, 2009 at 10:19 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote: In this case, the code may have been submitted by a committer without using the trybots (tsk, tsk). We don't currently mention the trybots on

[chromium-dev] How to use automation to do form submission?

2009-09-10 Thread hap 497
Hi, From looking at tab_proxy.cc, there is a way to load the browser with a specified URL: TabProxy::NavigateToURL(const GURL url); But Is there anyway to do a form submission to the browser (Http post with form submission data)? If there is no existing API for that purpose, how can I write

[chromium-dev] Re: How to use automation to do form submission?

2009-09-10 Thread Paweł Hajdan Jr .
I think you can execute javascript with automation (see chrome/test/automation/tab_proxy.h). It is possible to submit forms using javascript. If you want to add a new automation request, see chrome/test/automation_messages{,_internal}.h and add a new message there. Then add a new call to TabProxy

[chromium-dev] Re: autolinking BUG= lines in Rietveld

2009-09-10 Thread Mohamed Mansour
Np! I will do one for gcl. -- Mohamed Mansour On Thu, Sep 10, 2009 at 3:31 AM, John Abd-El-Malek j...@chromium.org wrote: This is just for Rietveld issues. We can possibly do the same to the commit log in gcl/git scripts, again patches welcome :) Thanks Mohamed for the patch, I committed it

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Adam Barth
On Thu, Sep 10, 2009 at 2:56 PM, Eric Roman ero...@chromium.org wrote: In the chromium trunk builds later than r25926, there is a new info page, view-net-internal: Can we move this to chrome://net-internal/ ? Proliferating random schemes adds up to a security issue. The chrome scheme has a

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Paweł Hajdan Jr .
I like it! Like every feature which allows one to take a look under the hood. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Eric Roman
Sure, I am willing to move things around. Note that I was following the model of view-cache: which uses similar URLs. (Turns out it is easier as its own scheme, since all of the implementation details can live in the network module. If we pull it up into chrome:// the code will need up move up

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Darin Fisher
Yeah, whatever problems we have with view-net-internal, we must have with view-cache. Before making a change, we should understand why view-cache hasn't been a problem. Or, has it? -Darin On Thu, Sep 10, 2009 at 3:07 PM, Eric Roman ero...@chromium.org wrote: Sure, I am willing to move

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Darin Fisher
http://www.corp.google.com/~darin/test/view-info.html ^ the iframes do not load On Thu, Sep 10, 2009 at 3:11 PM, Darin Fisher da...@chromium.org wrote: Yeah, whatever problems we have with view-net-internal, we must have with view-cache. Before making a change, we should understand why

[chromium-dev] Re: Wanted: anonymous FTP servers running rare software

2009-09-10 Thread Paweł Hajdan Jr .
On Thu, Sep 10, 2009 at 15:54, Chris Evans cev...@chromium.org wrote: Sounds like a moderate amount of work. IMHO, it would be acceptable from a security standpoint to: 1) Fix any bugs turned up by fuzzing. Even then, I'd need some way to verify the validity of the fixes. Mozilla has some