[chromium-dev] Re: FYI: Linux interactive_ui_tests a bit hosed

2009-11-02 Thread Paweł Hajdan Jr .
I think that the right fix is to switch interactive_ui_tests to browser_tests launcher (jcampan did some great work to make the launcher more flexible, it may be quite simple to do the switch now - if there are no UI tests in interactive_ui_tests). I also suggest bumping the priority of

[chromium-dev] Re: Compiler warning with Arch Linux and make

2009-11-02 Thread Alexander Teinum
Success. Adding 'remove_webcore_debug_symbols' to include.gypi probably solved my problem (although I did a debug build now). This is the first time that I have had success compiling Chromium in Arch Linux with make. And it's also the first time that I have gotten a debug build working in Arch

[chromium-dev] Re: [FYI] Build errors while building Chromium with gcc 4.4.

2009-11-02 Thread Joel Stanley
2009/11/2 Hironori Bono (坊野 博典) hb...@chromium.org: 1. Creating a file ~/.gyp/inclulde.gypi'. 2. Adding a following lines to the file. { 'variables': { 'no_strict_aliasing': 1 } } If you're only building chrome, not the unit_tests target, you can instead define gcc_version

[chromium-dev] Compiler warning with Arch Linux and make

2009-11-02 Thread Alexander Teinum
I'm trying to compile Chromium on 64-bit Arch Linux. It did work fine with SCons in release mode, but it seems like make is going to replace SCons from what I have read in the recent discussions. I have had a lot of pain compiling Chromium in general, because of gperf, generated code, strict

[chromium-dev] How much RAM needed to get past linking? (Linux)

2009-11-02 Thread Akira
Hi, I was building on Fedora 10 and was able to compile but the linking stage (see below) consumes more and more memory- the 500Mb of remaining memory, then another 1Gb of swap- before being killed. . Compiling /home/akira/chromium/src/sconsbuild/Debug/obj/chrome/chrome/

[chromium-dev] Re: How much RAM needed to get past linking? (Linux)

2009-11-02 Thread Adam Langley
On Fri, Oct 30, 2009 at 9:10 AM, Akira ak...@yayakoshi.net wrote:    I was building on Fedora 10 and was able to compile but the linking stage (see below) consumes more and more memory- the 500Mb of remaining memory, then another 1Gb of swap- before being killed. Are you using gold?

[chromium-dev] Re: Compiler warning with Arch Linux and make

2009-11-02 Thread Evan Martin
On Sun, Nov 1, 2009 at 8:01 AM, Alexander Teinum atei...@gmail.com wrote: Success. That's great! If you have any notes that would be useful to other Arch users, please update the instructions on the wiki at http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites (There's a

[chromium-dev] Re: Compiler warning with Arch Linux and make

2009-11-02 Thread Craig Schlenter
As Evan notes, things move quickly :) What made the difference here is that Joel fixed that error and you must have updated your tree. --Craig On Sun, Nov 1, 2009 at 5:01 PM, Alexander Teinum atei...@gmail.com wrote: Success. Adding 'remove_webcore_debug_symbols' to include.gypi probably

[chromium-dev] Re: How much RAM needed to get past linking? (Linux)

2009-11-02 Thread Paweł Hajdan Jr .
If you have less than 1 GB of RAM, I wouldn't even try to link the biggest binaries. 2 GB of RAM should be sufficient, although with 4 and more it's better. And you will notice the change after switching to gold. On Mon, Nov 2, 2009 at 18:58, Adam Langley a...@chromium.org wrote: On Fri, Oct

[chromium-dev] Re: FYI: Linux interactive_ui_tests a bit hosed

2009-11-02 Thread John Abd-El-Malek
(CCing today's sheriffs + Jay) I was thinking of marking the bug to P1, except that won't change much if no one has the time to work on it now. I think to keep tree green, the entire test should be disabled until singletons are cleared between each test, or it's switched to browser_tests

[chromium-dev] compile fails on Ubuntu 9.04

2009-11-02 Thread Paweł Hajdan Jr .
I'm getting this compile error when compiling on Ubuntu 9.04 (scons): Compiling /home/ph/chromium/src/sconsbuild/Debug/obj/libxslt/libxslt/libxslt/xsltutils.o Generating version information Creating library /home/ph/chromium/src/sconsbuild/Debug/lib/libxslt.a Indexing

[chromium-dev] Chromium security UI choices

2009-11-02 Thread Mike Hearn
Hiya, I'm not sure if chromium-dev is the right place for this discussion as it's a bit vague. Please don't hesitate to redirect me if not. I'm concerned about the way Chromium displays SSL security indicators, which this blog post reminded me about:

[chromium-dev] Re: compile fails on Ubuntu 9.04

2009-11-02 Thread Mark Mentovai
Paweł Hajdan Jr. wrote: scons: *** [/home/ph/chromium/src/sconsbuild/Debug/obj/yasm/genmacro/source/patched-yasm/tools/genmacro/genmacro.o] Source `/home/ph/chromium/src/third_party/yasm/source/patched-yasm/tools/genmacro/genmacro.c' not found, needed by target

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Peter Kasting
+CC Ian Fette, our security PM. None of the issues you raise are new; we've considered them for a couple of years. In general I agree that positive security indicators are designed around the idea that users should be alarmed by something's _absence_, which doesn't work well with how people

[chromium-dev] [Mac] Make sure you're working on M4 P1 bugs

2009-11-02 Thread Mike Pinkerton
Our goal for this Friday is to be able to count our Mac P1 M4 release blocker bugs on one hand (we're in the 20s now). To that end, everyone should have their P1 list practically at zero by the end of this week. If you are not going to be able to reach this, let me (or other triage folk) know

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread John Munro
I do think our host-versus-everything-else coloring in the address bar helps with phishing URLs even if users can't articulate what the different colored sections are. Would this be a good time to revisit this issue: http://code.google.com/p/chromium/issues/detail?id=1971 Both Firefox and

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Peter Kasting
On Mon, Nov 2, 2009 at 1:10 PM, John Munro ghost...@gmail.com wrote: I do think our host-versus-everything-else coloring in the address bar helps with phishing URLs even if users can't articulate what the different colored sections are. Would this be a good time to revisit this issue:

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Erik Kay
On Mon, Nov 2, 2009 at 11:23 AM, Mike Hearn mh.in.engl...@gmail.com wrote: - Use of cheap negative trust indicators, for instance if a page matches the regex Bank of America and is not the well known site a small bar or bubble could appear that says This website is not owned by Bank of

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Mike Hearn
The malware and phishing system does a pretty good job of detecting phishing sites like this, which we get notified of via SafeBrowsing SafeBrowsing is a great system, but it ultimately relies on savvy users telling us that a site is phishing. Some scams are sufficiently good that the majority

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Peter Kasting
On Mon, Nov 2, 2009 at 2:28 PM, Mike Hearn mh.in.engl...@gmail.com wrote: I disagree that the padlock animation would be adding visual noise, I wasn't commenting about the animation, rather the presence of an indicator on normal sites. PK --~--~-~--~~~---~--~~

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Mike Hearn
[repost with my actual signup address] Ah, I see. Yeah, I agree, that would clutter Chrome a bit. I'm not sure what direction to look in then. Things like SafeBrowsing suffer from the imperfect protection problem, but they are still worth doing. Only showing indicators when the site

[chromium-dev] Re: readability extension (experience writeup)

2009-11-02 Thread Evan Martin
On Sat, Oct 31, 2009 at 3:41 PM, Aaron Boodman a...@chromium.org wrote:  - The docs are behind the code (had to read the code once or twice to figure out what was going wrong). Were you using trunk or dev? I was using dev. I think I just searched on Google and clicked through to whichever

[chromium-dev] refactoring and git

2009-11-02 Thread Drew Wilson
Hi all, I'm doing some refactoring in the chromium worker code, and I got the following review feedback: small request: can the files that were branched from existing files be svn copy'd instead of copying manually and svn added? This will preserve history and will make it easier to see what

[chromium-dev] Re: refactoring and git

2009-11-02 Thread Evan Martin
On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson atwil...@chromium.org wrote: I'm doing some refactoring in the chromium worker code, and I got the following review feedback: small request: can the files that were branched from existing files be svn copy'd instead of copying manually and svn

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Adam Barth
On Mon, Nov 2, 2009 at 11:23 AM, Mike Hearn mh.in.engl...@gmail.com wrote: I'm concerned about the way Chromium displays SSL security indicators, which this blog post reminded me about:   http://chrome.blogspot.com/2009/10/are-you-seeing-red.html There have been a few studies of SSL

[chromium-dev] Re: Inheritance in gyp configurations

2009-11-02 Thread 王重傑
On Sun, Nov 1, 2009 at 3:26 PM, Bradley Nelson bradnel...@google.comwrote: 1) Do you support multiple inheritance? I notice the inherit_from is specified as an array. That's scaryish. Multiple inheritance is supported, not sure it's wise to use, but well gyp has lots of features like

[chromium-dev] Re: Inheritance in gyp configurations

2009-11-02 Thread Mark Mentovai
We've got the gypd (d = debug) sorta-generator format as an option, alongside xcode, msvs, make, etc. It dumps the dicts it receives as .gypd files next to your .gyp files, so you can see what would be fed to a generator. You might need to feed it some -D because it's not tied to an OS by

[chromium-dev] Re: browser/sync test fixit next week [Nov 2 - 6]

2009-11-02 Thread Tim Steele
Just a reminder, this is happening now! On Fri, Oct 30, 2009 at 1:14 PM, Tim Steele t...@chromium.org wrote: Hello! A heads-up that folks working on sync will be holding a test fixit next week, Nov 2 - 6. The motivation is to improve test coverage of our code, as there are many more chunks

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Evan Stade
I now have a new response ready for the next click to select all thread: the best way to make your case is to write an academic paper and conduct a user study that shows how the new UI out-performs the current UI. -- Evan Stade --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Adam Barth
I'm sorry if my email came off as dismissive. I really would like to see some serious study of user interfaces for certificate errors. I think everyone agrees that the current designs can be improved. We even know how to measure success (e.g.,

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-02 Thread Huan Ren
Cool! I could compare the builds before and after these changes to see what difference it makes. Of course it also prevents future issues. Huan On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.org wrote: Over the last week, I've been making some changes to how threads are used

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-02 Thread John Abd-El-Malek
That sounds interesting, but there are still two changes remaining and other unrelated changes have gone in in the meantime, so it wouldn't be an apple to apple comparison. I can let you know when I'm done though (when the bug is marked fixed). On Mon, Nov 2, 2009 at 10:09 PM, Huan Ren

[chromium-dev] Compiling error after I did a 'gclient sync'

2009-11-02 Thread n179911
Hi, I have tried syncing up chromium HEAD by doing this (since i use git for chromium and webkit). $ git pull (update chromium) $ gclient sync $ tools/sync-webkit-git.py (update webkit) But i got the following errors when I compile it. It appears the method

[chromium-dev] Re: refactoring and git

2009-11-02 Thread Paweł Hajdan Jr .
That's a good news. Can that info be put somewhere in the UsingGit wiki page? On Mon, Nov 2, 2009 at 23:56, Evan Martin e...@chromium.org wrote: On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson atwil...@chromium.org wrote: I'm doing some refactoring in the chromium worker code, and I got the

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-02 Thread Chase Phillips
On Mon, Nov 2, 2009 at 10:27 PM, n179911 n179...@gmail.com wrote: Hi, I have tried syncing up chromium HEAD by doing this (since i use git for chromium and webkit). $ git pull (update chromium) $ gclient sync $ tools/sync-webkit-git.py (update webkit) Hi Samuel, The error you're seeing

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-02 Thread Kenneth Russell
On Mon, Nov 2, 2009 at 10:27 PM, n179911 n179...@gmail.com wrote: Hi, I have tried syncing up chromium HEAD by doing this (since i use git for chromium and webkit). $ git pull (update chromium) $ gclient sync $ tools/sync-webkit-git.py (update webkit) But i got the following errors when