[chromium-dev] Re: Next dev release

2009-11-05 Thread Aaron Boodman
On Thu, Nov 5, 2009 at 10:18 AM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, Just wanted to know when will the next dev release be? Hi Marcos, We usually try to do dev channel releases once a week, but it varies depending on the state of the tree. Releases (even dev channel ones) take

[chromium-dev] Ensuring that all destructors of ref counted objects are private

2009-11-05 Thread John Abd-El-Malek
I've gone through the code and made all destructors of objects that derive from base::RefCounted or base::RefCountedThreadSafe private. This helps to catch corruption bugs at compile time. For classes that are derived from refcounted, make the destuctor protected and ensure that all derived

[chromium-dev] Large commit - update your .gclient files to avoid

2009-11-05 Thread Steve VanDeBogart
This afternoon I will update DEPS to pull in 170MB of profile data for memory_test. Unless you run memory_test, you probably want to add the following line to the custom_deps section of your .gclient file. src/data/memory_test/membuster: None, -- Steve

[chromium-dev] Re: Next dev release

2009-11-05 Thread Marcos Aruj
Ok, thanks a lot. I was asking because I am testing the Notifications API and only got it working on the latest nightly build of chromium, but devtools for it doesn't work. Thanks for your help. On Thu, Nov 5, 2009 at 1:11 PM, Aaron Boodman a...@chromium.org wrote: On Thu, Nov 5, 2009 at 10:18

[chromium-dev] Next dev release

2009-11-05 Thread Marcos Aruj
Hi all, Just wanted to know when will the next dev release be? Thanks -- Marcos Aruj Alvarez Ingeniero de Software --- marcos.a...@gmail.com - --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Re: Next dev release

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 10:18 AM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, Just wanted to know when will the next dev release be? Don't spam this list with questions like this. If you look at the timeline of past dev releases you can probably estimate how long it is between each one.

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Adam Barth
Can we note this on dev.chromium.org somewhere? Adam On Thu, Nov 5, 2009 at 11:16 AM, Steve VanDeBogart vand...@chromium.org wrote: This afternoon I will update DEPS to pull in 170MB of profile data for memory_test. Unless you run memory_test, you probably want to add the following line to

[chromium-dev] history.back always fires onload in chromium - is it expected?

2009-11-05 Thread Kinuko Yasuda
Hi chromium developers, I've been looking into a layout-test bug 20341 ( http://code.google.com/p/chromium/issues/detail?id=20341) and found that in chromium history.back always fires onload() even if WebKit's page cache is enabled (== WebKitUsePageCachePreferenceKey is set true). This makes

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Jeremy Orlow
In general, it might be interesting to document how to get a more lean checkout of Chromium. On Thu, Nov 5, 2009 at 11:34 AM, Adam Barth aba...@chromium.org wrote: Can we note this on dev.chromium.org somewhere? Adam On Thu, Nov 5, 2009 at 11:16 AM, Steve VanDeBogart vand...@chromium.org

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Ben Goodger (Google)
it'd be nice to have a gclient config lean or something like that. -Ben On Thu, Nov 5, 2009 at 11:42 AM, Jeremy Orlow jor...@google.com wrote: In general, it might be interesting to document how to get a more lean checkout of Chromium. On Thu, Nov 5, 2009 at 11:34 AM, Adam Barth

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Charles Reis
See the Reducing the size of your checkout section of this page for a place to mention it: http://dev.chromium.org/developers/how-tos/get-the-code (gclient config lean would also be nice) Charlie On Thu, Nov 5, 2009 at 11:44 AM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Lei Zhang
And have the tarball generated from this lean configuration. On Thu, Nov 5, 2009 at 11:44 AM, Ben Goodger (Google) b...@chromium.org wrote: it'd be nice to have a gclient config lean or something like that. -Ben On Thu, Nov 5, 2009 at 11:42 AM, Jeremy Orlow jor...@google.com wrote: In

[chromium-dev] Re: [Chrome-team] Re: [MEMORY] Counting committed bytes

2009-11-05 Thread Ricardo Vargas
On Thu, Nov 5, 2009 at 7:32 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Nov 4, 2009 at 3:39 AM, Ricardo Vargas rvar...@google.com wrote: I don't see the post to chromium-dev so... Sorry, responding to chromium-dev. Playing with your code the only delta that I see is one page (for

[chromium-dev] Re: Extensions performance data

2009-11-05 Thread Anton Muhin
Adam, all, I've got http://codereview.chromium.org/355047/ which should speed up accessing isolated worlds (it at least passes layout tests). Could someone either see if it helps or give me instructions how to bench it? yours, anton. On Tue, Oct 27, 2009 at 8:04 PM, Anton Muhin

[chromium-dev] Re: history.back always fires onload in chromium - is it expected?

2009-11-05 Thread Tony Chang
It sounds like the test depends on the page cache being enabled so we won't be able to pass it until we support the page cache ( http://code.google.com/p/chromium/issues/detail?id=2879 ). There are a couple options: 1) Try to implement the page cache-- abarth probably has some thoughts on this.

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Antoine Labour
On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. Antoine --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Explaining to users how to enable logging

2009-11-05 Thread Eric Roman
If you want to ask a user for their chrome_debug.log in a bug report, you can just paste them this URL: http://dev.chromium.org/for-testers/enable-logging I got tired of writing these steps repeatedly in bug reports, so collected them into a document. I am still unhappy with how complicated

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Scott Hess
On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.org wrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. As long as we're on

[chromium-dev] Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. I know we've avoided

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Jeremy Orlow
I started a new thread about a lite version of the checkout. Might be good to move discussion there. On Thu, Nov 5, 2009 at 12:44 PM, Scott Hess sh...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Ben Goodger (Google)
+1. This would be fab. There are so many test executables now it's not practical to run them all (unless we have a script... which is sort of what the trybot is like you say). I like the idea of having full/lean configs. That way you don't need to remember to set up the right .gclient when you

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Pam Greene
On Thu, Nov 5, 2009 at 1:38 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Dirk Pranke
+1. I also wonder if it might be useful to have a names file/service for configs so I don't have to remember the full URL when doing a gclient config ... -- Dirk On Thu, Nov 5, 2009 at 12:50 PM, Ben Goodger (Google) b...@chromium.org wrote: +1. This would be fab. There are so many test

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Pam Greene
On Thu, Nov 5, 2009 at 1:50 PM, Ben Goodger (Google) b...@chromium.orgwrote: +1. This would be fab. There are so many test executables now it's not practical to run them all (unless we have a script... which is sort of what the trybot is like you say). chrome/tools/test/smoketests.py Runs

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Ben Goodger (Google)
We should include a VM image that these tests get run inside of. ;D -Ben On Thu, Nov 5, 2009 at 12:56 PM, Pam Greene p...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:50 PM, Ben Goodger (Google) b...@chromium.org wrote: +1. This would be fab. There are so many test executables now it's not

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Antoine Labour
On Thu, Nov 5, 2009 at 1:38 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like

[chromium-dev] test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
For a personal project (well, an OS -- check out www.brevityos.org if you're interested), I need something like test_shell in fullscreen mode. The UI is basically an HTML-file with an iframe for every document. CSS-classes are used to describe what application is active, what documents are active

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.org wrote: Over the last week, I've been making some changes to how threads are used in the browser process, with the goal of simplifying cross-thread access and improving stability. *The problem* We were using a number of

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
I could probably hack it so that it went into fullscreen, and then disable F11, but that's dirty. All the UI stuff from Chromium would still be there, although it would be hidden. Alexander On Thu, Nov 5, 2009 at 10:32 PM, Dirk Pranke dpra...@chromium.org wrote: test_shell being a test shell

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Dirk Pranke
test_shell being a test shell used mostly for non-interactive testing, we haven't given a lot of concern to its perfomance AFAIK. I'm not even sure how long of a lifespan it'll have since we aim to merge/replace it with WebKit's DumpRenderTree at some point soon. Is there some reason you're not

[chromium-dev] Tech talk topics

2009-11-05 Thread Jeremy Orlow
About 6 months ago, we had a series of tech talks on various bits of Chromium's architecture. (They're listed here: http://dev.chromium.org/developers/tech-talk-videos) The youtube ratings are pretty high, they've all had over a thousand views, and I've seen them mentioned in a couple

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread John Abd-El-Malek
On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote: Over the last week, I've been making some changes to how threads are used in the browser process, with the goal of simplifying cross-thread access

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote: Over the last week, I've been making some changes to how threads are

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 1:44 PM, Alexander Teinum atei...@gmail.com wrote: I could probably hack it so that it went into fullscreen, and then disable F11, but that's dirty. All the UI stuff from Chromium would still be there, although it would be hidden. test_shell doesn't implement the fast

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
This is exactly what i want. Thanks! I'll see if I can make it work. Alexander On Thu, Nov 5, 2009 at 10:51 PM, Nico Weber tha...@chromium.org wrote: http://codereview.chromium.org/244003/show might be what you want. On Thu, Nov 5, 2009 at 1:44 PM, Alexander Teinum atei...@gmail.com wrote:

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Nico Weber
http://codereview.chromium.org/244003/show might be what you want. On Thu, Nov 5, 2009 at 1:44 PM, Alexander Teinum atei...@gmail.com wrote: I could probably hack it so that it went into fullscreen, and then disable F11, but that's dirty. All the UI stuff from Chromium would still be there,

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
test_shell doesn't implement the fast painting for one. Is the scrolling performance the problem that you're seeing? Yes, I perceive the scolling, CSS scale-transformations on the iframes, and moving the iframes around as the biggest performance problems. All of these issues might be related

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Steve VanDeBogart
Apologies, this will only apply to committers from Google. -- Steve On Thu, Nov 5, 2009 at 11:16 AM, Steve VanDeBogart vand...@chromium.orgwrote: This afternoon I will update DEPS to pull in 170MB of profile data for memory_test. Unless you run memory_test, you probably want to add the

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Nico Weber
Maybe star http://crbug.com/23145 to express your interest. That might motivate mhm to get this ready for checkin. On Thu, Nov 5, 2009 at 1:58 PM, Alexander Teinum atei...@gmail.com wrote: This is exactly what i want. Thanks! I'll see if I can make it work. Alexander On Thu, Nov 5, 2009

[chromium-dev] Re: Explaining to users how to enable logging

2009-11-05 Thread Eric Roman
On Thu, Nov 5, 2009 at 2:10 PM, Chase Phillips ch...@chromium.org wrote: On Thu, Nov 5, 2009 at 12:34 PM, Eric Roman ero...@chromium.org wrote: If you want to ask a user for their chrome_debug.log in a bug report, you can just paste them this URL:

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread John Abd-El-Malek
On Thu, Nov 5, 2009 at 1:42 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
Maybe star http://crbug.com/23145 to express your interest. That might motivate mhm to get this ready for checkin. Done! :) Alexander On Thu, Nov 5, 2009 at 11:02 PM, Nico Weber tha...@chromium.org wrote: Maybe star http://crbug.com/23145 to express your interest. That might motivate mhm

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 1:44 PM, Alexander Teinum atei...@gmail.com wrote: I could probably hack it so that it went into fullscreen, and then disable F11, but that's dirty. All the UI stuff from Chromium would still be there, although it would be hidden. Why is that dirty? This is basically

[chromium-dev] Re: Explaining to users how to enable logging

2009-11-05 Thread Chase Phillips
On Thu, Nov 5, 2009 at 12:34 PM, Eric Roman ero...@chromium.org wrote: If you want to ask a user for their chrome_debug.log in a bug report, you can just paste them this URL: http://dev.chromium.org/for-testers/enable-logging I got tired of writing these steps repeatedly in bug reports,

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Marshall Greenblatt
On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: test_shell being a test shell used mostly for non-interactive testing, we haven't given a lot of concern to its perfomance AFAIK. I'm not even sure how long of a lifespan it'll have since we aim to merge/replace it with

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Scott Violet
It's not Chromium, but how about some WebKit tech talks? Such talks would be incredibly valuable to those helping out now and then with WebKit. -Scott On Thu, Nov 5, 2009 at 1:35 PM, Jeremy Orlow jor...@chromium.org wrote: About 6 months ago, we had a series of tech talks on various bits of

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 1:56 PM, Alexander Teinum atei...@gmail.com wrote: Yes, I perceive the scolling, CSS scale-transformations on the iframes, and moving the iframes around as the biggest performance problems. All of these issues might be related to that? You could try reading

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
Why is that dirty? This is basically kiosk mode, which other people have asked for too. The last time, that ballooned into an enormous unwieldy patch, but just adding a --fullscreen switch wouldn't be so bad. Sorry Dirk, I could have said why I don't think it's an optimal solution. I think

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
Sure...we definitely have some in-house expertise on this. I could even see if any of the Apple guys would be interested in this...but I wouldn't hold my breath. :-) What types of WebKit topics? On Thu, Nov 5, 2009 at 2:17 PM, Scott Violet s...@chromium.org wrote: It's not Chromium, but how

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Scott Violet
A general big picture talk would be a great starter. How the DOM is modeled, how the render tree works, the interesting objects ... -Scott On Thu, Nov 5, 2009 at 2:22 PM, Jeremy Orlow jor...@chromium.org wrote: Sure...we definitely have some in-house expertise on this.  I could even see if

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
Whops, I'm saying sorry to Dirk and replying to Peter. Sorry to both of you. ;) On Thu, Nov 5, 2009 at 11:24 PM, Alexander Teinum atei...@gmail.com wrote: Why is that dirty?  This is basically kiosk mode, which other people have asked for too.  The last time, that ballooned into an enormous

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 2:01 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:42 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 1:51 PM, Nico Weber tha...@chromium.org wrote: http://codereview.chromium.org/244003/show might be what you want. I thought this was intentionally abandoned because it was growing out of control. That's what I was alluding to before. On Thu, Nov 5, 2009 at 2:24 PM,

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 2:03 PM, Steve VanDeBogart vand...@chromium.orgwrote: Apologies, this will only apply to committers from Google. For clarity: If you added this line to your .gclient, you can remove it. PK --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Dirk Pranke
On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: test_shell being a test shell used mostly for non-interactive testing, we haven't given a lot of concern to its perfomance AFAIK. I'm not

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
What? What OS? There shouldn't be any 1 pixel border in our fullscreen mode. It's in the Linux-version. In BrowserWindowGtk::InitWidgets() there’s this line: gtk_widget_set_size_request(toolbar_border_, -1, 1); I changed it into: gtk_widget_set_size_request(toolbar_border_, -1, -1);

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.com wrote: What? What OS? There shouldn't be any 1 pixel border in our fullscreen mode. It's in the Linux-version. In BrowserWindowGtk::InitWidgets() there’s this line: gtk_widget_set_size_request(toolbar_border_, -1, 1);

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.com wrote: It's in the Linux-version. You should have mentioned the platform. You have an awful lot of work to get the Linux test_shell up to Chromium speeds. There's a lot of raw Xlib calls to keep the image of the page in video

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
Sure. I'm not into the patching process yet, but give me a couple of days, and I'll try to get it fixed. Alexander On Thu, Nov 5, 2009 at 11:48 PM, Peter Kasting pkast...@google.com wrote: On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.com wrote: What?  What OS?  There

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 2:51 PM, Adam Langley a...@chromium.org wrote: You have an awful lot of work to get the Linux test_shell up to Chromium speeds. I'm really opposed to doing work like this on test_shell. It's not just that it's a waste of time. One of the reasons we have test_shell is

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Evan Stade
-- Evan Stade On Thu, Nov 5, 2009 at 2:48 PM, Peter Kasting pkast...@google.com wrote: On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.comwrote: What? What OS? There shouldn't be any 1 pixel border in our fullscreen mode. It's in the Linux-version. In

[chromium-dev] The future for test shell (WAS: test_shell performance is bad compared to Chromium)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: test_shell being a test shell used mostly for

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Moskovich
IMHO it would be immensely valuable to give a talk explaining what Layout tests are and how they work in a *simple* enough manner to allow web developers to create tests for bugs that affect them. I haven't found any easily discoverable introductory material on this topic. Best regards, Jeremy

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
That's an excellent idea! Do you think you'd be able to give it? If not, do you have any suggestions on who would be good? Maybe Pam? On Thu, Nov 5, 2009 at 3:08 PM, Jeremy Moskovich jer...@chromium.orgwrote: IMHO it would be immensely valuable to give a talk explaining what Layout tests

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread Marcos Aruj
Hi all, We've been testing the Notifications API and have shown them successfully on a regular page. We are trying to use it from within an extension, but Chromium crashes when calling requestPermission. It correctly asks to allow notifications for chrome-extension://XX/, but

[chromium-dev] Re: The future for test shell (WAS: test_shell performance is bad compared to Chromium)

2009-11-05 Thread Dirk Pranke
Yeah, we would have to work out a way of handling these sorts of features. -- Dirk On Thu, Nov 5, 2009 at 3:01 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread Aaron Boodman
Creating a bug with a small sample attached would be great. On Thu, Nov 5, 2009 at 3:11 PM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, We've been testing the Notifications API and have shown them successfully on a regular page. We are trying to use it from within an extension, but

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread John Gregg
Thanks for the bug report, I am currently working on getting Notifications working for extensions and I'm familiar with this issue, although I don't think there is a bug for it yet. If you would create one I can update it as I get the fix checked in (which will hopefully be tomorrow, I think it's

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Mohamed Mansour
On Thu, Nov 5, 2009 at 5:33 PM, Peter Kasting pkast...@google.com wrote: On Thu, Nov 5, 2009 at 1:51 PM, Nico Weber tha...@chromium.org wrote: http://codereview.chromium.org/244003/show might be what you want. I thought this was intentionally abandoned because it was growing out of

[chromium-dev] Re: The future for test shell (WAS: test_shell performance is bad compared to Chromium)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 3:01 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

2009-11-05 Thread Drew Wilson
So I've officially switched to carbon emacs, and I'm loving it. Is there a way to launch a second instance - double-clicking the executable seems to just bring the original instance to the foreground. Feel free to tell me I'm Doing It Wrong, but when working on two trees simultaneously I like to

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Mohamed Mansour
+1 on the WebKit tech talks. And maybe on on the WebKitAPI infrastructure that darin organized. - Mohamed Mansour On Thu, Nov 5, 2009 at 5:17 PM, Scott Violet s...@chromium.org wrote: It's not Chromium, but how about some WebKit tech talks? Such talks would be incredibly valuable to those

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Pam Greene
I'd be happy to give a talk about layout tests. It would help me if people could suggest subtopics, or more simply, ask questions they'd like answered. I've been working with the things for so long, it's hard for me to know what's confusing or unclear anymore. - Pam On Thu, Nov 5, 2009 at 4:10

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Andrew Scherkus
Something that would have been immensely helpful to me when I started was a talk explaining the interaction between the javascript bindings, HTMLFooElement classes and RenderFoo classes. I'd volunteer, but I still don't know enough about this stuff myself -- other than when Foo == Media :)

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Alexander Teinum
I want to make it clear, and it might be obvious by now, but test_shell isn't interesting to me. I just want the fastest browser engine that I can get. What makes Chromium different than WebKitGTK+ for my project, is that Chromium renders the GTK stuff correctly with CSS transformations. It's

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
Thanks for the suggestions so far! Here's what I've seen so far: WebKit API - Darin? Eric's WebKit talk LayoutTests - Pam? Bindings - Andrew? Keep the ideas coming. If we get more than we want to tackle we can always vote on which would be most helpful to the community, but all the ones I've

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 3:34 PM, Alexander Teinum atei...@gmail.com wrote: Making the rendering part of Chromium easier to use for open source project would benefit projects such as mine or uzbl for instance. uzbl is a WebKitGTK+ browser that is controlled similar to Vim. This is one of the

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread Marcos Aruj
Ok, done: http://www.crbug.com/26859 I attached a crx to the report that triggers the bug. Thanks! On Thu, Nov 5, 2009 at 5:19 PM, John Gregg john...@google.com wrote: Thanks for the bug report, I am currently working on getting Notifications working for extensions and I'm familiar with this

[chromium-dev] Preventing keypress after accellerator?

2009-11-05 Thread Erik Arvidsson
We have code to suppress the keypress event if keydown triggered a browser accelerator both inside and outside of WebKit. I don't understand why we want to prevent a keypress after a Ctrl+A or Ctrl+B keydown? -- erik --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: Circular relationship in NaCl .gyp files - this is bad!

2009-11-05 Thread Bradley Nelson
Some further info on this topic: There are circular dependencies in nacl, but the reason this does not afflict the buildbots is that xcode will handle this correctly IF you CMD-Q out of xcode before regenerating the project file. We should nonetheless fix the circularity and then have gyp

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread James Su
You may refer to following bug reports: http://crbug.com/21624 http://crbug.com/21471 2009/11/6 Erik Arvidsson a...@chromium.org We have code to suppress the keypress event if keydown triggered a browser accelerator both inside and outside of WebKit. I don't understand why we want to prevent

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-05 Thread n179911
On Thu, Nov 5, 2009 at 9:23 AM, Evan Martin e...@chromium.org wrote: On Wed, Nov 4, 2009 at 11:55 PM, Chase Phillips ch...@chromium.org wrote: FWIW I see the same error you see when I try to git clone the WebKit git repository again locally while git fetch on an existing repository works

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-05 Thread 鵜飼文敏
seems git.webkit.org/WebKit.git is out of sync? it only has r50565, but should have r50584 or later to build chromium. On Fri, Nov 6, 2009 at 11:42 AM, n179911 n179...@gmail.com wrote: On Thu, Nov 5, 2009 at 9:23 AM, Evan Martin e...@chromium.org wrote: On Wed, Nov 4, 2009 at 11:55 PM, Chase

[chromium-dev] Re: Extensions performance data

2009-11-05 Thread Adam Barth
Try running a DOM benchmark while there is a content script that's waiting for a message from a background page. Adam On Thu, Nov 5, 2009 at 12:12 PM, Anton Muhin ant...@chromium.org wrote: Adam, all, I've got http://codereview.chromium.org/355047/ which should speed up accessing isolated

[chromium-dev] Re: history.back always fires onload in chromium - is it expected?

2009-11-05 Thread Adam Barth
We might or might not decide to implement page cache (Darin is in the might not camp). In either case, this LayoutTest shouldn't drive that decision. Adam On Thu, Nov 5, 2009 at 12:17 PM, Tony Chang t...@chromium.org wrote: It sounds like the test depends on the page cache being enabled so

[chromium-dev] A question regarding to the keyboard event flow in the browser process.

2009-11-05 Thread James Su
(Ask this question again, in case you know the answer but missed this thread.) Thanks for your clear explanation. Now I have some questions regarding to the keyboard event flow: As I understand, a keyboard event will firstly be sent to the RenderWidgetHostView object, which will forward the event

[chromium-dev] Re: history.back always fires onload in chromium - is it expected?

2009-11-05 Thread Kinuko Yasuda
Thanks for the replies, for now I'm going to do 2), i.e. mark the test SKIP, add a comment and wait for the decision for the page cache. (of course I don't think the test should determine the future of the page cache... :)) Kinuko On Fri, Nov 6, 2009 at 1:47 PM, Adam Barth aba...@chromium.org

[chromium-dev] Google URL as KURL

2009-11-05 Thread TAMURA, Kent
Why we use Google URL as KURL in WebCore? Google URL and the default KURL implementation have some differences on validation rule, and they make a layout test failure of LayoutTests/fast/forms/ValidityState-typeMismatch-url.html . (See https://bugs.webkit.org/show_bug.cgi?id=29913 for the detail)

[chromium-dev] Re: Google URL as KURL

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 9:47 PM, TAMURA, Kent tk...@chromium.org wrote: Why we use Google URL as KURL in WebCore? brettw is the man you want. IIRC the main issues are that we need to have consistent validity enforcement throughout our entire browser stack, and modifying KURL to make it act

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread Erik Arvidsson
On Thu, Nov 5, 2009 at 17:58, James Su su...@chromium.org wrote: You may refer to following bug reports: http://crbug.com/21624 http://crbug.com/21471 2009/11/6 Erik Arvidsson a...@chromium.org We have code to suppress the keypress event if keydown triggered a browser accelerator both

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread Peter Kasting
On Thu, Nov 5, 2009 at 10:49 PM, Erik Arvidsson a...@chromium.org wrote: On Thu, Nov 5, 2009 at 17:58, James Su su...@chromium.org wrote: if we still send the key press event of Ctrl+B to the WebKit, it might be handled by some javascript code in the web page and perform a specified action.

[chromium-dev] Re: Preventing keypress after accellerator?

2009-11-05 Thread James Su
You might want to read http://crbug.com/21624 first. It's the root cause for this change. I chose to fix that issue in such a generic way, because it's much more elegant than dealing with specific key bindings. If you encountered any issues caused by this change, please report them then let's