[chromium-dev] Re: Is it possible to create branches?
As the team's git fanatic I feel it's my duty to tell you that git would help with this, but I agree with the commenters who say that your commits must be reviewed. The way I use it is a single git branch manages the period between start typing and think this is ready for review commit, while a series of interrelated git branches track the larger arc of your feature. Then you can get each branch reviewed and committed separately. As the team's git fanatic I'll throw in that I think git is very useful for managing an interrelated series of changes -- you can, for example, iterate on feedback on change A while still working on dependent change B. But you also need to be decently comfortable with git for that and learning is slow. On Tue, Jun 16, 2009 at 9:35 PM, Daniel Cowxdaniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do you generate the VS project files from GYP without gclient?
See the hooks section at the bottom of src/DEPS to see what that runhooks command does. On Tue, Jun 16, 2009 at 9:17 PM, Daniel Cowxdaniel.c...@gmail.com wrote: I know that you typically generate the project files via gclient runhooks --force, but I'm curious to know how to generate the project files via python directly, instead of via gclient. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] git.chromium.org hiccup, fixed now
I'm not sure why, but the git.chromium.org repo was getting some checksum failures. It stopped updating around 6pm PDT. I rewound it a bit and restarted its mirroring, and it seems to be ok now, but you'll find the hashes have changed from around r18522. I think if you do an ordinary git merge it will be able to figure out that the data is the same on either side of the fork. Please contact me directly if you run into anything weird. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: skia backend support
Skia is already enabled in Chrome. We are not using the GL backend (it's not really finished). Thanks -- dean On Wed, Jun 17, 2009 at 1:43 PM, mailandroid wrote: I was looking at the support of skia backend for rendering (OpenGL/ OpenVG). How and where can we enable these backend in skia for chrome? Please provide me the details. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
I learned git 3 days ago and I actually love it. It is very easy to create branches and for your big feature you are trying to implement, it is better to organize it into different milestones. Because in git/chromium world, every branch can have at most one CL (Change List, Review). So if you define your milestones for your big feature before hand, by describing what your trying to do, you can then define how you can apply them to different branches and incrementally review each branch. Its easier for you to manage as well for the reviewers. Make sure you present a proposal on what your trying to accomplish and attach it to a tracking bug. For example, write up a detailed design document on what your big feature will do and then request comments on the discuss mailing lists. Its good to address the issues on why your big feature should be done in chrome. Don't put a lot of work implementing this before people think your design and idea is ok for the chromium project. -- Mohamed Mansour On Wed, Jun 17, 2009 at 12:35 AM, Daniel Cowx daniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
Against that, I sometimes use git to manage breaking reviews up. I'm always a bit unhappy to get a review which includes one bit of complex stuff that needs a bunch of back-and-forth, and another few bits of uncontentious stuff which is easy to +1. I'd rather see those separately, so that the easy-to-review stuff can get committed and we don't have to worry about accidental changes creeping into that code. 'git rebase -i' and keeping your local commits small and targeted makes this pretty easy to do. -scott On Tue, Jun 16, 2009 at 11:07 PM, Evan Martine...@chromium.org wrote: As the team's git fanatic I feel it's my duty to tell you that git would help with this, but I agree with the commenters who say that your commits must be reviewed. The way I use it is a single git branch manages the period between start typing and think this is ready for review commit, while a series of interrelated git branches track the larger arc of your feature. Then you can get each branch reviewed and committed separately. As the team's git fanatic I'll throw in that I think git is very useful for managing an interrelated series of changes -- you can, for example, iterate on feedback on change A while still working on dependent change B. But you also need to be decently comfortable with git for that and learning is slow. On Tue, Jun 16, 2009 at 9:35 PM, Daniel Cowxdaniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: git.chromium.org hiccup, fixed now
To answer some questions I got off-list, it looks like this wasn't quite sufficient. git-svn still caches the old hashes and will be confused. It's safe* to rm -rf .git/svn/ and then try something like git svn find-rev r18522 just to verify it rebuilds its index. To completely clobber a checkout or a branch, you can do one of: - git checkout -b someotherbranch origin; git branch -D mybranch - git reset --hard origin # clobbers current branch If you have changes you want to transplant, your best bet is probably saving them as a patch :\. See git help format-patch to construct them and git help am to apply them. (* I believe it's not safe if you have fancy settings like useSvmProps, but if you're doing that then you should probably understand how git-svn works.) On Wed, Jun 17, 2009 at 12:09 AM, Evan Martine...@chromium.org wrote: I'm not sure why, but the git.chromium.org repo was getting some checksum failures. It stopped updating around 6pm PDT. I rewound it a bit and restarted its mirroring, and it seems to be ok now, but you'll find the hashes have changed from around r18522. I think if you do an ordinary git merge it will be able to figure out that the data is the same on either side of the fork. Please contact me directly if you run into anything weird. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
If you blow up svn.bat and python.bat in your depot tools, it will create 'svn' and 'python' scripts so cygwin will pick them up earlier (according you ran gclient recently). But personally, I stay in shape, eat healthy, use svn in cmd and git in cygwin. M-A On Tue, Jun 16, 2009 at 1:04 PM, Darin Fisherda...@chromium.org wrote: On Tue, Jun 16, 2009 at 10:01 AM, Peter Kasting pkast...@google.com wrote: On Tue, Jun 16, 2009 at 9:55 AM, Darin Fisher da...@chromium.org wrote: That's not true anymore. The canary bot uses svn from depot_tools. Then all I can say is: when I accidentally used the depot_tools svn on my existing cygwin svn checkout late last week, I had to blow away the checkout to recover :( That I don't doubt :-( So perhaps using one or the other from the very beginning works OK now? I wouldn't mix them though. Yeah, that's been my experience. Where OK comes with some caveats where svn from depot_tools is concerned. -Darin --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: v8 support in other browsers
Given that you'd still need to use the COM-based Scripting Engine API (like IActiveScriptParse), I'm not sure how much you'd gain. But for running with cscript.exe, the difference would be appreciable, depending on how much DOM access you are doing. Reference: http://msdn.microsoft.com/en-us/library/xawadt95(VS.85).aspx M-A On Tue, Jun 16, 2009 at 1:01 PM, Fernandofernac...@gmail.com wrote: Is this project (or some other Google project) considering to provide a browser extension for other browsers (like Internet Explorer), which would allow existing JavaScript pages to run faster (and provide Chrome behavior) on such browsers? For example, a site that requires v8 performance or v8 compliance could just switch: script type=text/javascript ... // my old script here. /script with script type=text/javascript_v8 ... ... // my old script here. /script or maybe using Flash-like style: object classid=... codebase=http://download.google.com/ v8engine ... // my old script here. /object Is somebody considering this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
#1, make sure you have a bug open and a design document (exampleshttp://dev.chromium.org/developers/design-documents). Nothing's worse than going off on a long-lived feature expedition and then returning to trunk to find out people don't want the feature or want some other design. #2, work on trunk (as pkasting outlined). Put on red slippers, click the heels together and repeat There's no place like trunk, there's no place like trunk... We've successfully developed many features behind command line switches, some of which required major surgery. Working on trunk, your code stays fresh, you get more feedback along the way, and you can have your unit tests running on the builders. A branch is really only useful if you need to collaborate with someone else or _need_ your code to diverge from trunk. --Mark On Tue, Jun 16, 2009 at 21:35, Daniel Cowx daniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] What's the TabRestoreUITest bug 1215881?
tab_restore_uitest.cc:
TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {
// This test is disabled on win2k. See bug 1215881.
I cant find anything about bug 1215881 on
http://code.google.com/p/chromium/issues/list,
where to find it?
Thanks.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
On Tue, Jun 16, 2009 at 12:04 PM, pizhu.she...@gmail.com wrote:
tab_restore_uitest.cc:
TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {
// This test is disabled on win2k. See bug 1215881.
I cant find anything about bug 1215881 on
http://code.google.com/p/chromium/issues/list,
where to find it?
That's an internal bug tracker, mostly for really old bugs.
Since we don't support win2k, that comment can probably be deleted.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Techcrunch What is a browser
This video is great. http://www.techcrunch.com/2009/06/17/yeah-what-is-a-browser-anyway/ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Techcrunch What is a browser
It made me cry :( it's like jay-walking, but more personal. 2009/6/17 Mike Belshe mbel...@google.com This video is great. http://www.techcrunch.com/2009/06/17/yeah-what-is-a-browser-anyway/ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
That comment was removed 4 weeks ago in revision 16206. In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Huan Ren wrote: Are you looking at the latest version of file tab_restore_uitest.cc? That comment was long gone. Huan On Wed, Jun 17, 2009 at 9:37 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: That's an internal bug tracker, mostly for really old bugs. Since we don't support win2k, that comment can probably be deleted. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: does chromium care about appcache manifests?
Chromium has no behavior whatsoever yet... the feature is utterly unimplemented thus far... but it will have identical behavior to safari, iphone, andriod by virtue of the same code base performing those behaviors... thats the plan at least, and I'm working on the code now. Gears (i'm partly guilty of that) users have similar issues with the gears system. Developing for 'offline' butts heads ( verb noun, not buttheads :O) with standard operating procedures for web development (put new stuff on server, hit reload, repeat as needed). I can think of at least some things that may help? * if the user-agent had a debugging level feature (in some debug/tools menu) to blow away the current appcache. would that help? Or perhaps a UI to show appcaches and a option to 'remove' one? The former could be provided without any spec changes and agreement amoungst browser vendors. We're not far enough along with this feature in chrome to be too concerned with UI yet... but I'll write this down in my design doc. On Wed, Jun 17, 2009 at 5:14 AM, Mark Janssenpraseo...@gmail.com wrote: Hi Michael, It's been some time (I rarely read this address), but why I was asking is because I'm testing a web application for iPhone/Android. Safari does care about appcache manifest, but does so a bit too well: it's nearly impossible get it to reload a new version from the server (thus ignoring the appcache manifest). As you can imagine this is quite cumbersome during development, so I was wondering of Chromium has the same behaviour. Regards, Mark On Mon, Jun 1, 2009 at 11:54 PM, Michael Nordmanmicha...@google.com wrote: Hi, I'm assuming you and praseodym in #chromium IRC are one and the same... if not, sorry for the spam. Yes, we do. At this point, there is no support for the feature in chromium, but we're working towards that. The implementation in webcore has to be refactored so that chromium can use it too... or chromium has to implement this feature outside of webcore... we're pursuing the first option at this time. https://bugs.webkit.org/show_bug.cgi?id=25436 Why do you ask? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
I'm trying to find out if it's possible to patch chrome to run on my old windows 2000 machine. When I debugging chrome 2.0.172.28, the Browser::CreateTabContentsForURL sometimes will raise exception. According to those comments in the source files, the TabUI indeed has some incompatibility on windows 2000. What's it? Can it be overcomed? The internal bug reports may be helpful. Dan Kegel wrote: On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Help with linux build error
This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: Linking /b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/symupload Compiling /b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/obj/net/tools/fetch/fetch_client.o Compiling /b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/obj/third_party/libxml/xmllint.o Compiling /b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/obj/breakpad/linux/minidump-2-core.o sed: can't read /b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/chrome.breakpad: No such file or directory scons: *** [/b/slave/google_chrome_rel_linux/build/src/sconsbuild/Release/chrome.breakpad] Error 2 scons: building terminated because of errors. program finished with exit code 2 Any ideas on how to fix this? --Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Help with linux build error
On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: I think this is mmoss, or maybe thestig. It's a symbol dumping process which is failing. I think there's a bug in the script, -nt doesn't work when the output doesn't exist. I'll fix it now. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Help with linux build error
On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: I think this is mmoss, or maybe thestig. It's a symbol dumping process which is failing. I think there's a bug in the script, -nt doesn't work when the output doesn't exist. I'll fix it now. I may, or may not have, fixed this in r18659. I'll wait for the builder to cycle round. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Help with linux build error
BTW, the mac script has the same thing (I added the -nt on Mark's suggestion), but maybe on mac it behaves differently so it's OK. Do we have a mac builder that's running dump_app_syms? Michael On Wed, Jun 17, 2009 at 2:59 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: I think this is mmoss, or maybe thestig. It's a symbol dumping process which is failing. I think there's a bug in the script, -nt doesn't work when the output doesn't exist. I'll fix it now. I may, or may not have, fixed this in r18659. I'll wait for the builder to cycle round. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Help with linux build error
Thanks, for the fix Adam. On Wed, Jun 17, 2009 at 15:04, Michael Moss mm...@chromium.org wrote: BTW, the mac script has the same thing (I added the -nt on Mark's suggestion), but maybe on mac it behaves differently so it's OK. Do we have a mac builder that's running dump_app_syms? I'd guess only the official release builder is running that, and it succeeded yesterday. We don't have a continuous Google Chrome builder on Mac, yet. Michael On Wed, Jun 17, 2009 at 2:59 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: I think this is mmoss, or maybe thestig. It's a symbol dumping process which is failing. I think there's a bug in the script, -nt doesn't work when the output doesn't exist. I'll fix it now. I may, or may not have, fixed this in r18659. I'll wait for the builder to cycle round. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Developing Chromium Mac? Try using it as your primary browser!
Sometimes, it's hard to work on a product and actually use it at the same time. The rapid stop/start cycles aren't exactly conducive to keeping long-lived activities like your e-mail open. I work on Chromium, but I surf in Camino, or Safari, or Firefox. Does that sound familiar? I've worked on other browsers in the past, and I've had the same problems with them too. Fortunately, Chromium supports multiple user profiles, so it actually is possible to leave a long-lived process around for your daily surfing hooked up to one profile, while you're developing in another. For the past couple of days, I've been trying this out, and I think it would be a good idea if everyone else who's not already doing so gave it a try too. Here's what I'm doing: I'm starting my long-lived Chrome (in my case, an official Google Chrome dev-channel build - ideally it shouldn't be the executable/bundle you're actively working on) with an alternate profile by telling my shell to do this: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir=~/Library/Application\ Support/ChromeToo chrome.out leaving the main profile at ~/Library/Application Support/Chrome free for development. (You could easily do it the other way around, but since I'm more likely to want to start the development Chromium more frequently, I figure I'll save myself some keystrokes.) So far, the biggest drawback has been no YouTube, but I bet you knew that already. I think it would be a great idea for everyone developing for the Mac to join me in eating our dogfood. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chromium Mac? Try using it as your primary browser!
On Wed, Jun 17, 2009 at 3:10 PM, Mark Mentovai m...@chromium.org wrote: Here's what I'm doing: I'm starting my long-lived Chrome (in my case, an official Google Chrome dev-channel build - ideally it shouldn't be the executable/bundle you're actively working on) with an alternate profile by telling my shell to do this: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir=~/Library/Application\ Support/ChromeToo chrome.out leaving the main profile at ~/Library/Application Support/Chrome free for development. (You could easily do it the other way around, but since I'm more likely to want to start the development Chromium more frequently, I figure I'll save myself some keystrokes.) This is exactly how I've run Chrome as my main Windows browser for a year and a half now. Recommended! I think it would be a great idea for everyone developing for the Mac to join me in eating our dogfood. When we pushed us Windows folks to do this (long ago now...) it really helped close the feedback loop. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Help with linux build error
On closer inspection, it looks like it's a bash vs. dash issue. Our Linux official builder (gHardy) is using bash (probably the Mac is too), so the original syntax works. This experimental bot (regular Hardy) is using dash, so '-nt' fails when the file doesn't exist. Adam's fix should make both happy. Michael On Wed, Jun 17, 2009 at 3:12 PM, Mark Larson (Google)m...@chromium.org wrote: Thanks, for the fix Adam. On Wed, Jun 17, 2009 at 15:04, Michael Moss mm...@chromium.org wrote: BTW, the mac script has the same thing (I added the -nt on Mark's suggestion), but maybe on mac it behaves differently so it's OK. Do we have a mac builder that's running dump_app_syms? I'd guess only the official release builder is running that, and it succeeded yesterday. We don't have a continuous Google Chrome builder on Mac, yet. Michael On Wed, Jun 17, 2009 at 2:59 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60 The linux compile fails here: I think this is mmoss, or maybe thestig. It's a symbol dumping process which is failing. I think there's a bug in the script, -nt doesn't work when the output doesn't exist. I'll fix it now. I may, or may not have, fixed this in r18659. I'll wait for the builder to cycle round. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
I filed this bug with this comment:-- TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled it. This is not reproducible outside the buildbot environment. The problem seems to be that chrome cannot access a font. I was not able to determine what the font was. --- Later on I fixed it, but forgot to remove the comment. This bug was only for debug mode, it should not matter for release mode. Nicolas On Wed, Jun 17, 2009 at 2:31 PM, pi zhu.she...@gmail.com wrote: I'm trying to find out if it's possible to patch chrome to run on my old windows 2000 machine. When I debugging chrome 2.0.172.28, the Browser::CreateTabContentsForURL sometimes will raise exception. According to those comments in the source files, the TabUI indeed has some incompatibility on windows 2000. What's it? Can it be overcomed? The internal bug reports may be helpful. Dan Kegel wrote: On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Changing the language of the spellchecker?
Just a guess, but perhaps when you change languages a new Spellchecker object with the new language is constructed. I would expect the language-picking options haven't yet been implemented. You can also switch languages via the right-click menu on a text area, but that may also be unimplemented. It might be worth implementing those as a prereq for your current project. :) On Wed, Jun 17, 2009 at 3:54 PM, pwickspwick...@gmail.com wrote: I'm working on porting the os x spellchecker to chromium and I've run into a question. I'm trying to figure out how the language of the spellchecker is change. The only place that I can see where it is ever specified is in the constructor to Spellchecker. I don't see any other functions/methods that deal with language selection, just with querying the available languages. I was going to try and trace this through in the debugger, but the button on the options pane to change the language is greyed out. Anybody know anything about how this works or can point me in the right direction? (Sid, is this what you were talking about when you mentioned that there was something unimplemented?) Thanks, --Paul Wicks --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Changing the language of the spellchecker?
The canonical example you should be following here is WebKit on OSX. Grepping the sourcecode for NSSpellChecker shows usage in WebKit/mac/WebCoreSupport/WebEditorClient.mm and WebKit/mac/WebView/WebHTMLView.mm WebKit/mac/WebCoreSupport/WebEditorClient.mm:638,664 : NSRange range = [[NSSpellChecker sharedSpellChecker] checkSpellingOfString:textString startingAt:0 *language:nil* wrap:NO inSpellDocumentWithTag:spellCheckerDocumentTag() wordCount:NULL]; Hope that helps. Best regards, Jeremy On Wed, Jun 17, 2009 at 3:54 PM, pwicks pwick...@gmail.com wrote: I'm working on porting the os x spellchecker to chromium and I've run into a question. I'm trying to figure out how the language of the spellchecker is change. The only place that I can see where it is ever specified is in the constructor to Spellchecker. I don't see any other functions/methods that deal with language selection, just with querying the available languages. I was going to try and trace this through in the debugger, but the button on the options pane to change the language is greyed out. Anybody know anything about how this works or can point me in the right direction? (Sid, is this what you were talking about when you mentioned that there was something unimplemented?) Thanks, --Paul Wicks --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Changing the language of the spellchecker?
Yes, Evan is right. So, when you change a spellcheck language in the Options menu (languages_page_view.cc), it changes a pref member (prefs::kSpellCheckDictionary) value. This change is caught by the Profile (ProfileImpl::Observe in profile.cc), which (re)initializes the spellchecker with the new language. The pref member can also be changed from the right-click context menu, as Evan pointed out (see RenderViewContextMenu::ExecuteItemCommand() in render_view_context_menu.cc). So it seems implementing languages Options menu and context menu items items for spellchecker might make this whole thing work automatically. -Sid On Jun 17, 4:02 pm, Evan Martin e...@chromium.org wrote: Just a guess, but perhaps when you change languages a new Spellchecker object with the new language is constructed. I would expect the language-picking options haven't yet been implemented. You can also switch languages via the right-click menu on a text area, but that may also be unimplemented. It might be worth implementing those as a prereq for your current project. :) On Wed, Jun 17, 2009 at 3:54 PM, pwickspwick...@gmail.com wrote: I'm working on porting the os x spellchecker to chromium and I've run into a question. I'm trying to figure out how the language of the spellchecker is change. The only place that I can see where it is ever specified is in the constructor to Spellchecker. I don't see any other functions/methods that deal with language selection, just with querying the available languages. I was going to try and trace this through in the debugger, but the button on the options pane to change the language is greyed out. Anybody know anything about how this works or can point me in the right direction? (Sid, is this what you were talking about when you mentioned that there was something unimplemented?) Thanks, --Paul Wicks --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] New group for extension developers: chromium-extensions
Hi all, As we're seeing an increasing number of people developing extensions (awesome!), we're creating a new and shiny discussion group for extension developers. If you're interested in developing extensions, we invite you to join us at: http://groups.google.com/group/chromium-extensions/subscribe Going forward, chromium-extensions will be your one-stop shop for extension development news, feedback and questions. We will cc chromium-extensions on any extension-related emails sent to chromium-dev. We'll post API design docs to both chromium-extensions and chromium-dev since their implementation affects Chrome's C++ code. Cheers, -The extensions team --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] IMPORTANT: repackage your extensions
Hi all, **We're excited to see many people are experimenting with the upcoming extension features of Chrome in the dev channel. We're getting a lot of great feedback and are working hard to bring extensions to the stable channel as quickly as possible. As part of the latest dev channel release, we've had to make a breaking change to the crx format. This change adds signatures to our package format, which are necessary to enable automatic updates. Unfortunately, this means that any existing extensions will stop working, and will have to be repackaged. - *If you've developed an extension,* you can learn how to repackage your extensions for Chrome v 3.0.189.0 in *the packaging dochttp://dev.chromium.org/developers/design-documents/extensions/packaging * on our developer site. Note that your extension ID will now be your public key, so you'll have to change any code that uses that. - *If you're using an extension someone else has developed, *you will have to reinstall it once the developer has repackaged it (as described above). We've already updated our sample extensionshttp://dev.chromium.org/developers/design-documents/extensions/samples . Even though the whole point of the dev channel is to make our APIs available early while they're still changing, we don't make these changes lightly. Once we push the extension system to the stable channel, breaking changes should be very rare (we'd like to say non-existent, but we don't want to jinx ourselves). Let us know if you have any questions or run into any problems. Cheers, -Nick PS: I'll be cc'ing chromium-dev and discuss for a few days, until people have had the time to subscribe to chromium-extensionshttp://groups.google.com/group/chromium-extensions. We also posted this to the chromium blog http://blog.chromium.org, which I recommend subscribing to if you haven't already. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Changing the language of the spellchecker?
Oh, ok, so when the language is changed, a new spellchecker object is created. That's what I thought might be happening. Thanks, -Paul Wicks On Wed, Jun 17, 2009 at 5:14 PM, sidchat sidc...@chromium.org wrote: Yes, Evan is right. So, when you change a spellcheck language in the Options menu (languages_page_view.cc), it changes a pref member (prefs::kSpellCheckDictionary) value. This change is caught by the Profile (ProfileImpl::Observe in profile.cc), which (re)initializes the spellchecker with the new language. The pref member can also be changed from the right-click context menu, as Evan pointed out (see RenderViewContextMenu::ExecuteItemCommand() in render_view_context_menu.cc). So it seems implementing languages Options menu and context menu items items for spellchecker might make this whole thing work automatically. -Sid On Jun 17, 4:02 pm, Evan Martin e...@chromium.org wrote: Just a guess, but perhaps when you change languages a new Spellchecker object with the new language is constructed. I would expect the language-picking options haven't yet been implemented. You can also switch languages via the right-click menu on a text area, but that may also be unimplemented. It might be worth implementing those as a prereq for your current project. :) On Wed, Jun 17, 2009 at 3:54 PM, pwickspwick...@gmail.com wrote: I'm working on porting the os x spellchecker to chromium and I've run into a question. I'm trying to figure out how the language of the spellchecker is change. The only place that I can see where it is ever specified is in the constructor to Spellchecker. I don't see any other functions/methods that deal with language selection, just with querying the available languages. I was going to try and trace this through in the debugger, but the button on the options pane to change the language is greyed out. Anybody know anything about how this works or can point me in the right direction? (Sid, is this what you were talking about when you mentioned that there was something unimplemented?) Thanks, --Paul Wicks --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] [chromium-dev]RE: why some chrome's tests fail?
hi,Evan You can comment it out and just run gclient sync again. Not sure why you'd want to pass the --revision flag. I just wanna use one fixed revision, don't wanna update it everyday. Take that into consideration, that's easy to fix problems. Some data used by tests is not in the public tree, as many (like performance tests) are attempting to test against real web sites and we can't republish their content. while, that must be a bug of chrome's test. I copied the url: file:///F:/chrometrunk/src/data/tab_switching/kannada.chakradeo.net/index.html from the url bar of chrome's tab_switching_test.exe, and chrome doesn't find that index.html. So I asked. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] why some chrome's tests fail?
hi, pawel. It is a bit worrying to me to read most of the tests fail. Do you encounter more failures? Yes, about 40% of my chrome's tests(I mean the .exe of tests) fail. And my revision is r17306. I am wondering why, -_-! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] why some chrome's tests fail?
I get a new question here: I've checked most of chrome's tests, and haven't find a RUN_ALL_TEST() which I think is necessary for GTest. simply, the printing_unittests project. why? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] changing chrome_exe to chrome, converting chrome.exe to gyp
Heads up, again, dept.:
In the next in an ongoing series of attempts to convert chrome.exe to gyp,
I'm going to (try to) land two changes now that you should be aware of:
1) convert the 'app' target in the chrome.gyp file to being named 'chrome'.2)
actually convert the 'chrome_exe' project to using a gyp-generated
chrome.vcproj file, instead of the checked-in one.
When the first change lands, Mac developers will need to look for the new
'chrome' target instead of 'app', and Linux developers who have been typing
'hammer app' (or 'make app' if you're using the Makefile generator) will
need to type 'hammer chrome' ('make chrome'). The default behaviors of
building everything should be unaffected.
When the second change lands, Visual Studio users will need to use the
'chrome' project, instead of the former 'chrome_exe' project. NOTE:
because the underlying .vcproj file will be completely different, any local
settings you've configured into the old 'chrome_exe' project will NOT be
transferred to the new 'chrome' project. You'll have to make a note of any
custom settings before updating and re-apply them to the new 'chrome'
project.
There's always the chance that one or both of these changes will have to be
reverted if unintended side effects pop up. I'll send out confirming email
with the final state of things.
--SK
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
