Look at how the current gyp hook works. It looks for changes to .gyp
files and only runs if a .gyp (and maybe gypi?) file has changed.
You can find what header it generates by opening the grd file and
parsing the XML (the XML lists the output files). You'll need to
build the base directory (e.g
Here's a crappy work around:
Add a gclient hook that checks for grd file changes. When a grd file
changes, force delete the header it would generate. I'm pretty sure
this would prevent bad builds from IncrediBuild.
Alternately, maybe we can make a reduced test case and file a bug
against Incred
I think that this workaround may be worth it. I'm not familiar with the
IncrediBuild, but I can help making the hook (and we can run it only on
Windows).
How do I make a hook know which grd files changed? And also know which
headers it generates? Alternatively, maybe this Windows-only hook would ju
On Thu, Jul 23, 2009 at 5:30 PM, Tony Chang wrote:
>
> Here's a crappy work around:
> Add a gclient hook that checks for grd file changes. When a grd file
> changes, force delete the header it would generate. I'm pretty sure
> this would prevent bad builds from IncrediBuild.
>
> Alternately, ma
On Thu, Jul 23, 2009 at 5:21 PM, Ben Laurie wrote:
> On Thu, Jul 23, 2009 at 4:54 PM, Evan Martin wrote:
> > On Thu, Jul 23, 2009 at 4:50 PM, Ben Laurie wrote:
> >>
> >> On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisher
> wrote:
> >>> On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie wrote:
>
>
On Thu, Jul 23, 2009 at 4:54 PM, Evan Martin wrote:
> On Thu, Jul 23, 2009 at 4:50 PM, Ben Laurie wrote:
>>
>> On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisher wrote:
>>> On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie wrote:
On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang wrote:
> Ben,
>>
On Thu, Jul 23, 2009 at 4:50 PM, Ben Laurie wrote:
>
> On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisher wrote:
>> On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie wrote:
>>>
>>> On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang wrote:
>>> > Ben,
>>> >
>>> > I believe the GCC warning you want is -Wreturn-typ
On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisher wrote:
> On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie wrote:
>>
>> On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang wrote:
>> > Ben,
>> >
>> > I believe the GCC warning you want is -Wreturn-type, which is enabled
>> > if we specify -Wall:
>> >
>> > http:
Is it possible to force it to rebuild some files, or... I don't know, do you
see some real way to fix this problem?
On Thu, Jul 23, 2009 at 16:41, Tony Chang wrote:
> To elaborate on Peter's comment. IncrediBuild (which the buildbots
> use) get confused by changes to our grd files. Our grd fil
On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie wrote:
>
> On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang wrote:
> > Ben,
> >
> > I believe the GCC warning you want is -Wreturn-type, which is enabled
> > if we specify -Wall:
> >
> http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warni
On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang wrote:
> Ben,
>
> I believe the GCC warning you want is -Wreturn-type, which is enabled
> if we specify -Wall:
> http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warning-Options
>
> Are we not compiling with -Wall?
Apparently not, whi
To elaborate on Peter's comment. IncrediBuild (which the buildbots
use) get confused by changes to our grd files. Our grd files generate
headers, which should then cause lots of cc files to get rebuilt.
Visual Studio seems to always get this right, but IncrediBuild gets
this wrong and cc files d
On Thu, Jul 23, 2009 at 4:31 PM, Paweł Hajdan Jr.
wrote:
> Some of the flaky failures are caused by resource bundle issues. If you are
> familiar with the build process, or the resource bundle, please take a look.
It looks like something needed a manual clobber and didn't get it.
PK
--~--~
Some of the flaky failures are caused by resource bundle issues. If you are
familiar with the build process, or the resource bundle, please take a look.
I'm pasting relevant parts of the logs:
C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(227):
error: Value of: server_->WaitF
Ben,
I believe the GCC warning you want is -Wreturn-type, which is enabled
if we specify -Wall:
http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warning-Options
Are we not compiling with -Wall?
Wan-Teh
--~--~-~--~~~---~--~~
Chromium Developers ma
On Thu, Jul 23, 2009 at 4:17 PM, Mike Mammarella wrote:
> gcc/g++ have __attribute__((warn_unused_result)) that you can specify
> on a per-function basis:
>
> http://www.ohse.de/uwe/articles/gcc-attributes.html#func-warn_unused_result
>
> Or do you mean warnings when a function is supposed to retu
gcc/g++ have __attribute__((warn_unused_result)) that you can specify
on a per-function basis:
http://www.ohse.de/uwe/articles/gcc-attributes.html#func-warn_unused_result
Or do you mean warnings when a function is supposed to return a value
but does not have a return statement at the end?
--Mik
I just fixed a bug that wouldn't have happened at all if missing
return values were flagged ... is there a way to turn on compiler
warnings (building on Linux using make)? Is there some reason they're
not on by default?
--~--~-~--~~~---~--~~
Chromium Developers mai
On Thu, Jul 23, 2009 at 10:55 PM, Dan Kegel wrote:
> If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message.
>
> tools/valgrind/chrome_tests.sh now uses the --show-possible option to
> valgrind. This option isn't in standard valgrind, so bad things will
> happen if you haven
If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message.
tools/valgrind/chrome_tests.sh now uses the --show-possible option to
valgrind. This option isn't in standard valgrind, so bad things will
happen if you haven't run tools/valgrind/build-valgrind-for-chrome.sh
to instal
Please have any strings you want in the next release in by Friday evening.
Kind Regards,
Anthony Laforge
Technical Program Manager
Mountain View, CA
External Phone: 1-650-214-4055
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
This kind of error tends to occur if gyp regenerates the project while you
are in visual studio.Very often if you close and reopen the solution the
problem will go away.
Unfortunately hitting yes to project/sln reload does not seem to be
equivalent in all cases to a full close and reopen.
-BradN
Have you 'gclient synced' since building Chromiumever? If so, have you
tried blowing away the Debug/Release directory and re-building? The
dependency tracking is not perfect.
On Wed, Jul 22, 2009 at 5:21 PM, Dan Duong wrote:
>
> Hi All,
>
> My name is Dan here goes my first post to chromiu
Hi All,
My name is Dan here goes my first post to chromium-dev! Anyone else
seeing problems building the mini_installer vcproj?
I get the following error:
5>fatal error RC1110: could not open .\$(IntDir)
\mini_installer_exe_version.rc
I'm guessing $(IntDir) is an absolute path and its trying to
(cc'ing chromium-discuss, bcc'ing chromium-dev)
It is? How do you specify keywords in Chrome's Bookmarks editor?
-- Dirk
On Wed, Jul 22, 2009 at 12:49 PM, Peter Kasting wrote:
> On Wed, Jul 22, 2009 at 12:46 PM, Igor Gatis wrote:
>>
>> (please forgive me if this not the right list)
>
> It's no
Hi,
I'm trying to figure out a way to get the rendered contents of a page
(such as amazon.com) to dump to an image file (PNG, bitmap or
similar), and I also want to be able to identify what objects are
being rendered (flash etc.). What would be the best way to approach
this?
Thanks for your help
Thank you Brian and Paul for your comments and insights. Yes, the plan
is to expand to multi-spellcheck simultaneously when the user types in
some other language other than the default one, and avoid changing on
the fly too often.
Paul, I have this feature on hold right now to discuss more issues
On Thu, Jul 23, 2009 at 9:01 AM, Nicolas Sylvain wrote:
> On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin wrote:
>> On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvain
>> wrote:
>> > gclient has nothing to do with this case. "svn update src/" was trying to
>> > add a directory called "src/bleh", but "
On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin wrote:
>
> On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvain
> wrote:
> > gclient has nothing to do with this case. "svn update src/" was trying to
> > add a directory called "src/bleh", but "src/bleh" already existed, so
> "svn
> > update" failed.
>
>
On Thu, Jul 23, 2009 at 9:15 AM, Thomas Van Lenten wrote:
> The other thing to remember is the buildbot scripts and a bunch of build
> scripts on all platforms are full of assumptions about the relationships
> between projects and the tree. :(
Well, yes. I didn't say it would be easy. I don't
The other thing to remember is the buildbot scripts and a bunch of build
scripts on all platforms are full of assumptions about the relationships
between projects and the tree. :(
TVL
On Thu, Jul 23, 2009 at 12:11 PM, Dan Kegel wrote:
> On Thu, Jul 23, 2009 at 9:07 AM, Thomas Van Lenten
> wrot
On Thu, Jul 23, 2009 at 9:07 AM, Thomas Van Lenten wrote:
>> Here's my christmas wish: I'd like gyp and chrome to
>> support cross-compilation, so that I could (on my Linux box) kick
>> off distcc-accelerated builds for all three platforms, each one
>> going into a separate objdir.
>> It's not as
On Thu, Jul 23, 2009 at 2:46 AM, Dean McNamee wrote:
> Any idea on how much this increase the size of chrome.dll?
Not yet - I'll let you know as soon as we're ready (some symbols are still
not being referenced, so the count probably isn't accurate yet).
-Greg.
--~--~-~--~~
On Thu, Jul 23, 2009 at 12:00 PM, Dan Kegel wrote:
>
> On Thu, Jul 23, 2009 at 2:28 PM, Darin Fisher wrote:
> >>> An objdir-ish solution would make sense, except the native build
> >>> systems we use don't really work in terms of objdirs, so we'd just
> >>> wind up generating a parallel directory
On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin wrote:
> On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvain
> wrote:
> > gclient has nothing to do with this case. "svn update src/" was trying to
> > add a directory called "src/bleh", but "src/bleh" already existed, so
> "svn
> > update" failed.
>
> So
On Thu, Jul 23, 2009 at 2:28 PM, Darin Fisher wrote:
>>> An objdir-ish solution would make sense, except the native build
>>> systems we use don't really work in terms of objdirs, so we'd just
>>> wind up generating a parallel directory structure with nothing but
>>> xcode projects, Makefiles, and
On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvain wrote:
> gclient has nothing to do with this case. "svn update src/" was trying to
> add a directory called "src/bleh", but "src/bleh" already existed, so "svn
> update" failed.
Sorry to back-seat drive, but can't you do something like
"svn status
On Wed, Jul 22, 2009 at 9:15 PM, Mark Larson (Google) wrote:
>
>
> On Wed, Jul 22, 2009 at 20:27, Dan Kegel wrote:
>
>>
>> Stop me if you've heard this one before.
>>
>> Today, a new directory was added to the source tree, and shortly
>> thereafter was reverted.
>> Should have been no problem, bu
On Thu, Jul 23, 2009 at 7:26 AM, Darin Fisher wrote:
> On Wed, Jul 22, 2009 at 9:56 PM, Mark Mentovai wrote:
>
>>
>> Dan Kegel wrote:
>> > No. Generating files is the point of gyp. Nothing says they have to
>> > be in the source tree.
>>
>> Out of all of the proposals out there, the only ones
On Wed, Jul 22, 2009 at 9:56 PM, Mark Mentovai wrote:
>
> Dan Kegel wrote:
> > No. Generating files is the point of gyp. Nothing says they have to
> > be in the source tree.
>
> Out of all of the proposals out there, the only ones that make any
> sense to my software-developin' mind are the one
On Thu, Jul 23, 2009 at 4:56 AM, Mark Mentovai wrote:
> An objdir-ish solution would make sense, except the native build
> systems we use don't really work in terms of objdirs, so we'd just
> wind up generating a parallel directory structure with nothing but
> xcode projects, Makefiles, and other
Just to be complete, linux can have the same issue, and I'd expect Windows
also to be able too. This is one class of things the try server doesn't
catch because it is building debug/unoptimized.
TVL
On Wed, Jul 22, 2009 at 10:09 PM, Andrew Scherkus wrote:
> On Wed, Jul 22, 2009 at 7:07 PM, Dan
Any idea on how much this increase the size of chrome.dll?
On Wed, Jul 22, 2009 at 9:51 PM, Nicolas Sylvain wrote:
>
>
> On Wed, Jul 22, 2009 at 11:47 AM, Greg Spencer wrote:
>>
>>
>> On Wed, Jul 22, 2009 at 11:27 AM, Nicolas Sylvain
>> wrote:
"src/third_party/nixysa/files":
>>>
>>>
43 matches
Mail list logo
