[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-16 Thread Elliot Glaysher (Chromium)
Happily, Howard Chu recently posted a partial example of how to do the latter, http://groups.google.com/group/mozilla.dev.tech.crypto/msg/af4b5b6c71b70702 I think the next step might be for me to write an app demonstrating how to handle 500 simultanous ssl connections using nss and

[chromium-dev] Current line number from within a CALLBACK_FUNC_DECL?

2008-09-26 Thread Elliot Glaysher (Chromium)
[Resending and forwarding since google groups doesn't like my google.com address:] Feng (or another v8 expert): Is there any way to get the current line number of an executing javascript from within a C++ custom callback? With JSC, you can get this information from the ExecState object with

[chromium-dev] Re: layout test result scores don't match up?

2008-12-12 Thread Elliot Glaysher (Chromium)
I added support for making score.txt a few weeks ago. score.txt is generated by passing a file stream to the same function that outputs to the console instead of passing in stdout. Everything should be the same unless the printing code has side effects. -- Elliot On Fri, Dec 12, 2008 at 9:26

[chromium-dev] cpplint.py open sourced!

2009-01-13 Thread Elliot Glaysher (Chromium)
Background: For the last couple of months, there have been requests from external contributors for a style linting tool. I've just finish cleaning Google's cpplint.py up for public release. cpplint.py takes file names as input and returns file/line number pairs with error messages about style

Fwd: [chromium-dev] Re: Why do you use SCONS ?

2009-01-16 Thread Elliot Glaysher (Chromium)
Usually Open Source projects use CMake Construction Tool Kit. Off the top of my head, KDE 4.x is the only project I know of that uses CMake, (which is different from the old unix make). From your first email: Usually, Open Source projects use Make. Very few open source projects use unix make

[chromium-dev] Why do you use SCONS ?

2009-01-16 Thread Elliot Glaysher (Chromium)
So, how do SCons improve the dependency checking and the autoconfiguration? This is a totally different issue. When I'm talking about dependency checking, I'm talking about dependencies between files in the source. So let's say I change a header file, and three .cc files #include it. SCons

[chromium-dev] Re: linux: the views situation

2009-01-29 Thread Elliot Glaysher (Chromium)
On Thu, Jan 29, 2009 at 12:10 PM, Paweł Prażak kojot...@gmail.com wrote: I'd really like to help you in some way, (unfortunately I don't have years of experience in C++ :/ ) and I'd like to try play chromium code, and try to make a Qt based test-shell, I know it's probably too difficult for

[chromium-dev] Re: Thoughts regarding exposing --single-process, in-process-plugins in release builds

2009-03-02 Thread Elliot Glaysher (Chromium)
+1. We absolutely should do this. -- Elliot On Mon, Mar 2, 2009 at 4:16 PM, John Abd-El-Malek j...@chromium.org wrote: I was looking at the second top crasher in 2.0.166.1, and it turned out that these users are running with --in-process-plugins.  This turns off the sandbox and runs plugins

[chromium-dev] Re: Changing default compile for Chrome Linux build?

2009-04-02 Thread Elliot Glaysher (Chromium)
I have CC=distcc gcc and CXX=distcc g++ in my bashrc file, so yes. -- Elliot On Wed, Apr 1, 2009 at 11:59 PM, QAH qah...@gmail.com wrote: Hello everyone! I am building the source code of chrome for linux, and I know that it uses gcc and g++. Since chrome is such a big build though and I

[chromium-dev] Re: WebContents is dead, long live TabContents!

2009-04-24 Thread Elliot Glaysher (Chromium)
Congrts, Brett! -- Erg. On Fri, Apr 24, 2009 at 9:15 AM, Erik Kay erik...@chromium.org wrote: woot! On Thu, Apr 23, 2009 at 11:02 PM, Brett Wilson bre...@chromium.org wrote: I just moved the remaining methods from WebContents to TabContents. I kept the methods and data members the same,

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-01 Thread Elliot Glaysher (Chromium)
On Fri, May 1, 2009 at 1:07 PM, Adam Barth aba...@chromium.org wrote: Wow, that's pretty deep magic. And you can use it like:  HANDLE_EINTR(close(fd)); Isn't it disaster if you say: HANDLE_EINTR(close(ret)); Yes. Regretfully, C doesn't have hygienic macros. It probably would be a good

[chromium-dev] Re: DLLs missing and DCHECKs in recent builds

2009-06-04 Thread Elliot Glaysher (Chromium)
I had to build under Windows for the first time in a month. I too can confirm this. -- Elliot On Wed, Jun 3, 2009 at 8:29 PM, Mohamed Mansour m...@chromium.org wrote: Yup, I can confirm. I had to manually build theme_dll or it hits crazy dchecks across the src. -- Mohamed Mansour On Wed,

[chromium-dev] Re: New views::Menu API

2009-06-05 Thread Elliot Glaysher (Chromium)
I wasn't happy doing a direct port of the old Menu to GTK. This sounds a lot better. -- Elliot On Fri, Jun 5, 2009 at 12:34 AM, Ben Goodger (Google) b...@chromium.org wrote: As part of the TOOLKIT_VIEWS work some of the long time deficiencies of the existing views::Menu API have come to a

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread Elliot Glaysher (Chromium)
Works for me. Synced yesterday. MSVS2005. -- Elliot On Fri, Jun 5, 2009 at 3:58 PM, nakro yoav.zilberb...@gmail.com wrote: for chrome_dll.vcproj : tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined in libcmt.lib(malloc.obj) and many others related to libcmt .

[chromium-dev] Re: Memory usage in chrome

2009-06-21 Thread Elliot Glaysher (Chromium)
On Sun, Jun 21, 2009 at 12:37 AM, n179911n179...@gmail.com wrote: There is a test which compares memory usage among rendering engines http://dotnetperls.com/chrome-memory From the site, it shows the maximum memory usage of Chrome is more than Safari is 2 times. From TFA: Google Chrome

[chromium-dev] Re: Memory usage in chrome

2009-06-24 Thread Elliot Glaysher (Chromium)
Could we stat at memory-model=hight and then change our memory model mid-flight if there are any large, non-chrome, memory hungry processes? -- Elliot On Wed, Jun 24, 2009 at 9:39 AM, Ian Fettei...@chromium.org wrote: +1. Most people are not doing compiles, we're trying to say that people live

[chromium-dev] Re: Fwd: [webkit-dev] Important change for ports regarding FocusController

2009-07-01 Thread Elliot Glaysher (Chromium)
Will this let us solve http://crbug.com/1674 ? -- Elliot On Wed, Jul 1, 2009 at 11:53 AM, Peter Kastingpkast...@google.com wrote: (Wanted to make sure the right people noticed this) -- Forwarded message -- From: David Hyatt hy...@apple.com Date: Jul 1, 2009 10:04 AM

[chromium-dev] Re: Updating Rietveld by replying to codereview emails

2009-07-06 Thread Elliot Glaysher (Chromium)
This is the best news I've heard in the last week. Thank you, Thank you, Thank you. -- Elliot On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malekj...@chromium.org wrote: Just a heads up that you can now reply to code review emails and your reply will show up on Rietveld.

[chromium-dev] Re: applying Rietveld issue patches from the command-line

2009-07-07 Thread Elliot Glaysher (Chromium)
If you are using git-cl: git cl patch patch URL or rietveld issue id On Tue, Jul 7, 2009 at 4:46 PM, Marshall Greenblattmagreenbl...@gmail.com wrote: Hi All, What is the best way to apply Rietveld issue patches from the command-line? I've found WebKit's nifty svn-apply script that does

[chromium-dev] Re: Linking with custom fontconfig

2009-07-08 Thread Elliot Glaysher (Chromium)
On Wed, Jul 8, 2009 at 4:22 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: It says no symbols. :-/ Do you have an idea how can I get them? When you're building fontconfig, you're building it with no optimization and -g for debugging symbols, right? -- Elliot

[chromium-dev] Clobber time?

2009-07-09 Thread Elliot Glaysher (Chromium)
I am landing a GRD change. You may need to clobber. -- Elliot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] Re: Idea for next valgrind/purify fixit week: just delete the suppressions and watch the tree go red

2009-08-06 Thread Elliot Glaysher (Chromium)
+1 to this idea. Close the tree, only fixes can get in. -- Elliot On Thu, Aug 6, 2009 at 4:09 PM, Dan Kegeld...@kegel.com wrote: Despite having had several valgrind/purify fixit weeks, our bug tracker is still full of 'em. It might be a mistake to expect people to get exicited about

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Elliot Glaysher (Chromium)
On Fri, Aug 21, 2009 at 10:25 AM, JT Oldsjto...@xnet5.com wrote: It's a shame this is what is left on the table, but hooray for git-svn! FYI: don't use git-svn. We have a dedicated git mirror that you can clone and fetch from. Much, much faster. http://code.google.com/p/chromium/wiki/UsingGit

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Elliot Glaysher (Chromium)
See what I do in GtkThemeProvider::LoadThemeBitmap: SkBitmap* bitmap = new SkBitmap; bitmap-setConfig(SkBitmap::kARGB__Config, kToolbarImageWidth, kToolbarImageHeight); bitmap-allocPixels(); bitmap-eraseRGB(color-red 8, color-green 8, color-blue 8);

[chromium-dev] Re: [linux] user feedback one month in

2009-09-20 Thread Elliot Glaysher (Chromium)
On Sun, Sep 20, 2009 at 7:43 PM, Evan Martin e...@chromium.org wrote: - CSS occasionally lost while browsing My response: I think I've seen this too, but I had been assuming it's site glitches.  Does this ring any bells for anyone? I see this at least twice a day on my home connection. A site

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

2009-09-23 Thread Elliot Glaysher (Chromium)
On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek j...@chromium.org wrote: I have to delete the v8 directory and run gclient sync again (or remove the generated files).  This is annoying, since it breaks syncing to all the Windows developers (I don't think this happens on Mac and Linux).

[chromium-dev] Re: SVN Stable Tree Path for 3.0.195.25

2009-10-07 Thread Elliot Glaysher (Chromium)
The latest source is in trunk, not a specific release branch. -- Elliot On Tue, Oct 6, 2009 at 12:34 PM, Amit Kishnani akish...@adobe.com wrote: Hey Guys, what is difference between these releases 3.0.190.2 3.0.195.25 i can get to SVN source tree to read access for code tree 3.0.190.2

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Elliot Glaysher (Chromium)
On Wed, Oct 28, 2009 at 9:20 AM, Evan Martin e...@chromium.org wrote: 3) Startup time is faster than calculator. I'm not sure if you're kidding.  Do you mean Windows calculator? On my home linux box (Jaunty, reasonably fast), warm startup time of chrome is less than the warm startup time

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Elliot Glaysher (Chromium)
On Wed, Oct 28, 2009 at 12:24 PM, Antoine Labour pi...@google.com wrote: For the UI bits, I'm willing to believe that GTK, which uses cairo, hence XRender for rendering, is hardware accelerated and in any case pipelined in another process (X), and so is faster than serialized, software

[chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Elliot Glaysher (Chromium)
Chromium developers, I have just submitted a PRESUBMIT.py for chrome/ which will run cpplint.py on your change as part of the presubmit process. cpplint is currently run at reduced strictness--cpplint run separately may generate more errors[1]. Currently, it only runs it at (gcl/git cl) upload

Re: [chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Elliot Glaysher (Chromium)
On Tue, Nov 17, 2009 at 11:29 AM, Peter Kasting pkast...@google.com wrote: There are some unittests where we have super-long bits which go over 80 chars, and there are also some where the linter thinks our indenting is strange when we do something like: struct Foo { ... }; Foo foo_cases[] = {

Re: [chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Elliot Glaysher (Chromium)
On Tue, Nov 17, 2009 at 11:31 AM, Nico Weber tha...@google.com wrote: Is cpplint the thing that generates the lint errors column on codereview? If so, it doesn't work very well for objective-c++ files (.mm) and .h files that contain objc++ declarations. The PRESUBMIT.py file only runs on cc

Re: [chromium-dev] SQLite compression in history database.

2009-11-24 Thread Elliot Glaysher (Chromium)
I'm all for it. I vaguely remember people complaining about the size of our history files, and most of my history files are over 50M. -- Elliot On Tue, Nov 24, 2009 at 10:13 AM, Scott Hess sh...@chromium.org wrote: Long ago when developing fts1, I experimented with using zlib compression as

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-09 Thread Elliot Glaysher (Chromium)
If there are consistent patterns of NOLINT usage, I can suppress the whole error class. Also, the linter is only automatically run on chrome/ and app/, IIRC. -- Elliot On Wed, Dec 9, 2009 at 4:38 PM, Brett Wilson bre...@chromium.org wrote: On Wed, Dec 9, 2009 at 4:24 PM, John Abd-El-Malek

Re: [chromium-dev] Problem in Hooking 'ExTextOut'

2010-09-15 Thread Elliot Glaysher (Chromium)
On Wed, Sep 15, 2010 at 10:04 AM, ZHOU Xiaobo xb.z...@qq.com wrote:  My question is:         what the sandbox does is just hooking a subset of the systemcall such as 'OpenFile' 'CreateProcess' etc ? The effect is crashing the process on any syscall we don't whitelist. I don't know exactly how