Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Antoine Labour
On Wed, Jan 13, 2010 at 10:06 AM, Stephen White senorbla...@chromium.orgwrote: On Wed, Jan 13, 2010 at 12:19 PM, Dan Kegel d...@kegel.com wrote: On Wed, Jan 13, 2010 at 9:12 AM, Stephen White senorbla...@chromium.org wrote: 2) Most of the supposed performance advantage of strict aliasing

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Antoine Labour
On Wed, Jan 13, 2010 at 10:53 AM, Craig Schlenter craig.schlen...@gmail.com wrote: On Wed, Jan 13, 2010 at 8:34 PM, Antoine Labour pi...@google.com wrote: On Wed, Jan 13, 2010 at 10:06 AM, Stephen White senorbla...@chromium.org wrote: On Wed, Jan 13, 2010 at 12:19 PM, Dan Kegel d

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-12 Thread Antoine Labour
On Tue, Jan 12, 2010 at 10:15 AM, Craig Schlenter craig.schlen...@chromium.org wrote: On Tue, Jan 12, 2010 at 7:13 PM, Evan Martin e...@chromium.org wrote: In this bug http://code.google.com/p/chromium/issues/detail?id=28749 It seems we're running afoul of a more finicky compiler not

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Antoine Labour
On Sat, Jan 9, 2010 at 2:44 AM, Victor Khimenko k...@google.com wrote: On Sat, Jan 9, 2010 at 6:08 AM, Antoine Labour pi...@google.com wrote: How about: int fd = open(file_or_url, O_RDONLY); if (fd = 0) { close(fd); OpenLocalFile(file_or_url); } else { OpenURL(file_or_url

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-08 Thread Antoine Labour
On Fri, Jan 8, 2010 at 5:15 AM, Paweł Hajdan, Jr. phajdan...@chromium.orgwrote: We have http://crbug.com/4436, and the problem is that if you launch chrome index.html (with index.html in the current directory) it will try to navigate to http://index.html/ instead. This behavior is useful for

Re: [chromium-dev] Re: buildbot failure in Chromium on Linux Perf, revision 35651

2010-01-06 Thread Antoine Labour
Go ahead and revert, I'm in a meeting. Sorry for this. - Brett (writing from Antoine's computer) On Wed, Jan 6, 2010 at 2:05 PM, Erik Arvidsson a...@chromium.org wrote: Brett, any progress? If I don't hear anything from you soon I'll revert the patch. erik On Wed, Jan 6, 2010 at 13:49,

[chromium-dev] PSA: new dev packages needed on linux

2010-01-04 Thread Antoine Labour
If you don't build on linux, you can stop reading now. For the incoming gpu plugin on linux, the following new packages are needed: * mesa-common-dev * libgl1-mesa-dev * libglu1-mesa-dev The gpu plugin change is not checked in yet (some of the slaves didn't get those packages), but will

Re: [chromium-dev] Linux 32-bit build instructions

2009-12-19 Thread Antoine Labour
On Sat, Dec 19, 2009 at 7:06 AM, Evan Martin e...@chromium.org wrote: On Sat, Dec 19, 2009 at 6:59 AM, Kevin Millikin kmilli...@chromium.org wrote: I'm trying to build Linux 32-bit on 64-bit Ubuntu 8.04. The closest think I've found is

Re: [chromium-dev] cross compile err: strict-aliasing

2009-12-18 Thread Antoine Labour
On Fri, Dec 18, 2009 at 12:48 AM, Richard Zhao linux...@gmail.com wrote: On Fri, Dec 18, 2009 at 3:46 PM, Richard Zhao linux...@gmail.com wrote: On Fri, Dec 18, 2009 at 2:46 PM, Antoine Labour pi...@google.com wrote: On Thu, Dec 17, 2009 at 10:36 PM, Richard Zhao linux...@gmail.com wrote

Re: [chromium-dev] Re: Building chromium for arm--erroring out

2009-12-15 Thread Antoine Labour
the gclient sync. That broke the whole thing. Does anyone know how I could get back to the old revision of source ? Thanks, Sofia On Mon, Dec 14, 2009 at 5:32 PM, Antoine Labour pi...@chromium.orgwrote: On Mon, Dec 14, 2009 at 1:30 PM, Sofia Tahseen sofia.tahs...@gmail.comwrote: Hi Antoine

Re: [chromium-dev] Re: Building chromium for arm--erroring out

2009-12-14 Thread Antoine Labour
. If it is not, the compiler should refuse NEON assembly... Antoine Thanks, Sofia On Fri, Dec 11, 2009 at 5:39 PM, Antoine Labour pi...@chromium.orgwrote: On Fri, Dec 11, 2009 at 3:28 PM, Sofia Tahseen sofia.tahs...@gmail.comwrote: Hi Joel/Erik/All, I don't think armv5 is an issue

Re: [chromium-dev] Re: Building chromium for arm--erroring out

2009-12-14 Thread Antoine Labour
on chromium browser and make chromium working on a hardware that does not support NEON? Is it still crashing in S32A_Opaque_BlitRow32_neon ? Thanks, Sofia On Fri, Dec 11, 2009 at 5:39 PM, Antoine Labour pi...@chromium.orgwrote: On Fri, Dec 11, 2009 at 3:28 PM, Sofia Tahseen

Re: [chromium-dev] Re: Building chromium for arm--erroring out

2009-12-11 Thread Antoine Labour
On Fri, Dec 11, 2009 at 3:28 PM, Sofia Tahseen sofia.tahs...@gmail.comwrote: Hi Joel/Erik/All, I don't think armv5 is an issue. Reason being I used the jaunty armv5 libraries to build chrome. I tried to debug the issue with gdb. gdb chrome GNU gdb 6.8-debian Copyright (C) 2008 Free

[chromium-dev] Re: Building chromium for arm--erroring out

2009-12-07 Thread Antoine Labour
On Mon, Dec 7, 2009 at 2:50 PM, SOFIA TAHSEEN dnk...@motorola.com wrote: Hi Antoine/Joel, When I try to build using the following make command I get the error as below...Have you seen this earlier : make -r -j3 BUILDTYPE=Release chrome (I have a dual core so used -j3) CXX(target)

[chromium-dev] Re: Building chromium for arm--erroring out

2009-12-07 Thread Antoine Labour
use_system_ffmpeg=1 gclient sync Let me know if I am doing something wrong. Try with a newer version of CodeSourcery. I haven't had this issue with 2009q1 or 2009q3. I'm working on a fix anyway, see http://codereview.chromium.org/464064 Antoine Thanks, Sofia On Dec 7, 5:13 pm, Antoine Labour

Re: [chromium-dev] -m32 not recognized on arm ubuntu

2009-12-07 Thread Antoine Labour
On Mon, Dec 7, 2009 at 7:30 PM, Richard Zhao linux...@gmail.com wrote: I found many places using -m32 cflags. but my gcc can recognize it. How do you compile? http://code.google.com/p/chromium/wiki/LinuxChromiumArm Antoine -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] -m32 not recognized on arm ubuntu

2009-12-07 Thread Antoine Labour
On Mon, Dec 7, 2009 at 8:35 PM, Richard Zhao linux...@gmail.com wrote: On Tue, Dec 8, 2009 at 11:41 AM, Antoine Labour pi...@chromium.org wrote: On Mon, Dec 7, 2009 at 7:30 PM, Richard Zhao linux...@gmail.com wrote: I found many places using -m32 cflags. but my gcc can recognize

Re: [chromium-dev] -m32 not recognized on arm ubuntu

2009-12-07 Thread Antoine Labour
On Mon, Dec 7, 2009 at 8:58 PM, Richard Zhao linux...@gmail.com wrote: On Tue, Dec 8, 2009 at 12:41 PM, Antoine Labour pi...@chromium.org wrote: On Mon, Dec 7, 2009 at 8:35 PM, Richard Zhao linux...@gmail.com wrote: On Tue, Dec 8, 2009 at 11:41 AM, Antoine Labour pi...@chromium.org

Re: [chromium-dev] -m32 not recognized on arm ubuntu

2009-12-07 Thread Antoine Labour
On Mon, Dec 7, 2009 at 9:58 PM, Richard Zhao linux...@gmail.com wrote: On Tue, Dec 8, 2009 at 1:54 PM, Richard Zhao linux...@gmail.com wrote: On Tue, Dec 8, 2009 at 1:03 PM, Antoine Labour pi...@chromium.org wrote: On Mon, Dec 7, 2009 at 8:58 PM, Richard Zhao linux...@gmail.com wrote

Re: [chromium-dev] Linux build instructions deleted from chromium wiki

2009-12-05 Thread Antoine Labour
On Fri, Dec 4, 2009 at 9:40 PM, Mark Larson (Google) m...@chromium.orgwrote: The LinuxBuildInstructions got deleted from the Wiki: http://code.google.com/p/chromium/source/detail?r=1495 Anyone know why? I restored them. Someone on IRC mentioned that they were using them, but then they

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Antoine Labour
On Sun, Nov 22, 2009 at 1:35 PM, Adam Langley a...@chromium.org wrote: On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make clean', but it said there is no 'clean' target'. % find out -type f -name

Re: [chromium-dev] Re: class has virtual method but non-virtual destructor

2009-11-21 Thread Antoine Labour
On Sat, Nov 21, 2009 at 7:21 AM, rahul rahulsin...@gmail.com wrote: Sorry about the late reply(I am in a different timezone and when my comment didn't appear after 12 hours of submission, I thought it had been pruned). @Eric Roman What class do you get this error on? I actually got fed up

Re: [chromium-dev] whitlisting compilers for -Werror

2009-11-21 Thread Antoine Labour
On Sat, Nov 21, 2009 at 12:33 PM, Peter Kasting pkast...@google.com wrote: On Sat, Nov 21, 2009 at 12:06 PM, Evan Martin e...@chromium.org wrote: This works for warnings we know about now, but not warnings that will occur in the future, which is the larger problem. I'd say we break the

Re: [chromium-dev] whitlisting compilers for -Werror

2009-11-21 Thread Antoine Labour
On Sat, Nov 21, 2009 at 5:43 PM, Fabien Tassin f...@sofaraway.org wrote: On Sat, 2009-11-21 at 12:06 -0800, Evan Martin wrote: I'd say we break the automated Ubuntu builds every couple of weeks (and get an additional report from users at about that same rate). I don't mind when my

Re: [chromium-dev] Linux: gold linker users should upgrade to 2.20 soon.

2009-11-21 Thread Antoine Labour
On Sat, Nov 21, 2009 at 6:24 PM, David Moore davemo...@google.com wrote: Since I did this upgrade my builds have gotten very very slow. A single file change, recompile and relink used to be about 35 seconds. Now it's 2 and a half minutes. As far as I can tell I'm using the right gold.

Re: [chromium-dev] skia floating point

2009-11-17 Thread Antoine Labour
On Mon, Nov 16, 2009 at 11:19 PM, Andy Quan androidr...@gmail.com wrote: Hi, I noticed that SKIA is by default using floating point calculation inside android. Does this mean that if the CPU has VFP unit, SKIA will run faster? I asked this due to my interest in JPEG viewer on android which

Re: [chromium-dev] skia floating point

2009-11-17 Thread Antoine Labour
On Tue, Nov 17, 2009 at 3:02 PM, Joel Stanley j...@chromium.org wrote: On Wed, Nov 18, 2009 at 05:23, Antoine Labour pi...@google.com wrote: That's really a question for the Android team, not Chromium... As far as Chrome's use of Skia, if you compile for ARMv7, you'll get NEON acceleration

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Antoine Labour
On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. Antoine --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Antoine Labour
On Thu, Nov 5, 2009 at 1:38 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like

[chromium-dev] Re: Can't build chrome; NameError: name '_toolset' is not defined. Can't sync webkit. :-(

2009-11-03 Thread Antoine Labour
On Tue, Nov 3, 2009 at 8:06 AM, Dan Kegel d...@kegel.com wrote: I get NameError: name '_toolset' is not defined while loading dependencies of base/base.gyp while loading dependencies of app/app.gyp while loading dependencies of build/all.gyp while trying to load build/all.gyp when

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.org wrote: I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have been several email threads

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:26 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:17 PM, Antoine Labour pi...@google.com wrote: On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.orgwrote: I've spent a good deal of this week trying to track down what turned out

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Antoine Labour
On Wed, Oct 28, 2009 at 12:05 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 28, 2009 at 8:05 AM, Evan Martin e...@chromium.org wrote: General comments: Linux tends to be lighter which means it does better on older hardware, so depending on what sorts of laptops you're talking

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Antoine Labour
On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑) ajw...@chromium.orgwrote: I actually got some weird warnings on the make build a while back when I specified the same file in two sources entries...something about circular dependencies and make ignore one. But don't remember the exact

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Antoine Labour
On Wed, Oct 28, 2009 at 1:37 PM, Evan Martin e...@chromium.org wrote: On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: I actually got some weird warnings on the make build a while back when I specified the same file in two sources entries...something about

[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread Antoine Labour
On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss mm...@chromium.org wrote: On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: On x86_64 machine, I couldn't build even if I clobber.. /usr/bin/ld: skipping incompatible

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Antoine Labour
different flags. TVL That means duplicating every rule that is needed for host and target though. Antoine On Wed, Oct 7, 2009 at 10:06 PM, Antoine Labour pi...@google.com wrote: If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Antoine Labour
On Thu, Oct 8, 2009 at 9:49 AM, Evan Martin e...@chromium.org wrote: On Wed, Oct 7, 2009 at 7:06 PM, Antoine Labour pi...@google.com wrote: If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding host support for cross-compiling

[chromium-dev] GYP and cross-compiling

2009-10-07 Thread Antoine Labour
If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding host support for cross-compiling into gyp. By this, I mean being able to use the cross-compiler to build Chrome, but still using the host compiler for build tools. Regular Chrome, with v8

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc needs to

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 4:25 PM, Peter Kasting pkast...@google.com wrote: On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour pi...@google.com wrote: On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined

[chromium-dev] Re: Jank: performance and animation frame rates

2009-10-02 Thread Antoine Labour
On Fri, Oct 2, 2009 at 2:02 PM, John Abd-El-Malek j...@chromium.org wrote: On Fri, Oct 2, 2009 at 12:54 PM, Evan Stade est...@chromium.org wrote: We try to fire the timer rapidly, but if we get bogged down, it just won't fire until later; when it actually does fire, we update our state

[chromium-dev] Re: Native Client in Cross Compile

2009-10-01 Thread Antoine Labour
On Tue, Sep 29, 2009 at 12:44 PM, Daniel mpc...@gmail.com wrote: I'm trying to cross compile chromium to ARM, but I'm getting errors in the native client code. ./native_client/src/include/elf.h:68:3: error: #error NACL_TARGET_SUBARCH must be defined to be 32 or 64 It looks like I have to

[chromium-dev] Re: GYP-generated make files now auto-regenate

2009-09-16 Thread Antoine Labour
On Wed, Sep 16, 2009 at 6:00 AM, Steven Knight s...@chromium.org wrote: Heads up for those using the GYP make generator: the GYP update last night included a patch from mattm to add dependencies to the generated Makefiles to run gyp to auto-regenerate the Makefiles if the .gyp file(s) change.

[chromium-dev] Re: Verdict: Menu string casing

2009-09-16 Thread Antoine Labour
On Wed, Sep 16, 2009 at 2:30 PM, krtulmay krtul...@gmail.com wrote: Sentence case is terrible. Can't understand why Vista HIG would choose that. After all, why use Sentence case on all these things that are *not* sentences? Definitely should use Title Case, even for Windows. After all,

[chromium-dev] Re: [linux] plugin paths

2009-08-28 Thread Antoine Labour
On Fri, Aug 28, 2009 at 11:03 AM, John Abd-El-Malek j...@chromium.orgwrote: Can't we blacklist nspluginwrapper, and use the same logic that it uses to find the real plugins? Last time I looked, the way nspw works: for each wrapped plugin it installs a version of the nspw plugin into the

[chromium-dev] Re: Cross-compiling on ARM

2009-08-24 Thread Antoine Labour
On Mon, Aug 24, 2009 at 1:53 PM, Scott Hesssh...@chromium.org wrote: Would it be possible/reasonable to use distcc plus a farm of cross-compiler machines to let you do faster self-hosted builds?  It's not the right solution, but in the past I've found it to sometimes be an easier path to take

[chromium-dev] Cross-compiling on ARM

2009-08-22 Thread Antoine Labour
There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts. I understand that Joel Stanley, Dean McNamee and Lei Zhang have already been doing a lot of work towards that. There's

[chromium-dev] Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts. I understand that Joel Stanley, Dean McNamee and Lei Zhang have already been doing a lot of work towards that. There's

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
On Fri, Aug 21, 2009 at 2:46 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:34 PM, Lei Zhang thes...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:25 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: - Gyp

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
On Fri, Aug 21, 2009 at 2:45 PM, Erik Corryerik.co...@gmail.com wrote: 2009/8/21 Antoine Labour pi...@google.com: There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts

[chromium-dev] Re: [linux] creating desktop shortcuts

2009-08-04 Thread Antoine Labour
On Tue, Aug 4, 2009 at 1:22 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Yes, but even then we need to know how the launcher is named. Hardcoding google-chrome is not good for chromium builds (and we are going to have Chromium packaged for Gentoo). Having it chromium for Chromium is also

[chromium-dev] Re: Make PostTask virtual?

2009-08-03 Thread Antoine Labour
On Mon, Aug 3, 2009 at 8:23 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: I've noticed that most public functions on MessageLoop are non-virtual.  How bad would it be to make PostTask, and its variants, virtual?  Are the perf implications or similar that would be bad? I'd like to be able

[chromium-dev] Re: [linux, maybe mac] gcc -fvisibility=hidden

2009-07-29 Thread Antoine Labour
On Wed, Jul 29, 2009 at 10:46 AM, Evan Martine...@chromium.org wrote: On Tue, Jul 28, 2009 at 11:18 PM, Brian Rynerbry...@google.com wrote: The -fvisibility=hidden flag is maybe supposed to do this (see discussion on http://gcc.gnu.org/wiki/Visibility ), but I tried building both with and

[chromium-dev] linux: debugging sandboxed renderers ?

2009-07-20 Thread Antoine Labour
So, sandboxing is in on linux, which is awesome. But how do I debug sandbox-related issues (in my case, why I can't create a shared memory buffer from the renderer when sandboxing is on). If I specify a --renderer-cmd-prefix, it doesn't use the zygote process, and I don't get sandboxed. If I let

[chromium-dev] Re: linux: debugging sandboxed renderers ?

2009-07-20 Thread Antoine Labour
On Tue, Jul 21, 2009 at 3:32 AM, Adam Langleya...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're

[chromium-dev] Re: linux: debugging sandboxed renderers ?

2009-07-20 Thread Antoine Labour
On Tue, Jul 21, 2009 at 4:49 AM, Evan Martine...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:39 AM, Antoine Labourpi...@google.com wrote: On Tue, Jul 21, 2009 at 3:32 AM, Adam Langleya...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Antoine Labour
On Tue, Jul 14, 2009 at 7:12 PM, Adam Langley a...@chromium.org wrote: * If you update your google-chrome-unstable packages and your development builds start hanging, sync to = 20710 * Details: The latest google-chrome packages contain a sandbox binary, which the development builds of

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Antoine Labour
On Tue, Jul 14, 2009 at 8:19 PM, Adam Langley a...@chromium.org wrote: On Tue, Jul 14, 2009 at 8:14 PM, Antoine Labourpi...@google.com wrote: Does this part need to be sticky, or is it just to build the chrome-devel-sandbox ? If the former it is going to be painful. You only need to build

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Antoine Labour
On Thu, Jun 25, 2009 at 5:57 PM, Dan Kegeldaniel.r.ke...@gmail.com wrote: I did  rm Makefile  gclient runhooks --force and it didn't regenerate Makefile. tools/gyp/gyp -f make build/all.gyp does rebuild it. Seems like gclient runhooks --force ought to, no? Are you seeing the same thing

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Antoine Labour
On Thu, Jun 25, 2009 at 6:20 PM, Dan Kegeld...@kegel.com wrote: On Thu, Jun 25, 2009 at 6:13 PM, Antoine Labourpi...@google.com wrote: Are you seeing the same thing I am seeing ? For me, through gclient, Makefile is generated one directory up and is messed up. By gum, yes: $ diff Makefile

[chromium-dev] Re: Proposal: extensions API documentation system

2009-06-23 Thread Antoine Labour
On Tue, Jun 23, 2009 at 11:41 AM, Jeremy Orlowjor...@chromium.org wrote: For what it's worth, I was really impressed by the O3D documentation:  http://code.google.com/apis/o3d/docs/index.html Not sure how they did it, but I believe it was all generated.  Not sure if that's close enough to 

[chromium-dev] Re: What is the best way to get document location from an NPAPI plugin?

2009-06-08 Thread Antoine Labour
On Sun, Jun 7, 2009 at 10:57 PM, vijaytec...@gmail.com wrote: Preferably a browser-independent way would be great. Thanks in advance, Vijay I believe the best way to do that is to use NPRuntime. Essentially, you programatically query window.location.href using a series of NPN_GetProperty.

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Antoine Labour
2009/6/3 Randall Spangler rspang...@google.com: Hi Dean, Croc (the coverage utility) currently takes an expansive view of which files need to be covered.  That's to catch cases where a new source file is added, but not compiled into any tests. The rules which Croc uses on linux are a

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-26 Thread Antoine Labour
On Tue, May 26, 2009 at 8:31 PM, Brett Wilson bre...@chromium.org wrote: On Tue, May 26, 2009 at 6:22 PM, Aaron Boodman a...@chromium.org wrote: I get different stories about this all the time from different people. It would be great to have them as part of the style guide so that I can

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Antoine Labour
2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Zhanyong Wan (λx.x x) w...@google.com 2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Zhanyong Wan (λx.x x) w...@google.com 2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Nicolas Sylvain