On Wed, Jan 13, 2010 at 3:55 PM, Chase Phillips ch...@chromium.org wrote:
On Wed, Jan 13, 2010 at 14:50, Chase Phillips ch...@chromium.org wrote:
Darin's June 2, 2009 Google I/O Exploring Chrome Internals presentation
slide deck is now available from
On Wed, Dec 16, 2009 at 4:25 AM, Jeremy Moskovich jer...@chromium.orgwrote:
Hi Horonori,
Thanks for taking a look at this!!
What kinds of differences are you seeing without the new spellchecker
class?
The only notable difference seems to be that the fonts are slightly
different vs. the
Have you considered making the output closer to that of WebKit's
run-webkit-tests?
It seems that would ease the hopeful transition to this version upstream.
dave
On Thu, Dec 10, 2009 at 7:23 PM, Dirk Pranke dpra...@chromium.org wrote:
Hi all,
If you never run the webkit layout tests, you
).
The output by directory also adapts better to the buildbot output instead of
the huge test-by-test list that chromium buildbots have (which takes a while
to download when you click the link for stdio).
dave
-- Dirk
On Thu, Dec 10, 2009 at 10:10 PM, David Levin le...@chromium.org wrote:
Actually, you
On Tue, Dec 1, 2009 at 2:30 PM, oshima osh...@chromium.org wrote:
Looks like there are more tests that failing in valgrind test.
shard=1 id=1513
[ FAILED ] WorkerTest.MultipleWorkers (103254 ms)
[ FAILED ] NewTabUITest.ChromeInternalLoadsNTP (74002 ms)
[ FAILED ]
That is excellent! I didn't know there was such a thing.
Thanks,
Dave
On Tue, Dec 1, 2009 at 4:09 PM, oshima osh...@chromium.org wrote:
# Re-sending b/c gmail didn't use my account properly. Sorry if you get
this twice.
On Tue, Dec 1, 2009 at 3:53 PM, David Levin le...@chromium.org wrote
On Fri, Oct 30, 2009 at 3:59 PM, Antoine Labour pi...@google.com wrote:
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote:
On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote:
Just to be clear for those of us who are wobbly on C++, this is
because
to tell folks b/c I'm
sure not everyone checks that every time they start gardening.
dave
On Tue, Oct 20, 2009 at 10:25 AM, Jeremy Orlow jor...@chromium.org wrote:
On Tue, Oct 20, 2009 at 10:19 AM, David Levin le...@google.com wrote:
That sounds like a reasonable policy.
Hmm...I thought
The webkit api won't help if chromium folks (especially when you change v8
bindings) don't *run the layout tests *which is what happened yesterday and
causes quite a few of our worst problems while gardening.
If you're changing the v8 bindings, you're doing it to fix a problem in
chromium, so you
A better solution would be to have the sheriff (or someone from LTTF)
assign the bugs to specific people
So how do you figure out who to assign it to?
with a general rule that such bugs must be fixed within two days (make
these bugs the top priority over other tasks).
Over security bugs?
Over
I glanced at the other one. there were a few issues with it:
1. It does more than it says. It changes how the horizontal lines are drawn
without explanation (nothing in the changelog and the bug only mentions the
other direction).
2. It uses a lot of magic numbers and the same ones repeatedly. It
Q: When I change src/DEPS, do I also have to change upstream
third_party/WebKit/WebKit/chromium/DEPS?
A: It depends why you update src/DEPS. Theoretically, you should only
update
the upstream DEPS if the fix to the dependency actually changes the way
webkit interacts with it, or fixes a
, Sep 29, 2009 at 1:12 PM, David Levin le...@google.com wrote:
Q: When I change src/DEPS, do I also have to change upstream
third_party/WebKit/WebKit/chromium/DEPS?
A: It depends why you update src/DEPS. Theoretically, you should only
update
the upstream DEPS if the fix to the dependency
about vetting changes to the modules. The canary bot can cover
those.
We could write a tool to sync deps, which we run periodically. I think
the Chromium repository should probably hold the truth.
-Darin
On Tue, Sep 29, 2009 at 4:46 PM, David Levin le...@google.com wrote:
What about
For windows (vista 64bit?), if you hit gclient hangs in general while
sync'ing:
Run this command (from an Administrator command prompt): netsh interface
tcp set global autotuninglevel=disabled
Hopefully, it will be fixed for you as it seems to be for me.
Reference:
I find that being a WebKit gardener is always dancing on a minefield
regardless of my familiarity with the WebKit code base. Look at yesterday
for an example.
In addition, we have several gardeners who are not actively working on
WebKit (amanda@ has 0 WebKit commits, pinkerton@ has a few all in
On Wed, Sep 23, 2009 at 8:53 AM, Glenn Wilson gwil...@chromium.org wrote:
I'll take the action item to remove anyone in the rotation who is not
actively working on Webkit / is not a committer.
Oh no... now it will happen even more often :)
Should there also be the reverse adding WebKit
Actionable items for keeping the tree green (in addition to blaming the
WebKit gardener for [insert action here]):
- *Get people putting in chromium patches upstream to run their changes
through trybots, etc*. imo, patches from @chromium folks cause well over
50% of the grief with WebKit
I like to use multiple directories using git-new-workdir (
http://www.google.com/search?q=git-new-workdir).
I tend to keep one directory for trunk and one for whatever branch I'm
working on (and if I'm working on a few branches, then I'll keep a few
directories). I still swap branches in the
On Tue, Sep 8, 2009 at 11:02 PM, Jeremy Orlow jor...@chromium.org wrote:
This has not always been true in the past. I think we (people working on
Chromium) made a good effort to help bring real code review infrastructure
to WebKit and that was a disaster (though maybe I don't know the full
But the canaries are release so having debug for the try bots allows one to
find issues that the canaries don't catch with new webkit merges.
On Tue, Sep 1, 2009 at 4:39 PM, Jeremy Orlow jor...@chromium.org wrote:
I'd suggest putting the webkit layout test slaves under release. This
would
On Mon, Aug 24, 2009 at 1:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Mon, Aug 24, 2009 at 11:37 AM, Ojan Vafaio...@chromium.org wrote:
The end goal is to be in a state where we have near zero failing tests
that
are not for unimplemented features. And new failures from the merge get
Then, run this command (from an Administrator command prompt):
netsh interface tcp set global autotuninglevel=disabled
Hopefully, it will be fixed for you as it seems to be for me.
Reference:
http://blogs.technet.com/asiasupp/archive/2006/12/14/windows-vista-tcp-auto-tuning.aspx
Dave
Plug: I believe check-webkit-style will ensure that it is there in cpp file
and not there in h files.
And yes, eventually this will likely be part of another tool so you get the
messages automatically when doing some step (like prepare-ChangeLog) but it
isn't yet.
On Fri, Aug 7, 2009 at 10:15
On Wed, Jul 29, 2009 at 11:28 AM, Drew Wilson atwil...@chromium.org wrote:
I've been starting to lean in this direction as well. The problem is that
extensions are currently not cross-platform and would require separate
implementations for each platform. And in many cases the extension
There is one internal site that I go to enter some feedback. (It has auto
save now but didn't at one point.)
Recently I don't go there very often. It is entirely possible (and
frequently happens) that I get interrupted while entering feedback and have
to look up other information (during which I
Woohoo
On Fri, Jul 17, 2009 at 10:42 AM, Nate Chapin jap...@google.com wrote:
As of r20923, src/webkit/port/ has been deleted and the last of the V8
bindings are living in svn.webkit.org. There's still some cleanup of
the bindings to be done, but they are all upstream now. Hopefully
fwiw, gears had an implementation that didn't depend
on XScreenSaverQueryInfo
http://code.google.com/p/gears/source/detail?r=2641path=/trunk/gears/notifier/user_activity.cc
see user_activity_linux.cc
2009/5/7 Adam Barth aba...@chromium.org
I'd encourage you to implement it for extensions
That file has been deleted from gears -- not as a reflection on the
implementation but due to the lack of its use in gears.
2009/5/7 Evan Martin e...@chromium.org
Does this mean PhistucK could just rely on the gears implementation?
Then it would require no Chrome changes.
2009/5/7 David
One of the few remaining forks is in
WebCore/platform/graphics/FontCache.cpp
(https://bugs.webkit.org/show_bug.cgi?id=21451).
I'll be checking in a change to remove this fork and as such we should
expect ~20% perf hit for the international page cycler. The
internatonal page cycler test
On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting pkast...@chromium.orgwrote:
On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow jor...@chromium.org wrote:
Darin was there on that lunch and was actually the one who first suggested
running parts of WebCore in the browser to me during a 1:1. :-)
On Mon, Apr 6, 2009 at 6:24 PM, Ojan Vafai o...@google.com wrote:
run_webkit_test.sh now runs cpus+1 test_shells for Release builds. Please
keep an eye out over the next couple days for test flakyness that may have
resulted from this.
Nice job!
Release tests on a dual core now take about
this.
Ojan
On Tue, Mar 24, 2009 at 12:31 PM, David Levin le...@google.com wrote:
I like this proposal. I would also like a bugs for P3 which could
explain
why it is a P3. If is it an unimplemented feature, then all tests for
that
unimplemented feature could have the same bug.
(Since I do
I like this proposal. *I would also like a bugs for P3* which could explain
why it is a P3. If is it an unimplemented feature, then all tests for that
unimplemented feature could have the same bug.
(Since I do merges and took a while to layout test file bugs from that) I
like option 2. *BUT I'm
This fellow has done a good job of highlighting improvements to WebKit on an
on going basis:
http://hanblog.info/blog/category/WebKit
Of course, not everything mentioned in there is in available just because
we're at ToT. (Some things are behind ifdef's etc.)
On Mon, Jan 5, 2009 at 11:06 PM,
So how does one know if the change they checked in requires a clobber build?
Dave
PS I tend to do clean builds once in a while just to ensure that everything
is in a good state. (I don't trust incremental builds to stay stable over
several days having spent way too much time on messed builds due
36 matches
Mail list logo
