Re: [chromium-dev] Browser power use

2009-12-17 Thread Mike Belshe
Thanks for sending this out. The results are nice :-) Mike On Wed, Dec 16, 2009 at 5:48 PM, Joel Stanley j...@chromium.org wrote: Hello Chromium, Continuing with my interest in Chromium's effect on battery life I've been playing with an ARM build of Chromium on the BeagleBoard, with

[chromium-dev] Ending the AsyncSlowStartExperiment

2009-12-11 Thread Mike Belshe
* I am going to turn off the AsyncSlowStart experiment, but wanted to send the results for the curious minded. What is the feature:* Some time ago, I observed that windows asynchronous IO may delay handing an IO completion to the application when only part of the requested IO can complete.

Re: [chromium-dev] Any interest in command line tools for network stack?

2009-11-23 Thread Mike Belshe
On Mon, Nov 23, 2009 at 2:26 PM, Eric Roman ero...@chromium.org wrote: One command line tool I have sometimes wanted when debugging, is a way to dump out a cached response from the disk cache. There is a dump_cache.exe utility; it can copy a cache or copy the whole thing to a set of disk

[chromium-dev] Re: buildbot failure in Chromium on Webkit Mac10.5 (dbg)(3), revision 32913

2009-11-23 Thread Mike Belshe
I'm looking at this; not sure that it is anything I caused Mike On Mon, Nov 23, 2009 at 8:18 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for test_shell_tests on Webkit Mac10.5 (dbg)(3)

[chromium-dev] Re: buildbot failure in Chromium on Webkit Mac10.5 (dbg)(3), revision 32913

2009-11-23 Thread Mike Belshe
Dirk suspects this was caused by his: http://chrome-buildbot.corp.google.com:8010/builders/Webkit%20(dbg)(3)/builds/10311 http://chrome-buildbot.corp.google.com:8010/builders/Webkit%20(dbg)(3)/builds/10311 Mike On Mon, Nov 23, 2009 at 8:23 PM, Mike Belshe mbel...@google.com wrote: I'm

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Mike Belshe
I think we should have a list of low-level functionality which we just never cleanup. For the items you listed, I think you should leak them all. Trying to cleanup these items creates complicated code and ultimately won't run any better and possibly slower. Mike On Fri, Nov 20, 2009 at 1:44

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Mike Belshe
I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. 2) If you turn on Intellisense, it crashes like crazy very regularly. I've turned off intellisense, but it is a big loss in

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Mike Belshe
...@chromium.orgwrote: On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Mike Belshe
On Wed, Oct 28, 2009 at 10:54 AM, Jens Alfke s...@chromium.org wrote: On Oct 27, 2009, at 9:10 PM, Mike Belshe wrote: From a performance perspective, it may be critical to use tcmalloc to match safari performance. It was literally a 50% speedup on most of the DOM perf when running on WinXP

[chromium-dev] Re: Fun with timers! A horror story

2009-10-27 Thread Mike Belshe
On Tue, Oct 27, 2009 at 7:34 PM, Darin Fisher da...@chromium.org wrote: A central clock is important for the reasons James describes, but using the one from WebKit is not a good option since that would make other modules in Chromium, like base/ and net/, have a dependency on WebKit. Also,

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-27 Thread Mike Belshe
On Tue, Oct 27, 2009 at 3:24 PM, Jens Alfke s...@chromium.org wrote: Do we plan to switch the Mac build of Chromium to use tcmalloc instead of the system malloc? I thought this was the case, but I can't find any bug covering the task to do that. I'm on the memory task force, and this decision

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread Mike Belshe
On Thu, Oct 15, 2009 at 11:11 AM, Jens Alfke s...@google.com wrote: I spent some time this morning looking at Chrome's memory usage (on OS X 10.5.8) while viewing flickr.com. First I simply started at my photo- stream page and hit Reload over and over. Next I tried going through all of my

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Mike Belshe
Probably caused by jemalloc. Jim was experimenting with the idea of getting some dev-channel data from using jemalloc as opposed to tcmalloc. I'm not surprised there was a perf delta, but I am surprised by how much. The DOM benchmark in this test dropped by 8%. Several other benchmarks took

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Mike Belshe
see about:tcmalloc (credit to sgk) - which dumps the *browser* stats. We need to plumb other processes. Mike On Thu, Oct 1, 2009 at 8:42 AM, Erik Kay erik...@chromium.org wrote: On Wed, Sep 30, 2009 at 11:22 AM, James Robinson jam...@google.com wrote: I agree completely that this seems

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Mike Belshe
I think we have a new constraint which we previously were ignoring. Spikes in memory usage of 500MB (which could be released) are no longer tolerable, ever. (I'd like to get agreement on how to define this - some amount of cached memory is okay, of course, but 500MB is not). Some of the

[chromium-dev] Re: [Memory] low memory callback

2009-10-01 Thread Mike Belshe
Sounds good to me - does windows have a good low-memory notification api? On Thu, Oct 1, 2009 at 7:22 AM, Anton Muhin ant...@chromium.org wrote: Thanks a lot for pointing that out. yours, anton. On Thu, Oct 1, 2009 at 6:20 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If you add

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Mike Belshe
benefits include some feedback on crashers, as each allocator illuminates a different set of corruption problems (if we have any :-) ). Do other folks agree it would be interesting to see a dev build go out with this in place?? Thanks, Jim On Thu, Oct 1, 2009 at 8:46 AM, Mike Belshe mbel

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Mike Belshe
in the browser. This shouldn't be overlooked. M-A On Oct 1, 10:11 am, Erik Kay erik...@chromium.org wrote: On Thu, Oct 1, 2009 at 8:49 AM, Mike Belshe mbel...@google.com wrote: see about:tcmalloc (credit to sgk) - which dumps the *browser* stats. We need to plumb other processes

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread Mike Belshe
On Wed, Sep 30, 2009 at 11:05 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 9:58 PM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 10:48 AM, Anton Muhin ant...@google.com wrote: On Wed, Sep 30, 2009 at 9:39 PM, Jim Roskind j...@google.com wrote

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread Mike Belshe
On Wed, Sep 30, 2009 at 11:24 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 10:17 PM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 11:05 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 9:58 PM, Mike Belshe mbel...@google.com wrote

[chromium-dev] Re: Question about UI and classic views

2009-09-24 Thread Mike Belshe
compatible UIs but sites like CNN do not. It sounds like Alice and others will figure out if there is something that needs to change. Mike -Darin On Wed, Sep 23, 2009 at 8:59 PM, Mike Belshe mbel...@google.com wrote: I just got a fairly angry email from my sister about the new tab page UI

[chromium-dev] Question about UI and classic views

2009-09-23 Thread Mike Belshe
I just got a fairly angry email from my sister about the new tab page UI. She writes: What’s up with the Chrome Tab page change? I thought I screwed up my page at home, but now my page at work has changed too. I don’t like it. Why do I have to have my tabs arranged 4x2 ? I liked 3x3.

[chromium-dev] Re: Question about UI and classic views

2009-09-23 Thread Mike Belshe
better? Should we have had better upgrade UI so that users knew this was happening? Mike -Ben On Wed, Sep 23, 2009 at 8:59 PM, Mike Belshe mbel...@google.com wrote: I just got a fairly angry email from my sister about the new tab page UI. She writes: What’s up with the Chrome Tab page

[chromium-dev] Re: V8 object-graph-tracing utilities?

2009-09-22 Thread Mike Belshe
Because we have C++ and JS wrappers, and there may be references known to the C++ side not known to the JS side, we have to do an object grouping before we can call GC. This grouping takes all wrappers and groups them by their root; and then they are collected together. This happens in

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Mike Belshe
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote: I think we need to re-consider our practice of shipping beta/stable browsers with experimental features hidden behind flags--at least when they have any side-effects in JavaScript. An example of where this has bitten us

[chromium-dev] Re: I wish IE8 installed as fast as chrome...

2009-09-19 Thread Mike Belshe
That's the advantage of knowing users have a forced path to install your product. While firefox, safari, opera, and chrome all focus on install speed, Microsoft doesn't. They know they'll get it on your box under all circumstances. So they just don't care. Sad. Think about the man-years (or

[chromium-dev] Re: private VM field on the about:memory page

2009-08-24 Thread Mike Belshe
On Mon, Aug 24, 2009 at 6:18 AM, Anand Mistry akmis...@gmail.com wrote: I'm looking at the about:memory page and am wondering how useful is the private VM field? Would it be just as good to have a total VM instead? The reason I ask is because private VM doesn't map easily to Linux where

[chromium-dev] Re: private VM field on the about:memory page

2009-08-24 Thread Mike Belshe
On Mon, Aug 24, 2009 at 8:13 AM, Anand Mistry akmis...@gmail.com wrote: On Mon, Aug 24, 2009 at 11:42 PM, Joel Stanley j...@jms.id.au wrote: Hello, On Mon, Aug 24, 2009 at 22:48, Anand Mistryakmis...@gmail.com wrote: Also, in general, how useful is knowing VM size considering it's not

[chromium-dev] Re: Mac Debug is hosed, needs an owner

2009-08-17 Thread Mike Belshe
Thanks, Mark. On Mon, Aug 17, 2009 at 10:27 AM, Mark Mentovai m...@chromium.org wrote: This should be fixed at our r23546. Mark I wrote: I've tracked this down to WebKit r47270, which we picked up in our merge at r23446. It looks like there's a fix for our specific case upstream at

[chromium-dev] Re: Trybot HUNK failed on patch

2009-08-17 Thread Mike Belshe
'--revision number' when you do 'gcl try' or upload. On Sat, Aug 15, 2009 at 12:59 PM, Mike Belshe mbel...@google.com wrote: I'm trying to test a simple patch which does nothing more than roll the DEPS file. The svn:eol-style is correct - LF. Any idea what I can do? This seems to happen a lot

[chromium-dev] Trybot HUNK failed on patch

2009-08-15 Thread Mike Belshe
I'm trying to test a simple patch which does nothing more than roll the DEPS file. The svn:eol-style is correct - LF. Any idea what I can do? This seems to happen a lot on the trybots? Thanks Mike --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Allocator Choice

2009-08-12 Thread Mike Belshe
On Tue, Aug 11, 2009 at 9:57 PM, Dean McNamee de...@chromium.org wrote: Do we have numbers on how the 4 allocates compare on those tests (page cycler, etc)? I do - I sent some of them around a few days ago. Summary: jemalloc and tcmalloc are pretty close; where jemalloc is a little more

[chromium-dev] Re: Allocator Choice

2009-08-12 Thread Mike Belshe
Yes Mike On Wed, Aug 12, 2009 at 9:37 AM, Linus Upson li...@google.com wrote: Does all this work with Purify? Linus On Wed, Aug 12, 2009 at 9:09 AM, Mike Belshe mbel...@google.com wrote: On Tue, Aug 11, 2009 at 9:57 PM, Dean McNamee de...@chromium.org wrote: Do we have numbers on how

[chromium-dev] Allocator Choice

2009-08-11 Thread Mike Belshe
In an effort to make it easier to test debugging heaps and allocators, I just landed a changelist which makes our allocators switchable at runtime. Unlike Obama's plan for healthcare, this CL is about giving you more choice. From an environment variable, you can now switch between 4 different

[chromium-dev] Re: Temporarily disable tcmalloc in build

2009-08-02 Thread Mike Belshe
On Sat, Aug 1, 2009 at 10:53 PM, Huan Ren hu...@google.com wrote: - The crash rates on chromebot are comparable for builds with and without tcmalloc. The crash rate for tcmalloc build is higher but it seems within error margin. - Wtih tcmalloc disabled, there are some promising data from

[chromium-dev] Re: Temporarily disable tcmalloc in build

2009-08-02 Thread Mike Belshe
On Sun, Aug 2, 2009 at 11:12 AM, Carlos Pizano c...@google.com wrote: On Sun, Aug 2, 2009 at 10:43 AM, Mike Belshe mbel...@google.com wrote: On Sat, Aug 1, 2009 at 10:53 PM, Huan Ren hu...@google.com wrote: - The crash rates on chromebot are comparable for builds with and without

[chromium-dev] How to add logging support to chromium

2009-07-19 Thread Mike Belshe
I want to log something from within webkit and have it show up in Chrome's log. This seemingly basic operation seems to be unsupported in chromium's version of webkit? First off, WebKit does have WTFLogging facilities (see logging.h and assertions.h) which are similar to our LOG(XXX) faciities.

[chromium-dev] Re: How to add logging support to chromium

2009-07-19 Thread Mike Belshe
On Sun, Jul 19, 2009 at 12:21 AM, Mike Belshe mbel...@google.com wrote: I want to log something from within webkit and have it show up in Chrome's log. This seemingly basic operation seems to be unsupported in chromium's version of webkit? First off, WebKit does have WTFLogging facilities (see

[chromium-dev] Re: How to add logging support to chromium

2009-07-19 Thread Mike Belshe
- thanks for the explanation. sounds like this could work. I misunderstood the comment in the readme. Mike J On Sun, Jul 19, 2009 at 2:11 PM, Mike Belshe mbel...@google.com wrote: Thanks, Jeremy. Are you sure this is right? I don't think so. First, the README in WebKit/api says

[chromium-dev] Re: extensions and memory usage

2009-07-11 Thread Mike Belshe
2-3MB is basically the minimum size. Mike On Fri, Jul 10, 2009 at 6:00 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: How big the V8 heap is? I think that it would be very useful to know how the memory is used inside the extension process. Are there good tools to do that? I heard about

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Mike Belshe
to be the only thing running on the machine. Linus On Thu, Jun 25, 2009 at 4:11 PM, Mike Beltzner beltz...@mozilla.comwrote: On 25-Jun-09, at 7:02 PM, Mike Belshe wrote: This screen actually confuses me a little, as the Summary statistics don't match the summation of the process based statistics

[chromium-dev] Re: Memory usage in chrome

2009-06-26 Thread Mike Belshe
On Thu, Jun 25, 2009 at 4:11 PM, Mike Beltzner beltz...@mozilla.com wrote: On 25-Jun-09, at 7:02 PM, Mike Belshe wrote: This screen actually confuses me a little, as the Summary statistics don't match the summation of the process based statistics. Do you mean to say your summary statistics

[chromium-dev] Re: Memory usage in chrome

2009-06-26 Thread Mike Belshe
On Fri, Jun 26, 2009 at 10:11 AM, Mike Beltzner beltz...@mozilla.comwrote: On 26-Jun-09, at 12:59 PM, Mike Belshe wrote: Overall, though, that should mean that we're *not* double counting memory. In fact, when I observed as the test ran, there were only three processes: one for the browser

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Belshe
On Thu, Jun 25, 2009 at 9:40 AM, Mike Beltzner beltz...@mozilla.com wrote: On 22-Jun-09, at 12:57 PM, Mike Belshe wrote: Yes, that accurately represents the private memory for a process, but it doesn't reflect the user's experience. Windows generally tracks working set. Why? Because

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Belshe
On Thu, Jun 25, 2009 at 3:26 PM, Mike Beltzner beltz...@mozilla.com wrote: On 25-Jun-09, at 12:52 PM, Mike Belshe wrote: Yeah, the APIs all have constraints. We end up walking the pages and adding them up. See process_util_win.cc in the chromium tree. Be sure to check about:memory

[chromium-dev] Re: Memory usage in chrome

2009-06-24 Thread Mike Belshe
On Wed, Jun 24, 2009 at 9:39 AM, Ian Fette i...@chromium.org wrote: +1. Most people are not doing compiles, we're trying to say that people live in the web and in their browser, and that their browser is the primary application. For me at least, that is true. The browser is the app I use the

[chromium-dev] Re: Memory usage in chrome

2009-06-22 Thread Mike Belshe
☆PhistucK On Sun, Jun 21, 2009 at 21:03, Mike Belshe mbel...@google.com wrote: I assume he's not a benchmark pro, but he did a decent job already. We can nitpick his sampling methodology - but it won't change the result. He is correct that many procs is far more memory consuming than

[chromium-dev] Re: Memory usage in chrome

2009-06-22 Thread Mike Belshe
On Mon, Jun 22, 2009 at 9:29 AM, Mike Beltzner beltz...@mozilla.com wrote: On 21-Jun-09, at 10:22 AM, Mike Belshe wrote: Second, the author is basically right. Since he's running on Vista, its a bit hard to tell whether his stats included shared memory or not; using the default memory

[chromium-dev] Re: Memory usage in chrome

2009-06-21 Thread Mike Belshe
On Sun, Jun 21, 2009 at 12:37 AM, n179911 n179...@gmail.com wrote: Hi, There is a test which compares memory usage among rendering engines http://dotnetperls.com/chrome-memory From the site, it shows the maximum memory usage of Chrome is more than Safari is 2 times. Since both of them

[chromium-dev] Re: Memory usage in chrome

2009-06-21 Thread Mike Belshe
I assume he's not a benchmark pro, but he did a decent job already. We can nitpick his sampling methodology - but it won't change the result. He is correct that many procs is far more memory consuming than single proc, and we already knew this. This is a tradeoff we made consciously and

[chromium-dev] Techcrunch What is a browser

2009-06-17 Thread Mike Belshe
This video is great. http://www.techcrunch.com/2009/06/17/yeah-what-is-a-browser-anyway/ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Chromium initial paint delay

2009-06-06 Thread Mike Belshe
Yes it does; this is part of Webkit. See HTMLTokenizer.cpp. Mike On Sat, Jun 6, 2009 at 8:35 PM, Nathan Summer nathan.charles.sum...@gmail.com wrote: Hi, Mozilla has initial paint delay feature, described here: http://kb.mozillazine.org/Nglayout.initialpaint.delay Basically, it delays

[chromium-dev] Re: Question about chromium architecture

2009-06-04 Thread Mike Belshe
On Thu, Jun 4, 2009 at 12:30 AM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: On Wed, Jun 3, 2009 at 11:09 PM, Mike Belshe mbel...@google.com wrote: On Wed, Jun 3, 2009 at 10:40 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: On Tue, Jun 2, 2009 at 5:00 PM, Brett

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Mike Belshe
scripts, which is what I'm trying to teach DOMMap. I'll ping you two with specific questions as they come up. Thanks, Adam On Wed, Jun 3, 2009 at 10:08 PM, Mike Belshe mbel...@google.com wrote: I may be able to help too. I'm very worried about adding more dependencies on it. void* casting

[chromium-dev] vs2008 - sync and sunk today

2009-06-04 Thread Mike Belshe
I've got a clean tree (I think), nuked things over and over again, rebuilt, restarted vs, and all the usual tricks, but the build is completely busted today. I'm getting incessant errors of this form: 2V8CharacterData.cpp 2C:\Program Files (x86)\Microsoft Visual Studio

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Mike Belshe
simpler, but it's not really your problem. Mike - a On Thu, Jun 4, 2009 at 10:00 AM, Mike Belshe mbel...@google.com wrote: Wow - that might get messy. I wonder if use of v8 hidden properties might be useful here. You could potentially add a hidden object to the wrapper. But this may

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-06-04 Thread Mike Belshe
Can we change this so that you have to opt-in to vs2008? I have vs2008 on my system, but I never really wanted to use it for chrome. It's just that gyp automatically switched me to it. The vs2008 build seems to be subject to many more errors than the vs2005 system. I suspect this is due to low

[chromium-dev] Re: V8DOMMap

2009-06-03 Thread Mike Belshe
I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth

[chromium-dev] Re: Destruction of C++ objects attached to V8 objects

2009-05-18 Thread Mike Belshe
On Sat, May 16, 2009 at 12:10 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Sat, May 16, 2009 at 1:27 PM, Mike Belshe mbel...@google.com wrote: You can create a weak reference to the object, and when the object is GC'd in v8, the weak reference handler will get called. Check out

[chromium-dev] Re: Try out --enable-omnibox2!

2009-05-08 Thread Mike Belshe
On Thu, May 7, 2009 at 4:27 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Great! adds a new fresh look. +1 One question though, is the transparency really needed? It distracts me for some reason from the actual results. I suggest lowering down the transparency a little, but that's

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-01 Thread Mike Belshe
On Fri, May 1, 2009 at 1:30 PM, Adam Langley a...@chromium.org wrote: On Fri, May 1, 2009 at 1:23 PM, Mike Belshe mbel...@google.com wrote: It's been a while since I dealt with unix signals; but in the work I did, the common trick was to disable signals on all threads except one

[chromium-dev] Re: Unforking: Canary Bot Lives!

2009-05-01 Thread Mike Belshe
What day would this momentous occasion have occurred if Dimitri hadn't joined Google on Monday August 4, 2008? * * *Thanks for bailing us out, DG!* * * *:-)* * * *Mike* On Fri, May 1, 2009 at 2:38 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: Hello all, This is kind of a momentous

[chromium-dev] Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
We're still using the test-shell to run the LayoutTests.I just fixed a bug, wrote a layout test, and then realized how dumb I was because the code I was testing was only in Chrome, and not in the test_shell. I think we're accumulating a lot of code that is chrome specific, but which could

[chromium-dev] Re: Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
. * We already have a 3% hit due to using v8 extensions (Interval, CSI, etc) which we hadn't detected via automation. Mike On Wed, Apr 29, 2009 at 2:18 PM, Mark Larson (Google) m...@chromium.orgwrote: On Wed, Apr 29, 2009 at 14:05, Mike Belshe mbel...@google.com wrote: We're still using

[chromium-dev] Re: Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
Whoops - I was wrong on this. page cycler tests on the bbots do run chrome now. Bug on making v8::extensions less costly is http://crbug.com/11189 Mike On Wed, Apr 29, 2009 at 3:02 PM, Mike Belshe mbel...@google.com wrote: The more I think about this, the more trouble we might

[chromium-dev] Re: depricating CppBindingClass

2009-04-28 Thread Mike Belshe
the functionality can be replaced by using NPAPI instead. I had an implementation of replacing CppBindingClass by NPAPI in test_shell (to avoid two implementations for JSC and V8), I don't remember where the code went. On Tue, Apr 28, 2009 at 6:15 PM, Mike Belshe mbel...@google.com wrote: I've

[chromium-dev] Turned on tcmalloc

2009-04-22 Thread Mike Belshe
I turned on tcmalloc last night as an experiment. I left it on so far. The good news is the perf: http://build.chromium.org/buildbot/perf/dashboard/overview.html The bad news is the reliability bot shows some crashes. I believe these are crashes not caused by tcmalloc but exposed by it. We'll

[chromium-dev] Re: In process browser tests and singleton shutdown.

2009-04-04 Thread Mike Belshe
Actually, I think its the opposite; the one which bit Ben this week was not a leakysingleton. Actually, the leakysingleton would have worked fine in this case.. He was forcing AtExit to be called, and then statics which held LazyInitPtrs were effectively uninitialized (no bug here, this is a

[chromium-dev] Re: New waterfall Developer View.

2009-03-15 Thread Mike Belshe
Wow - thanks Nicolas! This looks really interesting. I look forward to seeing it in action this week! Mike On Sun, Mar 15, 2009 at 6:54 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello! A lot of people told me that they did not like the waterfall, mainly because it's hard to find

[chromium-dev] Need an idiot's guide to GYP

2009-03-03 Thread Mike Belshe
I probably missed the email on the new Mac build system. (I was gypped!) So I went to http://dev.chromium.org/developers/quick-reference to try to learn how to add a file to the mac port. But alas, it just talks about xcodeproj. And of course, GMail search doesn't work, so I can't find any doc

[chromium-dev] Re: Need an idiot's guide to GYP

2009-03-03 Thread Mike Belshe
The answer to this question lies in the thread Let's make build system history. I've minimally updated the wiki page below. We should expand the gyp docs as it gets more mature. Mike On Tue, Mar 3, 2009 at 11:22 AM, Mike Belshe mbel...@google.com wrote: I probably missed the email on the new

[chromium-dev] Re: Thoughts regarding exposing --single-process, in-process-plugins in release builds

2009-03-02 Thread Mike Belshe
Good find. When there are crashers in the field, we need to squash them, so I don't have any objection to this. It would be nice to leave it enabled for chromium builds, however, since lots of people use it for debugging. Mike On Mon, Mar 2, 2009 at 4:16 PM, John Abd-El-Malek j...@chromium.org

[chromium-dev] Re: Thoughts regarding exposing --single-process, in-process-plugins in release builds

2009-03-02 Thread Mike Belshe
Maybe turn of crash reporting when these flags are enabled? Mike On Mon, Mar 2, 2009 at 4:49 PM, Darin Fisher da...@chromium.org wrote: Wow... we definitely have re-entrancy bugs with --in-process-plugins that are not worth fixing. Command line options like this are, however, kind of nice

[chromium-dev] Re: Thoughts regarding exposing --single-process, in-process-plugins in release builds

2009-03-02 Thread Mike Belshe
, and we should be fixing them instead of spending time supporting multiple modes. On Mon, Mar 2, 2009 at 5:52 PM, Mike Belshe mbel...@google.com wrote: I don't think it is so black and white. If we're going to ignore all crash dumps that have certain cmdline flags anyway, then collecting

[chromium-dev] Re: How To Turn A Friend To A Girlfriend.

2009-02-07 Thread Mike Belshe
So, if we send spam to our own internal email lists, you'll remove us from the list and we'll get less email and get more stuff done? I so wish I were a spammer! Mike On Sat, Feb 7, 2009 at 10:22 AM, Ian Fette i...@chromium.org wrote: sigh, working so much I didn't even see the spam. Thanks

[chromium-dev] Re: using string16

2009-02-04 Thread Mike Belshe
The big string area is webkit, of course. If webkit were 100% UTF-8 already, we might take a different stance on this issue as well. If it is our goal to get to UTF-8 everywhere, then laying the plumbing for utf8 strings rather than string16 strings seems like the right thing to do. Mike On

[chromium-dev] Re: How to returning JavaScript Objects

2009-01-23 Thread Mike Belshe
Try v8_proxy.cc, v8_custom.cc. You may also want to look into the DerivedSources; these are files generated as part of the build which create the bindings between JS and C++. Mike On Fri, Jan 23, 2009 at 12:49 PM, vlad megav...@gmail.com wrote: Can someone one point me to the location in the

[chromium-dev] Re: HTTP BASIC/DIGEST BUG - Has it been fixed yet?

2009-01-05 Thread Mike Belshe
Hi, Hector, Have you filed a bug to be specific about which problem you're having? There is a reasonable chance we're working on it, but let's be specific about what the problem is. If you can provide a repro case, that would be great. Also, we're working on some significant changes to the

[chromium-dev] Re: Proposal: enforcing unit testing in gcl

2009-01-05 Thread Mike Belshe
Sounds great, Pam! I think the gcl command line option to submit without a test should be: gcl upload --i-am-a-test-slacker Mike On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote: We don't have very good unit test coverage (in the broad sense, including ui_tests,

[chromium-dev] Re: quick sort test results

2008-12-16 Thread Mike Belshe
What are you sorting? (can you provide the test?) You could look at about:stats and see if the GC times are going nuts. Or, if you're sorting DOM nodes, it may be that we're getting bogged down with large numbers of JS wrapper creations. Mike On Tue, Dec 16, 2008 at 12:34 PM, Andy

[chromium-dev] Mysterious build errors today

2008-11-26 Thread Mike Belshe
Today my builds mysteriously started failing. When building DerivedSources I get /cygdrive/e/trunk/src/THIRD_~1/WebKit/WebCore/svg/SVGNumberList.idl:1:6 warning: null character(s) ignored lots of these followed by Can't call method fileName without a package or object reference at

[chromium-dev] Re: converting Windows build to SCons

2008-11-14 Thread Mike Belshe
Thanks, Steven for taking care of this so transparently so far! Its hard to comment on, because I'm not sure if I'm yet seeing what it means to build via scons from within VS. Is there a branch where I can test out the new build system before it goes live? mike On Fri, Nov 14, 2008 at 1:12 AM,

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

2008-10-01 Thread Mike Belshe
On Wed, Oct 1, 2008 at 6:35 AM, Marshall Greenblatt [EMAIL PROTECTED]wrote: Hi Mike, On Wed, Oct 1, 2008 at 4:02 AM, Mike Belshe [EMAIL PROTECTED] wrote: You should be able to use v8::Array for this; (see v8.h). Create your array: v8::Localv8::Array array = v8::Array::New(); for (int

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

2008-10-01 Thread Mike Belshe
, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi Mike, On Wed, Oct 1, 2008 at 1:02 PM, Mike Belshe [EMAIL PROTECTED] wrote: Generally, I don't think you should touch the bridge (btw - the bridge is going away as we reconcile differences w/ webkit- it will be the scriptController, I believe

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

2008-09-30 Thread Mike Belshe
Hi, Marshall, I'm not quite sure what you are trying to do; a frame-independent script object is generally something we'd try not to do. I admit, I'm not up to speed with what Gears may have needed to do to support some of its background workers, and maybe that is where you found this call. Are