[chromium-dev] waterfall and memory tests

2010-01-17 Thread Nicolas Sylvain
Hi, The number of memory tests bots has been increasing rapidly recently, and since the main buildbot console view was getting too big and slow, I decided to move the memory tests in their own buildbot master. HOWEVER, this does not indicate in any ways that they are less important. On

Re: [chromium-dev] Red Tree 2010/1/6

2010-01-07 Thread Nicolas Sylvain
On Thu, Jan 7, 2010 at 11:22 AM, James Robinson jam...@google.com wrote: Thanks a lot, Chase. When will it become feasible to run the perf tests as part of the WebKit canary process? We seem to have all the code necessary to catch these regressions at the exact WebKit revision that causes

Re: [chromium-dev] LATEST symlink missing for win builds

2010-01-06 Thread Nicolas Sylvain
On Wed, Jan 6, 2010 at 3:32 PM, Kenneth Russell k...@chromium.org wrote: It looks like the LATEST symlink was deleted out of the directory http://build.chromium.org/buildbot/continuous/win/ . It's there for Mac and Linux. Could someone please take a look? It should be fixed now. Feel free to

Re: [chromium-dev] gcl commit throwing SVN server error

2009-12-04 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 4:03 PM, Dan Kegel d...@kegel.com wrote: If you're a committer, you should have recieved instructions on how to set up your client (it will have an svn rather than an http url) when you got your commit password. Or for new people to the team, your mentor should guide

[chromium-dev] Re: Something smells weird on the buildbot

2009-12-03 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 10:09 AM, Dimitri Glazkov dglaz...@google.comwrote: On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: +chromium-dev as others who look at the waterfall might also be confused. On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov dglaz...@google.com wrote:

[chromium-dev] Re: Something smells weird on the buildbot

2009-12-03 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai o...@chromium.org wrote: On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov dglaz...@google.com wrote: How about we turn red for unexpected crashiness? Makes sense to me. We can just not retry tests that unexpectedly crash. On Thu, Dec 3, 2009

[chromium-dev] GTTF: results. WAS: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-12-02 Thread Nicolas Sylvain
Hi, It looks like our discussion here helped a lot. The tree has never been that green. In the past 6 months, we averaged at about 60-65% tree open during work hours (pacific time). But in the last month, we are at about 85-90%. This is really great! Thanks to all the sheriffs! I attached a

Re: [chromium-dev] [GTTF] running tests that fail most often early in the queue

2009-11-19 Thread Nicolas Sylvain
On Thu, Nov 19, 2009 at 10:48 AM, Paweł Hajdan jr phajdan...@gmail.comwrote: Nicolas, what do you think about applying the reordering to our bots? we should do it. On Thu, Nov 12, 2009 at 20:10, Pam Greene p...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:52 AM, Paweł Hajdan Jr.

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
in through other means in the debug version. No, they do not currently build the release version. Nicolas -atw On Tue, Nov 3, 2009 at 7:30 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Tue, Nov 3, 2009 at 7:46 PM, Kenneth Russell k...@chromium.org wrote: On Tue, Nov 3, 2009 at 6:05

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
On Wed, Nov 4, 2009 at 11:40 AM, Peter Kasting pkast...@google.com wrote: On Tue, Nov 3, 2009 at 6:05 PM, John Abd-El-Malek j...@chromium.orgwrote: But this means that the person didn't use the trybot. I think we need to be harsher on people who commit with changes that didn't complete or

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
On Wed, Nov 4, 2009 at 12:16 PM, Peter Kasting pkast...@google.com wrote: On Wed, Nov 4, 2009 at 12:08 PM, James Robinson jam...@google.com wrote: I don't see who this benefits - assuming that a given patch is broken and needs a small delta to be correct, it's just as easy to submit a patch

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
On Tue, Nov 3, 2009 at 7:08 PM, Ben Goodger (Google) b...@chromium.orgwrote: I am supportive of auto-revert as long as we apply it universally. So many times the tree has been busted forever because of a vacuum of action by the sheriff. Also FYI - the trybots never work for me on my home

[chromium-dev] Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
Hi One of the goal of the Green Tree Task Force was to make reverting a change easy and fast. This is really important to keep the tree green and open. The old saying is Revert now, think later... If a change broke the build and the fix would take more than 1 or 2 minutes to be committed, or if

[chromium-dev] Re: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
that this is still the case. Good point, it should have a way to specify which url it should use to checkout from. by default it uses the internal url. I'll try to find a way to fix that. Nicolas On Tue, Nov 3, 2009 at 1:53 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hi One of the goal

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
On Tue, Nov 3, 2009 at 7:46 PM, Kenneth Russell k...@chromium.org wrote: On Tue, Nov 3, 2009 at 6:05 PM, John Abd-El-Malek j...@chromium.org wrote: But this means that the person didn't use the trybot. I think we need to be harsher on people who commit with changes that didn't complete

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

2009-10-24 Thread Nicolas Sylvain
On Fri, Oct 23, 2009 at 2:16 PM, Andrew Scherkus scher...@chromium.orgwrote: On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Fri, Oct 23, 2009 at 12:21 PM, Andrew Scherkus scher...@chromium.orgwrote: I've never witnessed these tests taking an extra 10

[chromium-dev] Re: revising the output from run_webkit_tests

2009-10-23 Thread Nicolas Sylvain
On Fri, Oct 23, 2009 at 3:43 PM, Dirk Pranke dpra...@chromium.org wrote: If you've never run run_webkit_tests to run the layout test regression, or don't care about it, you can stop reading ... If you have run it, and you're like me, you've probably wondered a lot about the output ...

[chromium-dev] Re: New Tab Cold 20% perf regression on xp-release

2009-10-16 Thread Nicolas Sylvain
On Fri, Oct 16, 2009 at 2:35 PM, Erik Arvidsson a...@chromium.org wrote: The performance for New Tab Cold has regressed without about 20% sometime before rev28918. This seems to be when i changed the hardware where this test is running. Where is the reference build? Nicolas

[chromium-dev] Re: layout test dashboard goofup

2009-10-14 Thread Nicolas Sylvain
On Wed, Oct 14, 2009 at 4:53 PM, Ojan Vafai o...@google.com wrote: The data is stored in a single file per bot. For example, the webkit release bot's results are at http://build.chromium.org/buildbot/layout_test_results/webkit-rel/results.json. That file holds all the historical data for

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

2009-10-13 Thread Nicolas Sylvain
On Tue, Oct 13, 2009 at 10:45 AM, Peter Kasting pkast...@google.com wrote: On Tue, Oct 13, 2009 at 10:43 AM, Dimitri Glazkov dglaz...@chromium.orgwrote: Let's not conflate the two. There are flakes, and there are clearly, consistently failing tests, arriving in chunks every day via WebKit

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
=213 Kind Regards, Anthony Laforge Technical Program Manager Mountain View, CA On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, Today I upgraded buildbot to the latest version. If you have a bookmark for the failures only waterfall, you will need

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
On Sun, Oct 11, 2009 at 6:50 PM, Thomas Van Lenten thoma...@chromium.orgwrote: Looks like the failures link needs to be updated in waterfall header. I'm pretty sure I did, can you show me which one is not updated? TVL On Sat, Oct 10, 2009 at 9:25 PM, Nicolas Sylvain nsylv

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
On Mon, Oct 12, 2009 at 7:58 AM, Thomas Van Lenten thoma...@chromium.orgwrote: On Mon, Oct 12, 2009 at 10:45 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Sun, Oct 11, 2009 at 6:50 PM, Thomas Van Lenten thoma...@chromium.org wrote: Looks like the failures link needs

[chromium-dev] Buildbot upgrade

2009-10-10 Thread Nicolas Sylvain
Hello, Today I upgraded buildbot to the latest version. If you have a bookmark for the failures only waterfall, you will need to change it. Previously it was failures=1 and it is now show_events=truefailures_only=true Other than that, nothing should have changed. If you see any issues with the

[chromium-dev] Re: How to deal with flaky unit tests

2009-10-07 Thread Nicolas Sylvain
at 5:02 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, We currently have more than 50 unit tests that are disabled. Most of them because they were flaky. Disabling tests is bad because we lose complete coverage on them, so I implemented a way to mark tests as flaky. The same way you

[chromium-dev] How to deal with flaky unit tests

2009-10-06 Thread Nicolas Sylvain
Hello, We currently have more than 50 unit tests that are disabled. Most of them because they were flaky. Disabling tests is bad because we lose complete coverage on them, so I implemented a way to mark tests as flaky. The same way you disable a test with DISABLED_ at the beginning of its name,

[chromium-dev] Re: gclient fails to update gyp files

2009-10-01 Thread Nicolas Sylvain
On Tue, Sep 29, 2009 at 11:37 AM, Chris Guillory ctg...@google.com wrote: Dominic and I starting running into this today also. We both don't have the src/native_client directory. And I don't see it listed in the directory list at http://src.chromium.org/svn/trunk/src/. gclient update will

[chromium-dev] src.chromium.org is down

2009-09-29 Thread Nicolas Sylvain
src.chromium.org is down for a few minutes... while we try to fix the disk error. Sorry for the inconvenience, Nicolas --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: src.chromium.org is down

2009-09-29 Thread Nicolas Sylvain
The server has been stable enough in the last 20 minutes, so I think it is fixed now. If you have problems with the server today, please let me know. Thanks Nicolas On Tue, Sep 29, 2009 at 7:45 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: src.chromium.org is down for a few minutes

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Nicolas Sylvain
you need to edit your .gclient and remove the line that says: src/native_client: None Is native_client really required? Why? We don't want to build this by default, do we? it's too big and it does not fit in the tarball, so it has been excluded there. Nicolas On Tue, Sep 29, 2009 at 12:40

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-23 Thread Nicolas Sylvain
On Wed, Sep 23, 2009 at 8:55 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Tue, Sep 22, 2009 at 18:06, Dimitri Glazkov dglaz...@google.comwrote: Today wasn't a happy day for p...@. He did a seemingly innocuous roll that broke the world: selenium, ui tests, layout tests. I am sure it

[chromium-dev] Re: Webkit merges and tree closures

2009-09-23 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 10:47 PM, David Levin le...@chromium.org wrote: Actionable items for keeping the tree green (in addition to blaming the WebKit gardener for [insert action here]): - *Get people putting in chromium patches upstream to run their changes through trybots, etc*. imo,

[chromium-dev] Re: [Green Tree] Week 1

2009-09-22 Thread Nicolas Sylvain
some alert mechanism. Nicolas On Mon, Sep 21, 2009 at 10:31 AM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Sep 21, 2009 at 8:25 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hi chromium-dev, A small group of us joined forces to create a Green Tree task force. The goal

[chromium-dev] Re: debugging the browser started by UI tests

2009-09-22 Thread Nicolas Sylvain
On windows just use windbg, and tell it to attach to child processes. I can show you if you want. Nicolas On Tue, Sep 22, 2009 at 4:10 PM, Scott Violet s...@chromium.org wrote: WAIT_FOR_DEBUGGER_ON_OPEN predates the Linux port. It may work on Linux, I just haven't tried it. -Scott On

[chromium-dev] Webkit merges and tree closures

2009-09-22 Thread Nicolas Sylvain
Hi, In the last few weeks I've been trying to be aware as much as possible about the reasons we close the tree, and my gut feeling seems to match what I'm seeing: Webkit merges is the main cause. Now, I understand that Webkit merges are not easy, and really, kudos to the team for keeping up with

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 6:08 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain nsylv...@chromium.org wrote: If this is an issue, I am proposing that Webkit merges be done outside peak hours (11am-5pm pacific). This seems backwards. Don't we want

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-22 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote: Is this even possible? i.e. I had uploaded a WebKit patch on codereview but none of the patchsets got run on the try server

[chromium-dev] [Green Tree] Week 1

2009-09-21 Thread Nicolas Sylvain
Hi chromium-dev, A small group of us joined forces to create a Green Tree task force. The goal of this task force is to make sure the tree stays green most of the time. The 2 main pain points that we are attacking at this time are reducing the buildbot cycle time, to catch errors earlier, and

[chromium-dev] Re: [Green Tree] Week 1

2009-09-21 Thread Nicolas Sylvain
AM, Nicolas Sylvain nsylv...@chromium.org wrote: Hi chromium-dev, A small group of us joined forces to create a Green Tree task force. The goal of this task force is to make sure the tree stays green most of the time. The 2 main pain points that we are attacking at this time

[chromium-dev] Re: Missing symbols for Chrome 2.0.172.43

2009-09-14 Thread Nicolas Sylvain
Symbols are being copied. If it still does not work for you, let us know. Thanks Nicolas On Mon, Sep 14, 2009 at 10:00 AM, Huan Ren hu...@google.com wrote: On Sat, Sep 12, 2009 at 5:49 PM, yuhong yuhongbao_...@hotmail.com wrote: Yes, notice the symbol path that begins with

[chromium-dev] Re: Argh: Rebuilding installer_util on every F5

2009-09-09 Thread Nicolas Sylvain
+maruel, who changed this code yesterday Nicolas On Wed, Sep 9, 2009 at 5:29 PM, Peter Kasting pkast...@google.com wrote: Somehow, starting today, I'm now rebuilding installer_util (recompiling a half dozen files, which then causes me to relink chrome.dll) every time I hit F5. Deleting

[chromium-dev] Re: Problem with try servers?

2009-08-27 Thread Nicolas Sylvain
On Thu, Aug 27, 2009 at 3:17 AM, Ben Laurie b...@chromium.org wrote: If I do a gcl try, I get prompted for a password for 'ben', which is my login name on my FreeBSD machine. Whatever I enter, the script then hangs - investigation shows that this is because it is prompting for a username,

[chromium-dev] Re: The webkit canary bots, now with performance tests!

2009-08-27 Thread Nicolas Sylvain
And now it is also running test_shell_tests in purify and valgrind: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Webkit+(purify+webkit.org)builder=Webkit+Linux+(valgrind+webkit.org)

[chromium-dev] Splitting up chrome.dll

2009-08-25 Thread Nicolas Sylvain
Hello, In the past a lot of you have asked to split up chrome.dll in multiple DLLs. For this quarter, I had a goal to see how feasible this is. Background information: Breaking up chrome.dll would make linking time faster and use less memory. It would also enforce a cleaner cut between our

[chromium-dev] Re: fighting the test flakiness

2009-08-24 Thread Nicolas Sylvain
phajdan: Feel free to add a link at the top of the waterfall. Maybe beside perf at the top left corner. You just need to edit http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/master.chromium/public_html/announce.html?view=markup

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Nicolas Sylvain
On Mon, Aug 10, 2009 at 10:35 AM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.orgwrote: On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-09 Thread Nicolas Sylvain
Some things to consider: 1. On windows, breakpad used to be wired in test_shell. And I'm pretty sure we used to archive crash dumps for the layout tests too. It should not be hard to do that again. Huan also write a nice script to dump to stdio the crashing stacks of all crashes that happened in

[chromium-dev] Re: flaky compilation of sandbox on Vista

2009-08-07 Thread Nicolas Sylvain
On Fri, Aug 7, 2009 at 11:02 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Example: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Vista%20(dbg)/builds/13568/steps/compile_3/logs/stdio C:\Windows\system32\cmd.exe /c src\third_party\python_24\python_slave.exe

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Nicolas Sylvain
On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet s...@chromium.org wrote: Not sure, perhaps Huan could answer that. That said, --enable-dcheck certainly works on the Chromium release builds from the buildbot: http://build.chromium.org/buildbot/continuous/LATEST/ . Yes, --enable-dcheck is

[chromium-dev] Re: Running UI test in parallel (experimental)

2009-08-06 Thread Nicolas Sylvain
On Thu, Aug 6, 2009 at 1:06 PM, John Abd-El-Malek j...@chromium.org wrote: This is very cool, but I ran into a few problems when I tried to run it: a:\chrome2\src\chrometools\test\smoketests.py --tests=ui You must have your local path of trunk/src/tools/python added to your PYTHONPATH.

[chromium-dev] Re: fighting the flakiness - resource bundle issues?

2009-07-28 Thread Nicolas Sylvain
On Tue, Jul 28, 2009 at 4:37 PM, Evan Martin e...@chromium.org wrote: On Tue, Jul 28, 2009 at 4:35 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: On Tue, Jul 28, 2009 at 16:30, Evan Martin e...@chromium.org wrote: This happens semi-frequently. It's related to the grit resources

[chromium-dev] Re: fighting the flakiness - resource bundle issues?

2009-07-24 Thread Nicolas Sylvain
Tony, just to make sure, are you certain that this is a IB only issue? I used to be convinced that it was happening with visual studio too. If this is a IB only problem, we should create a repro case and send it to them, they are usually really responsive. [For some reasons, I thought it was

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Nicolas Sylvain
On Wed, Jul 22, 2009 at 9:15 PM, Mark Larson (Google) m...@chromium.orgwrote: On Wed, Jul 22, 2009 at 20:27, Dan Kegel d...@kegel.com wrote: Stop me if you've heard this one before. Today, a new directory was added to the source tree, and shortly thereafter was reverted. Should have

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Nicolas Sylvain
On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin e...@chromium.org wrote: On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvainnsylv...@chromium.org wrote: gclient has nothing to do with this case. svn update src/ was trying to add a directory called src/bleh, but src/bleh already existed, so svn

[chromium-dev] Re: FYI: Upcoming O3D integration changes.

2009-07-22 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 4:30 PM, Greg Spencer gspen...@google.com wrote: Hello Chromium Devs, The O3D team is working on getting O3D integrated into the Chromium build, and we're close to being able to complete our first step towards integration: To build the O3D plugin as part of the

[chromium-dev] Re: FYI: Upcoming O3D integration changes.

2009-07-22 Thread Nicolas Sylvain
On Wed, Jul 22, 2009 at 11:47 AM, Greg Spencer gspen...@google.com wrote: On Wed, Jul 22, 2009 at 11:27 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: src/third_party/nixysa/files: why in a subdir called files? A leftover from converting from p4/scons -- I'll remove it. # NACL

[chromium-dev] No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Nicolas Sylvain
Hi, Last week a lot of people on this list said that they like the idea of disabling the auto-reload for our buildbot waterfall and console view. This is now implemented. If you do want to keep the page auto-refreshing, please update your bookmark. just add the query parameter reload=X, where X

[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!

2009-07-21 Thread Nicolas Sylvain
On Mon, Jul 20, 2009 at 5:50 PM, Ben Goodger (Google) b...@chromium.orgwrote: This mostly applies to people working on UI. Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder to the front page of the waterfall. Right now it's building just the chrome target, and running

[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!

2009-07-21 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Can we have a trybot with that configuration, which would just compile the code? I think it would really save people's time. I never build with TOOLKIT_VIEWS, and in case of breakage I would have to immediately

[chromium-dev] Re: No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 11:37 AM, Aaron Boodman a...@chromium.org wrote: Nicolas, Are you going to be turning back on the extension support at any point? If not, just let us know so that we can remove the feature from the sample. Right now it looks broken. Is the reload in the extension

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Nicolas Sylvain
On Fri, Jul 17, 2009 at 7:40 AM, Dan Kegel d...@kegel.com wrote: On Fri, Jul 17, 2009 at 2:34 PM, Thomas Van Lententhoma...@chromium.org wrote: We're already running at -O1 on Linux, so there isn't much improvement left to be had, I suspect. It might be worth it, dunno. There is a lot

[chromium-dev] Re: Code coverage

2009-07-17 Thread Nicolas Sylvain
On Fri, Jul 17, 2009 at 8:39 AM, Scott Violet s...@chromium.org wrote: I'm interested in seeing code coverage. We have a code coverage page (http://build.chromium.org/buildbot/perf/dashboard/coverage.html), but I can't make heads or tails of this. Is there a page that shows coverage per

[chromium-dev] Re: Code coverage

2009-07-17 Thread Nicolas Sylvain
+cc randall, the coverage guru On Fri, Jul 17, 2009 at 10:20 AM, Scott Violet s...@chromium.org wrote: Thanks! Personally I think the overall numbers are the most important, rather than what they are for a build. Any reason we don't drop you into the subdirectory view from the get go?

[chromium-dev] Re: Purify - instrumentation fails on XP Unit (purify) bot

2009-07-16 Thread Nicolas Sylvain
On Thu, Jul 16, 2009 at 1:04 PM, Sverrir Á. Berg sver...@chromium.orgwrote: http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) I cleaned up the machine and restarted it. Sometimes it's enough to make it work. Nicolas

[chromium-dev] Buildbot performance issue.

2009-07-14 Thread Nicolas Sylvain
Hello, We reached a point where we have too many build slaves and too many users to get good performance/latency out of our current buildbot waterfall and console view page. We've been tweaking the page a lot lately to make it faster to load, but the number of new slaves every day, and the

[chromium-dev] Re: Buildbot performance issue.

2009-07-14 Thread Nicolas Sylvain
On Tue, Jul 14, 2009 at 2:25 PM, Evan Martin e...@chromium.org wrote: On Tue, Jul 14, 2009 at 2:18 PM, Nicolas Sylvainnsylv...@chromium.org wrote: The underlying problem with buildbot is the database format, which is just hundred of thousand of files on the harddrive, with no seek

[chromium-dev] Re: [chromium-checkins] r20238 - trunk/tools/buildbot/config/master.chromium.fyi

2009-07-09 Thread Nicolas Sylvain
linux2 there is the platform, as in linux with kernel 2.*. import sys print sys.platform linux2 Nicolas On Thu, Jul 9, 2009 at 12:34 AM, PhistucK phist...@gmail.com wrote: Should this not be changed also? m_webkit_linux_v8_latest = chromium_factory.ChromiumFactory('src/build',

[chromium-dev] Re: running browser_tests on more bots

2009-07-08 Thread Nicolas Sylvain
On Wed, Jul 8, 2009 at 9:42 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: I noticed that browser_tests run on the Chromium XP buildbot, but I couldn't see them on other official (non-FYI) buildbots, and they don't run on trybots. What's blocking us from enabling these tests on more

[chromium-dev] Re: Rev 19669 and WebFrame::GetPrintPageShrink()

2009-07-07 Thread Nicolas Sylvain
On Tue, Jul 7, 2009 at 7:25 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: On Mon, Jul 6, 2009 at 6:28 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Mon, Jul 6, 2009 at 6:09 PM, Darin Fisher da...@chromium.org wrote: I'm not sure what would be best. I was just describing the

[chromium-dev] Re: Clobber third_party/ffmpeg/binaries before syncing

2009-07-07 Thread Nicolas Sylvain
On Tue, Jul 7, 2009 at 9:05 AM, Erik Kay erik...@chromium.org wrote: With a gclient sync this morning, it seems very confused about ffmpeg/binaries. First the sync failed saying that ffmpeg/binaries was from a different repository. Then I removed the directory and did a sync where it pulled

[chromium-dev] Re: WebKit Sheriffing Documentation Update

2009-06-26 Thread Nicolas Sylvain
On Fri, Jun 26, 2009 at 12:10 PM, Amanda Walker ama...@chromium.org wrote: On Fri, Jun 26, 2009 at 2:42 PM, Ojan Vafaio...@chromium.org wrote: For the layout tests steps, why do you we need to build test_shell locally, rebaseline and then add the other platforms to tests_fixable? Can't we

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Nicolas Sylvain
On Thu, Jun 25, 2009 at 7:03 AM, Evan Martin e...@chromium.org wrote: On Thu, Jun 25, 2009 at 6:27 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee de...@chromium.org wrote: I just took a look at what was happening on one of the Linux

[chromium-dev] New waterfall mode for sheriffs

2009-06-25 Thread Nicolas Sylvain
Hello, The console view is not the best for sheriffs since it does not show in details the current state of the tree. The waterfall has always been better for that. But since our waterfall is really big, it can be hard to scroll all the time and keep track of all the failures. For that, I

[chromium-dev] Re: Is it possible to do a gclient sync without running hooks?

2009-06-23 Thread Nicolas Sylvain
On Tue, Jun 23, 2009 at 5:53 PM, Daniel Cowx daniel.c...@gmail.com wrote: When I run gclient sync, it automatically runs the hooks; which causes various non-versioned files to get generated within my tree (most notably *.vcproj and *.sln files, but there may be others). I'd like to be able

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Nicolas Sylvain
On Fri, Jun 19, 2009 at 9:42 AM, Brett Wilson bre...@chromium.org wrote: Our team has had somewhat of an ad-hoc approach to organizing code that's different across platforms. In many cases our approach has been quite good. In others, less so, and there have also been questions about what the

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Nicolas Sylvain
On Fri, Jun 19, 2009 at 11:15 AM, Mike Pinkerton pinker...@chromium.orgwrote: On Fri, Jun 19, 2009 at 2:11 PM, Peter Kastingpkast...@google.com wrote: On Fri, Jun 19, 2009 at 11:07 AM, Nicolas Sylvain nsylv...@chromium.org wrote: We should say that we prefer #if defined(OS_WIN) over

[chromium-dev] Viewvc on src.chromium.org is down

2009-06-18 Thread Nicolas Sylvain
Hello, we've had a couple of problems with viewvc on src.chromium.org in the last day, so I turned it off for now. I'll try to fix it in the next hours. in the mean time you can still use src.chromium.org to fetch your files, and http://src.chromium.org/svn to browse the repo. Thanks Nicolas

[chromium-dev] Re: Viewvc on src.chromium.org is down

2009-06-18 Thread Nicolas Sylvain
back online thanks Nicolas On Thu, Jun 18, 2009 at 10:56 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, we've had a couple of problems with viewvc on src.chromium.org in the last day, so I turned it off for now. I'll try to fix it in the next hours. in the mean time you can

[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?

2009-06-17 Thread Nicolas Sylvain
I filed this bug with this comment:-- TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled it. This is not reproducible outside the buildbot environment. The problem seems to be that chrome cannot access a font. I was not able to determine what the font was. --- Later on I

[chromium-dev] Re: Can I have sandbox/linux?

2009-06-12 Thread Nicolas Sylvain
On Fri, Jun 12, 2009 at 2:48 PM, Adam Langley a...@chromium.org wrote: On Fri, Jun 12, 2009 at 2:40 PM, Nicolas Sylvainnsylv...@chromium.org wrote: In theory sandbox/ should be fetched from DEPS pointing to http://code.google.com/p/rollcage , but since we don't really have a lot of

[chromium-dev] Re: FYI: Layout test failures for audio and video if you don't have FFmpeg dlls

2009-06-12 Thread Nicolas Sylvain
On Fri, Jun 12, 2009 at 4:43 PM, Alpha Lam hc...@chromium.org wrote: (This only applies to Windows, if you are not developing on Windows and you don't care about layout tests, you can stop reading now.) Hi all, I enabled about 150 layout tests for media today, they are mostly sitting

[chromium-dev] Re: No symbols for Google Chrome 2.0.172.30

2009-06-10 Thread Nicolas Sylvain
Looks like it did not. I'll investigate why. thanks Nicolas On Wed, Jun 10, 2009 at 1:00 AM, Dean McNamee de...@chromium.org wrote: Hey Nicolas, Did these symbols ever get uploaded? Thanks On Sun, Jun 7, 2009 at 2:55 AM, yuhongyuhongbao_...@hotmail.com wrote: SYMSRV:

[chromium-dev] Re: build.chromium.org / buildbot downtime - June 7th

2009-06-07 Thread Nicolas Sylvain
On Sat, Jun 6, 2009 at 1:51 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, Sunday June 7th from 10:30 AM PST to 1:30PM PST the buildbot and web server will be moved to a new location. During this time the tree will be closed and http://build.chromium.orgmight be inaccessible

[chromium-dev] Re: build.chromium.org / buildbot downtime - June 7th

2009-06-07 Thread Nicolas Sylvain
On Sun, Jun 7, 2009 at 1:32 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Sat, Jun 6, 2009 at 1:51 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, Sunday June 7th from 10:30 AM PST to 1:30PM PST the buildbot and web server will be moved to a new location. During this time

[chromium-dev] Re: trybots down?

2009-06-07 Thread Nicolas Sylvain
On Sun, Jun 7, 2009 at 5:16 PM, Dan Kegel d...@kegel.com wrote: On Sun, Jun 7, 2009 at 4:41 PM, Nicolas Sylvainnsylv...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/waterfall isn't showing any activity since 2pm, and my jobs aren't showing up or generating email...?

[chromium-dev] Re: trybots down?

2009-06-07 Thread Nicolas Sylvain
Ok, there was another change missing. Now gclient update should work for real! Nicolas On Sun, Jun 7, 2009 at 5:21 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Sun, Jun 7, 2009 at 5:16 PM, Dan Kegel d...@kegel.com wrote: On Sun, Jun 7, 2009 at 4:41 PM, Nicolas Sylvainnsylv

[chromium-dev] Re: chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-06 Thread Nicolas Sylvain
On Sat, Jun 6, 2009 at 10:41 AM, dhhwai dhh...@gmail.com wrote: And also, the script uses this directory: BUILD_BASE_URL = http://build.chromium.org/buildbot/snapshots/ chromium-rel-mac which would seem to be the Mac Chrome *Snapshot* build archive, as opposed to Continuous builds. My

[chromium-dev] build.chromium.org / buildbot downtime - June 7th

2009-06-06 Thread Nicolas Sylvain
Hello, Sunday June 7th from 10:30 AM PST to 1:30PM PST the buildbot and web server will be moved to a new location. During this time the tree will be closed and http://build.chromium.orgmight be inaccessible. Sorry for the inconvenience! Thank you, Nicolas

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-05 Thread Nicolas Sylvain
People were getting the same error when we introduced tcmalloc a long time ago. (40 days ago). the fix was this one : http://codereview.chromium.org/92037 It required a clobber build... When is the last time you synced? Nicolas On Fri, Jun 5, 2009 at 3:58 PM, nakro yoav.zilberb...@gmail.com

[chromium-dev] Re: Collapsed view of our waterfall

2009-06-05 Thread Nicolas Sylvain
On Fri, Jun 5, 2009 at 4:29 PM, Ben Goodger (Google) b...@chromium.orgwrote: It'd be cool if it at least had a URL so one could bookmark it. It sets a cookie. You don't have to set it everytime. But yeah, a flag would be nice too. Nicolas -Ben On Fri, Jun 5, 2009 at 4:27 PM, Eric

[chromium-dev] Re: [linux] nested messageloop patch landed

2009-06-03 Thread Nicolas Sylvain
On Wed, Jun 3, 2009 at 3:25 PM, Lei Zhang thes...@chromium.org wrote: Aren't the bots in virtual machines? Since we're in the middle of some hardware upgrades, perhaps the new host machine isn't as loaded. Would that affect the performance numbers? The first time the blue line dropped it

[chromium-dev] Re: Buildbot is failing, I don't know what to do.

2009-06-02 Thread Nicolas Sylvain
The machines with this error need to be clobbered. I did most of them this afternoon, but looks like I forgot some! Thanks Nicolas On Tue, Jun 2, 2009 at 7:36 PM, Adam Barth aba...@chromium.org wrote: We're working through this on #chromium Adam On Tue, Jun 2, 2009 at 7:29 PM, Mohamed

[chromium-dev] Re: Unittesting python

2009-05-27 Thread Nicolas Sylvain
Usually we use the default unittest framework that comes with python http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/unittests/ http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT_unittest.py?view=markup gclient also has a bunch of tests:

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Nicolas Sylvain
On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) ajw...@chromium.orgwrote: [ +zhanyong ] I chatted with Zhanyong about both swapping out tr1::tuple, and about removing the svn:external reference in the repository. The gmock actions use tr1:tuple as part of the public interface for

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Nicolas Sylvain
2009/5/15 Nicolas Sylvain nsylv...@chromium.org On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: [ +zhanyong ] I chatted with Zhanyong about both swapping out tr1::tuple, and about removing the svn:external reference in the repository. The gmock actions

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Nicolas Sylvain
2009/5/15 Zhanyong Wan (λx.x x) w...@google.com 2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Nicolas Sylvain nsylv...@chromium.org On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: [ +zhanyong ] I chatted with Zhanyong about both

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Nicolas Sylvain
2009/5/15 Zhanyong Wan (λx.x x) w...@google.com 2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Zhanyong Wan (λx.x x) w...@google.com 2009/5/15 Nicolas Sylvain nsylv...@chromium.org: 2009/5/15 Nicolas Sylvain nsylv...@chromium.org On Fri, May 15, 2009 at 12

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Nicolas Sylvain
On Mon, May 11, 2009 at 10:38 PM, Mohamed Mansour m0.interact...@gmail.comwrote: I would say we do it. I would like to see statuses of checkins live. Instead of no sort of notifications in the build bot page other than the auto refresh. I personally like to learn from others on how they do

[chromium-dev] Re: Skia is moving

2009-05-12 Thread Nicolas Sylvain
On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.orgwrote: I'm in the process of updating chromium to use tip-of-tree skia, and in the same CL, moving skia to a third_party directory, retrieved via DEPS. What this means for you: Hi, Why do you want to move it to third

[chromium-dev] Re: Skia is moving

2009-05-12 Thread Nicolas Sylvain
On Tue, May 12, 2009 at 3:05 PM, Stephen White senorbla...@chromium.orgwrote: On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.orgwrote: I'm in the process of updating chromium to use tip

  1   2   >