Chromium developers,
I have just submitted a PRESUBMIT.py for chrome/ which will run
cpplint.py on your change as part of the presubmit process. cpplint is
currently run at reduced strictness--cpplint run separately may
generate more errors[1]. Currently, it only runs it at (gcl/git cl)
upload
To be clear, it'll be a warning prompt on commit, not an error. You
can say (y)es to continue.
M-A
On Tue, Nov 17, 2009 at 2:16 PM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Chromium developers,
I have just submitted a PRESUBMIT.py for chrome/ which will run
cpplint.py on your
On Tue, Nov 17, 2009 at 11:16 AM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Currently, it only runs it at (gcl/git cl)
upload time and only generates warnings. In the future, it should
error at commit time, but I want to put this through a trial period so
please pay attention to
On Tue, Nov 17, 2009 at 11:29 AM, Peter Kasting pkast...@google.com wrote:
There are some unittests where we have super-long bits which go over 80
chars, and there are also some where the linter thinks our indenting is
strange when we do something like:
struct Foo { ... };
Foo foo_cases[] = {
On Tue, Nov 17, 2009 at 11:31 AM, Nico Weber tha...@google.com wrote:
Is cpplint the thing that generates the lint errors column on codereview?
If so, it doesn't work very well for objective-c++ files (.mm) and .h files
that contain objc++ declarations.
The PRESUBMIT.py file only runs on cc
On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin ev...@google.com wrote:
Since we're talking about style, I'll note that this pattern is no
good (and I've seen it explicitly called out somewhere before).
The problem is that your assertions are not helpful. You get
expected 'foo', got 'bar' on
On Tue, Nov 17, 2009 at 20:43, Peter Kasting pkast...@google.com wrote:
On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin ev...@google.com wrote:
Since we're talking about style, I'll note that this pattern is no
good (and I've seen it explicitly called out somewhere before).
The problem is
