On Wed, Jul 22, 2009 at 2:57 PM, Mark Larson (Google) wrote:
> On Wed, Jul 22, 2009 at 14:02, Peter Kasting wrote:
>> On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
>>>
>>> Here comes the bike shedding
>>
>> Yes, Evan already concluded that was where we were.
>>>
>>> RELEASE_NOTES=
>>
>> I
Even though git-cl doesn't have presubmit checks per se, I do like how it
forces your first line to <= 100 characters (rietveld limitation, I
believe).
gcl gets around this issue by truncating your description and adding an
ellipsis.
On Wed, Jul 22, 2009 at 2:52 PM, Darin Fisher wrote:
> On Wed
On Wed, Jul 22, 2009 at 2:02 PM, Peter Kasting wrote:
> On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
>
>> Here comes the bike shedding
>
>
> Yes, Evan already concluded that was where we were.
>
> RELEASE_NOTES=
>>
>
> I thought the conclusion was that people should just write better com
On Wed, Jul 22, 2009 at 14:02, Peter Kasting wrote:
> On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
>
>> Here comes the bike shedding
>
>
> Yes, Evan already concluded that was where we were.
>
> RELEASE_NOTES=
>>
>
> I thought the conclusion was that people should just write better commi
On Wed, Jul 22, 2009 at 2:52 PM, Darin Fisher wrote:
> On Wed, Jul 22, 2009 at 2:02 PM, Peter Kasting wrote:
>
>> On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
>>
>>> Here comes the bike shedding
>>
>>
>> Yes, Evan already concluded that was where we were.
>>
>> RELEASE_NOTES=
>>>
>>
>> I
Bug filed: http://code.google.com/p/chromium/issues/detail?id=17471
On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
> Here comes the bike shedding...but what about this:
> """
>
>
> BUG=
> TEST=
> RELEASE_NOTES=
> """
>
> I don't think any ALL CAPS TEXT at the top is going to make people pu
On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow wrote:
> Here comes the bike shedding
Yes, Evan already concluded that was where we were.
RELEASE_NOTES=
>
I thought the conclusion was that people should just write better commit
messages? Maybe I'm wrong.
I'd almost prefer:
BUG=
TEST=
..
Here comes the bike shedding...but what about this:
"""
BUG=
TEST=
RELEASE_NOTES=
"""
I don't think any ALL CAPS TEXT at the top is going to make people put in
better descriptions. If you want bug to be a url, it should use
crbug.cominstead of the full string, but the convention so far has
been
I'm OK with not having the function list. I can see the advantages of the
webkit approach as it means that comments in the code don't get outdated.
But, then it forces you to look at the changelog history of every line of
code.
Anyways, how about we prepopulate gcl/git-cl change with this text:
DET
On Wed, Jul 22, 2009 at 1:22 PM, Peter Kasting wrote:
> On Wed, Jul 22, 2009 at 1:17 PM, Ojan Vafai wrote:
>
>>
platform/graphics/chromium/FontPlatformDataLinux.cpp:
>>>(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontP
>>> platform/graphics/chromium/FontPlatformDataLinux.cpp:
>>>
>>> (WebCore::FontPlatformData::setHinting):
>>> (WebCore::FontPlatformData::setAntiAlias):
>>> (WebCore::FontPlatformData::setSubpixelGlyphs):
>>> (WebCore::FontPlatformData::setupPaint): Modified to do something super
>>> spec
On Wed, Jul 22, 2009 at 1:17 PM, Ojan Vafai wrote:
>
>>> platform/graphics/chromium/FontPlatformDataLinux.cpp:
>>>
>> (WebCore::FontPlatformData::setHinting):
>>> (WebCore::FontPlatformData::setAntiAlias):
>>> (WebCore::FontPlatformData::setSubpixelGlyphs):
>>> (WebCore::FontPlatformData:
On Wed, Jul 22, 2009 at 12:26 PM, Jeremy Orlow wrote:
> On Wed, Jul 22, 2009 at 11:57 AM, Ojan Vafai wrote:
>
>> This is an understatement. We really do a poor job with commit
>> descriptions. There is a lot to be gained by having better commit
>> descriptions. We can learn from WebKit process h
On Wed, Jul 22, 2009 at 11:57 AM, Ojan Vafai wrote:
> On Wed, Jul 22, 2009 at 10:07 AM, Darin Fisher wrote:
>
>> On Wed, Jul 22, 2009 at 10:03 AM, Adam Langley wrote:
>>
>>> * By having the ChangeLog in the review, reviewers can critique it.
>>>
>>
>>> Many of our commit messages are little bri
14 matches
Mail list logo
