As the team's git fanatic I feel it's my duty to tell you that git
would help with this, but I agree with the commenters who say that
your commits must be reviewed.
The way I use it is a single git branch manages the period between
start typing and think this is ready for review commit, while a
See the hooks section at the bottom of src/DEPS to see what that
runhooks command does.
On Tue, Jun 16, 2009 at 9:17 PM, Daniel Cowxdaniel.c...@gmail.com wrote:
I know that you typically generate the project files via gclient
runhooks --force, but I'm curious to know how to generate the
I'm not sure why, but the git.chromium.org repo was getting some
checksum failures. It stopped updating around 6pm PDT.
I rewound it a bit and restarted its mirroring, and it seems to be ok
now, but you'll find the hashes have changed from around r18522.
I think if you do an ordinary git merge
Skia is already enabled in Chrome. We are not using the GL backend (it's not
really finished). Thanks -- dean On Wed, Jun 17, 2009 at 1:43 PM,
mailandroid wrote: I was looking at the support of skia backend for
rendering (OpenGL/ OpenVG). How and where can we enable these backend in
skia for
I learned git 3 days ago and I actually love it. It is very easy to create
branches and for your big feature you are trying to implement, it is better
to organize it into different milestones. Because in git/chromium world,
every branch can have at most one CL (Change List, Review). So if you
Against that, I sometimes use git to manage breaking reviews up. I'm
always a bit unhappy to get a review which includes one bit of complex
stuff that needs a bunch of back-and-forth, and another few bits of
uncontentious stuff which is easy to +1. I'd rather see those
separately, so that the
To answer some questions I got off-list, it looks like this wasn't
quite sufficient.
git-svn still caches the old hashes and will be confused. It's safe*
to rm -rf .git/svn/ and then try something like git svn find-rev
r18522 just to verify it rebuilds its index.
To completely clobber a
If you blow up svn.bat and python.bat in your depot tools, it will
create 'svn' and 'python' scripts so cygwin will pick them up earlier
(according you ran gclient recently).
But personally, I stay in shape, eat healthy, use svn in cmd and git in cygwin.
M-A
On Tue, Jun 16, 2009 at 1:04 PM,
Given that you'd still need to use the COM-based Scripting Engine API
(like IActiveScriptParse), I'm not sure how much you'd gain. But for
running with cscript.exe, the difference would be appreciable,
depending on how much DOM access you are doing.
Reference:
#1, make sure you have a bug open and a design document
(exampleshttp://dev.chromium.org/developers/design-documents).
Nothing's worse than going off on a long-lived feature expedition and then
returning to trunk to find out people don't want the feature or want some
other design.
#2, work on
tab_restore_uitest.cc:
TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {
// This test is disabled on win2k. See bug 1215881.
I cant find anything about bug 1215881 on
http://code.google.com/p/chromium/issues/list,
where to find it?
Thanks.
On Tue, Jun 16, 2009 at 12:04 PM, pizhu.she...@gmail.com wrote:
tab_restore_uitest.cc:
TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {
// This test is disabled on win2k. See bug 1215881.
I cant find anything about bug 1215881 on
http://code.google.com/p/chromium/issues/list,
where
This video is great.
http://www.techcrunch.com/2009/06/17/yeah-what-is-a-browser-anyway/
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
It made me cry :( it's like jay-walking, but more personal.
2009/6/17 Mike Belshe mbel...@google.com
This video is great.
http://www.techcrunch.com/2009/06/17/yeah-what-is-a-browser-anyway/
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
That comment was removed 4 weeks ago in revision 16206.
In the latest revision 18442, there are comments such as Bug
1230446, Bug 1204135.
Is there any means to view these internal bug reports?
Huan Ren wrote:
Are you looking at the latest version of file tab_restore_uitest.cc? That
comment
Chromium has no behavior whatsoever yet... the feature is utterly
unimplemented thus far... but it will have identical behavior to
safari, iphone, andriod by virtue of the same code base performing
those behaviors... thats the plan at least, and I'm working on the
code now.
Gears (i'm partly
On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote:
In the latest revision 18442, there are comments such as Bug
1230446, Bug 1204135.
Is there any means to view these internal bug reports?
Not directly. What are you trying to do?
I'm trying to find out if it's possible to patch chrome to run on my
old windows 2000 machine.
When I debugging chrome 2.0.172.28, the
Browser::CreateTabContentsForURL sometimes will raise exception.
According to those comments in the source files, the TabUI indeed has
some incompatibility on
This is happening on a new Google Chrome Linux builder on the 'experimental'
waterfall:
http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60
The linux compile fails here:
Linking
On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote:
This is happening on a new Google Chrome Linux builder on the 'experimental'
waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60
On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote:
On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org
wrote:
This is happening on a new Google Chrome Linux builder on the 'experimental'
waterfall:
BTW, the mac script has the same thing (I added the -nt on Mark's
suggestion), but maybe on mac it behaves differently so it's OK. Do we
have a mac builder that's running dump_app_syms?
Michael
On Wed, Jun 17, 2009 at 2:59 PM, Adam Langleya...@chromium.org wrote:
On Wed, Jun 17, 2009 at 2:41
Thanks, for the fix Adam.
On Wed, Jun 17, 2009 at 15:04, Michael Moss mm...@chromium.org wrote:
BTW, the mac script has the same thing (I added the -nt on Mark's
suggestion), but maybe on mac it behaves differently so it's OK. Do we
have a mac builder that's running dump_app_syms?
I'd guess
Sometimes, it's hard to work on a product and actually use it at the
same time. The rapid stop/start cycles aren't exactly conducive to
keeping long-lived activities like your e-mail open. I work on
Chromium, but I surf in Camino, or Safari, or Firefox. Does that
sound familiar? I've worked
On Wed, Jun 17, 2009 at 3:10 PM, Mark Mentovai m...@chromium.org wrote:
Here's what I'm doing: I'm starting my long-lived Chrome (in my case,
an official Google Chrome dev-channel build - ideally it shouldn't be
the executable/bundle you're actively working on) with an alternate
profile by
On closer inspection, it looks like it's a bash vs. dash issue. Our
Linux official builder (gHardy) is using bash (probably the Mac is
too), so the original syntax works. This experimental bot (regular
Hardy) is using dash, so '-nt' fails when the file doesn't exist.
Adam's fix should make both
I filed this bug with this comment:--
TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled
it.
This is not reproducible outside the buildbot environment.
The problem seems to be that chrome cannot access a font. I was not able to
determine what the font was.
---
Later on I
Just a guess, but perhaps when you change languages a new Spellchecker
object with the new language is constructed.
I would expect the language-picking options haven't yet been
implemented. You can also switch languages via the right-click menu
on a text area, but that may also be
The canonical example you should be following here is WebKit on OSX.
Grepping the sourcecode for NSSpellChecker shows usage in
WebKit/mac/WebCoreSupport/WebEditorClient.mm
and WebKit/mac/WebView/WebHTMLView.mm
WebKit/mac/WebCoreSupport/WebEditorClient.mm:638,664 :
NSRange range = [[NSSpellChecker
Yes, Evan is right. So, when you change a spellcheck language in the
Options menu (languages_page_view.cc), it changes a pref member
(prefs::kSpellCheckDictionary) value. This change is caught by the
Profile (ProfileImpl::Observe in profile.cc), which (re)initializes
the spellchecker with the new
Hi all,
As we're seeing an increasing number of people developing extensions
(awesome!), we're creating a new and shiny discussion group for extension
developers. If you're interested in developing extensions, we invite you to
join us at:
Hi all,
**We're excited to see many people are experimenting with the upcoming
extension features of Chrome in the dev channel. We're getting a lot of
great feedback and are working hard to bring extensions to the stable
channel as quickly as possible.
As part of the latest dev channel release,
Oh, ok, so when the language is changed, a new spellchecker object is
created. That's what I thought might be happening. Thanks,
-Paul Wicks
On Wed, Jun 17, 2009 at 5:14 PM, sidchat sidc...@chromium.org wrote:
Yes, Evan is right. So, when you change a spellcheck language in the
Options menu
hi,Evan
You can comment it out and just run gclient sync again. Not sure
why you'd want to pass the --revision flag.
I just wanna use one fixed revision, don't wanna update it everyday. Take that
into consideration, that's easy to fix problems.
Some data used by tests is not in the public
hi, pawel.
It is a bit worrying to me to read most of the tests fail. Do you
encounter more failures?
Yes, about 40% of my chrome's tests(I mean the .exe of tests) fail. And my
revision is r17306. I am wondering why, -_-!
--~--~-~--~~~---~--~~
Chromium Developers
I get a new question here:
I've checked most of chrome's tests, and haven't find a RUN_ALL_TEST() which I
think is necessary for GTest.
simply, the printing_unittests project.
why?
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
Heads up, again, dept.:
In the next in an ongoing series of attempts to convert chrome.exe to gyp,
I'm going to (try to) land two changes now that you should be aware of:
1) convert the 'app' target in the chrome.gyp file to being named 'chrome'.2)
actually convert the 'chrome_exe' project to
37 matches
Mail list logo
