RE: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-03-01 Thread Dan Wilder
AM To: ClamAV Development Subject: Re: [Clamav-devel] One problem in filetype.c in clamav0.90 -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Feb 27, 2007, at 22:28:38, alex wrote: Dears all: I have read the source code of clamav 0.90 and found a strange code in filetype.c

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 alex wrote: Dears all: I have read the source code of clamav 0.90 and found a strange code in filetype.c. There is an expressioniIn 233 line of filetype.c : if(!iscntrl(buf[i]) !isprint(buf[i]) !internat[buf[i] 0xff])

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 11:28:38 +0800 alex [EMAIL PROTECTED] wrote: Dears all: I have read the source code of clamav 0.90 and found a strange code in filetype.c. There is an expressioniIn 233 line of filetype.c : if(!iscntrl(buf[i]) !isprint(buf[i]) !internat[buf[i]

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 11:09:16 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: alex wrote: Dears all: I have read the source code of clamav 0.90 and found a strange code in filetype.c. There is an expressioniIn 233 line of

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 15:21:52 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: I've noticed it too, in my port I have changed it to: if(!(iscntrl(buf[i]) || isprint(buf[i])) || !internat[buf[i] xff]) This one is much worse

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 16:03:08 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 15:21:52 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: I've noticed it too, in my port I have changed it to:

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 16:03:08 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 15:21:52 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote:

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 19:04:43 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: There is a reason if we (clamwin) changed this, we still prefer to skip unknown files, and we don't need to care much about html and mail You don't need to care about HTML? files, so I've made some tweaks (not only

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread aCaB
Gianluigi Tiesi wrote: There is a reason if we (clamwin) changed this, we still prefer to skip unknown files, and we don't need to care much about html and mail files, so I've made some tweaks (not only this one) to save some cpu cycles avoiding scan of unneeded files. I'm aware that for a

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 19:23:32 +0100 aCaB [EMAIL PROTECTED] wrote: Long ago we started implementing a list of types which are always considered not harmful. Unfortunately it seems that no file type is currently safe by default as demonstrated by the gif and jpeg exploits. Maybe we should

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 21:07:42 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: It seams you want flame me, I've only expressed my opinions but not asked you to use my decisions. I think you're still missing the point of this discussion. And the point is that changing the line 233 of

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tomasz Kojm wrote: On Wed, 28 Feb 2007 21:07:42 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: It seams you want flame me, I've only expressed my opinions but not asked you to use my decisions. I think you're still missing the point of this

Re: [Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-28 Thread Tomasz Kojm
On Wed, 28 Feb 2007 22:19:50 +0100 Gianluigi Tiesi [EMAIL PROTECTED] wrote: I think you're still missing the point of this discussion. And the point is that changing the line 233 of libclamav/filetypes.c to if(!(iscntrl(buf[i]) || isprint(buf[i])) || !internat[buf[i] xff]) you seriously

[Clamav-devel] One problem in filetype.c in clamav0.90

2007-02-27 Thread alex
Dears all: I have read the source code of clamav 0.90 and found a strange code in filetype.c. There is an expressioniIn 233 line of filetype.c : if(!iscntrl(buf[i]) !isprint(buf[i]) !internat[buf[i] 0xff]) and this expression would ALWAYS be false. I want to know if i am