Tom Tromey wrote:
>
> The test class is something like:
>
> public class Foo$What { }
>
> The simple name of this is "Foo$What", not "What".
Ahh, *that's* what you're talking about.
Fixed thusly.
Andrew.
2008-05-28 Andrew Haley <[EMAIL PROTECTED]>
* java/lang/Class.java (getSimpl
Andrew> I don't understand where you think the problem lies. As far
Andrew> as I can see the form of a name is guaranteed, and therefore
Andrew> using '$' is OK.
The mangling of inner types and whatnot is specified. So, one
direction is ok. But, a top level type can still have a "$" in its
name
Tom Tromey wrote:
>> "Andrew" == Andrew Haley <[EMAIL PROTECTED]> writes:
>
> Andrew> Yes, but gcj's implementation was also broken. This is the
> Andrew> current gcj code; please let me know if you think it's still
> Andrew> wrong.
>
> I think looking for a "$" in general is wrong. I think i
> "Andrew" == Andrew Haley <[EMAIL PROTECTED]> writes:
Andrew> Yes, but gcj's implementation was also broken. This is the
Andrew> current gcj code; please let me know if you think it's still
Andrew> wrong.
I think looking for a "$" in general is wrong. I think instead the
name should be loo
Tom Tromey writes:
> > "Sebastian" == Sebastian Mancke <[EMAIL PROTECTED]> writes:
>
> Sebastian> Now, the method getSimpleName() is merged with the one of
> Sebastian> glibgcj. (Not changing behaviour, but avoiding recursion)
>
> I noticed it is still different.
> My recollection (I h
Sebastian> GCJ's implementation seems not to handle inner and local classes.
Thanks.
Sebastian> I don't have a good overview of the classpath architecture,
Sebastian> yet. Maybe it would be better to remove the method
Sebastian> getSimpleName() in VMClass.java and implement it directly
Sebastian>
> "Sebastian" == Sebastian Mancke <[EMAIL PROTECTED]> writes:
Sebastian> Now, the method getSimpleName() is merged with the one of
Sebastian> glibgcj. (Not changing behaviour, but avoiding recursion)
I noticed it is still different.
My recollection (I haven't looked at this in a while) is tha
Hi.
Now, the method getSimpleName() is merged with the one of glibgcj. (Not
changing behaviour, but avoiding recursion)
The Testcase has additional checks for array types and is converted to
mauve, now. I could not find regression due to my changes
--Sebastian
Sebastian Mancke schrieb:
>
>
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Mark Wielaard schrieb:
> Hi,
>
> On Thu, 2008-04-17 at 00:50 +0100, Andrew John Hughes wrote:
>> As to your contribution, the Classpath part (i.e. the java.lang.Class
>> changes, Mauve has different contribution rules) looks minor enough to
>> not r
Hi,
On Thu, 2008-04-17 at 00:50 +0100, Andrew John Hughes wrote:
> As to your contribution, the Classpath part (i.e. the java.lang.Class
> changes, Mauve has different contribution rules) looks minor enough to
> not require an assignment, but I'll let Mark (CCed) answer that for
> definite. Howev
On Thu, 2008-04-17 at 00:50 +0100, Andrew John Hughes wrote:
> twisti, we should also maybe port the CACAO test if it's not VM specific?
No, the testcase is not VM specific. IIRC I also encouraged the student
to write the testcase for Mauve, but that does not work all the time :-)
- twisti
On 16/04/2008, Sebastian Mancke <[EMAIL PROTECTED]> wrote:
>
>
> Sebastian Mancke schrieb:
>
> >
> >
> > Christian Thalinger schrieb:
> >> On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote:
> >>> I saw this patch and think it broke the behaviour, because of the wrong
> >>> usage of fu
Sebastian Mancke schrieb:
>
>
> Christian Thalinger schrieb:
>> On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote:
>>> I saw this patch and think it broke the behaviour, because of the wrong
>>> usage of fullName.lastIndexOf(".", pos): The pos argument, counted from
>>> left makes no se
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Christian Thalinger schrieb:
> On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote:
>> I saw this patch and think it broke the behaviour, because of the wrong
>> usage of fullName.lastIndexOf(".", pos): The pos argument, counted from
>> left ma
On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote:
> I saw this patch and think it broke the behaviour, because of the wrong
> usage of fullName.lastIndexOf(".", pos): The pos argument, counted from
> left makes no sense in this method.
>
> Also, I think, that advancing 'pos', dependent on
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Christian Thalinger schrieb:
> On Tue, 2008-04-15 at 23:28 +0200, Sebastian Mancke wrote:
>> Hi,
>>
>> attached is a fix for the method Class.getSimpleName(), together with a
>> small testcase. The old implementation failed on usual class names, as
>
On Tue, 2008-04-15 at 23:28 +0200, Sebastian Mancke wrote:
> Hi,
>
> attached is a fix for the method Class.getSimpleName(), together with a
> small testcase. The old implementation failed on usual class names, as
> well as on inner classes.
>
> Please comment/commit.
This reminds me of this pat
Hi,
attached is a fix for the method Class.getSimpleName(), together with a
small testcase. The old implementation failed on usual class names, as
well as on inner classes.
Please comment/commit.
This is my first direct classpath contribution. Do I need to sign any
copyright assignment?
Regards
18 matches
Mail list logo
