Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v4]

2022-05-10 Thread Prasanta Sadhukhan
On Tue, 10 May 2022 19:03:23 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v4]

2022-05-10 Thread DamonGuy
> The insets for buttons were incorrect for L&Fs except for Aqua when the text > is set to HTML. This was fixed in Aqua by adding a conditional to check for > the BasicHTML property key in the button component. This same logic can be > used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v3]

2022-05-10 Thread DamonGuy
On Tue, 10 May 2022 06:29:47 GMT, Prasanta Sadhukhan wrote: >> DamonGuy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed test summary. Added check for JButton. > > test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTes

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v3]

2022-05-09 Thread Prasanta Sadhukhan
On Mon, 9 May 2022 16:15:48 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-05-09 Thread DamonGuy
On Mon, 9 May 2022 06:04:05 GMT, Prasanta Sadhukhan wrote: >> DamonGuy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed approach to fix. > > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java > line 39

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v3]

2022-05-09 Thread DamonGuy
> The insets for buttons were incorrect for L&Fs except for Aqua when the text > is set to HTML. This was fixed in Aqua by adding a conditional to check for > the BasicHTML property key in the button component. This same logic can be > used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-05-08 Thread Prasanta Sadhukhan
On Wed, 27 Apr 2022 18:52:46 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-04-29 Thread Phil Race
On Wed, 27 Apr 2022 18:52:46 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-04-27 Thread DamonGuy
On Tue, 26 Apr 2022 20:15:20 GMT, Phil Race wrote: >> DamonGuy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed approach to fix. > > src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 271: > >> (failed to retrie

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-04-27 Thread DamonGuy
> The insets for buttons were incorrect for L&Fs except for Aqua when the text > is set to HTML. This was fixed in Aqua by adding a conditional to check for > the BasicHTML property key in the button component. This same logic can be > used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding

2022-04-26 Thread Phil Race
On Tue, 26 Apr 2022 19:42:05 GMT, DamonGuy wrote: > The insets for buttons were incorrect for L&Fs except for Aqua when the text > is set to HTML. This was fixed in Aqua by adding a conditional to check for > the BasicHTML property key in the button component. This same logic can be > used to

RFR: JDK-8282772: JButton text set as HTML content has unwanted padding

2022-04-26 Thread DamonGuy
The insets for buttons were incorrect for L&Fs except for Aqua when the text is set to HTML. This was fixed in Aqua by adding a conditional to check for the BasicHTML property key in the button component. This same logic can be used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not f