On Thu, 28 Oct 2021 03:13:21 GMT, Phil Race wrote:
> Well .. the cursor issue is a suggestion for root cause [*] Do you have any
> other ideas ? I mean other than ...
As noted above our spec mention that the cursor should not be present on the
screenshot, and we use the appropriate native API
> Could you please review the 8275715 bug fixes?
>
> I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing
> PaintEvent. When the validate method is called from createGraphics,
> repaintPeerTarget should not be called.
Masanori Yano has updated the pull request increment
On Sat, 23 Oct 2021 19:40:59 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> src/java.desktop/windows/classes/sun/jav
On Thu, 28 Oct 2021 01:58:33 GMT, Alexander Zuev wrote:
> Creation of component like instantiation?
Yes, every access to the Swing components:
https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/package-summary.html
> That seems to be wrong. We always had the notion of r
On Thu, 28 Oct 2021 08:24:46 GMT, Masanori Yano wrote:
>> src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java
>> line 455:
>>
>>> 453: rq.unlock();
>>> 454: }
>>> 455: } else if (!validate(sd, true))
On Thu, 28 Oct 2021 08:57:34 GMT, Sergey Bylokhov wrote:
> I think that was changed 15 years ago or so somewhere before the release of
> the JDK5 the spec was updated
Ok, i will fix that in this particular test for the sake of getting a closure
on it but it seems wrong to me on so many levels.
Could you please review the 8262297 bug fixes?
In this case, ImageIO.write() should throw java.io.IOException rather than
java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
wrapped in IIOException in ImageIO.write() with this fix. In addition,
IndexOutOfBoundsException
> Moved Swing component modification to the EDT.
> Increased wait time for popup to show up.
> Made checking variabled volatile.
> Generic code cleanup.
> Removed the test from ProblemList.txt
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revi
javax/swing/JMenu/4515762/bug4515762.java is failing in macos12 due to same
root cause as in JDK-8273520 and JDK-8273506 so problemlist it till it is fixed.
-
Commit messages:
- 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
- 8276110: Problemlist javax/
This test does not fail on Windows and does fail on Linux.
After de-iconification we expect to see the button focused:
Actual look:
.
-
PR: https:/
On Thu, 28 Oct 2021 09:29:13 GMT, Masanori Yano wrote:
> Could you please review the 8262297 bug fixes?
>
> In this case, ImageIO.write() should throw java.io.IOException rather than
> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
> wrapped in IIOException in Ima
On Thu, 28 Oct 2021 12:47:10 GMT, Prasanta Sadhukhan
wrote:
> javax/swing/JMenu/4515762/bug4515762.java is failing in macos12 due to same
> root cause as in JDK-8273520 and JDK-8273506 so problemlist it till it is
> fixed.
This pull request has now been integrated.
Changeset: c92f2305
Author
When i reproduced the test failures locally on Ubuntu 18 it seems like AWT Frame
that appeared on the screen had not received focus and keyboard events went to
the
Window Manager which ignored them for having no meaning in the current context.
Added explicit toFront and requestFocus calls so windo
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 09:21:27 GMT, Alexander Zuev wrote:
>>> Creation of component like instantiation?
>>
>> Yes, every access to the Swing components:
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/package-summary.html
>>
>>> That seems to be wrong. We always had
On Thu, 28 Oct 2021 13:24:41 GMT, Alexander Zvegintsev
wrote:
> This test does not fail on Windows and does fail on Linux.
>
> After de-iconification we expect to see the button focused:
> ` when its frame not yet fully
configured, so the obtained button location is shifted by window's height.
Waiting a bit after `setVisible()` call fixes the issue. Some cleanup was made
also. Testing is green on all platforms.
-
Comm
On Thu, 28 Oct 2021 19:30:45 GMT, Sergey Bylokhov wrote:
>> This test does not fail on Windows and does fail on Linux.
>>
>> After de-iconification we expect to see the button focused:
>> ` when its frame not yet
> fully configured, so the obtained button location is shifted by window's
> height.
>
> Waiting a bit after `setVisible()` call fixes the issue. Some cle
> Test trying to call `button.getLocationOnScreen()` when its frame not yet
> fully configured, so the obtained button location is shifted by window's
> height.
>
> Waiting a bit after `setVisible()` call fixes the issue. Some cleanup was
> made also. Testing is green on all platforms.
Alexan
On Thu, 28 Oct 2021 22:32:27 GMT, Sergey Bylokhov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more EDT
>
> test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java
> line 97:
>
>>
On Thu, 28 Oct 2021 22:17:13 GMT, Sergey Bylokhov wrote:
> Confirm that the CGDisplayHideCursor/CGDisplayShowCursor solves the problem
> on my side, I'll prepare the patch. I think it should be backported to all
> old trains.
Well .. if you think that's what's needed I suggest you ask the fixe
On Fri, 29 Oct 2021 03:49:04 GMT, Phil Race wrote:
> Well .. if you think that's what's needed I suggest you ask the fixer if
> they'd prefer to do that themselves first as the owner of this issue.
This issue is broader than the cursor, not sure that the test which needs a
"tolerance" will be
On Fri, 29 Oct 2021 01:24:41 GMT, Alexander Zvegintsev
wrote:
>> Test trying to call `button.getLocationOnScreen()` when its frame not yet
>> fully configured, so the obtained button location is shifted by window's
>> height.
>>
>> Waiting a bit after `setVisible()` call fixes the issue. Som
On Fri, 29 Oct 2021 03:49:04 GMT, Phil Race wrote:
> Regardless, there's value in the test updates, although my existing comments
> on the specifics there still stand.
Should I pursue with the test updates with this PR as it seems it can be
addressed by product change? I am not sure what speci
On Thu, 28 Oct 2021 19:27:31 GMT, Sergey Bylokhov wrote:
>>> I think that was changed 15 years ago or so somewhere before the release of
>>> the JDK5 the spec was updated
>>
>> Ok, i will fix that in this particular test for the sake of getting a
>> closure on it but it seems wrong to me on so
On Fri, 29 Oct 2021 04:31:29 GMT, Sergey Bylokhov wrote:
> This issue is broader than the cursor, not sure that the test which needs a
> "tolerance" will be fixed by the hidden cursor. So the cursor is a separate
> part and could be fixed and especially tested separately. I am still not sure
>
On Fri, 29 Oct 2021 05:23:39 GMT, Phil Race wrote:
> Broader ? Please expand since the change you suggest is only about the cursor
This issue JDK-8276058 is broader than the cursor, related, this is why I would
like to exclude it from it.
> The test part of the fix has multiple stability impro
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote:
> At the time Java supported applets and webstart, a special mechanism for
> launching various applications in one JVM was used to reduce memory usage and
> each application was isolated from each other.
>
> This isolation was implemented
On Fri, 29 Oct 2021 05:10:29 GMT, Alexander Zuev wrote:
>> We did not change the behavior of the Swing, it works the same before and
>> after that spec update. That tests were broken from the beginning and this
>> is why they are unstable, and this is why the requirements were changed.
>
> You
On Mon, 27 Sep 2021 03:33:52 GMT, Sergey Bylokhov wrote:
> This test depends on the next windows UI performance option:
> “Show window contents while dragging”, see
> https://answers.microsoft.com/en-us/windows/forum/all/in-windows-7-how-do-i-show-window-contents-while/18e3aee2-bcc7-4005-a45d-c5
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote:
> - The hand-crafted methods for addition and multiplication are replaced by
> the "Math" versions.
> - Cleanup: the usage of do/while(false) is removed
not now
-
PR: https://git.openjdk.java.net/jdk/pull/
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote:
> In JDK 9 the native code for the robot class was reworked to get an access to
> the HiDPI quality screenshots. So we allocate the data storage for the HiDPI
> quality and then request the best quality from the macOS.
>
> It works fine i
On Thu, 14 Oct 2021 05:43:53 GMT, Sergey Bylokhov wrote:
> The PrintServiceLookupProvider can spawn 2 threads on WIndows and one thread
> on Linux. These threads are connected to the classloader of the web
> application. During undeployment the app classloader gets removed together
> with the
On Fri, 29 Oct 2021 04:43:10 GMT, Prasanta Sadhukhan
wrote:
> > Regardless, there's value in the test updates, although my existing
> > comments on the specifics there still stand.
>
> Should I pursue with the test updates with this PR as it seems it can be
> addressed by product change?
Ye
On Fri, 29 Oct 2021 05:49:27 GMT, Phil Race wrote:
> So your assumption is the cursor is an arrow. It could be an X .. in which
> case your fix won't work of ots
Can't we add instructions additionally similar to what we have in our test wiki
to only have default arrow cursor. Also, since it is
On Fri, 29 Oct 2021 05:38:55 GMT, Sergey Bylokhov wrote:
> but there are suspicious cases like using tolerance.
We have same test failure in macos-aarch64 in JDK-8266245 and I guess tolerance
level of 5 should not be an issue. I was told earlier tolerance level of upto
15 should be acceptable.
On Fri, 29 Oct 2021 05:38:55 GMT, Sergey Bylokhov wrote:
> > Broader ? Please expand since the change you suggest is only about the
> > cursor
>
> This issue JDK-8276058 is broader than the cursor, related, this is why I
> would like to exclude it from it.
Still not explained. Broader why ?
>
On Fri, 29 Oct 2021 05:49:34 GMT, Prasanta Sadhukhan
wrote:
> We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> tolerance level of 5 should not be an issue. I was told earlier tolerance
> level of upto 15 should be acceptable..
I do not like the tolerance approaches in g
On Wed, 27 Oct 2021 00:52:10 GMT, Alexander Zuev wrote:
> The problem here is that due to the approximation of the coordinates when
> converting
> to and from screen cordinate system on screen with 125% magnification
> two things can happen:
> 1. New mouse position calculated can be 149/149 whi
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had following log
>
> --System.out:(1/75)--
> color
On Fri, 29 Oct 2021 06:00:54 GMT, Sergey Bylokhov wrote:
> > We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> > tolerance level of 5 should not be an issue. I was told earlier tolerance
> > level of upto 15 should be acceptable..
>
> I do not like the tolerance approache
On Fri, 29 Oct 2021 06:06:31 GMT, Phil Race wrote:
>
>
> > > We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> > > tolerance level of 5 should not be an issue. I was told earlier tolerance
> > > level of upto 15 should be acceptable..
> >
> >
> > I do not like the tole
On Fri, 29 Oct 2021 05:56:06 GMT, Phil Race wrote:
> I pointed that out earlier .. even before you raised the cursor size issue.
Missed that, and still cannot find it by searching the discussion above, I
probably need to rest
-
PR: https://git.openjdk.java.net/jdk/pull/6140
On Fri, 29 Oct 2021 05:49:27 GMT, Phil Race wrote:
>
>
> Shouldn't this use TESTCLASSES or something like that ?
>
> We have used the same way of ImageIO.write() in jtreg tests
>
> OK ..doesn't mean its right please check with jtreg devs etc ..
If it's not right, then we have to
On Fri, 29 Oct 2021 06:11:28 GMT, Sergey Bylokhov wrote:
>
>
> > I pointed that out earlier .. even before you raised the cursor size issue.
>
> Missed that, and still cannot find it by searching the discussion above, I
> probably need to rest
It was added as part of https://bugs.openjdk.jav
58 matches
Mail list logo
