On Wed, 20 Apr 2022 13:28:17 GMT, Manukumar V S wrote:
>> These dnd tests fails with a time out intermittently in some machines(mostly
>> Windows 11) which creates frequent noise in CI.
>> 1. java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java
>> 2. java/awt/dnd/DropTargetEnterExit
> Create an automated test for
> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
> AccessibleValue implementation only accept Integers
> The AccessibleValue implementations of the following components:
>
> java.awt.Scrollbar
> javax.swing.AbstractButton
> javax.swing.JInternalFram
On Fri, 22 Apr 2022 18:02:47 GMT, Alisen Chung wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Comments Fixed: Simplified test code with a loop over the
>> JComponents being tested.
>
> test/jdk/javax
On Mon, 25 Apr 2022 08:15:18 GMT, Toshio Nakamura wrote:
>> Japanese logical fonts are drawn with wrong size since Java 18.
>> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration`
>> (and `sun.awt.windows.WFontConfiguration`) seems to expect the native
>> encoding instead of
On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.desktop/macosx/classes/com/apple/laf/A
The insets for buttons were incorrect for L&Fs except for Aqua when the text is
set to HTML. This was fixed in Aqua by adding a conditional to check for the
BasicHTML property key in the button component. This same logic can be used to
fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not f
On Tue, 26 Apr 2022 19:42:05 GMT, DamonGuy wrote:
> The insets for buttons were incorrect for L&Fs except for Aqua when the text
> is set to HTML. This was fixed in Aqua by adding a conditional to check for
> the BasicHTML property key in the button component. This same logic can be
> used to
On Tue, 26 Apr 2022 01:44:45 GMT, lawrence.andrews
wrote:
> 1) Removed yesno since test was failing with parser error due to @run
> main/manual=yesno
> 2) User can't decide whether it as pass or fail after looking into the
> printout so add the PassFailJFrame support
>
> @shurymury
> @aivan
On Mon, 25 Apr 2022 22:36:59 GMT, lawrence.andrews
wrote:
> 1) Removed yesno to eliminate parserException
> 2) Added code to fit into manual framework so that timeout, pass & fail is
> handled.
> 3) Added code to mark the test as pass if printer service is not available
> 4) Added code to handl
On Fri, 22 Apr 2022 21:57:23 GMT, Alexander Zuev wrote:
>> Clean up imports;
>> Close and dispose frame before exiting the test;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use one tyr/catch instead of two
> Generic
On Fri, 22 Apr 2022 19:41:44 GMT, Alisen Chung wrote:
> Added a background to the test to prevent the file from dragging onto the
> desktop and creating an extra file.
This pull request has now been integrated.
Changeset: 102a305f
Author:Alisen Chung
Committer: Phil Race
URL:
http
On Fri, 22 Apr 2022 17:38:28 GMT, Alisen Chung wrote:
> Removed passing tests from problem list
This pull request has now been integrated.
Changeset: dbcf3893
Author:Alisen Chung
Committer: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/dbcf38932ef4f87b560ec660851368ac5697f
On Thu, 21 Apr 2022 17:15:20 GMT, Phil Race wrote:
> This fix moves a closed test to open but updated to be more comprehensive in
> testing multiple pipelines and with some stabilisation improvements.
This pull request has now been integrated.
Changeset: 110edd99
Author:Phil Race
URL:
On Thu, 21 Apr 2022 22:03:17 GMT, Alexander Zuev wrote:
> Clean up imports;
> Close and dispose frame before exiting the test;
This pull request has now been integrated.
Changeset: e574cc0e
Author:Alexander Zuev
URL:
https://git.openjdk.java.net/jdk/commit/e574cc0e2b3330daf7494b809a
> Clean up imports;
> Close and dispose frame before exiting the test;
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Merge branch 'master' into JDK-8196367
- Use one tyr/catch instead of two
Gener
> Detect the situation where we do need to perform interpolation during
> ImageIcon
> painting and set a hint to the rendering to perform bicubic approximation so
> image details are preserved during transition.
Alexander Zuev has updated the pull request incrementally with one additional
commit
On Tue, 26 Apr 2022 22:06:09 GMT, Alexander Zuev wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has u
On Wed, 16 Mar 2022 05:36:04 GMT, Sergey Bylokhov wrote:
>>> This might be a rookie question:
>>>
>>> When it comes to modifying and restoring a Graphics, I've seen two common
>>> patterns: A. Call `newG = g.create()` and later `newG.dispose()` B. Call
>>> `g.setX(newValue)` and then call `g.s
On Tue, 26 Apr 2022 22:06:09 GMT, Alexander Zuev wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has u
To enable more complete doclint checking (courtesy @jonathan-gibbons), please
review this PR to add type-level @param tags where they are missing.
To the maintainers of java.util.concurrent, those changes could be separated
out in another bug if that would ease maintenance of that code.
Making
> 1) Removed yesno to eliminate parserException
> 2) Added code to fit into manual framework so that timeout, pass & fail is
> handled.
> 3) Added code to mark the test as pass if printer service is not available
> 4) Added code to handle pressing or clicking of 'Cancel' button.
>
> @shurymury
>
On Tue, 26 Apr 2022 22:23:55 GMT, Alexander Zuev wrote:
> Yes, the issue manifests itself only on Windows - but i was able to reproduce
> it using generic MultiResolutionIcon in the test case so while it CAN be
> fixed in the Windows specific code i still think addressing it in the shared
> co
On Tue, 19 Apr 2022 21:03:13 GMT, Harshitha Onkar wrote:
> The exisiting manual test case tests different html styles of JTabbedPane tab
> title. The tab with "big" as title is seen to be clipped on Aqua LAF for
> larger font-size. In other LAFs it is observed that bigger font-size can be
> ac
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in an
On Tue, 26 Apr 2022 22:46:47 GMT, Sergey Bylokhov wrote:
> Fixing it in the ImageIcon is similar to fixing it by changing internal
> default state of the rendering pipeline in any other places like
> images/graphics/fonts, while we have to change that state "externally". We
> have to set BICUB
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in an
On Sat, 23 Apr 2022 07:21:51 GMT, Alexander Zuev wrote:
> Ok, starting from the beginning - there is no possibility to press the
> Function key with Robot, the corresponding key code (OSX_Function - 0x3F) has
> not mapped to any of the keys available to Robot. Function key does not act
> like
On Tue, 26 Apr 2022 23:22:18 GMT, Alexander Zuev wrote:
> We are setting the BICUBIC only in place where we draw the image part of
> ImageIcon. There is no benefit in pushing this change down the pipeline.
We don't need to push change down to the pipeline, we should push it up to the
place whe
1) Fixed Parser error by removing yesno from @run main/manual=yesno
2) Used PassFaileJFrame to show the test instruction to the user instead of
printing the test instruction on the console or jtreg log file.
3) If printer is not configured then mark the test as passed.
@shurymury
@aivanov-jdk
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in an
On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare,
On Tue, 26 Apr 2022 23:49:26 GMT, Sergey Bylokhov wrote:
> That description is very helpful, thank you. Based on that it looks like this
> is a bug in the macOS, did we report it to the Apple?
No, we did not. I probably will but it is unlikely it will be addressed quickly
so fixing this issue
On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.desktop/macosx/classes/com/apple/laf/A
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a lighter focus ring color by changing
> saturation and setting brightness component to 100% of original focus ring
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a lighter focus ring color by changing
> saturation and setting brightness component to 100% of original focus ring
On Thu, 14 Apr 2022 21:12:07 GMT, Alisen Chung wrote:
> test passes, so removing from problem list
This pull request has now been integrated.
Changeset: cc89f1bc
Author:Alisen Chung
Committer: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/cc89f1bc618c6199030bd7cd1df050a175
On Sat, 23 Apr 2022 14:34:58 GMT, XenoAmess wrote:
>> These are the changes that too many to be reviewed in 8186958, thus split
>> some of them out.
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - maintains compatibility wi
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan
wrote:
> Test was failing in the past owing to NPE while accessing JMenu probably
> owing to fact the test did not wait for UI to be visible before starting the
> test, so added a delay after the frame is made visible. Also, added disposal
On Wed, 27 Apr 2022 04:36:37 GMT, Phil Race wrote:
> I'm getting a bit tired of seeing these JDK wide changes with lots of files
> touched.
@prrace
I'm also a bit tired of seeing so many amazing mis-use in existed codes in jdk.
In some place I even see somebody creates a HashMap with factor
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan
wrote:
> Test was failing in the past owing to NPE while accessing JMenu probably
> owing to fact the test did not wait for UI to be visible before starting the
> test, so added a delay after the frame is made visible. Also, added disposal
On Wed, 27 Apr 2022 04:36:27 GMT, Harshitha Onkar wrote:
>> Previously while tabbing through the JTable cell, the cell highlighter/focus
>> ring was not visible against the selection background.
>>
>> Changes are made to Aqua LAF to derive a lighter focus ring color by
>> changing saturation
41 matches
Mail list logo
