ew
> commit since the last revision:
>
> Unused imports removed
https://mach5.us.oracle.com/mdash/jobs/Tejesh-jdk-20220603-0433-33053953?search=result.status:PASSED
-
PR: https://git.openjdk.java.net/jdk/pull/8952
On Tue, 31 May 2022 08:14:14 GMT, Tejesh R wrote:
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the
Test is failing in iMac CI systems owing to color difference of 1
`x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
Added minor color tolerance check. CI testing is green
-
Commit messages:
- 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed
Changes: https://git.openjdk.jav
On Fri, 3 Jun 2022 03:47:14 GMT, Prasanta Sadhukhan
wrote:
> However, there are some observations in the JBS by @prrace regarding the test
> which have not been handled
>
> ```
> Also I noticed that the test doesn't exit. It appears that the call to
>
> Desktop.getDesktop().setDefaultMenuBar(
> This test was failing consistently on same machines and at the same time as
> #8532.
>
> Test failure is also no longer reproducible after #8320 fix.
>
> This is macOS only test, so corresponding `@requires os.family` tag was
> added. Testing is green.
Alexander Zvegintsev has updated the pu
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
> The NSAccessibilityShouMinuAction action does not show the menu for the text
> element.
> Steps to reproduce:
> 1. redefine the accessible context with the addition of the toggle popup
> action;
> 2. run on macOS with VoiceOver enabled;
> 3. try to call the context menu in the editor by pre
On Fri, 3 Jun 2022 05:41:24 GMT, Sergey Bylokhov wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Just a small nit, can we use the same style of instructions, the previous
>> tests use a separate text to press the
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
Sorry for the confusion, "maxp" being absent was only my assumption:
`CTFontCopyTable` re
On Fri, 3 Jun 2022 05:30:10 GMT, Sergey Bylokhov wrote:
> Currently, the logging of the J2DBench differs from run to run. Each time the
> order of the parameters is random.
>
> For example:
> First run: `with to Default Frame, bounce, 1x1, SrcOver, ident, !extraalpha,
> !xormode, !clip, Defaul
On Thu, 2 Jun 2022 08:14:23 GMT, Manukumar V S wrote:
>> This test verifies that dragging from one InternalFrame and a drop target in
>> another InternalFrame functions properly.
>> This fix moves an unstable closed applet based test to open regression based
>> java test, but updated to be more
On Thu, 2 Jun 2022 08:11:20 GMT, Manukumar V S wrote:
>> test/jdk/java/awt/dnd/DropTargetInInternalFrameTest.java line 244:
>>
>>> 242: private final Dimension preferredDimension = new
>>> Dimension(200, 100);
>>> 243: private final CountDownLatch dropLatch;
>>> 244: pri
On Fri, 3 Jun 2022 15:04:02 GMT, Tejesh R wrote:
>> In order to get the updated data all the time, as this variable will be
>> updated from EDT and the value will be read from main thread also.
>
> I meant was it causing an issue in the previous test (before updating the
> test)?
I think this
On Fri, 3 Jun 2022 10:27:20 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Thu, 2 Jun 2022 09:14:30 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Fri, 3 Jun 2022 05:42:38 GMT, Tejesh R wrote:
> I see that the bug description has a test case which produce this exception.
> There are these lines on the stack:
>
> ```
> at
> sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:116)
> at java.awt.Container.paint
On Fri, 3 Jun 2022 15:21:02 GMT, Alexey Ivanov wrote:
> > I think that the rendering to the BufferedImage as suggested by
> > @aivanov-jdk should work as well.
>
> In theory only. I was unable to make the table paint with its header to
> `BufferedImage`. The component isn't laid out until it's
Add try/catch clause to ignore an exception since it is harmless for we isolated
the massge data before passing it ro processor.
Add test case.
-
Commit messages:
- 8282578: AIOOBE in javax.sound.sampled.Clip
Changes: https://git.openjdk.java.net/jdk/pull/9016/files
Webrev: https:/
On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Fri, 3 Jun 2022 15:43:39 GMT, Alexander Zuev wrote:
> Add try/catch clause to ignore an exception since it is harmless for we
> isolated
> the massge data before passing it ro processor.
> Add test case.
@azvegint @prrace please review
-
PR: https://git.openjdk.java.net/jdk/pul
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- don't reset transform if it contains a non-scale transformation
- updated test
-
On Thu, 2 Jun 2022 15:32:11 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespaces
Except for the minor comments, it looks good now.
te
On Thu, 2 Jun 2022 21:48:07 GMT, Sergey Bylokhov wrote:
>>> BTW I think that the usage of
>>> `return icons.toArray(EMPTY_TRAY_ARRAY);`
>>> is slower than any of other cases: presized or zero. So if we would like to
>>> use a similar pattern the zero version is better.
>>
>> Why is it? It's the
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with two
On Tue, 24 May 2022 16:54:55 GMT, Alisen Chung wrote:
> Removed stacktrace from WClipboard
Marked as reviewed by dnguyen (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/8871
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
On Fri, 3 Jun 2022 18:51:40 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - don't reset transform if it
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
Marked as reviewed by prr (Reviewer).
oh my gosh .. it is a font designed for PRE-macOSX
On Fri, 3 Jun 2022 10:35:22 GMT, Artem Semenov wrote:
>> The NSAccessibilityShouMinuAction action does not show the menu for the text
>> element.
>> Steps to reproduce:
>> 1. redefine the accessible context with the addition of the toggle popup
>> action;
>> 2. run on macOS with VoiceOver en
On Thu, 26 May 2022 11:43:07 GMT, Martin Desruisseaux
wrote:
> As a minor note, in `com.sun.imageio.plugins.common.ReaderUtil` class the
> `readMultiByteInteger(ImageInputStream)` method is used only by
> `WBMPImageReader`. Would it be worth to move (in a separated pull request)
> that method
On Fri, 3 Jun 2022 15:43:39 GMT, Alexander Zuev wrote:
> Add try/catch clause to ignore an exception since it is harmless for we
> isolated
> the massge data before passing it ro processor.
> Add test case.
Probably it is better to check the data length for each sys message and discard
it if t
On Fri, 13 May 2022 12:23:24 GMT, Martin Desruisseaux
wrote:
> Invoking `ImageReaderSpi.canDecodeInput(Object)` with a stream having less
> than 8 bytes causes an `EOFException` to be thrown instead of returning
> `false`. This is caused by BMP, WBMP, GIF, PNG and TIFF reader
> implementation
On Fri, 3 Jun 2022 15:43:39 GMT, Alexander Zuev wrote:
> Add try/catch clause to ignore an exception since it is harmless for we
> isolated
> the massge data before passing it ro processor.
> Add test case.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/j
On Fri, 27 May 2022 20:48:30 GMT, Alexey Ivanov wrote:
>> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
>> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>>
>> **SystemTray**: removed redundant initialisers; replaced sized array with
>
On Thu, 21 Apr 2022 15:54:02 GMT, Srinivas Mandalika
wrote:
> Create an automated test for
> [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233)
>
> Several new AccessibleRole and AccessibleRelation constants are needed in
> those classes in the java.accessibility package. These n
On Fri, 3 Jun 2022 05:30:10 GMT, Sergey Bylokhov wrote:
> Currently, the logging of the J2DBench differs from run to run. Each time the
> order of the parameters is random.
>
> For example:
> First run: `with to Default Frame, bounce, 1x1, SrcOver, ident, !extraalpha,
> !xormode, !clip, Defaul
On Thu, 2 Jun 2022 16:07:37 GMT, Artem Semenov wrote:
> The NSAccessibilityShouMinuAction action does not show the menu for the text
> element.
> Steps to reproduce:
> 1. redefine the accessible context with the addition of the toggle popup
> action;
> 2. run on macOS with VoiceOver enabled;
On Thu, 21 Apr 2022 10:51:18 GMT, Srinivas Mandalika
wrote:
> Create an automated test for
> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286)
>
> AccessibleJTable.setAccessibleSelction should select rows/cols when cell
> selection.
> When cell selection is not enabled, there is
On Fri, 3 Jun 2022 05:13:25 GMT, Alexander Zuev wrote:
>>> I still do not see a reason why we cannot request the exact size of the
>>> image from the windows, so if the small icon and the screen scale is 1.25
>>> we can try to extract 20x20
>>
>> Because for some files - and we can not predict
On Fri, 3 Jun 2022 21:46:29 GMT, Sergey Bylokhov wrote:
>>> But can we use it as a backup if the system does not return the expected
>>> size on the initial/current call?
>>
>> No, because in case when current implementation returns bad results this
>> function also returns incorrect results s
On Sat, 30 Apr 2022 18:58:56 GMT, Andrey Turbanov wrote:
> `sun.awt.ExtendedKeyCodes#regularKeyCodesMap` contains only non-null values.
> It means we can replace containsKey+get with get+null check.
> It's clearer and a bit faster.
Marked as reviewed by prr (Reviewer).
-
PR: https
On Thu, 2 Jun 2022 08:14:23 GMT, Manukumar V S wrote:
>> This test verifies that dragging from one InternalFrame and a drop target in
>> another InternalFrame functions properly.
>> This fix moves an unstable closed applet based test to open regression based
>> java test, but updated to be more
Hi all,
Please review this trivial change which fixes the compile failure of
AccessiblePropertiesTest.java .
Thanks.
Best regards,
Jie
-
Commit messages:
- 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to
compile
Changes: https://git.openjdk.java.net/j
On Sat, 4 Jun 2022 00:40:19 GMT, Jie Fu wrote:
> Hi all,
>
> Please review this trivial change which fixes the compile failure of
> AccessiblePropertiesTest.java .
> Thanks.
>
> Best regards,
> Jie
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR:
On Sat, 4 Jun 2022 00:40:19 GMT, Jie Fu wrote:
> Hi all,
>
> Please review this trivial change which fixes the compile failure of
> AccessiblePropertiesTest.java .
> Thanks.
>
> Best regards,
> Jie
This pull request has now been integrated.
Changeset: 005a3303
Author:Jie Fu
URL:
On Sat, 4 Jun 2022 02:42:37 GMT, Daniel D. Daugherty wrote:
> Thumbs up. This is a trivial fix.
Thanks @dcubed-ojdk for your review.
-
PR: https://git.openjdk.java.net/jdk/pull/9027
On Tue, 17 May 2022 15:52:03 GMT, Manukumar V S wrote:
> This test verifies that dragging from one InternalFrame and a drop target in
> another InternalFrame functions properly.
> This fix moves an unstable closed applet based test to open regression based
> java test, but updated to be more co
48 matches
Mail list logo
