On Fri, 3 Jun 2022 10:06:21 GMT, Alexander Zvegintsev
wrote:
>> This test was failing consistently on same machines and at the same time as
>> #8532.
>>
>> Test failure is also no longer reproducible after #8320 fix.
>>
>> This is macOS only test, so corresponding `@requires os.family` tag wa
On Tue, 7 Jun 2022 04:15:49 GMT, Sergey Bylokhov wrote:
> This is an update of the test which was de-problemlisted
> [here](https://github.com/openjdk/jdk/pull/8450).
>
> Looks like the initial root cause of the issue was related to the last
> disposed frame which for some reason was not delet
On Mon, 6 Jun 2022 21:11:03 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use RObot.createMultiResoutionCapture
>
> test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 147:
Hi Justin,
To unsubscribe from any OpenJDK mailing lists, go to its page; for
client-libs-dev, go to:
https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev
Scroll to the bottom of the page, enter your email address in the
section "To unsubscribe from client-libs-dev…" and click "Uns
On Mon, 6 Jun 2022 06:08:38 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
On Tue, 7 Jun 2022 10:47:25 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
>
>> 70:
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Tue, 7 Jun 2022 10:46:15 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 58:
>
>> 56:2.
On Tue, 7 Jun 2022 11:11:24 GMT, Alexey Ivanov wrote:
>> I think it wouldn't make any difference calling static methods via an
>> instance variable or directly with class name.
>
> Yes, the same method would be called. Yet the difference is in the semantics:
> the instance variable isn't used w
On Tue, 7 Jun 2022 11:06:06 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
>>
>>> 70: //Adding the Test Frame to handle dispose
>>> 71: passFailJFrame.addTestFrame(testObj);
>>> 72: passFailJFrame.pos
> This is an update of the test which was de-problemlisted
> [here](https://github.com/openjdk/jdk/pull/8450).
>
> Looks like the initial root cause of the issue was related to the last
> disposed frame which for some reason was not deleted from the memory, for
> that issue, the [next](https://
On Tue, 7 Jun 2022 04:15:49 GMT, Sergey Bylokhov wrote:
> This is an update of the test which was de-problemlisted
> [here](https://github.com/openjdk/jdk/pull/8450).
>
> Looks like the initial root cause of the issue was related to the last
> disposed frame which for some reason was not delet
On Mon, 6 Jun 2022 06:16:16 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
On Tue, 7 Jun 2022 11:42:38 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JTableHeader/TableRendererTest.java line 31:
>
>> 29:@summar
On Tue, 7 Jun 2022 11:19:10 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Tue, 7 Jun 2022 11:58:01 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Tue, 7 Jun 2022 12:44:43 GMT, Alexey Ivanov wrote:
> It looks good now.
>
> What's left is to ensure it passes when run headless. It should just work on
> Windows.
>
> Can we address @mrserb's concern and extend the test be run on other
> platforms and with all L&Fs?
Yeah sure.
-
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Tue, 7 Jun 2022 12:27:51 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 94:
>
>> 92: JRadioBut
On Tue, 7 Jun 2022 07:41:20 GMT, Prasanta Sadhukhan
wrote:
> I thought I already approved..
Sure, it was, but it differs significantly from the approved version. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/9003
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev
wrote:
> This test was failing consistently on same machines and at the same time as
> #8532.
>
> Test failure is also no longer reproducible after #8320 fix.
>
> This is macOS only test, so corresponding `@requires os.family` tag was
> a
On Mon, 6 Jun 2022 09:48:47 GMT, Prasanta Sadhukhan
wrote:
> I see even `Gulimche `and `Batang `are not visible without -Dfile.encoding=ko
> so maybe it's what is expected.
Malgun Gothic is visible without user.language=ko and user.country=KR in
command line (of course without -Dfile.encoding
On Tue, 7 Jun 2022 13:40:57 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Sun, 31 Oct 2021 08:21:58 GMT, Emmanuel Bourg wrote:
> When a list of icons is set on a window, the most appropiate icon is selected
> depending on the graphics configuration. But if the graphics configuration
> changes (because the window is moved to a different screen, or because the
> DP
On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg wrote:
>> Emmanuel Bourg has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (Java generic font
>> names are usually capitalized)
>> - Te
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote:
> Added test for checking setMargin() of JRadioButton.
This pull request has now been integrated.
Changeset: 67f1bd7f
Author:Tejesh R
Committer: Alexey Ivanov
URL:
https://git.openjdk.java.net/jdk/commit/67f1bd7ff1bb218fd6de9ef1e957
On Fri, 11 Mar 2022 23:19:19 GMT, Damon Nguyen wrote:
> So I wrote a test with a JEditorPane loading HTML from a file, but couldn't
> get HTML buttons to render properly in JEditorPane. I wanted HTML buttons to
> test a foo function encased in script tags in my HTML file to see if script
> tag
On Mon, 6 Jun 2022 16:28:22 GMT, Damon Nguyen wrote:
>> I see your points and agree that your points are valid. Parser has no part
>> in the display and is fact handled elsewhere.
>>
>> I initially had to look through and learn what each class for HTML parsing
>> is responsible for, and Parser
On Mon, 6 Jun 2022 20:45:46 GMT, Damon Nguyen wrote:
>> Updated Parser class doc by appending to the doc regarding lack of support
>> for HTML script tags. Adding this information to the "parse" function did
>> not seem as consistent for formatting as adding it to the Parser class doc.
>
> Damo
On Mon, 6 Jun 2022 16:19:18 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/text/html/parser/HtmlTagParserTest.java line 1:
>>
>>> 1: import java.awt.Dimension;
>>
>> where's the GPL header on this test ?
>
> Added the header and moved the test to the HTML folder instead since I
> believe the
On Sat, 30 Apr 2022 18:58:56 GMT, Andrey Turbanov wrote:
> `sun.awt.ExtendedKeyCodes#regularKeyCodesMap` contains only non-null values.
> It means we can replace containsKey+get with get+null check.
> It's clearer and a bit faster.
Thank you for review!
-
PR: https://git.openjdk.j
On Sat, 30 Apr 2022 18:58:56 GMT, Andrey Turbanov wrote:
> `sun.awt.ExtendedKeyCodes#regularKeyCodesMap` contains only non-null values.
> It means we can replace containsKey+get with get+null check.
> It's clearer and a bit faster.
This pull request has now been integrated.
Changeset: 1aa87e00
On Fri, 27 May 2022 20:48:30 GMT, Alexey Ivanov wrote:
>> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
>> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>>
>> **SystemTray**: removed redundant initialisers; replaced sized array with
>
A trivial fix to ProblemList
java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on
macosx-aarch64.
What I'd really like to is to ProblemList this test
on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release values
(M.N) did not work when I tried them a month or so ago.
On Tue, 7 Jun 2022 20:33:43 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on
> macosx-aarch64.
>
> What I'd really like to is to ProblemList this test
> on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release
On Tue, 7 Jun 2022 20:33:43 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on
> macosx-aarch64.
>
> What I'd really like to is to ProblemList this test
> on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release
On Tue, 7 Jun 2022 20:33:43 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on
> macosx-aarch64.
>
> What I'd really like to is to ProblemList this test
> on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release
On Mon, 6 Jun 2022 20:46:03 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> skip transform is m01 or m10 i
On Tue, 7 Jun 2022 11:36:52 GMT, Sergey Bylokhov wrote:
>> This is an update of the test which was de-problemlisted
>> [here](https://github.com/openjdk/jdk/pull/8450).
>>
>> Looks like the initial root cause of the issue was related to the last
>> disposed frame which for some reason was not
On Tue, 7 Jun 2022 04:15:49 GMT, Sergey Bylokhov wrote:
> This is an update of the test which was de-problemlisted
> [here](https://github.com/openjdk/jdk/pull/8450).
>
> Looks like the initial root cause of the issue was related to the last
> disposed frame which for some reason was not delet
41 matches
Mail list logo
