On Tue, 14 Mar 2023 10:06:47 GMT, Tejesh R wrote:
> The issue is intermittent and was not able to reproduce it. Though through
> code analysis and bug reported logs, the issue seems to be in COM thread of
> `FilesLoader` class in `BasicDirectoryModel` file. Looks like there are
> certain place
On Tue, 14 Mar 2023 10:06:47 GMT, Tejesh R wrote:
> The issue is intermittent and was not able to reproduce it. Though through
> code analysis and bug reported logs, the issue seems to be in COM thread of
> `FilesLoader` class in `BasicDirectoryModel` file. Looks like there are
> certain place
On Sat, 8 Apr 2023 00:58:57 GMT, Roger Riggs wrote:
>> Update classes in the java.desktop module to use the
>> jdk.internal.util.OperatingSystem enum instead of the `os.name` system
>> property to select OS specific behaviors.
>
> Roger Riggs has updated the pull request with a new target base
> Update classes in the java.desktop module to use the
> jdk.internal.util.OperatingSystem enum instead of the `os.name` system
> property to select OS specific behaviors.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes
I may be confused, too! I haven’t kept close track of the various issues and
PRs.
My comment relates to a perhaps old idea of using a graphics rendering hint to
suppress painting the window background.
VAqua knows nothing about volatile buffering, nor do I. :-)
> On Apr 7, 2023, at 3:29 PM,
On Wed, 5 Apr 2023 11:47:06 GMT, Ravi Gupta wrote:
>> This testcase Checking whether the Component becoming the Focus Owner and
>> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is
>> requested on the component using requestFocus.
>>
>> Testing:
>> Tested using Mach5(
On Mon, 27 Mar 2023 21:45:08 GMT, Jeremy wrote:
> The original write-up contains two complaints:
> 1. The window is opaque, so pixels that should be transparent are black.
> 2. The window is the wrong resolution. On a 200% resolution monitor it
> renders as if it were 100% (so it looks pixelated
On Fri, 7 Apr 2023 06:03:11 GMT, Thomas Stuefe wrote:
>>> What did you use as the example that would not compile on the other
>>> architecture?
>>
>> https://github.com/openjdk/jdk/blob/52ca4a70fc3de9e285964f9545ea8cd54e2d9924/src/java.base/share/classes/jdk/internal/util/OperatingSystemProps.
On Fri, 7 Apr 2023 12:05:28 GMT, Lutz Schmidt wrote:
>> Okay, Lutz is the expert here. Sorry for the noise.
>
> Just to let my voice be heard directly after being cited several times: s390
> is used to designate the CPU architecture. The arch-specific files are stored
> in src/hotspot/cpu/s390
On Fri, 7 Apr 2023 21:13:03 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X,
> PPC64LE`
> Note
On Mon, 20 Mar 2023 01:07:25 GMT, Sergey Bylokhov wrote:
> Support of premultiplied alpha is added to the "accelerated" code path of the
> CMM. It is implemented on top of the new feature added to the littlecms
> library in 2.13 and 2.15.
>
> The next formats are now "supported": TYPE_INT_ARGB
On Mon, 20 Mar 2023 01:07:25 GMT, Sergey Bylokhov wrote:
> Support of premultiplied alpha is added to the "accelerated" code path of the
> CMM. It is implemented on top of the new feature added to the littlecms
> library in 2.13 and 2.15.
>
> The next formats are now "supported": TYPE_INT_ARGB
On Wed, 5 Apr 2023 08:19:50 GMT, Maxim Kartashev wrote:
> Getting bounds of a `GraphicsDevice` and insets of a screen are fairly
> frequent operations. When working over the network (remote X session), those
> can take several *seconds* to complete, introducing repeated freezes even
> when typ
On Fri, 7 Apr 2023 19:52:46 GMT, Harshitha Onkar wrote:
> @dmarkov20 We will be having a HarfBuzz upgrade to mainline soon. As @prrace
> suggested, this might be unnecessary at this point then.
I think it extremely likely we'll do a HB update before JDK 21 RDP1 so, yes.
-
PR Comme
On Fri, 7 Apr 2023 05:32:55 GMT, Phil Race wrote:
> > > I don't see why we need this in mainline. I'd prefer to not have it
> > > unless we need it.
> >
> >
> > I believe it is better to have all JDK branches in sync if it's possible.
> > This change is harmless and as Sergey mentioned it wou
On Fri, 7 Apr 2023 18:39:03 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/classes/java/awt/Window.java line 3953:
>>
>>> 3951: if (gg instanceof Graphics2D) {
>>> 3952: gg.setColor(getBackground());
>>> 3953: ((Graphics2D)
>>> gg).set
> I'm confident about the new test case for this ticket, but the resolution is
> more invasive than I'd like. (It works, though.)
>
> In short:
> This introduces a new RenderingHint (in SunHints) to bypass the call in
> Window to `gg2d.fillRect(0, 0, getWidth(), getHeight());`
>
> I left more d
On Fri, 7 Apr 2023 17:03:56 GMT, Damon Nguyen wrote:
>> Jeremy has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8303950: adding unit test for legacy window behavior
>>
>> This test passes in the current JDK. The test criteria don't r
On Fri, 7 Apr 2023 16:24:37 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java
>> line 113:
>>
>>> 111: frame2.setBounds(120, 120, 120, 120);
>>> 112: frame2.setVisible(true);
>>> 113: }
>>
>> S
> This test issue was due to race condition that occured when using
> `-Dsun.java2d.uiScale >= 2`.
> As a result it led to incorrect mouse position being compared as opposed to
> the updated mouse position after the final mouse move event.
>
> Following is the event log before and after fix.
>
On Wed, 5 Apr 2023 11:47:06 GMT, Ravi Gupta wrote:
>> This testcase Checking whether the Component becoming the Focus Owner and
>> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is
>> requested on the component using requestFocus.
>>
>> Testing:
>> Tested using Mach5(
On Fri, 7 Apr 2023 07:03:32 GMT, Xue-Lei Andrew Fan wrote:
> how did you test it ?
> The existing regression tests will be used for the testing. I will ask for a
> Mach5 testing if approved. Hopefully, the current regression test coverage is
> sufficient. I have no plan to add new test cases.
When I added support for translucent windows to VAqua, I used a different
solution: I “tricked” the AWT Window into
accepting a transparent (alpha = 0) background color. I’m not sure if this is
better or worse than your idea of suppressing the
painting of the background, but it does raise the iss
On Thu, 6 Apr 2023 14:16:46 GMT, Ajit Ghaisas wrote:
> Root cause : The CVDisplayLink used in MTLLayer stops invoking callbacks on
> screen sleep and wakeup event. It is found that stop and restart of
> CVDisplayLink on these events also does not help.
>
> Fix : Recreate the CVDisplayLink on s
On Fri, 7 Apr 2023 11:49:50 GMT, Ajit Ghaisas wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 102:
>>
>>> 100:
>>> 101: [self stopDisplayLink];
>>> 102: }
>>
>> I'm assuming this is something we should have done already to save wasted
>> work ?
>> i.e if
On Tue, 21 Mar 2023 21:07:42 GMT, Jeremy wrote:
>> I'm confident about the new test case for this ticket, but the resolution is
>> more invasive than I'd like. (It works, though.)
>>
>> In short:
>> This introduces a new RenderingHint (in SunHints) to bypass the call in
>> Window to `gg2d.fill
On Fri, 7 Apr 2023 04:47:56 GMT, Phil Race wrote:
>> This test issue was due to race condition that occured when using
>> `-Dsun.java2d.uiScale >= 2`.
>> As a result it led to incorrect mouse position being compared as opposed to
>> the updated mouse position after the final mouse move event.
>
On Thu, 6 Apr 2023 14:16:46 GMT, Ajit Ghaisas wrote:
> Root cause : The CVDisplayLink used in MTLLayer stops invoking callbacks on
> screen sleep and wakeup event. It is found that stop and restart of
> CVDisplayLink on these events also does not help.
>
> Fix : Recreate the CVDisplayLink on s
On Thu, 6 Apr 2023 22:44:52 GMT, Phil Race wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/jdk.accessibility/windows/classes/com/sun/java/accessi
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote:
>> Hello Thomas, that change was based on the review comment here
>> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942
>
> Okay, Lutz is the expert here. Sorry for the noise.
Just to let my voice be heard directly after being
On Thu, 6 Apr 2023 14:16:46 GMT, Ajit Ghaisas wrote:
> Root cause : The CVDisplayLink used in MTLLayer stops invoking callbacks on
> screen sleep and wakeup event. It is found that stop and restart of
> CVDisplayLink on these events also does not help.
>
> Fix : Recreate the CVDisplayLink on s
On Fri, 7 Apr 2023 04:36:39 GMT, Phil Race wrote:
> I'm assuming this is something we should have done already to save wasted
> work ?
i.e if the screen is asleep, we don't need to be connected to it and updating
windows ?
We start the DisplayLink from Metal RenderQueue whenever there is somet
On Fri, 7 Apr 2023 10:52:47 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 41:
>>
>>> 39: AARCH64(),
>>> 40: RISCV64(),
>>> 41: S390(),
>>
>> Why getting rid of the X in s390x? There has not been an s390 linux kernel
>> in almost te
On Fri, 7 Apr 2023 10:24:20 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/java.base/share/classes/jdk/internal/util/Architec
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Wed, 5 Apr 2023 15:54:53 GMT, Nikita Gubarkov wrote:
> There are freezes reported on some Linux configurations which are believed to
> may be caused by the toolkit thread quickly reacquiring AWT_LOCK while
> polling for events, which starves EDT waiting on that lock.
> Adding new `awt.lock.f
On Fri, 7 Apr 2023 09:28:18 GMT, Thomas Stuefe wrote:
> > > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian.
> > > We also have PPC big-endian, it is used by AIX (and you can also run
> > > Linux with PPC big-endian). Why omit that?
> > > os.arch for AIX is "ppc64".
> >
On Fri, 7 Apr 2023 07:42:51 GMT, Alan Bateman wrote:
> > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We
> > also have PPC big-endian, it is used by AIX (and you can also run Linux
> > with PPC big-endian). Why omit that?
> > os.arch for AIX is "ppc64".
>
> So I thin
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Mon, 20 Mar 2023 13:06:19 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests to modernize the JVM arguments used to
> enable debugging in the netbeans project files for demos.
>
> The netbeans projects found in src/demo/share/nbproject currently use the
> following outdated
On Fri, 7 Apr 2023 06:44:14 GMT, Eirik Bjorsnos wrote:
> Or could we simply withdraw this PR and instead broaden the scope of #13098
> to remove all Netbeans projects?
As #13098 is now integrated, it would now make more sense to create a seperate
PR for a removal of these projects.
-
On Fri, 7 Apr 2023 06:33:08 GMT, Thomas Stuefe wrote:
> What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We
> also have PPC big-endian, it is used by AIX (and you can also run Linux with
> PPC big-endian). Why omit that?
>
> os.arch for AIX is "ppc64".
So I think you ar
On Fri, 7 Apr 2023 06:26:18 GMT, Eirik Bjorsnos wrote:
> Thanks, but it seems Alan did not actually approve anything, he simply left
> an infomational note.
>
> We still only have the approval from Sergey, and it is still not clear what
> he approved.
Right, I just added a note as I remember
On Fri, 7 Apr 2023 05:45:05 GMT, Phil Race wrote:
> how did you test it ?
The existing regression tests will be used for the testing. I will ask for a
Mach5 testing if approved. Hopefully, the current regression test coverage is
sufficient. I have no plan to add new test cases.
45 matches
Mail list logo
