Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v4]

2025-02-07 Thread Sergey Bylokhov
On Thu, 6 Feb 2025 14:13:50 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make >> `Introspector.addMethod()` working properly when filtering methods out. >> >> Also fixed the test, and added the approptiate test case. > > Roman Marchenko has updated t

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Phil Race
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8348106: Catch C++ exception in Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon

2025-02-07 Thread Sergey Bylokhov
On Wed, 5 Feb 2025 18:40:07 GMT, Rajat Mahajan wrote: > **Issue:** > The JNI method `Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon `calls > `CreateIconFromRaster `that can throw a C++ exception. > > The C++ exception must be caught and must not be allowed to escape the JNI > method. The cal

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 06:52:48 GMT, Prasanta Sadhukhan wrote: >> I tested different ways to merge this block with the below blocks. I'm not >> sure if it makes sense to do so now because it wouldn't be as simple as >> adding `|| focusOwner == null` to the first if-statement or appending the >> l

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 14:11:15 GMT, Matthias Baesken wrote: >> What tests have you run? > >> What tests have you run? > > Had this in our internal test queue with jtreg / JCK plus some additional > SAP internal tests. No issues seen. > However I think I have to run some more manual tests on clien

Re: RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java [v3]

2025-02-07 Thread Harshitha Onkar
> FileDialogIconTest.java has been updated. > > Following changes were made. > > - Test instructions updated > - BugID associated with the test is updated to the correct one > - setIconBufferedImagesToFrame and setIconBufferedImagesToDialog btns added > to the frame. > - other minor cleanups

Re: RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java [v2]

2025-02-07 Thread lawrence . andrews
On Fri, 7 Feb 2025 21:18:47 GMT, Harshitha Onkar wrote: >> FileDialogIconTest.java has been updated. >> >> Following changes were made. >> >> - Test instructions updated >> - BugID associated with the test is updated to the correct one >> - setIconBufferedImagesToFrame and setIconBufferedIma

Re: RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java [v2]

2025-02-07 Thread Harshitha Onkar
> FileDialogIconTest.java has been updated. > > Following changes were made. > > - Test instructions updated > - BugID associated with the test is updated to the correct one > - setIconBufferedImagesToFrame and setIconBufferedImagesToDialog btns added > to the frame. > - other minor cleanups

RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java

2025-02-07 Thread Harshitha Onkar
FileDialogIconTest.java has been updated. Following changes were made. - Test instructions updated - BugID associated with the test is updated to the correct one - setIconBufferedImagesToFrame and setIconBufferedImagesToDialog btns added to the frame. - other minor cleanups - C

Re: RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 19:50:03 GMT, Harshitha Onkar wrote: > FileDialogIconTest.java has been updated. > > Following changes were made. > > - Test instructions updated > - BugID associated with the test is updated to the correct one > - setIconBufferedImagesToFrame and setIconBufferedImagesToDi

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v10]

2025-02-07 Thread Alexey Ivanov
On Fri, 7 Feb 2025 05:26:10 GMT, Prasanta Sadhukhan wrote: >> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radio

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File

2025-02-07 Thread Alexey Ivanov
On Fri, 7 Feb 2025 17:29:58 GMT, Harshitha Onkar wrote: >> Is it needed? If there are no failures, I see no reason to increase the >> tolerance. > > If it test runs fine on CI then it should be okay. Previously, I came across > few tests which required increasing tolerance value (although not i

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v10]

2025-02-07 Thread Alexey Ivanov
On Fri, 7 Feb 2025 05:26:10 GMT, Prasanta Sadhukhan wrote: >> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radio

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 16:34:20 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java line 47: >> >>> 45: private static final int SIZE = 100; >>> 46: // Allow a margin tolerance of 1 pixel due to scaling >>> 47: private static final int MARGIN_TOL

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File

2025-02-07 Thread Alexey Ivanov
On Thu, 6 Feb 2025 23:45:43 GMT, Harshitha Onkar wrote: >> While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), >> we discovered that there are two tests meant to perform the same task. >> >> The first test is located at >> test/jdk/java/awt/Multiscreen/MultiScreenInset

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Fri, 7 Feb 2025 13:08:17 GMT, Magnus Ihse Bursie wrote: > What tests have you run? Had this in our internal test queue with jtreg / JCK plus some additional SAP internal tests. No issues seen. However I think I have to run some more manual tests on client like setups. Unfortunately my Li

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-02-07 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Magnus Ihse Bursie
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8348600: Update PipeWire to 1.3.81

2025-02-07 Thread Alexander Zvegintsev
On Fri, 7 Feb 2025 06:57:01 GMT, Prasanta Sadhukhan wrote: > When you say "Testing looks good" you mean the normal jtreg client testsuite > or any other specific testing that was done? normal jtreg client testsuite + manual testing - PR Comment: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v10]

2025-02-07 Thread Alexey Ivanov
On Fri, 7 Feb 2025 05:28:28 GMT, Prasanta Sadhukhan wrote: > It seems in windows 11, the menuitem text location is dependant on presence > of menuitem icon. As per this screenshot, the bullet/checkmark seems to be in > its fixed location but text is shifted depending on menuitem icon. That's

Re: RFR: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS [v2]

2025-02-07 Thread Alexey Ivanov
On Wed, 5 Feb 2025 11:50:36 GMT, Alexey Ivanov wrote: >>> Nothing stops you from doing so… >> >> I agree but I have never seen any application which is having a single >> RadioButton for selection. >> >>> I still think the condition in the radio button case should be the same: >>> Object.equ

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v9]

2025-02-07 Thread Alexey Ivanov
On Fri, 7 Feb 2025 03:10:03 GMT, Prasanta Sadhukhan wrote: > I am not sure if we can satisfy both windows 10 and windows 11 simultaneously > as both design is different for this logic... We absolutely can… I'm not proposing using different rendering, instead I'm for following Windows 11 rende

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Thu, 6 Feb 2025 14:03:16 GMT, Erik Joelsson wrote: >> The splashscreen lib is currently built with LOW optimization. >> This might be fine because it is not very performance critical (and LOW is >> not really low when looking at the opt-flags used). >> But building it with SIZE optimization

Re: RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v9]

2025-02-07 Thread Sergey Bylokhov
On Thu, 6 Feb 2025 18:14:26 GMT, Phil Race wrote: >You are the only person who reads it this way. So do you think that kcms/lcms do not follow the icc specification? and the whole feature to support lcms specific and custom/applications specific intents are useless? Its even described in the d

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v2]

2025-02-07 Thread GennadiyKrivoshein
> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use > more that one print option. > > **Reason of the bug**: > execCmd array uses one index per print flag, but 'OPTIONS' flag can use two > indexes for the options. > > **Fix description**: > make the size of the exec

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v2]

2025-02-07 Thread GennadiyKrivoshein
On Fri, 7 Feb 2025 08:13:50 GMT, Prasanta Sadhukhan wrote: >> The format is space delimited values, each value is a "key=value". >> There is no difference between Linux and Mac and there are no changes in the >> format of the options. > > If it's a space delimited values, then can't we use "op

Re: RFR: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS [v2]

2025-02-07 Thread Abhishek Kumar
On Wed, 5 Feb 2025 11:50:36 GMT, Alexey Ivanov wrote: >>> Nothing stops you from doing so… >> >> I agree but I have never seen any application which is having a single >> RadioButton for selection. >> >>> I still think the condition in the radio button case should be the same: >>> Object.equ

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time

2025-02-07 Thread Prasanta Sadhukhan
On Fri, 7 Feb 2025 08:08:39 GMT, GennadiyKrivoshein wrote: >> src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 1578: >> >>> 1576: } >>> 1577: if (options != null && !options.isEmpty()) { >>> 1578: optionArgs = options.trim().split("\\s+"); >> >> In wha

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time

2025-02-07 Thread GennadiyKrivoshein
On Fri, 7 Feb 2025 07:38:30 GMT, Prasanta Sadhukhan wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for