On Wed, 5 Feb 2025 11:50:36 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>>> Nothing stops you from doing so… >> >> I agree but I have never seen any application which is having a single >> RadioButton for selection. >> >>> I still think the condition in the radio button case should be the same: >>> Object.equals handles all the cases, and the code becomes consistent. >>> Otherwise, the radio button stands out… for no apparent reason. >> >> For consistency, it can be done. I need to check if it impacts on VO >> announcement. > >> For consistency, it can be done. I need to check if it impacts on VO >> announcement. > > It shouldn't impact the announcements. One button gets deselected, another > one gets selected… > > Yet now that I think about it more, we may want to skip announcing > deselecting a button in the group when selection moves to another button. > > What about the case where currently focused or unfocused selected button gets > deselected programmatically? Is there an interactive way to deselect a radio > button when it's the only button in its own group? > > This *needs more testing*. > @aivanov-jdk I think we should not change RadioButton's implementation as the > announcement is not consistent. Do you have any other suggestion ? Yes, I agree. I just wanted to test it myself too, and I haven't been able to yet. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23436#discussion_r1946381166
