On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
> does in native tree view in Finder.
> Fixed the keybindings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Test modification
-
Change
On Thu, 26 Jun 2025 04:55:01 GMT, Abhishek Kumar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 62:
>
>> 60: frame.pack();
>
On Wed, 25 Jun 2025 12:15:54 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
>> "Due to an unfortunate set of historical events this method is
>> inappropriately named".
>
> Prasanta Sadhukhan has updated the pull request incrementa
On Thu, 26 Jun 2025 02:31:17 GMT, Prasanta Sadhukhan
wrote:
>> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
>> does in native tree view in Finder.
>> Fixed the keybindings.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Thu, 26 Jun 2025 03:09:29 GMT, Prasanta Sadhukhan
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radi
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
> drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing
> the radiobutton win
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
> drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing
> the radiobutton win
On Thu, 26 Jun 2025 02:31:17 GMT, Prasanta Sadhukhan
wrote:
>> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
>> does in native tree view in Finder.
>> Fixed the keybindings.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
> does in native tree view in Finder.
> Fixed the keybindings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Fix
-
Changes:
- all: ht
On Wed, 25 Jun 2025 14:59:53 GMT, Alexey Ivanov wrote:
>> This PR removes the usage of AppContext from the GraphicsDevice class. The
>> original use case was to store the full-screen window in some AppContext,
>> which was necessary in the context of plugin/appletviewer environments.
>> Howeve
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Tue, 24 Jun 2025 14:58:38 GMT, Weijun Wang wrote:
>> However, there is no space required between two Chinese sentences. In
>> English, we usually write "I am here, and you are there." But in Chinese,
>> with the full-width punctuation, it's always "我在这里，你在那里。".
>
> Some people like to insert
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
revert german translation, revert english wxl fo
(Disclaimer: I happen to work for Oracle but this has nothing to do with my
job.)
I have been having trouble double-clicking things with my Apple Magic Mouse
on my M1 Mac when running (Swing-based) Netbeans (see
https://github.com/apache/netbeans/issues/8609 and the inciting discussion
at https://
On Tue, 24 Jun 2025 12:50:14 GMT, Alexey Ivanov wrote:
>>>What I mean is two threads that called GraphicsDevice.getFullScreenWindow
>>>still established a happens-before relation for each call, which will be
>>>gone with the volatile modifier.
>>>It may be fine… or may be not… this is why I'm a
On Wed, 11 Jun 2025 13:18:47 GMT, Daniel Jeliński wrote:
> Add an exception check after a JNI static method call, and re-enable checks
> for CallStatic in JNICheck.sh test.
>
> I verified that the JNICheck test is passing on all headless and headful
> platforms I had access to (Windows, Linux
Hi all,
This pull request contains a backport of commit
[bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Manukumar V S on 24 Jun 2025 and
was re
On Mon, 23 Jun 2025 08:53:16 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.or
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the
On Wed, 25 Jun 2025 09:37:10 GMT, Prasanta Sadhukhan
wrote:
> I dont want to do it as I already told before..Its the same strategy used in
> other recently opensourced tests I mentioned before where
> `SwingUtilities.updateComponentTreeUI(frame)` is used ...
But missing `SwingUtilities.update
On Mon, 23 Jun 2025 08:53:16 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
Marked as reviewed by serb (Reviewer).
please rerun the Pre-submit tests in the GA
--
On Mon, 16 Jun 2025 06:17:32 GMT, Sergey Bylokhov wrote:
> This PR removes the usage of AppContext from the GraphicsDevice class. The
> original use case was to store the full-screen window in some AppContext,
> which was necessary in the context of plugin/appletviewer environments.
> However,
On Wed, 25 Jun 2025 12:15:54 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
>> "Due to an unfortunate set of historical events this method is
>> inappropriately named".
>
> Prasanta Sadhukhan has updated the pull request incrementa
On Tue, 24 Jun 2025 11:44:13 GMT, Abhishek Kumar wrote:
>> `AccessibleText.getBeforeIndex` method returns `null for last characte`r due
>> to the **wrong boundary value condition check**.
>> This method returns `null` when the `passed index parameter` is equal to
>> `text's length` which is inc
On Tue, 24 Jun 2025 14:54:17 GMT, Weijun Wang wrote:
>> Thank you for the clarification.
>
> However, there is no space required between two Chinese sentences. In
> English, we usually write "I am here, and you are there." But in Chinese,
> with the full-width punctuation, it's always "我在这里，你在那
On Sat, 21 Jun 2025 00:17:26 GMT, Sergey Bylokhov wrote:
> That only affects the case where the second thread tries to read shared data
> (unrelated to GraphicsDevice) without synchronization, which was written
> before the first thread called getFullScreenWindow(). If visibility is
> required
On Thu, 19 Jun 2025 06:06:23 GMT, Prasanta Sadhukhan
wrote:
> > > In SwingSet2, now there will be gap between bullet and text to accomodate
> > > non-existing imageicon
> >
> >
> > That gap should only be there if _at least one_ menu item has an image
> > icon. It shoudn't be there if none h
On Mon, 23 Jun 2025 13:41:38 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright
>
> Marked as reviewed by aivanov (Reviewer).
Thanks @aivanov-jdk for the re-review.
---
On Thu, 19 Jun 2025 09:45:14 GMT, Alexey Ivanov wrote:
> > In SwingSet2, now there will be gap between bullet and text to accomodate
> > non-existing imageicon
>
> That gap should only be there if _at least one_ menu item has an image icon.
> It shoudn't be there if none have an icon.
@prrace
On Wed, 25 Jun 2025 07:06:13 GMT, Prasanta Sadhukhan
wrote:
>>> It is passed to `View.setSize` also so just mentioning one may not be right…
>>
>> Right. Both uses cases fall into the same category: the allocation controls
>> the size of the root view.
>>
>> The returned allocation rectangle
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
Alisen Chung has updated the pull request incrementally with three additional
commits since the last revision:
- update majorticks translation
- Merge branc
On Wed, 25 Jun 2025 00:27:48 GMT, Damon Nguyen wrote:
>> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
>> line 49:
>>
>>> 47: .Principal.=\t主用户：\u0020
>>> 48: .Public.Credential.=\t公共身份证明:\u0020
>>> 49: .Private.Credential.=\t专用身份证明:\u0020
>>
>> Why aren't t
On Wed, 25 Jun 2025 04:43:14 GMT, Abhishek Kumar wrote:
> So, if someone wants to retrieve the first or last character, they shouldn't
> rely on `getAfterIndex and getBeforeIndex` method respectively, rather use
> `getAtIndex` method to get the first and last character with index passed as
> 0
On Wed, 25 Jun 2025 16:59:09 GMT, Justin Lu wrote:
>> I checked the ASCII codes here and on the source file. The updated colons
>> are localized to full-width colons as @justin-curtis-lu mentioned in another
>> thread here.
>>
>> I agree. I also believe lines 48 & 49 need to be updated to the
On Tue, 24 Jun 2025 05:42:04 GMT, Prasanta Sadhukhan
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radi
On Wed, 25 Jun 2025 06:52:15 GMT, Prasanta Sadhukhan
wrote:
>> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
>> does in native tree view in Finder.
>> Fixed the keybindings.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Wed, 25 Jun 2025 15:05:27 GMT, Alexey Ivanov wrote:
> > The spec says
>
> What spec in particular?
https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/accessibility/AccessibleText.html#getBeforeIndex(int,int)
It says, `index - an index within the text` for the `getBeforeIn
On Wed, 25 Jun 2025 04:43:14 GMT, Abhishek Kumar wrote:
> The spec says
What spec in particular?
-
PR Comment: https://git.openjdk.org/jdk/pull/25941#issuecomment-3005132532
On Tue, 24 Jun 2025 17:34:54 GMT, Sergey Bylokhov wrote:
>>> That only affects the case where the second thread tries to read shared
>>> data (unrelated to GraphicsDevice) without synchronization, which was
>>> written before the first thread called getFullScreenWindow(). If visibility
>>> is
On Mon, 23 Jun 2025 08:53:16 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.o
On Wed, 25 Jun 2025 10:01:52 GMT, Alexey Ivanov wrote:
> > I dont want to do it as I already told before..Its the same strategy used
> > in other recently opensourced tests I mentioned before where
> > `SwingUtilities.updateComponentTreeUI(frame)` is used ...
>
> But missing `SwingUtilities.up
On Wed, 25 Jun 2025 03:14:33 GMT, Prasanta Sadhukhan
wrote:
> I dont think its a product bug since the L&F was not propagated to all nodes
> of the Swing components after L&F change so it should be a test issue which
> was solved.
I didn't say it was a product bug, it is rather a product *fea
> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
> "Due to an unfortunate set of historical events this method is
> inappropriately named".
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- Update
On Wed, 25 Jun 2025 12:12:54 GMT, Prasanta Sadhukhan
wrote:
>> If linked with ‘and’, there should be no comma.
>
> ok..modified..
ok..modified..
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25850#discussion_r2166567168
On Wed, 25 Jun 2025 10:47:27 GMT, Alexey Ivanov wrote:
>> We may break the description into paragraphs like this:
>>
>>
>> /**
>> * Gets the allocation for the root view.
>> *
>> * The returned rectangle is unrelated to visibility.
>> * It is used to set the size of the
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
On Wed, 25 Jun 2025 10:36:46 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
>> 1034:
>>
>>> 1032: * Gets the allocation for the root view.
>>> 1033: * The returned rectangle is unrelated to visibility,
>>> 1034: * and is u
On Wed, 25 Jun 2025 07:09:10 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
>> "Due to an unfortunate set of historical events this method is
>> inappropriately named".
>
> Prasanta Sadhukhan has updated the pull request incrementa
On Wed, 25 Jun 2025 10:33:48 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update javadoc
>> - Update javadoc
>> - Update javadoc
>
> src/java.desktop/share/classes/javax/swing/plaf
On Wed, 25 Jun 2025 09:24:21 GMT, Alexey Ivanov wrote:
> > Rewriting the test, if needed, could be done as part of new issue but this
> > one fixes the issue and let manual testing team run the test in all L&F
>
> Why not now? We have a bug in the test, your fix doesn't fix the fundamental
> p
No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
can call `List.remove(Object)` directly. It's faster and cleaner.
-
Commit messages:
- [PATCH] Remove unnecessary List.indexOf key from
AbstractMidiDevice.TransmitterList.remove
Changes: https://git.openj
On Mon, 23 Jun 2025 08:53:16 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
looks fine
-
PR Comment: https://git.openjdk.org/jdk/pull/25931#issuecomment-
On Wed, 19 Mar 2025 13:06:56 GMT, Nikita Gubarkov wrote:
>> 8352407: PixelInterleavedSampleModel with unused components throws
>> RasterFormatException: Incorrect pixel stride
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
Many Mixing tests failed because the work around click lands on the minimizing
area in the window control and causes the tests to fail.
This fix changes the width of base frames which allows most of tests to pass.
-
Commit messages:
- Problem list files for Mac OS only
- Removes p
> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it
> does in native tree view in Finder.
> Fixed the keybindings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Correct bugid
-
Changes:
> Added an on-demand installation of the native OpenURL event handler to the
> `Application.setOpenURIHandler()`.
>
> This does not break the specification for the affected API, since the
> requirement of the application being bundled and containing
> `CFBundleURLTypes` in the `Info.plist` is s
On Fri, 20 Jun 2025 11:26:09 GMT, Alexey Ivanov wrote:
>> It is passed to `View.setSize` also so just mentioning one may not be
>> right..and I guess {@code allocation} is a no-op as it is not a class..
>>
>> Maybe we can mention "The returned rectangle is unrelated to visibility, and
>> is us
> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
> "Due to an unfortunate set of historical events this method is
> inappropriately named".
Prasanta Sadhukhan has updated the pull request incrementally with three
additional commits since the last revision:
- Updat
61 matches
Mail list logo
