Integrated: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index

2025-09-01 Thread Jayathirth D V
On Tue, 29 Jul 2025 05:38:00 GMT, Jayathirth D V wrote: > We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegIma

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v5]

2025-08-29 Thread Jayathirth D V
On Thu, 28 Aug 2025 12:49:37 GMT, Alexey Ivanov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Keep verifyImageIndex in try block > > test/jdk/javax/imageio/plugins/jpeg/JpegNegat

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v5]

2025-08-29 Thread Jayathirth D V
On Thu, 28 Aug 2025 13:04:53 GMT, Alexey Ivanov wrote: >> test/jdk/javax/imageio/plugins/jpeg/JpegNegativeImageIndexTest.java line 52: >> >>> 50: >>> 51: private static void testMethod(String methodName, >>> 52:RunnableWithException method) { >> >> The `

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v6]

2025-08-28 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has upda

Re: RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Jayathirth D V
On Mon, 25 Aug 2025 20:18:49 GMT, Phil Race wrote: > The disposer for MemoryCacheImageInputStream isn't needed. All it does is > clear an ArrayList of byte[] > GC can take care of that. Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/26933#pullr

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v5]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has upda

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v4]

2025-08-25 Thread Jayathirth D V
On Tue, 26 Aug 2025 05:49:59 GMT, Prasanta Sadhukhan wrote: >> Jayathirth D V has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Make test more robust >> - Use thread lock > > src/java.desktop/share/

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v3]

2025-08-25 Thread Jayathirth D V
On Mon, 25 Aug 2025 14:12:05 GMT, Alexey Ivanov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update image index verification function name > > src/java.desktop/share/classe

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v4]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has upda

Re: RFR: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize() [v2]

2025-08-25 Thread Jayathirth D V
On Wed, 20 Aug 2025 20:36:21 GMT, Phil Race wrote: >> Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated >> for removal. >> The impact of this should be minimal. The IIORegistry will now be a >> singleton - which it already was >> in practice since Applets are no longer

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-25 Thread Jayathirth D V
On Fri, 22 Aug 2025 07:13:45 GMT, Prasanta Sadhukhan wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v3]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has upda

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-25 Thread Jayathirth D V
On Thu, 21 Aug 2025 20:46:41 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five addi

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-20 Thread Jayathirth D V
On Tue, 29 Jul 2025 17:22:09 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five addi

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-20 Thread Jayathirth D V
On Fri, 1 Aug 2025 00:31:45 GMT, Alisen Chung wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-20 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has upda

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v6]

2025-08-13 Thread Jayathirth D V
On Wed, 13 Aug 2025 16:07:45 GMT, Nikita Gubarkov wrote: >> For "true" null objects, reset the ref itself to null. Non-null ref with >> null content means that the object was GC'ed. GC'ed state always behaves as >> not-equal to the new one, causing corresponding ops to be written into RQ. >> >

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v5]

2025-08-13 Thread Jayathirth D V
On Tue, 12 Aug 2025 12:00:37 GMT, Nikita Gubarkov wrote: >> For "true" null objects, reset the ref itself to null. Non-null ref with >> null content means that the object was GC'ed. GC'ed state always behaves as >> not-equal to the new one, causing corresponding ops to be written into RQ. >> >

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v5]

2025-08-13 Thread Jayathirth D V
On Tue, 12 Aug 2025 12:00:37 GMT, Nikita Gubarkov wrote: >> For "true" null objects, reset the ref itself to null. Non-null ref with >> null content means that the object was GC'ed. GC'ed state always behaves as >> not-equal to the new one, causing corresponding ops to be written into RQ. >> >

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v4]

2025-08-12 Thread Jayathirth D V
On Tue, 12 Aug 2025 11:48:56 GMT, Laurent Bourgès wrote: >> test/jdk/java/awt/ColorClass/WeakColorTest.java line 24: >> >>> 22: */ >>> 23: >>> 24: import java.awt.*; >> >> Better to expand wild card imports. > > If test depends on gc collector + special mode, then set explicitely the > neede

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v4]

2025-08-12 Thread Jayathirth D V
On Mon, 11 Aug 2025 15:48:58 GMT, Nikita Gubarkov wrote: >> For "true" null objects, reset the ref itself to null. Non-null ref with >> null content means that the object was GC'ed. GC'ed state always behaves as >> not-equal to the new one, causing corresponding ops to be written into RQ. >> >

Re: RFR: JDK-8361748 : Enforce limits on the size of an XBM image [v2]

2025-08-08 Thread Jayathirth D V
On Fri, 8 Aug 2025 10:03:18 GMT, Jayathirth D V wrote: >> ByteArrayOutputStream stmt part of try-with-resources block. > > I understand, but line no 55 has extra space instead of usual 4 space > indentation which is followed in next line. > Also its a good practice to wa

Re: RFR: JDK-8361748 : Enforce limits on the size of an XBM image [v2]

2025-08-08 Thread Jayathirth D V
On Thu, 7 Aug 2025 21:27:53 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/image/XBMDecoder/XBMDecoderTest.java line 55: >> >>> 53: System.out.println("--- Testing " + fileName + " ---"); >>> 54: try (FileInputStream fis = new FileInputStream(file); >>> 55:

Re: RFR: 8356320: GifImageDecoder can produce wrong image when GCE changes transparent pixel index [v3]

2025-08-04 Thread Jayathirth D V
On Fri, 11 Jul 2025 23:01:24 GMT, Jeremy Wood wrote: >> When a gif frame's disposal code is DISPOSAL_BGCOLOR and we're maintaining a >> saved image: we have to flood-fill the frame's bounds. And if the >> transparent pixel index changes across frames: we could sometimes flood fill >> the wrong

Re: RFR: 8362898: Remove finalize() methods from javax.imagio TIFF classes.

2025-08-04 Thread Jayathirth D V
On Mon, 21 Jul 2025 16:51:51 GMT, Phil Race wrote: > Remove finalize from TIFF ImageIO implementatation classes. > > Following copied from the bug description > The TIFF image (de)compressors can make use of a JPEG reader / writer > Like all ImageIO readers and writers, once done, the owner sho

Re: RFR: JDK-8361748 : Enforce limits on the size of an XBM image [v2]

2025-08-04 Thread Jayathirth D V
On Fri, 25 Jul 2025 23:58:39 GMT, Harshitha Onkar wrote: >> XBM (X Bitmap) images are small one-bit deep images that were developed as a >> simple uncompressed format that could easily be included in C source files >> as include files. >> >> Format of XBM image: >> >> >> #define width w >>

RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for non-zero image index

2025-07-28 Thread Jayathirth D V
We need to throw appropriate exception when we pass invalid image index values to ImageReader.getImageTypes(). We throw IOOBE in all other plugins except JPEG, Added appropriate check to throw IOOBE when JpegImageReader has invalid image index. - Commit messages: - 8364135: JPEGIma

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v6]

2025-07-13 Thread Jayathirth D V
On Fri, 11 Jul 2025 18:59:18 GMT, Jeremy Wood wrote: >> If there are two consecutive frames that use DISPOSAL_SAVE, but the >> transparent pixel index changed: we might accidentally send the wrong data >> to the ImageConsumer. >> >> We already had logic that submits info "the hard way" (see co

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v5]

2025-07-11 Thread Jayathirth D V
On Fri, 11 Jul 2025 06:36:31 GMT, Jayathirth D V wrote: > Latest change looks good to me. I will run CI tests and update. Applied this PR over latest mainline code and CI test is all green. - PR Comment: https://git.openjdk.org/jdk/pull/25264#issuecomment-3061621716

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v5]

2025-07-10 Thread Jayathirth D V
On Thu, 10 Jul 2025 21:20:07 GMT, Jeremy Wood wrote: >> If there are two consecutive frames that use DISPOSAL_SAVE, but the >> transparent pixel index changed: we might accidentally send the wrong data >> to the ImageConsumer. >> >> We already had logic that submits info "the hard way" (see co

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v11]

2025-07-10 Thread Jayathirth D V
On Thu, 10 Jul 2025 21:41:51 GMT, Phil Race wrote: > I did modify the test to dump the frames being generated and the accumulated > image, just so I could see. Maybe you could add such a feature as a debugging > option in one of the follow-on PRs. Followed same approach. As mentioned its bette

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v4]

2025-07-10 Thread Jayathirth D V
On Sun, 1 Jun 2025 07:13:14 GMT, Jeremy Wood wrote: >> If there are two consecutive frames that use DISPOSAL_SAVE, but the >> transparent pixel index changed: we might accidentally send the wrong data >> to the ImageConsumer. >> >> We already had logic that submits info "the hard way" (see com

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v11]

2025-07-10 Thread Jayathirth D V
On Wed, 9 Jul 2025 20:54:23 GMT, Jeremy Wood wrote: >> This resolves a gif parsing bug where an unwanted opaque rectangle could >> appear under these conditions: >> >> 1. The disposal method for frames is 1 (meaning "do not dispose", aka >> "DISPOSAL_SAVE") >> 2. The transparent pixel is non-z

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v9]

2025-07-09 Thread Jayathirth D V
On Sun, 1 Jun 2025 06:43:44 GMT, Jeremy Wood wrote: >> This resolves a gif parsing bug where an unwanted opaque rectangle could >> appear under these conditions: >> >> 1. The disposal method for frames is 1 (meaning "do not dispose", aka >> "DISPOSAL_SAVE") >> 2. The transparent pixel is non-z

Re: RFR: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Jayathirth D V
On Mon, 2 Jun 2025 15:05:44 GMT, Phil Race wrote: >> test/jdk/java/awt/FontMetrics/ExtremeFontSizeTest.java line 39: >> >>> 37: /* >>> 38: * @test >>> 39: * @bug 8328896 8357672 >> >> I thought Freetype rasterizer is used on all platforms(Linux, Windows & >> macOS) by default. Since Freetype

Re: RFR: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Jayathirth D V
On Wed, 28 May 2025 20:19:42 GMT, Phil Race wrote: > Instrumenting the existing ExtremeFontSizeTest.java, it was noted that the > freetype code, when encountering a null return from getting a scaler context, > would over-interpret this as a bad font. > The test was intended to check this wasn't

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v6]

2025-05-27 Thread Jayathirth D V
On Mon, 26 May 2025 05:29:45 GMT, Jeremy Wood wrote: >> This resolves a gif parsing bug where an unwanted opaque rectangle could >> appear under these conditions: >> >> 1. The disposal method for frames is 1 (meaning "do not dispose", aka >> "DISPOSAL_SAVE") >> 2. The transparent pixel is non-

Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep [v2]

2025-05-25 Thread Jayathirth D V
On Fri, 23 May 2025 11:38:32 GMT, Jayathirth D V wrote: >> In stress based scenarios it is observed that nothing is drawn in UI content >> when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i >> am not able to reproduce it, but based on details in the

Integrated: 8312198: [macos] metal pipeline - window rendering stops after display sleep

2025-05-25 Thread Jayathirth D V
On Wed, 21 May 2025 06:11:18 GMT, Jayathirth D V wrote: > In stress based scenarios it is observed that nothing is drawn in UI content > when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i > am not able to reproduce it, but based on details in the bug it look

Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep [v2]

2025-05-23 Thread Jayathirth D V
On Thu, 22 May 2025 08:07:34 GMT, Alexey Ushakov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add macro > > src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLaye

Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep [v2]

2025-05-23 Thread Jayathirth D V
deprecated from macOS 14 and going forward we need to use > CADisplayLink/CAMetalDisplayLink. I have raised > [JDK-8357418](https://bugs.openjdk.org/browse/JDK-8357418) for the same. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Ad

Re: RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]

2025-05-22 Thread Jayathirth D V
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote: >> Unfortunately I'm unable to reproduce this failure. I slowed the test down; >> it passes on my machine before and after this PR. >> >> I added a little bit of logging that might also help identify what's >> happening. >> >> Does anyone h

Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep

2025-05-22 Thread Jayathirth D V
On Thu, 22 May 2025 03:04:44 GMT, Sergey Bylokhov wrote: > Is it possible that it is somehow related to 8304825? could be the layer > created "during display sleep" and that might be in "sleep" more that 5 > seconds? This is follow-up fix for JDK-8304825. Basically we have a race condition be

RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep

2025-05-21 Thread Jayathirth D V
In stress based scenarios it is observed that nothing is drawn in UI content when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i am not able to reproduce it, but based on details in the bug it looks like we are hitting a race condition. Call to CVDisplayLinkCreateWithAct

Re: RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]

2025-05-20 Thread Jayathirth D V
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote: >> Unfortunately I'm unable to reproduce this failure. I slowed the test down; >> it passes on my machine before and after this PR. >> >> I added a little bit of logging that might also help identify what's >> happening. >> >> Does anyone h

Re: RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]

2025-05-20 Thread Jayathirth D V
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote: >> Unfortunately I'm unable to reproduce this failure. I slowed the test down; >> it passes on my machine before and after this PR. >> >> I added a little bit of logging that might also help identify what's >> happening. >> >> Does anyone h

Re: RFR: 8356145: ListEnterExitTest.java fails on macos

2025-05-19 Thread Jayathirth D V
On Mon, 19 May 2025 08:15:29 GMT, Abhishek Kumar wrote: > Test was failing on macOS 14.7.1 system in CI pipeline. Logged output > suggests that the mouse exit event is not triggered and thus the test fails. > Increased number of list items and adjusted the X and Y offset for mouse move > events

Re: RFR: 8356752: Log mouse enter and exit events for debugging

2025-05-12 Thread Jayathirth D V
On Mon, 12 May 2025 07:20:43 GMT, Abhishek Kumar wrote: > Log mouse events output to analyze the failure in CI pipeline. Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25176#pullrequestreview-2832349394

Re: RFR: 8354418: Open source Swing tests Batch 4 [v2]

2025-04-18 Thread Jayathirth D V
On Thu, 17 Apr 2025 04:25:59 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review comment > > test/jdk/com/sun/java/swing/plaf/windows

Integrated: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64

2025-04-18 Thread Jayathirth D V
On Thu, 17 Apr 2025 05:59:03 GMT, Jayathirth D V wrote: > javax/swing/AbstractButton/bug4133768.java was automated and open-sourced > recently and it fails intermittently in CI. > > Looks like when we have mouse pointer at same location from where we are > picking UI color

Re: RFR: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64 [v2]

2025-04-18 Thread Jayathirth D V
On Fri, 18 Apr 2025 08:17:10 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update > > test/jdk/javax/swing/AbstractButton/bug4133768.java line 1: > >

Re: RFR: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64 [v2]

2025-04-18 Thread Jayathirth D V
have mouse pointer to be at different place from where we are > picking roll-over color of buttons. > Also made other changes to make test more robust. With all these changes test > now passes all the time in CI. Jayathirth D V has updated the pull request incrementally with one add

Re: RFR: 8354365: Opensource few Modal and Full Screen related tests [v3]

2025-04-18 Thread Jayathirth D V
On Thu, 17 Apr 2025 12:31:48 GMT, Abhishek Kumar wrote: >> Few Modal and Full Screen related tests are converted from applet and open >> sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Typo fix Marked as review

Re: RFR: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64

2025-04-18 Thread Jayathirth D V
On Fri, 18 Apr 2025 07:27:57 GMT, Abhishek Kumar wrote: >> You had any background window while running this test? >> Also make sure if you have proper color profile for display. >> It runs properly in my machine and our CI with 50 test runs on all platforms. >> >> I can add tolerance, but since

Re: RFR: 8353661: Open source several swing tests batch5

2025-04-18 Thread Jayathirth D V
On Tue, 15 Apr 2025 22:37:05 GMT, Damon Nguyen wrote: > Open-sourcing and standardizing several tests (windows & JSlider) Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24671#pullrequestreview-2777857023

Re: RFR: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64

2025-04-17 Thread Jayathirth D V
On Fri, 18 Apr 2025 05:53:01 GMT, Abhishek Kumar wrote: >> javax/swing/AbstractButton/bug4133768.java was automated and open-sourced >> recently and it fails intermittently in CI. >> >> Looks like when we have mouse pointer at same location from where we are >> picking UI color from robot, it

Integrated: 8354285: Open source Swing tests Batch 3

2025-04-17 Thread Jayathirth D V
On Wed, 16 Apr 2025 08:42:20 GMT, Jayathirth D V wrote: > Open source some of the swing LAF tests This pull request has now been integrated. Changeset: 4c994894 Author: Jayathirth D V URL: https://git.openjdk.org/jdk/commit/4c99489420bd73159eca6bae22442f7b29156c1d Stats:

Integrated: 8354418: Open source Swing tests Batch 4

2025-04-17 Thread Jayathirth D V
On Wed, 16 Apr 2025 08:54:29 GMT, Jayathirth D V wrote: > Open source some of the swing windows LAF tests This pull request has now been integrated. Changeset: dda4b5a4 Author: Jayathirth D V URL: https://git.openjdk.org/jdk/commit/dda4b5a4ade2e5d7225117e58fce4038bb0e0f1b St

Re: RFR: 8354451: Open source some more Swing popup menu tests [v3]

2025-04-17 Thread Jayathirth D V
On Wed, 16 Apr 2025 20:33:06 GMT, Phil Race wrote: >> Open source some more Swing menu tests > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8354451 Can we automate test/jdk/javax/swing/JPopupMenu/bug4188832.java ? Or do we w

Re: RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

2025-04-17 Thread Jayathirth D V
On Thu, 17 Apr 2025 06:31:03 GMT, Abhishek Kumar wrote: >> Few Modal and Full Screen related tests are converted from applet and open >> sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix Marked as revi

RFR: 8354900: javax/swing/AbstractButton/bug4133768.java failing on macosx-aarch64

2025-04-17 Thread Jayathirth D V
javax/swing/AbstractButton/bug4133768.java was automated and open-sourced recently and it fails intermittently in CI. Looks like when we have mouse pointer at same location from where we are picking UI color from robot, it picks wrong color. Updated test to have mouse pointer to be at different

Re: RFR: 8354418: Open source Swing tests Batch 4 [v2]

2025-04-16 Thread Jayathirth D V
> Open source some of the swing windows LAF tests Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review comment - Changes: - all: https://git.openjdk.org/jdk/pull/24678/files - new: ht

Re: RFR: 8354285: Open source Swing tests Batch 3 [v2]

2025-04-16 Thread Jayathirth D V
> Open source some of the swing LAF tests Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review - Changes: - all: https://git.openjdk.org/jdk/pull/24677/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8354285: Open source Swing tests Batch 3 [v2]

2025-04-16 Thread Jayathirth D V
On Thu, 17 Apr 2025 04:24:57 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/com/sun/java/swing/plaf/windows/MenuItem/4685

RFR: 8354285: Open source Swing tests Batch 3

2025-04-16 Thread Jayathirth D V
Open source some of the swing LAF tests - Commit messages: - 8354285: Open source Swing tests Batch 3 Changes: https://git.openjdk.org/jdk/pull/24677/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24677&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354285 Stats:

Integrated: 8354214: Open source Swing tests Batch 2

2025-04-15 Thread Jayathirth D V
On Fri, 11 Apr 2025 05:52:47 GMT, Jayathirth D V wrote: > Few swing JList tests are open sourced. This pull request has now been integrated. Changeset: 2be5bc84 Author: Jayathirth D V URL: https://git.openjdk.org/jdk/commit/2be5bc847a444f08a4ebb41b58e8a2bf4553d621 Stats:

Re: RFR: 8352682: Opensource JComponent tests [v3]

2025-04-15 Thread Jayathirth D V
On Mon, 14 Apr 2025 12:53:59 GMT, Prasanta Sadhukhan wrote: >> Few JComponent tests are opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Redundant method removed Marked as reviewed by jdv (Reviewer). ---

RFR: 8354163: Open source Swing tests Batch 1

2025-04-15 Thread Jayathirth D V
Few Swing AbstractButton, JList and JMenu tests are open sourced. - Commit messages: - Update - 8354163: Open source Swing tests Batch 1 Changes: https://git.openjdk.org/jdk/pull/24650/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24650&range=00 Issue: https://bugs.ope

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2 [v2]

2025-04-15 Thread Jayathirth D V
On Tue, 15 Apr 2025 11:02:39 GMT, Tejesh R wrote: >> Open source these AWT TextComponent tests: >> >> java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java >> java/awt/TextComponent/SelectionTest/SelectionTest.java >> java/awt/TextComponent/CorrectTextComponentSelectionTest/C

Re: RFR: 8353589: Open source a few Swing menu-related tests [v2]

2025-04-15 Thread Jayathirth D V
On Mon, 7 Apr 2025 16:41:37 GMT, Phil Race wrote: >> Open source a few tests related to Swing menus. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8353589 LGTM. Also tested them on my macOS machine. - Marked a

Integrated: 8354163: Open source Swing tests Batch 1

2025-04-15 Thread Jayathirth D V
On Tue, 15 Apr 2025 07:09:51 GMT, Jayathirth D V wrote: > Few Swing AbstractButton, JList and JMenu tests are open sourced. This pull request has now been integrated. Changeset: b7837843 Author: Jayathirth D V URL: https://git.openjdk.org/jdk/com

Re: RFR: 8354163: Open source Swing tests Batch 1 [v2]

2025-04-15 Thread Jayathirth D V
On Tue, 15 Apr 2025 07:28:39 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/AbstractButton/bug4133768.java line 54: >> >>> 52: private static AbstractButton[] buttons; >>> 53: private static Point buttonLocation; >>> 54: private static int buttonWidth, buttonHeight; >> >> d

Re: RFR: 8354163: Open source Swing tests Batch 1 [v2]

2025-04-15 Thread Jayathirth D V
On Tue, 15 Apr 2025 07:26:44 GMT, Prasanta Sadhukhan wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review comments > > test/jdk/javax/swing/AbstractButton/bug

Re: RFR: 8354163: Open source Swing tests Batch 1 [v2]

2025-04-15 Thread Jayathirth D V
> Few Swing AbstractButton, JList and JMenu tests are open sourced. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review comments - Changes: - all: https://git.openjdk.org/jdk/pull/24650/files -

Re: RFR: 8354214: Open source Swing tests Batch 2 [v3]

2025-04-15 Thread Jayathirth D V
> Few swing JList tests are open sourced. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review comments - Changes: - all: https://git.openjdk.org/jdk/pull/24588/files - new: https://git.openjdk.

Re: RFR: 8354214: Open source Swing tests Batch 2 [v2]

2025-04-15 Thread Jayathirth D V
On Mon, 14 Apr 2025 11:26:18 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/javax/swing/JList/bug4193267.java line 44: > &g

Re: RFR: 8354214: Open source Swing tests Batch 2 [v2]

2025-04-14 Thread Jayathirth D V
On Fri, 11 Apr 2025 20:19:30 GMT, Andrey Turbanov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/javax/swing/JList/bug4193267.java line 8

Re: RFR: 8354214: Open source Swing tests Batch 2 [v2]

2025-04-14 Thread Jayathirth D V
On Fri, 11 Apr 2025 10:31:14 GMT, Mikhail Yankelevich wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/javax/swing/JList/bug4618767.java line 2

Re: RFR: 8354214: Open source Swing tests Batch 2 [v2]

2025-04-14 Thread Jayathirth D V
> Few swing JList tests are open sourced. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review - Changes: - all: https://git.openjdk.org/jdk/pull/24588/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8354214: Open source Swing tests Batch 2 [v2]

2025-04-14 Thread Jayathirth D V
On Fri, 11 Apr 2025 17:14:06 GMT, Harshitha Onkar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/javax/swing/JList/bug4193267.java line 63: >

Re: RFR: 8353832: Opensource FontClass, Selection and Icon tests

2025-04-14 Thread Jayathirth D V
On Mon, 14 Apr 2025 05:57:16 GMT, Abhishek Kumar wrote: > Font Class, Selection adn Icon related Applet tests are converted to manual > and open sourced. Marked as reviewed by jdv (Reviewer). Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/2461

RFR: 8354214: Open source Swing tests Batch 2

2025-04-10 Thread Jayathirth D V
Few swing JList tests are open sourced. - Commit messages: - 8354214: Open source Swing tests Batch 2 Changes: https://git.openjdk.org/jdk/pull/24588/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24588&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354214 Stats:

Re: RFR: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Jayathirth D V
On Thu, 10 Apr 2025 16:35:33 GMT, Alexander Zvegintsev wrote: > Problem list two tests crashing XWayland server > Corresponding issue [JDK-8354097](https://bugs.openjdk.org/browse/JDK-8354097) Suggestion: Since we will be streamlining things to run on Ubuntu 24.04 & Wayland, we can use/add uti

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v2]

2025-02-16 Thread Jayathirth D V
On Thu, 13 Feb 2025 22:00:26 GMT, Harshitha Onkar wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc update > > src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1154: > >> 1152: * T

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v4]

2025-02-16 Thread Jayathirth D V
On Thu, 13 Feb 2025 23:15:52 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v9]

2025-01-23 Thread Jayathirth D V
On Tue, 21 Jan 2025 20:06:55 GMT, Harshitha Onkar wrote: >> ICC_Profile.setData(..) does validation of the specified tag contents and >> throws an exception if it is not valid. But if the tag represents the >> header, at least some of the validation is lazy, occurring only when the >> data is

Integrated: 8347911: Limit the length of inflated text chunks

2025-01-16 Thread Jayathirth D V
On Thu, 16 Jan 2025 11:52:14 GMT, Jayathirth D V wrote: > In PNG we have non-essential compressed text chunks zTXt and iTXt, which can > consume considerable amount of memory when they contain large amount of > compressed data. > > We should restrict the amount of text

RFR: 8347911: Limit the length of inflated text chunks

2025-01-16 Thread Jayathirth D V
In PNG we have non-essential compressed text chunks zTXt and iTXt, which can consume considerable amount of memory when they contain large amount of compressed data. We should restrict the amount of text data we want to decompress from these text chunks. This PR adds limit of 256k bytes of infl

Re: RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

2025-01-15 Thread Jayathirth D V
On Tue, 14 Jan 2025 20:45:14 GMT, Harshitha Onkar wrote: >>> our own profiles do not strictly follow these specification, so if lcms >>> ignores that we can do the same, especially since we fallback to the >>> "Perceptual intent" >>> >>> https://github.com/openjdk/jdk/blob/13a1775718f329b02cde

Re: RFR: 8339341: SurfaceManager cacheMap retains strong references [v4]

2024-10-09 Thread Jayathirth D V
On Thu, 19 Sep 2024 11:54:56 GMT, Nikita Gubarkov wrote: >> I moved SurfaceDataProxy cache into a separate class. >> Now caching level is determined by placement of the >> SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" >> proxies and therefore strong refs via them

Integrated: 8341162: Open source some of the AWT window test

2024-10-04 Thread Jayathirth D V
On Tue, 1 Oct 2024 10:34:53 GMT, Jayathirth D V wrote: > Clean up and open source some of the AWT window tests. > Automated test `OwnedWindowShowTest.java` is verified in our CI also and it > passes on all platforms. This pull request has now been integrated. Changeset: c8e70d

Re: RFR: 8341162: Open source some of the AWT window test [v4]

2024-10-04 Thread Jayathirth D V
On Fri, 4 Oct 2024 17:16:26 GMT, Jayathirth D V wrote: >> Clean up and open source some of the AWT window tests. >> Automated test `OwnedWindowShowTest.java` is verified in our CI also and it >> passes on all platforms. > > Jayathirth D V has updated the pull reques

Re: RFR: 8341162: Open source some of the AWT window test [v3]

2024-10-04 Thread Jayathirth D V
On Fri, 4 Oct 2024 13:41:19 GMT, Alexey Ivanov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update based on review comments > > test/jdk/java/awt/Window/LocationByPlatform/Te

Re: RFR: 8341162: Open source some of the AWT window test [v4]

2024-10-04 Thread Jayathirth D V
> Clean up and open source some of the AWT window tests. > Automated test `OwnedWindowShowTest.java` is verified in our CI also and it > passes on all platforms. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update f

Re: RFR: 8341298: Open source more AWT window tests [v3]

2024-10-04 Thread Jayathirth D V
On Fri, 4 Oct 2024 10:42:23 GMT, Jayathirth D V wrote: >> Clean up and open source more of the AWT window tests. >> Automated tests `PopupProxyCrash` and `NoResizeEvent` are also verified in >> our CI. > > Jayathirth D V has updated the pull request incrementally with

Integrated: 8341298: Open source more AWT window tests

2024-10-04 Thread Jayathirth D V
On Fri, 4 Oct 2024 07:33:42 GMT, Jayathirth D V wrote: > Clean up and open source more of the AWT window tests. > Automated tests `PopupProxyCrash` and `NoResizeEvent` are also verified in > our CI. This pull request has now been integrated. Changeset: db61458d Author:Jayathirth

Re: RFR: 8341298: Open source more AWT window tests [v2]

2024-10-04 Thread Jayathirth D V
On Fri, 4 Oct 2024 09:28:15 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add headful tag in PopupProxyCrash Test > > test/jdk/java/awt/Window/

Re: RFR: 8341298: Open source more AWT window tests [v3]

2024-10-04 Thread Jayathirth D V
> Clean up and open source more of the AWT window tests. > Automated tests `PopupProxyCrash` and `NoResizeEvent` are also verified in > our CI. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update based on review

Re: RFR: 8341298: Open source more AWT window tests [v2]

2024-10-04 Thread Jayathirth D V
> Clean up and open source more of the AWT window tests. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Add headful tag in PopupProxyCrash Test - Changes: - all: https://git.openjdk.org/jdk/pull/21348/files -

Re: RFR: 8341111: open source several AWT tests including menu shortcut tests [v2]

2024-10-04 Thread Jayathirth D V
On Thu, 3 Oct 2024 19:21:29 GMT, Phil Race wrote: >> Open source several AWT tests, mostly related to menu short cuts. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 834 Marked as reviewed by jdv (Reviewer). ---

  1   2   3   4   >