On Thu, 4 May 2023 17:36:33 GMT, Rajat Mahajan wrote:
>> **Problem:**
>>
>> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
>> reconstruct() function as we detect that we have missing information for the
>> animated image since we are copying single frame at a time.
>>
Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
-
Commit messages:
- Open source few Applet test
- Open source few Applet test
Changes: https://git.openjdk.org/jdk/pull/13828/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13828&range=00
Issu
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev
wrote:
> Modern Linux systems often come with
> [Wayland](https://wayland.freedesktop.org/) by default.
> This comes with some difficulties, and one of them is the inability to get
> screenshots from the system.
> This is because we now use
On Linux systems, we rely on XGrabPointer (X11 API) to capture mouse input and
dismiss popup menus on mouse clicks outside the popup menu.
Unfortunately, on Linux systems using the
[Wayland](https://wayland.freedesktop.org/) session this only works inside
[XWayland(Wayland's X11 server
implemen
On Wed, 3 May 2023 16:00:39 GMT, Tejesh R wrote:
>> Open source few AWT ScrollPane related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespace error
Changes requested by aivanov (Reviewer).
test/jdk/java
On Fri, 5 May 2023 12:27:04 GMT, Alexander Zvegintsev
wrote:
> I also have doubts about the need to change the documentation, as I can't
> find where it is described that the popup menu should be hidden when clicked
> outside the menu.
FWIW, I agree that you only need to change the documentat
On Wed, 5 Apr 2023 14:31:34 GMT, Nikita Gubarkov wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported &
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>> bilin
On Thu, 4 May 2023 19:32:45 GMT, Jiangli Zhou wrote:
>>> [...] I'll see if I can test this on a mandrel build tomorrow...
>>
>> @jianglizhou So I've tested this with a mandrel build and it doesn't break
>> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a)
>> doesn't
> Modern Linux systems often come with
> [Wayland](https://wayland.freedesktop.org/) by default.
> This comes with some difficulties, and one of them is the inability to get
> screenshots from the system.
> This is because we now use the [X Window System
> API](https://en.wikipedia.org/wiki/X_Wi
On Fri, 5 May 2023 09:33:00 GMT, Maxim Kartashev wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update, based on review comments
>> - remove wayland detection
>> - BUILD_LIBPIPEWIRE_HEADER_DIRS -> LI
On Thu, 4 May 2023 19:52:22 GMT, Erik Joelsson wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update, based on review comments
>> - remove wayland detection
>> - BUILD_LIBPIPEWIRE_HEADER_DIRS -> LIBP
On Fri, 5 May 2023 14:26:49 GMT, Alexander Zvegintsev
wrote:
> P.S. I removed synchronized modifier from getRGBPixels
My main point was that you don't seem to need to have both, and while I picked
one you picked the other ;-) So it's OK.
>> src/java.desktop/unix/native/libawt_xawt/awt/screenca
On Sat, 29 Apr 2023 19:26:00 GMT, Julian Waters wrote:
> In windowsaccessbridge(-64).dll the following methods are exported in a def
> file to C API which in turn call their real implementation, which are
> instance methods of the class WinAccessBridge:
>
> addJavaEventNotification
> removeJav
On Fri, 5 May 2023 02:37:28 GMT, Sergey Bylokhov wrote:
> > If the user wishes to change their mind about the screens allowed to be
> > captured, the user should use the new Robot#resetScreenCapturePermission
> > method
>
> Do we really need to add this new API? probably we can implement the f
On Fri, 5 May 2023 14:57:27 GMT, Daniel Jeliński wrote:
> FWIW, this is what dumpbin displays for these entries:
>
> ```
> 12 351C addAccessibilityEventNotification =
> ?addAccessibilityEventNotification@WinAccessBridge@@QEAAX_J@Z (public: void
> __cdecl WinAccessBridge::addA
GTK3 has been the default for several years now. GTK2 is now only available by
specifying it with the jdk.gtk.version system property. With the announcement
of the GTK 4 release in December 2020, the GTK 2 toolkit has reached its end of
life.
It is time to deprecate it for removal.
Since there
On Fri, 28 Apr 2023 18:34:36 GMT, Damon Nguyen wrote:
> This PR open sources more AWT DnD & Event related tests
This pull request has now been integrated.
Changeset: b5a48277
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/b5a48277ab5b42c4b13db7ddb5418a17ada512ec
Stats:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>> https://github.com/oracle/graal/blob/f1c1d710625ac84559
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Fri, 5 May 2023 16:43:46 GMT, Jiangli Zhou wrote:
>>> [...] I'll see if I can test this on a mandrel build tomorrow...
>>
>> @jianglizhou So I've tested this with a mandrel build and it doesn't break
>> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a)
>> doesn't
Harfbuzz updated from 7.0.1 to 7.2.0.
Files changed -
- harfbuzz.md file updated
- 1 newly added source file - hb-ot-var-cvar-table.hh
- 73 modified source files
Following testing was carried for the update and works as expected.
1. Client CI Testing
2. TextLayout related tests
3. Font2DTest
Open sourcing few more tests:
java/awt/datatransfer/MimeFormatsTest/MimeFormatsTest.java
java/awt/datatransfer/RemoveFlavorListenerTest/RemoveFlavorListenerTest.java
java/awt/dnd/AutoscrollStopTest/AutoscrollStopTest.java
java/awt/dnd/ButtonReleaseTest/ButtonReleaseTest.java
Testing looks good
On Thu, 4 May 2023 20:27:48 GMT, Harshitha Onkar wrote:
>> Open sourced the following JFrame, JIF related Swing tests.
>>
>>
>> test/jdk/javax/swing/JFrame/bug4101444.java
>> test/jdk/javax/swing/JFrame/bug4208018.java
>> test/jdk/javax/swing/JInternalFrame/bug4308938.java
>> test/jdk/javax/swi
On Fri, 5 May 2023 16:40:57 GMT, Harshitha Onkar wrote:
> Harfbuzz updated from 7.0.1 to 7.2.0.
>
> Files changed -
>
> - harfbuzz.md file updated
> - 1 newly added source file - hb-ot-var-cvar-table.hh
> - 73 modified source files
>
>
> Following testing was carried for the update and works
On Fri, 5 May 2023 16:54:20 GMT, Alexander Zvegintsev
wrote:
> Open sourcing few more tests:
>
>
> java/awt/datatransfer/MimeFormatsTest/MimeFormatsTest.java
> java/awt/datatransfer/RemoveFlavorListenerTest/RemoveFlavorListenerTest.java
> java/awt/dnd/AutoscrollStopTest/AutoscrollStopTest.java
On Fri, 5 May 2023 15:21:14 GMT, Alexander Zvegintsev
wrote:
> GTK3 has been the default for several years now. GTK2 is now only available
> by specifying it with the jdk.gtk.version system property. With the
> announcement of the GTK 4 release in December 2020, the GTK 2 toolkit has
> reache
On Fri, 5 May 2023 16:40:57 GMT, Harshitha Onkar wrote:
> Harfbuzz updated from 7.0.1 to 7.2.0.
>
> Files changed -
>
> - harfbuzz.md file updated
> - 1 newly added source file - hb-ot-var-cvar-table.hh
> - 73 modified source files
>
>
> Following testing was carried for the update and works
On Fri, 5 May 2023 15:04:36 GMT, Julian Waters wrote:
> > FWIW, this is what dumpbin displays for these entries:
> > ```
> > 12 351C addAccessibilityEventNotification =
> > ?addAccessibilityEventNotification@WinAccessBridge@@QEAAX_J@Z (public: void
> > __cdecl WinAccessBridge:
On Fri, 5 May 2023 05:25:55 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 365:
>>
>>> 363:
>>> 364: if (start >= 0 && end > start) {
>>> 365: List listStart_OldSize = new
>>> V
Open source few Swing JMenu tests
-
Commit messages:
- Initial test add
Changes: https://git.openjdk.org/jdk/pull/13839/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13839&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8307130
Stats: 272 lines in 4 files changed:
On Fri, 5 May 2023 09:54:36 GMT, Tejesh R wrote:
> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
test/jdk/java/awt/Panel/SetForegroundTest.java line 33:
> 31: import java.awt.Color;
> 32:
> 33: import javax.swing.JWindow;
Would be nice to have an empty line her
On Wed, 3 May 2023 11:00:36 GMT, Prasanta Sadhukhan
wrote:
>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual()
>> method which can fail due to missing implementation of equals method in CSS
>> subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font
On Wed, 3 May 2023 21:14:25 GMT, Phil Race wrote:
>> I'm pretty sure the test will still pass because Java compiler interns
>> strings. You have to explicitly create a new instance of the String to make
>> the test fail.
>>
>> In real applications, attributes are parsed from a style sheet and
On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan wrote:
> **Problem:**
>
> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
> reconstruct() function as we detect that we have missing information for the
> animated image since we are copying single frame at a time.
> Due t
On Fri, 5 May 2023 04:56:22 GMT, Abhishek Kumar wrote:
> This PR is to open source JMenuItem related swing tests.
test/jdk/javax/swing/JMenuItem/bug4304129.java line 47:
> 45: public static void main(String args[]) throws Exception {
> 46: bug4304129 test = new bug4304129();
> 47:
On Fri, 5 May 2023 17:41:26 GMT, Damon Nguyen wrote:
> Open source few Swing JMenu tests
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13839#pullrequestreview-1415239602
On Wed, 3 May 2023 20:58:00 GMT, Harshitha Onkar wrote:
> Open sourced the following JFrame, JIF related Swing tests.
>
>
> test/jdk/javax/swing/JFrame/bug4101444.java
> test/jdk/javax/swing/JFrame/bug4208018.java
> test/jdk/javax/swing/JInternalFrame/bug4308938.java
> test/jdk/javax/swing/JInt
> moving tests to open
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/java/awt/dnd/MissedDragEnterTest.java
Co-authored-by: Andrey Turbanov
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1376
On Fri, 5 May 2023 15:21:14 GMT, Alexander Zvegintsev
wrote:
> GTK3 has been the default for several years now. GTK2 is now only available
> by specifying it with the jdk.gtk.version system property. With the
> announcement of the GTK 4 release in December 2020, the GTK 2 toolkit has
> reache
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
> When converting this test to be applicable to be open sourced, changes were
> made. I reverted some of these changes to get the test stable again. Now it
> passes when run on various OS's 100x.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last r
update freetype version to 2.13, all tests passed
-
Commit messages:
- fixed whitespace errors
- removed extra copyright line from md file
- fixed spacing in md file
- updated freetype.md
- updated config files
- added dependencies for freetype
- update freetype.md
- revert fr
On Fri, 5 May 2023 18:28:38 GMT, Alisen Chung wrote:
> update freetype version to 2.13, all tests passed
Can you also confirm that you compiled this using the option discussed in
UPDATING.txt, ie
When updating specify --with-freetype=bundled to test builds to expose build
issues.
This is impo
On Wed, 3 May 2023 20:51:15 GMT, Phil Race wrote:
>> This work is primarily about adding `@spec` tags, in a semi-automated
>> fashion, using a custom utility that scans comments in the public API,
>> looking for `href`s to "well-known" sites hosting external specifications.
>> While "mostly a
On Fri, 7 Apr 2023 01:36:37 GMT, Phil Race wrote:
>> Please review a docs-only change to add `@spec` tags into `java.desktop`
>> public API files
>
> src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java
> line 227:
>
>> 225: * @spec https://www.rfc-editor.org/
On Fri, 5 May 2023 22:19:38 GMT, Jonathan Gibbons wrote:
>> Sorry, but no matter how many times I try, it seems wrong to even for some
>> short amount of time to have @spec point to one place and the javadoc point
>> to another. They should always be consistent.
>> If it is out of scope to upd
On Fri, 5 May 2023 22:19:03 GMT, Jonathan Gibbons wrote:
>> src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java
>> line 227:
>>
>>> 225: * @spec https://www.rfc-editor.org/info/rfc1951
>>> 226: * RFC 1951: DEFLATE Compressed Data Format Specification
On Fri, 5 May 2023 04:56:22 GMT, Abhishek Kumar wrote:
> This PR is to open source JMenuItem related swing tests.
test/jdk/javax/swing/JMenuItem/bug4839464.java line 29:
> 27: @summary Shortcoming in the way JMenuItem handles 'propertyChange()'
> events.
> 28: @library ../../regtesthel
On Fri, 5 May 2023 04:56:22 GMT, Abhishek Kumar wrote:
> This PR is to open source JMenuItem related swing tests.
test/jdk/javax/swing/JMenuItem/bug4839464.java line 220:
> 218: // Check mnemonics
> 219: int tmpInt = item.getMnemonic();
> 220: robo.clickMouseOn(changeMne
On Sat, 6 May 2023 00:17:01 GMT, Damon Nguyen wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> test/jdk/javax/swing/JMenuItem/bug4839464.java line 29:
>
>> 27: @summary Shortcoming in the way JMenuItem handles 'propertyChange()'
>> events.
>> 28: @library ../../reg
> Open source few Swing JMenu tests
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Add Util. Change helper path
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13839/files
- new: https://git.openjdk.org/jdk/pull/
The fix disables expansion-to-defined warning for gcc.
Thanks.
-
Commit messages:
- 8307569: Build with gcc8 is broken after JDK-8307301
Changes: https://git.openjdk.org/jdk/pull/13850/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13850&range=00
Issue: https://bugs.openj
> The fix disables expansion-to-defined warning for gcc.
> Thanks.
Jie Fu has updated the pull request incrementally with one additional commit
since the last revision:
Add comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13850/files
- new: https://git.openjdk.org/j
On Sat, 6 May 2023 01:41:11 GMT, Jie Fu wrote:
>> The fix disables expansion-to-defined warning for gcc.
>> Thanks.
>
> Jie Fu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Add comment
It failed with gcc8 & gcc9, but passed with gcc10+.
On Fri, 5 May 2023 16:54:20 GMT, Alexander Zvegintsev
wrote:
> Open sourcing few more tests:
>
>
> java/awt/datatransfer/MimeFormatsTest/MimeFormatsTest.java
> java/awt/datatransfer/RemoveFlavorListenerTest/RemoveFlavorListenerTest.java
> java/awt/dnd/AutoscrollStopTest/AutoscrollStopTest.java
> update freetype version to 2.13, all tests passed
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
readd spaces to comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13841/files
- new: https://git.openjdk.o
58 matches
Mail list logo
