Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-08-22 Thread Magnus Ihse Bursie
On Thu, 22 Aug 2024 00:30:07 GMT, Jiangli Zhou wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Also update build to link properly > > I compared the extracted changes in this PR with the related parts in > h

Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-08-22 Thread Magnus Ihse Bursie
On Thu, 22 Aug 2024 02:46:34 GMT, David Holmes wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Also update build to link properly > > Sorry but I don't understand the point of changing build-time constructs

Re: RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]

2024-08-22 Thread Harshitha Onkar
On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R wrote: >> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow >> native actions of Linux. In native the actions are extended to end of >> selected columns cells either LEFT/RIGHT but in swing gtk look and feel the >> selection is

RFR: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used

2024-08-22 Thread Sergey Bylokhov
The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is deleted. It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485): Refactor java.awt.datatransfer to eliminate dependency on AWT. See: https://github.com/openjdk/jdk/commit/0fecd7769453dfb3ef1609b057a9e

Withdrawn: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-08-22 Thread duke
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > This fix will resolve page range not printing proper pages if the rage begin > from 2 or above on Mac machines. > I have verified the manual range related tests like PageRanges.java, > ClippedImages.java

Re: Seeking feedback on a possible JDatePicker Swing component

2024-08-22 Thread SWinxy
Tejesh, I think it would be a nice feature, and I would be happy to help with it. There are a lot of considerations for displaying calendars. I don't think we should have the date & time combined into one UI component, but separate components, the former of which I'll focus on here. There are two p

Re: RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v4]

2024-08-22 Thread Manukumar V S
> This PR creates a new test by stabilising and open sourcing a closed test. > This test verifies that the OpenGL pipeline does not create artifacts with > swing components after window is zoomed to maximum size and then resized back > to normal. > This test is run twice, with and without the fla

Re: RFR: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used

2024-08-22 Thread SWinxy
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote: > The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is > deleted. > > It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485): > Refactor java.awt.datatransfer to eliminate dependency on AWT. > >

Re: RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]

2024-08-22 Thread Alisen Chung
On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R wrote: >> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow >> native actions of Linux. In native the actions are extended to end of >> selected columns cells either LEFT/RIGHT but in swing gtk look and feel the >> selection is

client-libs-dev@openjdk.org

2024-08-22 Thread Alisen Chung
On Thu, 22 Aug 2024 05:24:24 GMT, Abhishek Kumar wrote: > This test should have failed with the > [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for > [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't > because GTK look and feel isn't supported in headle

client-libs-dev@openjdk.org

2024-08-22 Thread Harshitha Onkar
On Thu, 22 Aug 2024 21:32:08 GMT, Alisen Chung wrote: >> This test should have failed with the >> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for >> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't >> because GTK look and feel isn't supported in head

client-libs-dev@openjdk.org

2024-08-22 Thread Harshitha Onkar
On Thu, 22 Aug 2024 05:24:24 GMT, Abhishek Kumar wrote: > This test should have failed with the > [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for > [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't > because GTK look and feel isn't supported in headle

Re: RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]

2024-08-22 Thread Harshitha Onkar
On Thu, 22 Aug 2024 21:24:50 GMT, Alisen Chung wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> sin

Re: RFR: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used

2024-08-22 Thread Harshitha Onkar
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote: > The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is > deleted. > > It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485): > Refactor java.awt.datatransfer to eliminate dependency on AWT. > >

Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-08-22 Thread David Holmes
On Thu, 22 Aug 2024 08:54:56 GMT, Magnus Ihse Bursie wrote: >> Sorry but I don't understand the point of changing build-time constructs >> using `ifdef STATIC_BUILD` into what appear to be runtime checks, but the >> result of which is already determined at build time. These are not really >> r

Re: RFR: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used

2024-08-22 Thread Damon Nguyen
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote: > The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is > deleted. > > It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485): > Refactor java.awt.datatransfer to eliminate dependency on AWT. > >

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v3]

2024-08-22 Thread Damon Nguyen
On Tue, 30 Jul 2024 05:17:12 GMT, Tejesh R wrote: >> Mismatch in key combinations, I have taken native macos Numbers application >> as reference to verify. Have added `Ctrl-Shift Left/Right` action keys >> similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've >> removed t

Re: RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable [v5]

2024-08-22 Thread Prasanta Sadhukhan
On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung wrote: >> Currently the bug described in the issue is that the colors of the >> TextComponents do not change when setting TextComponents to uneditable. The >> default uneditable color (SystemColor.control) happens to be the same as the >> default

Re: RFR: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used

2024-08-22 Thread Phil Race
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote: > The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is > deleted. > > It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485): > Refactor java.awt.datatransfer to eliminate dependency on AWT. > >

Re: RFR: 4795384: GTK+ JFileChooser buttons should have mnemonics [v2]

2024-08-22 Thread Phil Race
On Mon, 19 Aug 2024 07:32:26 GMT, Abhishek Kumar wrote: >> JFileChooser don't have the mnemonics for open and save button in GTK L&F. >> Fix is to add mnemonics for open and save button. >> Fix can be verified by Swingset2 demo application. Mnemonics in GTK L&F are >> visible once alt key is pr

RE: [External] : Re: Seeking feedback on a possible JDatePicker Swing component

2024-08-22 Thread Tejesh R
Hello SWinxy, Thank you for the feedback. We will consider your feedback suggestions and these are really helpful in this proposal. Regards, Tejesh R From: SWinxy Sent: 22 August 2024 23:37 To: Tejesh R Cc: client-libs-...@openjdk.java.net Subject: [External] : Re: Seeking feedb

Re: RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable [v5]

2024-08-22 Thread Abhishek Kumar
On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung wrote: >> Currently the bug described in the issue is that the colors of the >> TextComponents do not change when setting TextComponents to uneditable. The >> default uneditable color (SystemColor.control) happens to be the same as the >> default

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work

2024-08-22 Thread Abhishek Kumar
On Thu, 25 Jul 2024 16:07:11 GMT, Tejesh R wrote: >> @TejeshR13 Looks like the bug is not accessible. > >> @TejeshR13 Looks like the bug is not accessible. > > Update the bug, PR should sync with the updates. @TejeshR13 Already approved by me. Are you going to address Damon's comment `also a h

Re: RFR: 4795384: GTK+ JFileChooser buttons should have mnemonics [v2]

2024-08-22 Thread Abhishek Kumar
On Fri, 23 Aug 2024 04:43:12 GMT, Phil Race wrote: > After some "umming" I think we should withdraw this PR The bug > https://bugs.openjdk.org/browse/JDK-4795384 is a VERY old bug which said lots > of things didn't have a mnemonic. Looks to me like most were addressed, then > a couple which we

Withdrawn: 4795384: GTK+ JFileChooser buttons should have mnemonics

2024-08-22 Thread Abhishek Kumar
On Fri, 16 Aug 2024 09:59:26 GMT, Abhishek Kumar wrote: > JFileChooser don't have the mnemonics for open and save button in GTK L&F. > Fix is to add mnemonics for open and save button. > Fix can be verified by Swingset2 demo application. Mnemonics in GTK L&F are > visible once alt key is presse

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v3]

2024-08-22 Thread Tejesh R
On Thu, 22 Aug 2024 23:54:08 GMT, Damon Nguyen wrote: > If the test window (not the instruction window) can't be expanded more, then > LGTM. The test window has a vertical scroll (which is fine), but also a > horizontal scroll (which can be avoided by expanding the width a bit more). > > Teste

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v3]

2024-08-22 Thread Abhishek Kumar
On Tue, 30 Jul 2024 05:17:12 GMT, Tejesh R wrote: >> Mismatch in key combinations, I have taken native macos Numbers application >> as reference to verify. Have added `Ctrl-Shift Left/Right` action keys >> similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've >> removed t