Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-10 Thread Daniel Gredler
On Mon, 17 Feb 2025 14:06:53 GMT, Daniel Gredler wrote: > On other platforms like Windows and Linux, the `\n`, `\r` and `\t` characters > are ignored when drawing text to a `Graphics2D` object. On macOS this is not > currently the case. > > See, for example, `CMap.getControlCodeGlyph(int, bool

Re: RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-10 Thread Abhishek Kumar
On Mon, 10 Mar 2025 14:48:09 GMT, Rajat Mahajan wrote: > Added code to Iterates over all installed Look and Feel environments and > added related exception handling. > > Testing done. test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 1: > 1: /* Minor changes can be done 1. mainF

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v7]

2025-03-10 Thread Phil Race
On Mon, 10 Mar 2025 13:28:16 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for

Re: RFR: 8286204: [Accessibility, macOS, VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS [v3]

2025-03-10 Thread Harshitha Onkar
On Mon, 3 Mar 2025 12:11:30 GMT, Abhishek Kumar wrote: >> VoiceOver is unable to announce the correct value for spinner. For JSpinner >> with maximum value of more than 10, VO announce 10 as 1, 20 as 2 and so on. >> Probable reason is the "ACCESSIBLE_TEXT_PROPERTY" fired by accessible >> JText

Withdrawn: 8337505: Footprint and startup regressions up to 20% in GUI apps

2025-03-10 Thread duke
On Mon, 28 Oct 2024 21:26:38 GMT, Phil Race wrote: > https://bugs.openjdk.org/browse/JDK-8338677 already improved things for this > so that's good. > > This fix adds to it lazy initialisation of VarHandles in StrikeCache at the > cost of some extra code. > Since these VarHandles get used more

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v4]

2025-03-10 Thread Alexey Ivanov
On Mon, 10 Mar 2025 18:22:49 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-10 Thread Alexey Ivanov
On Mon, 10 Mar 2025 17:17:28 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v11]

2025-03-10 Thread Harshitha Onkar
On Thu, 6 Mar 2025 20:20:28 GMT, Sergey Bylokhov wrote: >> Yes, readObject(..) and readResolve(..) will return the singleton, as per >> the serialization spec 👍 >> https://docs.oracle.com/en/java/javase/21/docs/api/serialized-form.html#java.awt.color.ICC_Profile >> but I agree we don't need to

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-10 Thread Alexey Ivanov
On Mon, 10 Mar 2025 17:20:36 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v3]

2025-03-10 Thread Phil Race
On Fri, 21 Feb 2025 21:13:16 GMT, Daniel Gredler wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which d

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-10 Thread Phil Race
On Mon, 17 Feb 2025 14:06:53 GMT, Daniel Gredler wrote: > On other platforms like Windows and Linux, the `\n`, `\r` and `\t` characters > are ignored when drawing text to a `Graphics2D` object. On macOS this is not > currently the case. > > See, for example, `CMap.getControlCodeGlyph(int, bool

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-10 Thread Phil Race
On Mon, 17 Feb 2025 14:06:53 GMT, Daniel Gredler wrote: > On other platforms like Windows and Linux, the `\n`, `\r` and `\t` characters > are ignored when drawing text to a `Graphics2D` object. On macOS this is not > currently the case. > > See, for example, `CMap.getControlCodeGlyph(int, bool

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-10 Thread Erik Joelsson
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v14]

2025-03-10 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-10 Thread Alexey Ivanov
On Mon, 10 Mar 2025 17:17:18 GMT, Jeremy Wood wrote: >> test/jdk/javax/imageio/plugins/jpeg/JpegWriterWriteNonOpaqueIndexColorModelTest.java >> line 81: >> >>> 79: e.printStackTrace(); >>> 80: return false; >>> 81: } >> >> Should an exception be allowed to escap

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v11]

2025-03-10 Thread Phil Race
On Fri, 7 Mar 2025 01:37:53 GMT, Sergey Bylokhov wrote: >>>If an app got a profile 'from some place', it probably should not be trying >>>to change it, >> >> But this is not always possible. For example, a buffered image has a color >> model that references a color space and a color profile. T

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote: >>> What is the intended way of using this? Do you run make with >>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the >>> specific way of linking to pthread? >> >> This is in preparation of the upcoming BSD port, which use

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v7]

2025-03-10 Thread Phil Race
On Mon, 10 Mar 2025 13:28:16 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-10 Thread Harshitha Onkar
On Mon, 10 Mar 2025 20:13:51 GMT, Daniel Gredler wrote: >> On other platforms like Windows and Linux, the `\n`, `\r` and `\t` >> characters are ignored when drawing text to a `Graphics2D` object. On macOS >> this is not currently the case. >> >> See, for example, `CMap.getControlCodeGlyph(int,

RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-10 Thread Rajat Mahajan
Added code to Iterates over all installed Look and Feel environments and added related exception handling. Testing done. - Commit messages: - removed unnecessary import - code refactoring - modified code to do exception handling better - 8280818: Expand bug8033699.java to iterat

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v10]

2025-03-10 Thread duke
On Tue, 4 Mar 2025 03:41:10 GMT, Jeremy Wood wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-10 Thread Daniel Gredler
On Mon, 10 Mar 2025 20:37:57 GMT, Harshitha Onkar wrote: >> Good news: it looks like it was possible to resolve the `0x` conflict on >> the HarfBuzz side by adjusting the HarfBuzz internal representation of AAT >> deleted glyphs. Amazingly quick turnaround from @behdad! I think we'll want

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v4]

2025-03-10 Thread Jeremy Wood
On Mon, 10 Mar 2025 17:28:12 GMT, Alexey Ivanov wrote: >> This is by design. >> >> The main method resembles: >> >> public static void main(String[] args) throws IOException { >> boolean b1 = testJpegWriter(Transparency.OPAQUE, "OPAQUE", true); >> boolean b2 = testJpegWriter

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v13]

2025-03-10 Thread Harshitha Onkar
On Thu, 6 Mar 2025 03:21:58 GMT, Sergey Bylokhov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor > > test/jdk/java/awt/color/ICC_ProfileSetNullDataTest.java line 37: > >> 35: ColorSpace.CS_PYC