On Wed, 19 Mar 2025 08:52:34 GMT, Tejesh R wrote:
>> In SwingSet2 JTable demo before the fix also, you can see only
>> "rowSelection" is enabled, but selectAll selects all cells in the table so
>> selectAll overrides that setting..
>
> Ok.
Added columnSelection check..SwingSet2 selectAll selec
> JTable.selectAll doesn't do anything if there are no rows or no columns.
> But it should still select all columns if there are no rows and the other way
> round.
> It is seen that isColumnSelected() will return false for all columns after
> calling selectAll() if there happened to be no rows.
On Sun, 16 Mar 2025 08:56:24 GMT, Manukumar V S wrote:
> **Issue**
> java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not
> supported
>
> **Reason**
> In `MailTest.java`, there is a condition check(`if
> (!desktop.isSupported(Desktop.Action.MAIL))`) which will force pass
On Wed, 19 Mar 2025 07:30:17 GMT, Tejesh R wrote:
>> Yes, good catch..we need to use local variable as done in old code and not
>> modify the class variables..Modified to store the instance variable in local
>> and use that..
>
> I didn't mean that, I meant the other way. This would still modif
On Wed, 19 Mar 2025 07:28:17 GMT, Prasanta Sadhukhan
wrote:
>> [Here](https://github.com/openjdk/jdk/blob/577ede73d8e916bac9050d3bee80d2f18cc833a7/src/java.desktop/share/classes/javax/swing/JTable.java#L5629)
>
> ok..But selectAll selects all cells as per the spec Spec says "Selects all
> rows,
On Wed, 19 Mar 2025 06:17:37 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 2188:
>>
>>> 2186: }
>>> 2187: if (rowCount > 0 && columnCount > 0) {
>>> 2188: selectRows(selectionModel, rowCount);
>>
>> Any reason for pass
On Wed, 19 Mar 2025 06:19:07 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 2162:
>>
>>> 2160: }
>>> 2161:
>>> 2162: private void selectColumns(TableColumnModel columnModel, int
>>> columnCount) {
>>
>> Should we check whether column se
On Fri, 28 Feb 2025 10:09:30 GMT, Roman Marchenko
wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also, after PR discussion, added the approptiate test cases with
>> corresponding fixes
On Mon, 3 Mar 2025 05:57:33 GMT, Phil Race wrote:
> The font tests that fail use non-finite or NaN float values.
> In such cases, no visible rendering is expected and the NaNTransform test
> does pass with empty shapes, but we can filter out these invalid floats
> before they get to native.
> T
On Wed, 19 Mar 2025 13:46:18 GMT, Prasanta Sadhukhan
wrote:
> Added columnSelection check..SwingSet2 selectAll selection can be viewed as
> selecting all rows which can be perceived as selecting all cells, so to be
> safe added the check..
Moreover, It is seen that by unchecking "rowSelection
On Wed, 19 Mar 2025 13:49:29 GMT, Prasanta Sadhukhan
wrote:
>> JTable.selectAll doesn't do anything if there are no rows or no columns.
>> But it should still select all columns if there are no rows and the other
>> way round.
>> It is seen that isColumnSelected() will return false for all co
On Thu, 20 Mar 2025 05:12:53 GMT, Tejesh R wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add check for rowselection and columnselection
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 2190:
On Thu, 20 Mar 2025 05:32:22 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 2198:
>>
>>> 2196: if (getColumnSelectionAllowed()) {
>>> 2197: selectColumns(columnCount);
>>> 2198: }
>>
>> Can we simplify the c
On Thu, 20 Mar 2025 05:27:59 GMT, Tejesh R wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add check for rowselection and columnselection
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 2198:
On Wed, 19 Mar 2025 13:49:29 GMT, Prasanta Sadhukhan
wrote:
>> JTable.selectAll doesn't do anything if there are no rows or no columns.
>> But it should still select all columns if there are no rows and the other
>> way round.
>> It is seen that isColumnSelected() will return false for all co
On Wed, 19 Mar 2025 13:49:29 GMT, Prasanta Sadhukhan
wrote:
>> JTable.selectAll doesn't do anything if there are no rows or no columns.
>> But it should still select all columns if there are no rows and the other
>> way round.
>> It is seen that isColumnSelected() will return false for all co
Il 19/03/2025 11:19, Davide Perini ha scritto:
I add some context:
I installed wix 5 using the donet command globally,
wix is in the path but when I try to run my jpackage command I get
this error:
jpackage -i ./target --type exe --main-class
org.dpsoftware.JavaFXStarter --main-jar
Firef
8352407: PixelInterleavedSampleModel with unused components throws
RasterFormatException: Incorrect pixel stride
-
Commit messages:
- 8352407: PixelInterleavedSampleModel with unused components throws
RasterFormatException: Incorrect pixel stride
Changes: https://git.openjdk.org/j
On Wed, 19 Mar 2025 07:45:39 GMT, Prasanta Sadhukhan
wrote:
>> ok..But selectAll selects all cells as per the spec Spec says "Selects all
>> rows, columns, and cells in the table..
>
> In SwingSet2 JTable demo before the fix also, you can see only "rowSelection"
> is enabled, but selectAll sel
On Wed, 19 Mar 2025 07:26:51 GMT, Tejesh R wrote:
>> No, as told earlier, selectAll selects all cells...
>> WHere do you see only row selection is enabled? In SwingSet2 JTable, if you
>> do ctrl+A which is equivalent to selectAll, all cells gets selected..
>
> [Here](https://github.com/openjdk/j
On Wed, 19 Mar 2025 08:52:08 GMT, Tejesh R wrote:
>> THis is the way it was done previously where also the action was done on
>> local var..please see previous codethe selectionIndex was obtained from
>> selectionModel class var..
>>
>>> And why do you want to use local variable ? I don't
On Wed, 19 Mar 2025 12:00:15 GMT, Prasanta Sadhukhan
wrote:
>> I meant w.r.t modifications applied to class and local reference. If both
>> are pointing to same variable you can minimise passing it as parameter in
>> methods selectColumns/Rows. Just a suggestion.
>
> Thank you for your suggest
On Wed, 19 Mar 2025 02:41:48 GMT, Manukumar V S wrote:
>> **Issue**
>> java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not
>> supported
>>
>> **Reason**
>> In `MailTest.java`, there is a condition check(`if
>> (!desktop.isSupported(Desktop.Action.MAIL))`) which will forc
On Wed, 26 Feb 2025 22:26:48 GMT, Alexander Zuev wrote:
> - Check that the calculated audio data size does not exceed available heap
> memory before committing to the rendering
> - Add a test case
This pull request has now been integrated.
Changeset: fcc2a242
Author:Alexander Zuev
URL:
On Wed, 19 Mar 2025 02:41:48 GMT, Manukumar V S wrote:
>> **Issue**
>> java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not
>> supported
>>
>> **Reason**
>> In `MailTest.java`, there is a condition check(`if
>> (!desktop.isSupported(Desktop.Action.MAIL))`) which will forc
25 matches
Mail list logo
