Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Sergey Bylokhov
On Tue, 17 Jun 2025 18:23:30 GMT, Phil Race wrote: >> This is the implementation of JEP 504 - Remove the Applet API. >> API changes are >> - Remove the entire java.applet package >> - Remove the javax/swing/JApplet class >> - Remove applet related APIs in java.beans >> - Update javadoc referring

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread lawrence . andrews
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread duke
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Joel Sikström
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 18:23:30 GMT, Phil Race wrote: >> This is the implementation of JEP 504 - Remove the Applet API. >> API changes are >> - Remove the entire java.applet package >> - Remove the javax/swing/JApplet class >> - Remove applet related APIs in java.beans >> - Update javadoc referring

Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 20:43:24 GMT, Phil Race wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8359053 > > I think I have responded to all substantial issues, and in most cases updated > the PR according to the feedback

Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Alexey Ivanov
On Mon, 9 Jun 2025 21:03:55 GMT, Phil Race wrote: >> src/java.desktop/share/classes/java/awt/Dialog.java line 174: >> >>> 172: * from the same toolkit except those from its own child >>> hierarchy. >>> 173: */ >>> 174: TOOLKIT_MODAL >> >> Should we add a note that `AP

Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Alexey Ivanov
On Tue, 10 Jun 2025 17:59:41 GMT, Phil Race wrote: >> Shall I submit a bug to consider removing this code? >> >> Without the comment and an issue to track it, no one will ever remember to >> look into it. > > yes, go ahead. Submitted [JDK-8359932](https://bugs.openjdk.org/browse/JDK-8359932):

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Alexander Zuev
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Manukumar V S
Issue: In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. Fix: Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null)

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar [v2]

2025-06-18 Thread Manukumar V S
> Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to the centre of the screen by calling > frame.setLocation

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar [v2]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 15:35:27 GMT, Manukumar V S wrote: >> Issue: >> In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers >> clicks on items pinned to the taskbar. This may open some other UI item and >> may interfere further testing on that machine. >> >> Fix: >> Move the tes

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar [v2]

2025-06-18 Thread duke
On Wed, 18 Jun 2025 15:38:13 GMT, Manukumar V S wrote: >> Issue: >> In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers >> clicks on items pinned to the taskbar. This may open some other UI item and >> may interfere further testing on that machine. >> >> Fix: >> Move the tes

Re: RFR: 8359053: Implement JEP 504 - Remove the Applet API [v9]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 02:39:53 GMT, Sergey Bylokhov wrote: > it is done intentionally to throw an exception if the file is locked. A comment would've clarified the intention. This also means that if the test fails for whatever reason and `Files.delete` throws the exception, the original exceptio

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Nizar Benalla
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 16:20:14 GMT, Manukumar V S wrote: > Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v2]

2025-06-18 Thread Manukumar V S
> Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing, the > test simply returns early, and the test ends up

Re: RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 17:57:26 GMT, Phil Race wrote: > Clarify the behaviour of new HeadlessException().getMessage() > The spec. is updated to be clear that empty means null, not an empty string. Should each constructor specify how the message returned by `getMessage` is constructed instead of _d

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Damon Nguyen
> This change is to restore the original intent of the test by updating the > instructions to check that the type of Cursor is preserved when clicked and > dragged. Now the test correctly has instructions to check that an I-beam > cursor stays an I-beam until released over a List with its cursor

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 18:38:45 GMT, Damon Nguyen wrote: >> This change is to restore the original intent of the test by updating the >> instructions to check that the type of Cursor is preserved when clicked and >> dragged. Now the test correctly has instructions to check that an I-beam >> curso

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]

2025-06-18 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: remove double quotes - Changes:

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 18:38:45 GMT, Damon Nguyen wrote: >> This change is to restore the original intent of the test by updating the >> instructions to check that the type of Cursor is preserved when clicked and >> dragged. Now the test correctly has instructions to check that an I-beam >> curso

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Manukumar V S
> Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing, the > test simply returns early, and the test ends up

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 18:59:08 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change timeout and instructions columns. > > test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 123: >

RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

2025-06-18 Thread Damon Nguyen
Compilation error on windows with `WindowsButtonUI` used. Replaced it with `BasicButtonUI` to maintain overriding the `paintText` method but this was not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI` and extending it, but the class is `final`. Instead, I chose to add a

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 05:14:08 GMT, Tejesh R wrote: >> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording >> "Due to an unfortunate set of historical events this method is >> inappropriately named". > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.jav

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]

2025-06-18 Thread Damon Nguyen
On Tue, 17 Jun 2025 23:15:05 GMT, Justin Lu wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove double quotes > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java > line 2: > >> 1

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v10]

2025-06-18 Thread Damon Nguyen
> This change is to restore the original intent of the test by updating the > instructions to check that the type of Cursor is preserved when clicked and > dragged. Now the test correctly has instructions to check that an I-beam > cursor stays an I-beam until released over a List with its cursor

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Damon Nguyen
On Wed, 18 Jun 2025 19:16:09 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 123: >> >>> 121: failBtn.addActionListener(e -> { >>> 122: throw new RuntimeException("Test Failed"); >>> 123: }); >> >> You have to release t

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Damon Nguyen
On Wed, 18 Jun 2025 19:20:32 GMT, Alexey Ivanov wrote: >The timer updates each second, which sends additional messages — the dragged >cursor changes as soon as the displayed time updates. > > Pause the timer, and the drag cursor doesn't change until you release the > left mouse button. > > Ha

Re: RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

2025-06-18 Thread Damon Nguyen
On Wed, 18 Jun 2025 22:28:46 GMT, Sergey Bylokhov wrote: > Please confirm that you can reproduce JDK-4991587 by the updated test. The updated test does contain all of the text within the blue border now as expected (instead of overlapping or being outside the borders of the textRect, as descri

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 12:43:23 GMT, Prasanta Sadhukhan wrote: > BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording > "Due to an unfortunate set of historical events this method is > inappropriately named". Changes requested by aivanov (Reviewer). src/java.desktop/share

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 05:01:53 GMT, Abhishek Kumar wrote: >> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording >> "Due to an unfortunate set of historical events this method is >> inappropriately named". > > CSR? > @kumarabhi006 > > > CSR? > > javadoc change is for a

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 20:18:29 GMT, Phil Race wrote: >> test/jdk/java/awt/font/TextLayout/MyanmarTextTest.java line 59: >> >>> 57: private static final String[] FONTS_WINDOWS = {"Myanmar Text", >>> "Noto Sans Myanmar"}; >>> 58: private static final String[] FONTS_LINUX = {"Padauk", "Noto

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Phil Race
On Tue, 17 Jun 2025 12:43:23 GMT, Prasanta Sadhukhan wrote: > BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording > "Due to an unfortunate set of historical events this method is > inappropriately named". This may yet need a CSR depending on where the wording ends up.

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v26]

2025-06-18 Thread Phil Race
On Wed, 28 May 2025 05:47:06 GMT, Prasanta Sadhukhan wrote: > In SwingSet2, now there will be gap between bullet and text to accomodate > non-existing imageicon That gap should only be there if *at least one* menu item has an image icon. It shoudn't be there if none have an icon. ---

RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

2025-06-18 Thread Phil Race
Clarify the behaviour of new HeadlessException().getMessage() The spec. is updated to be clear that empty means null, not an empty string. - Commit messages: - 8358526 Changes: https://git.openjdk.org/jdk/pull/25881/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25881&rang

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result on headless machines

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 16:20:14 GMT, Manukumar V S wrote: > Issue: > java/awt/font/TextLayout/MyanmarTextTest.java passes on headless machines > even though it creates GUI components. Ideally, when you create some GUI > components in your code in a headless machine, it should through > HeadlessEx

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 16:25:29 GMT, Justin Lu wrote: >> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1: >> >>> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights >>> reserved. >> >> Shall the copyright year be updated? > > In the past, we usually don't

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v9]

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 17:38:22 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> SUmmary fix > > src/java.desktop/share/classes/javax/swing/ImageIcon.java line 374: > >> 372: /** >> 373:

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v9]

2025-06-18 Thread Phil Race
On Tue, 17 Jun 2025 10:08:49 GMT, Prasanta Sadhukhan wrote: >> When trying to call 'icon.setImage(null);' where 'icon' is an instance of >> ImageIcon, a null pointer exception is thrown at runtime. >> The code tried to get the `id` for that image and instantiates >> `MediaTracker` to associate

Re: RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 18:34:32 GMT, Alexey Ivanov wrote: > Should each constructor specify how the message returned by `getMessage` is > constructed instead of _directing to the specification of `getMessage` for > details_? 100% no. I am not wasting time on that. This whole spec. is getting reva

Re: RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

2025-06-18 Thread Sergey Bylokhov
On Wed, 18 Jun 2025 19:28:18 GMT, Damon Nguyen wrote: > Compilation error on windows with `WindowsButtonUI` used. Replaced it with > `BasicButtonUI` to maintain overriding the `paintText` method but this was > not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI` > and e

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 16:20:14 GMT, Manukumar V S wrote: > Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 05:01:53 GMT, Abhishek Kumar wrote: >> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording >> "Due to an unfortunate set of historical events this method is >> inappropriately named". > > CSR? @kumarabhi006 > CSR? javadoc change is for a protected

Re: RFR: 8131136: java/awt/font/JNICheck/JNICheck.sh issue warning on core-libs code

2025-06-18 Thread Sergey Bylokhov
On Wed, 11 Jun 2025 13:18:47 GMT, Daniel Jeliński wrote: > Add an exception check after a JNI static method call, and re-enable checks > for CallStatic in JNICheck.sh test. > > I verified that the JNICheck test is passing on all headless and headful > platforms I had access to (Windows, Linux

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Justin Lu
On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > line 56:

RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result on headless machines

2025-06-18 Thread Manukumar V S
Issue: java/awt/font/TextLayout/MyanmarTextTest.java passes on headless machines even though it creates GUI components. Ideally, when you create some GUI components in your code in a headless machine, it should through HeadlessException, but MyanmarTextTest.java seems to suppress it and gives a

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Justin Lu
On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1: > >> 1: # Copyright (c)

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v5]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 03:41:32 GMT, Prasanta Sadhukhan wrote: >> Note that "ImageIcon(URL location)" will throw npe as well, do we want to >> ignore it or specify NPE? That is actually interesting question since >> initially some of methods throw NPE and another ignore the image. > > ImageIcon(U

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 19:18:06 GMT, Manukumar V S wrote: >> Issue: >> MyanmarTextTest.java produces a false positive result when some of the test >> preconditions are not met. It checks whether certain fonts are present in >> the system, for example, 'Padauk' on Linux. If the required font is mis

Re: RFR: 8131136: java/awt/font/JNICheck/JNICheck.sh issue warning on core-libs code

2025-06-18 Thread Phil Race
On Wed, 11 Jun 2025 13:18:47 GMT, Daniel Jeliński wrote: > Add an exception check after a JNI static method call, and re-enable checks > for CallStatic in JNICheck.sh test. > > I verified that the JNICheck test is passing on all headless and headful > platforms I had access to (Windows, Linux

Re: RFR: 8355904: Use variadic macros for J2dTrace [v7]

2025-06-18 Thread Phil Race
On Fri, 6 Jun 2025 08:36:40 GMT, Nikita Gubarkov wrote: >> J2dTrace macros have multiple overloads specifying number of arguments, >> making it less convent to change number of arguments. There were cases when >> existing macros were not enough and people had to add new variants with even >> m

Integrated: 8357686: Remove unnecessary Map.get from AWTAutoShutdown.unregisterPeer

2025-06-18 Thread Andrey Turbanov
On Thu, 24 Apr 2025 20:18:01 GMT, Andrey Turbanov wrote: > Instead of separate `.get(Key)`+`.remove(Key)` calls we can call > `.remove(Key, Value)`. > `peerMap` is an `IdentityHashMap`. IdentityHashMap.remove compares values > with == since Java 20 > ([JDK-8178355](https://bugs.openjdk.org/bro

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v5]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 02:46:37 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 373: >> >>> 371: /** >>> 372: * Sets the image displayed by this icon. >>> 373: * Setting null image will not render any image icon. >> >> Suggestion: >>

Re: RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 17:57:26 GMT, Phil Race wrote: > Clarify the behaviour of new HeadlessException().getMessage() > The spec. is updated to be clear that empty means null, not an empty string. CSR to be reviewed https://bugs.openjdk.org/browse/JDK-8359951 - PR Comment: https://git

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 17:00:53 GMT, Phil Race wrote: > I don't understand how what you changed related to the stated problem. In > fact I don't see the point of this PR at all. Sorry @prrace, my earlier description was ambiguous. I have updated it. In fact, the issue is about reporting a false p

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 18:38:45 GMT, Damon Nguyen wrote: >> This change is to restore the original intent of the test by updating the >> instructions to check that the type of Cursor is preserved when clicked and >> dragged. Now the test correctly has instructions to check that an I-beam >> curso

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v5]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 16:32:54 GMT, Damon Nguyen wrote: >> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 105: >> >>> 103: Panel btnPanel = new Panel(); >>> 104: Button passBtn = new Button("PASS"); >>> 105: Button failBtn = new Button("FAIL"); >> >> Sugg

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v3]

2025-06-18 Thread Manukumar V S
> Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing, the > test simply returns early, and the test ends up

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v10]

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 22:55:12 GMT, Damon Nguyen wrote: >> This change is to restore the original intent of the test by updating the >> instructions to check that the type of Cursor is preserved when clicked and >> dragged. Now the test correctly has instructions to check that an I-beam >> curso

Re: RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

2025-06-18 Thread Sergey Bylokhov
On Wed, 18 Jun 2025 19:28:18 GMT, Damon Nguyen wrote: > Compilation error on windows with `WindowsButtonUI` used. Replaced it with > `BasicButtonUI` to maintain overriding the `paintText` method but this was > not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI` > and e

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v2]

2025-06-18 Thread Tejesh R
On Thu, 19 Jun 2025 02:34:22 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JCheckBox/4449413/bug4449413.java line 192: >> >>> 190: >>> 191: b.setOpaque(true); >>> 192: b.setBackground(Color.red); >> >> The test is specifically for background color black, I think you n

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v2]

2025-06-18 Thread Tejesh R
On Thu, 19 Jun 2025 02:38:10 GMT, Prasanta Sadhukhan wrote: >> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible >> while running on Windows L&F as background color is same as >> RBMenuItem/CBMenuItem's checkmark.. >> Modified the color so that they are visible.. > > Pra

RFR: 8359266: Delete the usage of AppContext in the GraphicsDevice

2025-06-18 Thread Sergey Bylokhov
This PR removes the usage of AppContext from the GraphicsDevice class. The original use case was to store the full-screen window in some AppContext, which was necessary in the context of plugin/appletviewer environments. However, there is now effectively only one main AppContext, so this indirec

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v10]

2025-06-18 Thread Prasanta Sadhukhan
> When trying to call 'icon.setImage(null);' where 'icon' is an instance of > ImageIcon, a null pointer exception is thrown at runtime. > The code tried to get the `id` for that image and instantiates `MediaTracker` > to associate the null image to that `id` and checks the status of loading > th

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v9]

2025-06-18 Thread Prasanta Sadhukhan
On Wed, 18 Jun 2025 22:18:45 GMT, Phil Race wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 374: >> >>> 372: /** >>> 373: * Sets the image displayed by this icon. >>> 374: * Setting a {@code null} image will not render any image icon. >> >> Suggestion: >>

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Naoto Sato
On Wed, 18 Jun 2025 09:47:57 GMT, Joel Sikström wrote: > Should the other localizations for the launcher help text (in > `launcher_.properties`) also be updated? I see that only the German, > Japanese and Chinese localizations have been updated so far. Those languages (de/ja/zh-CN) are the one

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v5]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 16:27:03 GMT, Alexey Ivanov wrote: >> ImageIcon(URL) will call ImageIcon(URL, String) where already image null >> check was there so I guess it will not throw NPE before fix too.. > > Indeed, it throws `NullPointerException`: > > > jshell> import javax.swing.ImageIcon; > >

Integrated: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

Re: RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v9]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 10:08:49 GMT, Prasanta Sadhukhan wrote: >> When trying to call 'icon.setImage(null);' where 'icon' is an instance of >> ImageIcon, a null pointer exception is thrown at runtime. >> The code tried to get the `id` for that image and instantiates >> `MediaTracker` to associate

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 14:45:32 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460: > >> 458: SliderDemo.

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 19:39:09 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added blank line before OS_NAME > > test/jdk/java/awt/font/TextLayout/MyanmarTextTest.java line 59: > >> 57: pri

Re: RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

2025-06-18 Thread Harshitha Onkar
On Wed, 18 Jun 2025 19:20:32 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change timeout and instructions columns. > > **Funny!** > >> The Windows test failing in PFJ was a separate issue tha

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v26]

2025-06-18 Thread Prasanta Sadhukhan
On Wed, 28 May 2025 05:38:17 GMT, Prasanta Sadhukhan wrote: >> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radi

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v2]

2025-06-18 Thread Prasanta Sadhukhan
On Thu, 19 Jun 2025 02:38:10 GMT, Prasanta Sadhukhan wrote: >> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible >> while running on Windows L&F as background color is same as >> RBMenuItem/CBMenuItem's checkmark.. >> Modified the color so that they are visible.. > > Pra

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v3]

2025-06-18 Thread Prasanta Sadhukhan
> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible > while running on Windows L&F as background color is same as > RBMenuItem/CBMenuItem's checkmark.. > Modified the color so that they are visible.. Prasanta Sadhukhan has updated the pull request incrementally with one a

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Prasanta Sadhukhan
On Thu, 19 Jun 2025 04:01:49 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line >> 1033: >> >>> 1031: /** >>> 1032: * Gets the allocation to give the root View. >>> 1033: * The Rectangle returned has nothing to do with vi

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v10]

2025-06-18 Thread ExE Boss
On Thu, 19 Jun 2025 03:01:15 GMT, Prasanta Sadhukhan wrote: >> When trying to call 'icon.setImage(null);' where 'icon' is an instance of >> ImageIcon, a null pointer exception is thrown at runtime. >> The code tried to get the `id` for that image and instantiates >> `MediaTracker` to associate

Re: RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

2025-06-18 Thread Prasanta Sadhukhan
On Wed, 18 Jun 2025 20:32:26 GMT, Phil Race wrote: >> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording >> "Due to an unfortunate set of historical events this method is >> inappropriately named". > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.ja

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v10]

2025-06-18 Thread Prasanta Sadhukhan
On Thu, 19 Jun 2025 04:12:25 GMT, ExE Boss wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Test fix >> - javadoc wording..clear image desscription if image is null > > src/java.desktop/share/classes/javax/

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v2]

2025-06-18 Thread Prasanta Sadhukhan
> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible > while running on Windows L&F as background color is same as > RBMenuItem/CBMenuItem's checkmark.. > Modified the color so that they are visible.. Prasanta Sadhukhan has updated the pull request incrementally with one a

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v2]

2025-06-18 Thread Prasanta Sadhukhan
On Wed, 18 Jun 2025 05:31:53 GMT, Tejesh R wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Window L&F fix > > test/jdk/javax/swing/JCheckBox/4449413/bug4449413.java line 192: > >> 190: >> 191: b.set

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v5]

2025-06-18 Thread Manukumar V S
> Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. If the required font is missing, the > test simply returns early, and the test ends up

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 20:26:51 GMT, Alexey Ivanov wrote: >> My comment was ONLY about Linux. I definitely didn't expect to see the fonts >> for other platforms updated. >> They can be a list of one font. > > That's how I read your suggestion too. > > Yet I like the idea of a platform-independent

Re: RFR: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible [v3]

2025-06-18 Thread Tejesh R
On Thu, 19 Jun 2025 04:10:20 GMT, Prasanta Sadhukhan wrote: >> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible >> while running on Windows L&F as background color is same as >> RBMenuItem/CBMenuItem's checkmark.. >> Modified the color so that they are visible.. > > Pra