The proposal to merge ~b1sandmann/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/399100
--
Your team cloud-init Commiters is requested
Thanks! Marking this as Rejected (which is the expected end state for this MP).
--
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/399100
Your team cloud-init Commiters is requested to review the proposed merge of
~b1sandmann/cloud-init:migrate-lp-to-github into
The proposal to merge ~lp-markusschade/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/392777
--
Your team cloud-init Commiters is
Thanks! I've confirmed that this matches in GitHub, so I'm going to mark this
as Rejected. This is the expected final state of this MP.
--
https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/392777
Your team cloud-init Commiters is requested to review the proposed
Thanks! I will now be marking this MP rejected, which is the expected end
state here.
--
https://code.launchpad.net/~vtqanh/cloud-init/+git/cloud-init/+merge/387447
Your team cloud-init Commiters is requested to review the proposed merge of
~vtqanh/cloud-init:migrate-lp-to-github into
Hi Andrea, this branch was migrated over to GitHub (along with the rest of
cloud-init's code hosting :) and was proposed here:
https://github.com/canonical/cloud-init/pull/114
It landed in March and was included in the 20.2 cloud-init release. It is
available in Ubuntu 20.04 (Focal Fossa),
The proposal to merge ~momousta/cloud-init:momousta-migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~momousta/cloud-init/+git/cloud-init/+merge/383902
--
Your team cloud-init Commiters is
Thanks! I'm moving this MP to Rejected, which is the expected end state for it.
--
https://code.launchpad.net/~momousta/cloud-init/+git/cloud-init/+merge/383902
Your team cloud-init Commiters is requested to review the proposed merge of
~momousta/cloud-init:momousta-migrate-lp-to-github into
The proposal to merge ~killermoehre/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~killermoehre/cloud-init/+git/cloud-init/+merge/381247
--
Your team cloud-init Commiters is
Thanks for this. Marking this as Rejected, which is the expected end state for
this MP.
--
https://code.launchpad.net/~killermoehre/cloud-init/+git/cloud-init/+merge/381247
Your team cloud-init Commiters is requested to review the proposed merge of
~killermoehre/cloud-init:migrate-lp-to-github
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init:master into
cloud-init:master.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init-1/+merge/377307
--
Your team cloud-init
The proposal to merge ~otubo/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~otubo/cloud-init/+git/cloud-init/+merge/377041
--
Your team cloud-init Commiters is requested to review
Thanks! (Moving this to Rejected now, which is the expected end state here. :)
--
https://code.launchpad.net/~otubo/cloud-init/+git/cloud-init/+merge/377041
Your team cloud-init Commiters is requested to review the proposed merge of
~otubo/cloud-init:migrate-lp-to-github into cloud-init:master.
Thanks! (I'm going to mark this as Rejected, which is the expected state here.
:)
--
https://code.launchpad.net/~afranceschini/cloud-init/+git/cloud-init/+merge/377244
Your team cloud-init Commiters is requested to review the proposed merge of
~afranceschini/cloud-init:migrate-lp-to-github
The proposal to merge ~afranceschini/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~afranceschini/cloud-init/+git/cloud-init/+merge/377244
--
Your team cloud-init Commiters is
The proposal to merge ~madhuri-rai07/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~madhuri-rai07/cloud-init/+git/cloud-init/+merge/377187
--
Your team cloud-init Commiters is
Thanks! (Moving this to Rejected, which is the expected end state here. :)
--
https://code.launchpad.net/~madhuri-rai07/cloud-init/+git/cloud-init/+merge/377187
Your team cloud-init Commiters is requested to review the proposed merge of
~madhuri-rai07/cloud-init:migrate-lp-to-github into
I'm going to close this out as it's been moved to GitHub:
https://github.com/canonical/cloud-init/pull/128/
--
https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/377090
Your team cloud-init Commiters is requested to review the proposed merge of
The proposal to merge ~louis/cloud-init:fix_scaleway_datasource_backtrace into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/377090
--
Your team cloud-init Commiters is
Dan Watkins has proposed merging ~madhuri-rai07/cloud-init:migrate-lp-to-github
into cloud-init:master.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~madhuri-rai07/cloud-init/+git/cloud-init/+merge/377187
--
Your team cloud-init
The proposal to merge ~askon/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~askon/cloud-init/+git/cloud-init/+merge/377185
--
Your team cloud-init Commiters is requested to review
Thanks! (Marking as Rejected, which is the expected final state here. :)
--
https://code.launchpad.net/~askon/cloud-init/+git/cloud-init/+merge/377185
Your team cloud-init Commiters is requested to review the proposed merge of
~askon/cloud-init:migrate-lp-to-github into cloud-init:master.
Thanks, Louis! (I'll be marking this as Rejected, which is the expected end
state. :)
--
https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/377091
Your team cloud-init Commiters is requested to review the proposed merge of
~louis/cloud-init:migrate-lp-to-github into
The proposal to merge ~louis/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/377091
--
Your team cloud-init Commiters is requested to review
The proposal to merge ~goneri/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/377008
--
Your team cloud-init Commiters is requested to
Thanks! (Rejected is the expected status here. :)
--
https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/377008
Your team cloud-init Commiters is requested to review the proposed merge of
~goneri/cloud-init:migrate-lp-to-github into cloud-init:master.
(Rejected is the normal state for this to end up in, no more work needed for
this!)
--
https://code.launchpad.net/~adobrawy/cloud-init/+git/cloud-init/+merge/376922
Your team cloud-init Commiters is requested to review the proposed merge of
~adobrawy/cloud-init:migrate-lp-to-github into
The proposal to merge ~adobrawy/cloud-init:migrate-lp-to-github into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~adobrawy/cloud-init/+git/cloud-init/+merge/376922
--
Your team cloud-init Commiters is requested to
Confirmed at
https://github.com/canonical/cloud-init/commit/2267cd31443d2c1032190102dd4b6011076ed182
--
https://code.launchpad.net/~adobrawy/cloud-init/+git/cloud-init/+merge/376922
Your team cloud-init Commiters is requested to review the proposed merge of
One inline question, probably for my own edification. Thanks!
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index e381596..44a2f11 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -708,6 +708,12 @@ class
You can see a successful run with this configuration here:
https://travis-ci.org/OddBloke/cloud-init/builds/600851758
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/374462
Your team cloud-init Commiters is requested to review the proposed merge of
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:travis into cloud-init:master.
Commit message:
introduce .travis.yml
This captures the CI testing that is currently performed by the Ubuntu
Server Jenkins instance into a Travis configuration, which is part
The proposal to merge ~d-info-e/cloud-init:gitignore-venv into
cloud-init:master has been updated.
Description changed to:
add .venv/ to .gitignore
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/373628
--
Your team cloud-init Commiters is
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1846535 in cloud-init: "cloud-init 19.2.36 fails with python exception
"Not al
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/disco into
cloud-init:ubuntu/disco.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1846535 in cloud-init: "cloud-init 19.2.36 fails with python exception
"Not al
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1846535 in cloud-init: "cloud-init 19.2.36 fails with python exception
"Not al
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/bionic into
cloud-init:ubuntu/bionic.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1846535 in cloud-init: "cloud-init 19.2.36 fails with python exception
"Not al
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1846535 into cloud-init:master.
Commit message:
get_interfaces: don't exclude bridge and bond members
The change that introduced this issue was handling interfaces that are
bonded in the kernel, in a way
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:net into cloud-init:master.
Commit message:
debian/ubuntu: add missing word to netplan/ENI header
Specifically, add in "reboot" to make it clear what people should expect
when modifying the file.
This al
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:whitespace into cloud-init:master.
Commit message:
analyze/show: remove trailing space in output
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~daniel
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ci_fix into cloud-init:master.
Commit message:
.pylintrc: ignore missing enter_context members
Pylint has started (incorrectly) warning about these in some test cases,
so unbreak the build by ignoring them
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1844191 in cloud-init: "azure advanced networking sometimes triggers
duplicate mac dete
Updated.
(CI failures are due to an infra problem, which we've hopefully just fixed.)
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491
Your team cloud-init Commiters is requested to review the proposed merge of
OK, I've updated the log message to indicate we're writing to a temporary file,
and added a log message for the rename (because I think failures could happen
in either of those steps, and this allows us to distinguish between those).
(We will also have the different logger name to distinguish
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Commit message:
atomic_helper: add DEBUG logging to write_file
Fixes LP: #1843276
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init
Oh yeah, great points. Will fix.
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491
Your team cloud-init Commiters is requested to review the proposed merge of
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Commit message:
atomic_helper: add DEBUG logging to write_file
Fixes LP: #1843276
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1843276 in cloud
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:networking
into cloud-init:master has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372289
--
Your team cloud-init
On Wed, Sep 04, 2019 at 06:30:07PM -, Ryan Harper wrote:
> If the interface already has an IP, it may not have anything else that
> we'd apply after parsing the lease output (routes, etc).
If the interface already has an IP before we DHCP, it's not 100% clear
to me that we should consider
Diff comments:
> diff --git a/doc/rtd/topics/docs.rst b/doc/rtd/topics/docs.rst
> new file mode 100644
> index 000..af2a3fb
> --- /dev/null
> +++ b/doc/rtd/topics/docs.rst
> @@ -0,0 +1,83 @@
> +.. _docs:
> +
> +Docs
> +
> +
> +These docs are hosted on Read the Docs. The following will
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:gitignore into cloud-init:master.
Commit message:
.gitignore: ignore files produced by package builds
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net
Diff comments:
> diff --git a/cloudinit/net/cmdline.py b/cloudinit/net/cmdline.py
> index 556a10f..c05d36c 100755
> --- a/cloudinit/net/cmdline.py
> +++ b/cloudinit/net/cmdline.py
> @@ -137,6 +203,24 @@ def config_from_klibc_net_cfg(files=None,
> mac_addrs=None):
> return {'config':
Diff comments:
> diff --git a/cloudinit/net/cmdline.py b/cloudinit/net/cmdline.py
> index 556a10f..c05d36c 100755
> --- a/cloudinit/net/cmdline.py
> +++ b/cloudinit/net/cmdline.py
> @@ -137,6 +203,24 @@ def config_from_klibc_net_cfg(files=None,
> mac_addrs=None):
> return {'config':
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:dracut into cloud-init:master.
Commit message:
net/cmdline: refactor to allow multiple initramfs network config sources
This refactors read_initramfs_config to support multiple different types
of initramfs
The proposal to merge
~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/371546
--
Your team cloud-init
The proposal to merge
~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into
cloud-init:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/371546
--
Your team cloud-init
Diff comments:
> diff --git a/cloudinit/config/cc_ubuntu_drivers.py
> b/cloudinit/config/cc_ubuntu_drivers.py
> index 4da34ee..ff56775 100644
> --- a/cloudinit/config/cc_ubuntu_drivers.py
> +++ b/cloudinit/config/cc_ubuntu_drivers.py
> @@ -90,17 +118,28 @@ def install_drivers(cfg,
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master.
Commit message:
DataSourceOracle: prefer DS network config over initramfs
DataSourceOracle.network_config merges the initramfs configuration with
configuration from OCI's IMDS, so
Good idea, done.
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/371350
Your team cloud-init commiters is requested to review the proposed merge of
~daniel-thewatkins/cloud-init/+git/cloud-init:pr_template into
cloud-init:master.
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into
cloud-init:master has been updated.
Commit message changed to:
cloudinit/distros/parsers/sys_conf: add docstring to SysConf
For more details, see:
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/371363
--
Your team cloud
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:pr_template into
cloud-init:master.
Commit message:
Add GitHub pull request template to point people at hacking doc
This will hopefully avoid people submitting PRs against our mirror repo.
(Thanks to GitHub
Hey Florian, thanks for submitting this! It looks like you haven't signed the
CLA; please check out the instructions at
https://cloudinit.readthedocs.io/en/latest/topics/hacking.html for how to do
so. Thanks!
--
On Mon, Aug 12, 2019 at 02:31:18PM -, Ryan Harper wrote:
> The method is call add_user and the variables match the method.
If the variable matched the method, I'd expect it to be add_user_cmd.
I'd be fine with that, if that's what you would prefer?
> So now we have
>
> def add_user()
>
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:useradd into cloud-init:master.
Commit message:
distros: fix confusing variable names
Building the subp arguments for a `useradd` call in a variable named
`adduser_cmd` is extremely confusing; let's not do
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1838794 in cloud-init: "Set Passwords documentation describes incorrect
beha
Made some changes locally, still thinking about one other. (Not pushing them
up until all comments are addressed, so I don't have to go digging to find the
current set of comments.)
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOracle.py
> b/cloudinit/sources/DataSourceOracle.py
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOracle.py
> b/cloudinit/sources/DataSourceOracle.py
> index 76cfa38..f18e5a0 100644
> --- a/cloudinit/sources/DataSourceOracle.py
> +++ b/cloudinit/sources/DataSourceOracle.py
> @@ -121,6 +190,14 @@ class
Thanks for the reviews! Responses inline.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOracle.py
> b/cloudinit/sources/DataSourceOracle.py
> index 76cfa38..f18e5a0 100644
> --- a/cloudinit/sources/DataSourceOracle.py
> +++ b/cloudinit/sources/DataSourceOracle.py
> @@ -28,8 +28,70
You have been requested to review the proposed merge of
~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master.
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/371053
--
Your team cloud-init commiters is requested
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master.
Commit message:
doc: remove intersphinx extension
We don't use it in our doc builds, and if sphinx.pocoo.org is down then
it causes doc build issues.
Requested reviews:
cloud-init
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master.
Commit message:
WIP: DataSourceOracle: configure secondary NICs on Virtual Machines
Oracle Cloud Infrastructure's Instance Metadata Service provides network
configuration
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master.
Commit message:
cc_set_passwords: rewrite documentation
What we had previously was inaccurate in a few respects.
LP: #1838794
Requested reviews:
Server Team CI bot (server-team
Diff comments:
> diff --git a/cloudinit/config/cc_set_passwords.py
> b/cloudinit/config/cc_set_passwords.py
> index 4585e4d..10d68ea 100755
> --- a/cloudinit/config/cc_set_passwords.py
> +++ b/cloudinit/config/cc_set_passwords.py
> @@ -9,27 +9,38 @@
> """
> Set Passwords
> -
>
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/370927
--
Your team cloud-init
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master.
Commit message:
cc_set_passwords: rewrite documentation
What we had previously was inaccurate in a few respects.
LP: #1838794
Requested reviews:
cloud-init commiters (cloud
Diff comments:
> diff --git a/cloudinit/sources/tests/test_oracle.py
> b/cloudinit/sources/tests/test_oracle.py
> index 97d6294..282382c 100644
> --- a/cloudinit/sources/tests/test_oracle.py
> +++ b/cloudinit/sources/tests/test_oracle.py
> @@ -145,15 +145,15 @@ class
The proposal to merge ~raharper/cloud-init:fix/debian-ntp-template into
cloud-init:master has been updated.
Commit message changed to:
templates/ntp.conf.debian.tmpl: fix missing newline for pools
The debian ntp.conf template did not contain a newline for the
comment used to mark the rendered
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:coverity into cloud-init:master.
Commit message:
Fix a couple of issues raised by a coverity scan
* cc_lxd: fix copy/paste error in debug logging
* DataSourceCloudSigma: remove unreachable code
* This unreachable
Thanks! A couple of follow-ups, and a couple of nits I missed first time
around.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master.
Commit message:
stages: allow data sources to override network config source order
Currently, if a platform provides any network configuration via the
"cmdline" method (i.
Quick drive-by review to ask if we can reuse the password fetching from the
CloudStack DS.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceExoscale.py
> b/cloudinit/sources/DataSourceExoscale.py
> new file mode 100644
> index 000..4588c9d
> --- /dev/null
> +++
On Tue, Jun 25, 2019 at 07:54:20PM -, Ryan Harper wrote:
> Nice. Let's add a link to netplan.io in there.
Done.
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/369312
Your team cloud-init commiters is requested to review the proposed merge of
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:docs into cloud-init:master.
Commit message:
doc: indicate that netplan is default in Ubuntu now
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~daniel
Hi Pavel, thanks for the contribution to cloud-init! I'm flitting between
meetings, so I'm not able to assess whether these changes are broadly
appropriate. That said, I do have an inline comment on how the changes could
be expressed a little more concisely. I'll revisit this later today for
Review: Needs Information
Hey David,
Thanks for the fix! To contribute to cloud-init, you must sign the Canonical
Contributor License Agreement (CLA) [1].
If you have already signed it as an individual, your Launchpad user will be
listed in the contributor-agreement-canonical launchpad group
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:warn into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1508442 in cloud-init: "LOG.warn is deprecated"
https://bugs.launchpad.net/cloud-init/+b
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 4d19f56..91046b5 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -707,6 +707,13 @@ class NetworkStateInterpreter(object):
> item_params =
Do we need to handle older versions of netplan that _don't_ understand the new
key?
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/366935
Your team cloud-init commiters is requested to review the proposed merge of
This is what I've done in terms of testing:
```
lxc launch ubuntu:b c1
lxc file push *.snap c1/tmp/
lxc exec c1 /bin/bash
snap install /tmp/*.snap
/snap/bin/cloud-init clean --logs
/snap/bin/cloud-init init --local
/snap/bin/cloud-init init
```
http://paste.ubuntu.com/p/TXrh2n4mpk/ is
The proposal to merge ~liaoishere/cloud-init:sysconfig-bond-options into
cloud-init:master has been updated.
Commit message changed to:
sysconfig: support more bonding options
Currently, only a few bonding parameters can be configured on
sysconfig systems. This patch aims to support more
I've just kicked off a CI run, the results will be reported in here once
complete.
--
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
Your team cloud-init commiters is requested to review the proposed merge of
~liaoishere/cloud-init:sysconfig-bond-options into
This looks like a reasonable set of changes to me; is there any good way for me
to test it? (Perhaps in a container/public cloud?)
Also, do we need to open a bug for converting this script to Python 3 in
preparation for dropping Python 2 support from cloud-init[0]?
[0]
I've tested that this (a) fixes the package build on CentOS, and (b) bash
completion still works from the installed package.
(I attempted to build the package on SuSE too, but I ran in to issues that I
believe are unrelated to this change.)
--
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master.
Commit message:
packages: update rpm specs for new bash completion path
LP: #1825444
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1825444 in cloud
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master.
Commit message:
setup.py: install bash completion script in new location
Per lintian, this is the path at which bash completion scripts should
now be installed.
Requested reviews
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/365823
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:revert into
cloud-init:master has been updated.
Commit message changed to:
Revert "DataSource: move update_events from a class to an instance attribute"
Moving update_events from a class attribute to an instance attribute
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1801364 in cloud-init
This is a re-submission of Chad's branch (which was previously reviewed at
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161).
I've addressed much of the review feedback there (generally in separate
commits, so review my new commits to understand the changes I've
1 - 100 of 169 matches
Mail list logo
