Re: [Cloud-init-dev] [Merge] ~t0rrant/cloud-init:1819966-sysconfig-options into cloud-init:master

Hi Ryan, > There is no direct integration in the module for dhcp provided ntp servers at > this time. It's possible but there isn't a great interface (AFAIK) to query > your OS for the dhcp response for a given interface. sorry but I don't understand your comment. The proposed change has

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4

The proposal to merge ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4 has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/372432 -- Your team cloud-init Commiters is requested to

[Cloud-init-dev] Invalid Commit Message

Review: Needs Fixing Commit message lints: - Line #0 has 17 too many characters. Line starts with: "Add brief README.md describing"... -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/372432 Your team cloud-init Commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4

The proposal to merge ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/372432 -- Your team cloud-init Commiters is requested to

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4

The proposal to merge ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4 has been updated. Commit message changed to: README.md: describe the branch intent For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/372432 -- Your team

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master. Commit message: atomic_helper: add DEBUG logging to write_file Fixes LP: #1843276 Requested reviews: cloud-init Commiters (cloud-init-dev) Related bugs: Bug #1843276 in

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master. Commit message: atomic_helper: add DEBUG logging to write_file Fixes LP: #1843276 Requested reviews: Server Team CI bot (server-team-bot): continuous-integration cloud-init

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

OK, I've updated the log message to indicate we're writing to a temporary file, and added a log message for the rename (because I think failures could happen in either of those steps, and this allows us to distinguish between those). (We will also have the different logger name to distinguish

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Your successful log path would not even include the final location for the file, which is ultimately the useful thing (except in the write-failed case, which is probably rare). I think I'd prefer logging with a message that included the target file (filename), not just the temporary file name.

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Oh yeah, great points. Will fix. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491 Your team cloud-init Commiters is requested to review the proposed merge of ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~ruansx/cloud-init:add-zstack-datasource into cloud-init:master

Quick review things: * make a better commit message (the 'Commit message` above will be be used when this is ultimately squashed and merged) * add 'LP: #1841181' to your commit message. See git log for examples. Thats how MPs get associated with bugs. * Tests needed. *

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:cea88e21a22c752bfd268e1ca49fada2858ab858 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1109/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

In the interest of making "cloud-init debug is way to loud" even worse, Could one log message be enough? "Atomic writing to %s via temporary %s", filename, tf.name If you see such a log and its not followed by a stack trace, then its good. --

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:ae70b6bcef3002b3ed7318faba23df4dda2d188b https://jenkins.ubuntu.com/server/job/cloud-init-ci/1110/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master

Updated. (CI failures are due to an infra problem, which we've hopefully just fixed.) -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491 Your team cloud-init Commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:stable-18.4 into cloud-init:stable-18.4

Review: Approve continuous-integration PASSED: Continuous integration, rev:aeeebf3f083e9d4e0fdd68ecf8c0ba5990301cd7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1113/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: