Re: [CLucene-dev] Wrong condition in check if space for terminating NULL is available in postingsFreeListDW.values

2010-09-17 Thread Kostka Bořivoj
Itamar, I pushed one more fix for this condition, previous one wasn't 100% correct, too. Could you please cherry pick it to master? Sorry. BTW is there any reason, why memset(this->postingsFreeListDW.values + this->postingsFreeCountDW , NULL , sizeof(Posti

Re: [CLucene-dev] Current branches state

2010-09-17 Thread Kostka Bořivoj
Itamar, I'm not sure, if I understand your strategy for creating branches. Do you mean I should create new branch for each test (and related core fixes, if any)? Borek > -Original Message- > From: Itamar Syn-Hershko [mailto:ita...@code972.com] > Sent: Thursday, September 16, 2010 5:25

Re: [CLucene-dev] Wrong condition in check if space for terminating NULL is available in postingsFreeListDW.values

2010-09-17 Thread Itamar Syn-Hershko
On 17/9/2010 9:55 AM, Kostka Bořivoj wrote: > Itamar, > > I pushed one more fix for this condition, previous one wasn't 100% correct, > too. Could you please cherry pick it to master? Sorry. > I can't see it. Please push it to master once you are sure it is the correct one :) > BTW is there

Re: [CLucene-dev] Current branches state

2010-09-17 Thread Itamar Syn-Hershko
On 17/9/2010 10:52 AM, Kostka Bořivoj wrote: > Itamar, > > I'm not sure, if I understand your strategy for creating branches. > Do you mean I should create new branch for each test (and related core fixes, > if any)? > > Borek The idea is simple - to have fixes and features self-contained in thei

Re: [CLucene-dev] Wrong condition in check if space for terminating NULL is available in postingsFreeListDW.values

2010-09-17 Thread Kostka Bořivoj
OK, done. Hope this condition is correct after 3 attempts :-) > -Original Message- > From: Itamar Syn-Hershko [mailto:ita...@code972.com] > Sent: Friday, September 17, 2010 11:15 AM > To: clucene-developers@lists.sourceforge.net > Subject: Re: [CLucene-dev] Wrong condition in check if spac

Re: [CLucene-dev] Current branches state

2010-09-17 Thread Kostka Bořivoj
We (me and Jiri) did tests on new merged master, as well as chck manually changes. Everything seems to be OK, so we moved to master branch. But some indexing tests on huge data are running now. So we would like to leave our branches in repo until tests finishes, if you don't mind. Once these tes

Re: [CLucene-dev] Current branches state

2010-09-17 Thread Šplíchal Jiří
Hi, we encountered one more issue that should be solved - at least in some future version: the FSDirectory::FSIndexOutput constructor may throw exception (this happens i.e. if you are out of disk space) and if it happens the destructor of the base class is called (BufferedIndexOutput) which lead