Re: [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range

2013-09-09 Thread Lon Hohberger
Yes, this is right. I'm not sure why I limited the port ranges - and differently, depending on where you look in the code. This should be merged. -- Lon On 09/03/2013 12:48 PM, Jan Pokorný wrote: Signed-off-by: Jan Pokorný jpoko...@redhat.com --- client/options.c | 2 +- server/config.c

Re: [Cluster-devel] [PATCH] rgmanager: Don't duplicate configuration change events

2013-02-27 Thread Lon Hohberger
status poll interval, thousands of duplicate events can be put onto the queue. This patch causes rgmanager to queue only one config event per detected configuration change. Good catch there. Ack / Reviewed-by: Lon Hohberger l...@redhat.com -- Lon This applies only to the RHEL5 branch

Re: [Cluster-devel] [PATCH][fence-virt] Drop executable flag for man pages

2012-12-04 Thread Lon Hohberger
On 11/27/2012 12:00 PM, Jan Pokorný wrote: Reported-by: rpmlint http://rpmlint.zarb.org/cgi-bin/trac.cgi Signed-off-by: Jan Pokorný jpoko...@redhat.com --- man/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/Makefile.in b/man/Makefile.in index

Re: [Cluster-devel] [PATCH] Med: Improve script.sh's error reporting (RHEL6)

2012-11-29 Thread Lon Hohberger
On 11/26/2012 10:23 AM, Lon Hohberger wrote: The script agent used primarily by rgmanager had a very minimal amount of error reporting, such that it could be very confusing as to why a script resource had failed. This patch looks for a variety of errors from the script resource. Replaced

[Cluster-devel] [PATCH] Med: Improve script.sh's error reporting (RHEL6)

2012-11-26 Thread Lon Hohberger
The script agent used primarily by rgmanager had a very minimal amount of error reporting, such that it could be very confusing as to why a script resource had failed. This patch looks for a variety of errors from the script resource. Resolves: rhbz#773478 Signed-off-by: Lon Hohberger l

Re: [Cluster-devel] fence daemon problems

2012-10-09 Thread Lon Hohberger
On 10/03/2012 12:44 PM, David Teigland wrote: You might be able to assign different numbers of votes to reduce the likelihood of everyone loosing quorum. (Late to thread - here's an example of what David is talking about): Node Votes - - node1 1 node2 2 node3 3 node4 5 Total:

Re: [Cluster-devel] fence daemon problems

2012-10-09 Thread Lon Hohberger
On 10/03/2012 12:55 PM, Dietmar Maurer wrote: The intention of that is to prevent an inquorate node/partition from killing a quorate group of nodes that are running normally. e.g. if a 5 node cluster is partitioned into 2/3 or 1/4. You don't want the 2 or 1 node group to fence the 3 or 4 nodes

Re: [Cluster-devel] [PATCH] rgmanager: Fix for deadlock

2012-10-02 Thread Lon Hohberger
On 10/01/2012 11:29 AM, Ryan McCabe wrote: This patch fixes a deadlock in rgmanager that could occur when a node starts rgmanager while a service is recovering. Resolves: rhbz#834459 Signed-off-by: Ryan McCabe rmcc...@redhat.com That looks like a RHEL5 port of the same patch. Ack. --

Re: [Cluster-devel] [PATCH] rgmanager: Fix for deadlock

2012-09-28 Thread Lon Hohberger
On 09/27/2012 03:18 PM, Ryan McCabe wrote: This patch fixes a deadlock in rgmanager that could occur when a node starts rgmanager while a service is recovering. This basically prevents (where other places in the code try to avoid, it looks like in the comments) cases where RG_START_REMOTE is

Re: [Cluster-devel] [PATCH] rgmanager: Don't use the resource name in tmp file names

2012-09-18 Thread Lon Hohberger
Signed-off-by: Ryan McCabe rmcc...@redhat.com Reviewed-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/fs.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/resources/fs.sh b/rgmanager/src/resources/fs.sh index 147f246..e55e77f

Re: [Cluster-devel] [PATCH] qdiskd: backport dual socket connection to cman

2012-08-13 Thread Lon Hohberger
On 08/13/2012 08:39 AM, Fabio M. Di Nitto wrote: From: Fabio M. Di Nitto fdini...@redhat.com Patch 76741bb2a94ae94e493c609d50f570d02e2f3029 had a not so obvious dependency on 08ae3ce147b2771c5ee6e1d364a5e48c88384427. Backport portion of 08ae3ce147b2771c5ee6e1d364a5e48c88384427 to handle

Re: [Cluster-devel] [PATCH] fence_xvm: Fix incorrect success return codes

2012-07-25 Thread Lon Hohberger
On 07/25/2012 10:43 AM, Ryan McCabe wrote: This patch fixes two places where fence_xvm will return success for fencing operations when fencing has failed due to the challenge/response failing. Resolves: rhbz#843083 ACK. -- Lon

Re: [Cluster-devel] [PATCH] rgmanager: Add IP interface parameter

2012-07-24 Thread Lon Hohberger
ACK -- Lon On 07/24/2012 01:37 PM, Ryan McCabe wrote: On Sat, Jul 21, 2012 at 06:47:50AM +0200, Fabio M. Di Nitto wrote: On 07/20/2012 11:07 PM, Lon Hohberger wrote: Sure; that's fine. prefer_interface= maybe? If more than one match, use this one, otherwise, use the one that matches

Re: [Cluster-devel] [PATCH] rgmanager: Add IP interface parameter

2012-07-20 Thread Lon Hohberger
On 07/14/2012 03:54 PM, Fabio M. Di Nitto wrote: On 07/13/2012 10:08 PM, Lon Hohberger wrote: On 07/13/2012 12:08 AM, Fabio M. Di Nitto wrote: Hi Ryan, only one comment here.. many times we have been asked to implement interface parameter to allow any random IP on any specific interface

Re: [Cluster-devel] [PATCH] rgmanager: Add IP interface parameter

2012-07-13 Thread Lon Hohberger
On 07/13/2012 12:08 AM, Fabio M. Di Nitto wrote: Hi Ryan, only one comment here.. many times we have been asked to implement interface parameter to allow any random IP on any specific interface (beside the pre configured ip on that interface). We haven't done that because we might end up

Re: [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node

2012-07-13 Thread Lon Hohberger
; } } Reviewed-by: Lon Hohberger l...@redhat.com -- Lon

Re: [Cluster-devel] [PATCH] qdiskd: Make multipath issues go away

2012-07-13 Thread Lon Hohberger
On 07/02/2012 09:55 AM, Fabio M. Di Nitto wrote: From: Lon Hohberger l...@redhat.com Qdiskd hsitorically has required significant tuning to work around delays which occur during multipath failover, overloaded I/O, and LUN trespasses in both device-mapper-multipath and EMC PowerPath

Re: [Cluster-devel] [PATCH] rgmanager: fix nfsrestart option to be effective

2012-06-21 Thread Lon Hohberger
On 06/21/2012 04:07 AM, Fabio M. Di Nitto wrote: From: Fabio M. Di Nittofdini...@redhat.com The original patch e512a9ce367 was still racy in some conditions as other rpc.* and nfs* processes were holding a lock on the filesystem. stopping nfs in kernel is simply not enough in rhel5 this fixed

[Cluster-devel] [PATCH] rgmanager: Add man page for cpglockd; update rgmanager.8

2012-05-01 Thread Lon Hohberger
Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/man/cpglockd.8 | 24 rgmanager/man/rgmanager.8 |7 ++- 2 files changed, 30 insertions(+), 1 deletions(-) create mode 100644 rgmanager/man/cpglockd.8 diff --git a/rgmanager/man/cpglockd.8 b/rgmanager

[Cluster-devel] [PATCH] rgmanager: Add man page for cpglockd; update rgmanager.8

2012-05-01 Thread Lon Hohberger
Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/man/cpglockd.8 | 21 + rgmanager/man/rgmanager.8 |7 ++- 2 files changed, 27 insertions(+), 1 deletions(-) create mode 100644 rgmanager/man/cpglockd.8 diff --git a/rgmanager/man/cpglockd.8 b/rgmanager/man

Re: [Cluster-devel] [PATCH] rgmanager: Add man page for cpglockd; update rgmanager.8

2012-05-01 Thread Lon Hohberger
On 05/01/2012 10:24 AM, Lon Hohberger wrote: Signed-off-by: Lon Hohbergerl...@redhat.com Wrong; see other patch. -- Lon

Re: [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails

2012-04-09 Thread Lon Hohberger
On 04/09/2012 10:34 AM, Ryan O'Hara wrote: If the do_action_on subroutine fails to create a reservation, the error count should be incremented not set to zero. Resolves: rhbz#809481 ACK -- Lon

Re: [Cluster-devel] [PATCH] fence_scsi_test: add option for strict verification

2012-04-09 Thread Lon Hohberger
and the number of paths. This is useful when testing multipath configurations. If this option is not specified, the verification will simply check to make sure the registration keys exist on the device. Resolves: rhbz#782919 Reviewed-by: Lon Hohberger l...@redhat.com -- Lon

Re: [Cluster-devel] [PATCH] resource-agents: Allow multiple mounts from the same NFS export

2012-03-05 Thread Lon Hohberger
On 03/05/2012 05:35 PM, Chris Feist wrote: Allow multiple mounts from the same NFS export Resolves: rhbz#78 If the fstype is set to nfs, cifs or nfs4 (netfs file types), then we don't say that we're in use or mounted in certain circumstances. ACK -- Lon

Re: [Cluster-devel] [PATCH] resource-agents: Fix to allow yes, true or 1 to enable --tunnelled

2012-03-05 Thread Lon Hohberger
On 03/05/2012 06:09 PM, Chris Feist wrote: Fix to allow yes, true or 1 to enable --tunnelled ACK

Re: [Cluster-devel] Small Bug in follow-service.sl

2012-03-01 Thread Lon Hohberger
On 02/28/2012 05:05 AM, Marc Grimme wrote: Hello, a few weeks ago I stumbled over an issue in the follow-service functionality in rgmanager event scripting with rind. When I wrote it I didn't think about people not having a specifically configured failover domain. But I had to setup the

[Cluster-devel] [PATCH] rgmanager: Retry when config is out of sync [RHEL5]

2012-02-29 Thread Lon Hohberger
. Update 22-Feb-2012: The above is incorrect, this was reproduced a rgmanager v3 installation. Resolves: rhbz#796272 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/rg_state.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git

[Cluster-devel] [PATCH] rgmanager: Fix clusvcadm message when run with -F [RHEL6]

2012-02-21 Thread Lon Hohberger
The new_owner was not being correctly set when enabling a service with -F when run without central processing enabled. Resolves: rhbz#727326 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/rg_state.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [Cluster-devel] [PATCH] config: make altname validation position indipendent

2012-02-20 Thread Lon Hohberger
On 11/28/2011 04:50 AM, Fabio M. Di Nitto wrote: From: Fabio M. Di Nittofdini...@redhat.com Resolves: rhbz#740552 Signed-off-by: Fabio M. Di Nittofdini...@redhat.com You didn't strictly have to make an ALTNAME ref block if you didn't want to. The FENCE block is used in two places, IIRC

[Cluster-devel] [PATCH] qdiskd: Make multipath issues go away [RHEL6, take2]

2012-02-17 Thread Lon Hohberger
. Resolves: rhbz#678372 Signed-off-by: Lon Hohberger l...@redhat.com --- cman/daemon/cnxman-socket.h |1 + cman/qdisk/Makefile |2 +- cman/qdisk/disk.h |6 + cman/qdisk/iostate.c| 16 -- cman/qdisk/iostate.h|4 ++- cman/qdisk/main.c

Re: [Cluster-devel] [PATCH] qdiskd: Make multipath issues go away

2012-02-17 Thread Lon Hohberger
On 02/17/2012 12:38 AM, Fabio M. Di Nitto wrote: The patch looks good and ACK, with one minor nitpick. that 178 port value in cman_recv/send_data is rather cryptic. I would prefer to see it defined as others in cman/cnxman-socket.h for documentation purposes (so we know it's QDISK). I pushed

[Cluster-devel] [PATCH] qdiskd: Make multipath issues go away

2012-02-15 Thread Lon Hohberger
. Resolves: rhbz#678372 Signed-off-by: Lon Hohberger l...@redhat.com --- cman/qdisk/Makefile |2 +- cman/qdisk/disk.h|6 ++ cman/qdisk/iostate.c | 16 +--- cman/qdisk/iostate.h |4 +++- cman/qdisk/main.c| 45 ++--- 5 files

Re: [Cluster-devel] [PATCH] qdiskd: Make multipath issues go away [RHEL6]

2012-02-15 Thread Lon Hohberger
Fixing subject. -- Lon

Re: [Cluster-devel] [fence-virt PATCH] backend plugin for Pacemaker

2012-02-07 Thread Lon Hohberger
On 09/20/2011 03:40 AM, Kazunori INOUE wrote: Merged in to 0.3.0 -- Lon

[Cluster-devel] fence-virt 0.3.0

2012-02-07 Thread Lon Hohberger
Hi, I've cut v0.3.0 of fence-virt. - Serial listener now can handle multiple domain starts/stops - Libvirt-qpid replaced with libvirt-qmf - QMFv2 management - A pacemaker backend is now available - Systemd integration - Deprecated cman/checkpoint plugin. - Easier to deploy on Fedora systems.

Re: [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED

2012-02-07 Thread Lon Hohberger
On 09/13/2011 04:44 AM, Kazunori INOUE wrote: [all late and wrong] Merged in to 0.3.0 -- Lon

Re: [Cluster-devel] fence-virt 0.3.0

2012-02-07 Thread Lon Hohberger
On 02/07/2012 06:13 PM, Lon Hohberger wrote: Bleeding edge packages: http://koji.fedoraproject.org/koji/taskinfo?taskID=3770449 Clearly, I need more coffee. Source tarball here: https://sourceforge.net/projects/fence-virt/files/fence-virt-0.3.0.tar.gz/download My apologies

Re: [Cluster-devel] [PATCH] fence_rhevm: Incorrect status detected when VM is not in up/down

2012-01-30 Thread Lon Hohberger
On 01/30/2012 10:58 AM, Marek 'marx' Grac wrote: For fencing purposes we have to focus on getting OFF status when machine is really 100% down, conditions for ON status are much simplier (as fact that machine is has power does not mean that it works). This patch specify condition for OFF status -

[Cluster-devel] [PATCH 1/5] rgmanager: Add extra service status call (RHEL5)

2012-01-05 Thread Lon Hohberger
Pass the flags and last transition time back to caller if the caller requests it with an additional parameter. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/slang_event.c | 105 +-- 1 files changed, 100 insertions

[Cluster-devel] [PATCH 5/5] rgmanager: Fix dependency issue related to ordering (RHEL5)

2012-01-05 Thread Lon Hohberger
(). Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/default_event_script.sl |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/resources/default_event_script.sl b/rgmanager/src/resources

[Cluster-devel] [PATCH 4/5] rgmanager: Fix tiny memory leak in sl_service_status (RHEL5)

2012-01-05 Thread Lon Hohberger
Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/slang_event.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c index c9cca7a

[Cluster-devel] [PATCH 3/5] rgmanager: Fix call to service_status() (RHEL5)

2012-01-05 Thread Lon Hohberger
This patch simply fixes the calls to service_status(), the s_trans variable was being incorrectly set. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/default_event_script.sl |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff

[Cluster-devel] [PATCH 2/5] rgmanager: Avoid duplicate restart of service (RHEL5)

2012-01-05 Thread Lon Hohberger
is that in order for this patch to work correctly, the cluster nodes' time must be approximately in sync. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/default_event_script.sl | 19 ++- 1 files changed, 18 insertions(+), 1 deletions

Re: [Cluster-devel] [PATCH 5/5] rgmanager: Fix dependency issue related to ordering (RHEL5)

2012-01-05 Thread Lon Hohberger
On 01/05/2012 10:57 AM, Lon Hohberger wrote: @@ -521,8 +523,8 @@ define default_service_event_handler() (s_trans,, s_state) = service_status(service_name, 1); if ((s_state == started) and (state == started

[Cluster-devel] [PATCH] rgmanager: OCF_NOT_INSTALLED is OK if we stop when stopped (RHEL5)

2012-01-04 Thread Lon Hohberger
not existing. The combination of these create the ability for a missing script to move to a node where the script exists, or be placed in to the stopped state. Resolves: rhbz#768146 Signed-off-by: Lon Hohberger l...@redhat.com Reviewed-by: Adam Drew ad...@redhat.com Tested-by: Adam Drew ad

Re: [Cluster-devel] [PATCH] rgmanager: OCF_NOT_INSTALLED is OK if we stop when stopped (RHEL5)

2012-01-04 Thread Lon Hohberger
On 01/04/2012 04:01 PM, Lon Hohberger wrote: Scripts often live in file systems which are mounted by rgmanager. This patch makes rgmanager ignore the OCF_NOT_INSTALLED error returned from the script agent if we attempt to stop when a start failed. (Note that Adam already reviewed this off

[Cluster-devel] [PATCH] rgmanager: Backport upstream fixes for SAPDatabase agent

2012-01-04 Thread Lon Hohberger
This patch is specific to the RHEL5 branches and was provided by Frank Danapfel based on his work with the upstream version of the SAPDatabase agent. Resolves: rhbz#747352 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/SAPDatabase | 95

[Cluster-devel] [PATCH 1/2] rgmanager: Add extra service status call (RHEL5)

2012-01-04 Thread Lon Hohberger
Pass the flags and last transition time back to caller if the caller requests it with an additional parameter. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/slang_event.c | 105 +-- 1 files changed, 100 insertions

Re: [Cluster-devel] [PATCH 32/41] qdiskd: clean code around case

2011-11-30 Thread Lon Hohberger
On 11/29/2011 01:24 PM, Fabio M. Di Nitto wrote: On 11/29/2011 06:59 PM, Lon Hohberger wrote: On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote: Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nittofdini...@redhat.com --- :100644 100644 c4db713... 51d9a39... Mcman/qdisk/main.c cman

Re: [Cluster-devel] [PATCH 32/41] qdiskd: clean code around case

2011-11-29 Thread Lon Hohberger
On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote: Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nittofdini...@redhat.com --- :100644 100644 c4db713... 51d9a39... M cman/qdisk/main.c cman/qdisk/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [Cluster-devel] [PATCH 38/41] qdiskd: fix possible resource leak in scandisk

2011-11-29 Thread Lon Hohberger
On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote: Spotted by Coverity Scan - while (fgets(line, sizeof(line), fp) - != NULL) { + + while (fgets(line, sizeof(line) - 1, fp) != NULL) { fgets takes at most size-1, this isn't needed -- Lon

Re: [Cluster-devel] [PATCH 37/41] qdiskd: add failure paths to check_process_running and drop duplicate check

2011-11-29 Thread Lon Hohberger
On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote: + fprintf(stderr, Unable to determin if %s is already running: %s\n, + argv[0], strerror(errno)); Typo (determine) -- Lon

[Cluster-devel] [PATCH 1/2] rgmanager: Mark services on dead nodes as stopped [RHEL5]

2011-10-27 Thread Lon Hohberger
Cleans up clustat reporting and avoids a race. Resolves: rhbz#722230 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/groups.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src

[Cluster-devel] [PATCH 2/2] rgmanager: Send events on service stop preserve frozen flag [RHEL5]

2011-10-27 Thread Lon Hohberger
The rgmanger FROZEN flag is supposed to persist until disabled explicitly by an administrator or loss of quorum. Resolves: rhbz#722230 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/include/event.h|1 + rgmanager/src/daemons/groups.c | 15 +-- rgmanager

[Cluster-devel] [PATCH] resource-agents: Handle TREX and Webdispatcher in SAPInstance [RHEL5]

2011-10-27 Thread Lon Hohberger
From: Harald Klein hkl...@redhat.com Note: This patch is not suitable for mainline resource-agents/heartbeat/SAPInstance, alterations must be made separately. Resolves: rhbz#746992 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/SAPInstance |2 +- 1 files changed

[Cluster-devel] [PATCH] resource-agents: nfsclient: fix wildcard status checks [RHEL5]

2011-10-27 Thread Lon Hohberger
Several permutations of nfsclients with options were not checked correctly due to bad pattern matching. Resolves: rhbz#700103 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/nfsclient.sh | 20 1 files changed, 12 insertions(+), 8 deletions

Re: [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED

2011-10-25 Thread Lon Hohberger
On 09/19/2011 04:32 PM, Lon Hohberger wrote: On 09/13/2011 04:44 AM, Kazunori INOUE wrote: I attached the patch for this problem. * Modified to send a SIGHUP to the primary thread from the secondary thread detects the start of the VM, and the primary thread is modified so

Re: [Cluster-devel] [fence-virt PATCH] backend plugin for Pacemaker

2011-10-25 Thread Lon Hohberger
. (3) vm-stonith requests 'fencing' to a host with fence_virt. (4) use the serial listener. (5~7) fence_virtd (pm-fence backend) requests 'forced stop' of VM resource (that is, srv-B) to pacemaker. (8) destroy the srv-B. Signed-off-by: Lon Hohberger l...@users.sourceforge.net --- configure.in

Re: [Cluster-devel] [fence-virt PATCH] backend plugin for monitoring a host's status

2011-10-25 Thread Lon Hohberger
On 10/05/2011 04:56 AM, Kazunori INOUE wrote: Hi all, I think that the communication function of fence-virt is flexible, so I want to use it more effectively. Therefore I made backend plugin for a guest to get the host's status using the communication facility of fence-virt, and I

Re: [Cluster-devel] [PATCH] rgmanager: Fix ASEHAagent to make server_name unique

2011-10-18 Thread Lon Hohberger
On 10/18/2011 01:29 PM, Chris Feist wrote: Require server_name to be unique. That looks fine; I tested it as well. -- Lon

[Cluster-devel] [PATCH 1/2] rgmanager: Clean up DBus concurrency [RHEL6]

2011-10-18 Thread Lon Hohberger
This centralizes creation/deletion of the DBus dispatch thread. Resolves: rhbz#741607 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/update-dbus.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/rgmanager/src/daemons/update-dbus.c

[Cluster-devel] [PATCH 2/2] rgmanager: Block signals when dealing with dbus [RHEL6]

2011-10-18 Thread Lon Hohberger
DBus calls seem to not retry in the event of signals; it appears that occasionally this causes a double unref or a segfault. So, block signals when dealing with DBus in order to prevent rgmanager from crashing. Resolves: rhbz#741607 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager

Re: [Cluster-devel] cluster4 gfs_controld

2011-10-13 Thread Lon Hohberger
On 10/13/2011 11:30 AM, David Teigland wrote: On Thu, Oct 13, 2011 at 03:41:31PM +0100, Steven Whitehouse wrote: cluster4 . jid from dlm-kernel slots which will be assigned similarly What is the actual algorithm used to assign these slots? The same as picking jids: lowest unused id starting

[Cluster-devel] [PATCH] rgmanager: Add -F to clusvcadm man page [RHEL5]

2011-10-11 Thread Lon Hohberger
Resolves: rhbz#715052 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/man/clusvcadm.8 |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/rgmanager/man/clusvcadm.8 b/rgmanager/man/clusvcadm.8 index d5e09eb..055a0bf 100644 --- a/rgmanager/man/clusvcadm.8

Re: [Cluster-devel] [PATCH 3/3] gfs_controld: full check for member changes

2011-09-28 Thread Lon Hohberger
On 09/28/2011 12:37 PM, David Teigland wrote: cman members are queried in response to a callback, and members sometimes leave and rejoin between queries (e.g. when they leave and rejoin before corosync detects they left.) This means that simply checking if a node is a member in consecutive

Re: [Cluster-devel] [PATCH] cman: fix copying uidgid trees to corosync

2011-09-19 Thread Lon Hohberger
On 09/16/2011 10:15 AM, Fabio M. Di Nitto wrote: Resolves: rhbz#733345 I acked this off-list; but adding it on-list too. -- Lon

Re: [Cluster-devel] [PATCH] cman: improve cman/qdisk interactions

2011-09-08 Thread Lon Hohberger
checking of some update opertaions Thanks, looks good. -- Lon -- Lon Hohberger - Red Hat, Inc.

[Cluster-devel] [PATCH] rgmanager: Fix segfault caused by unref race [RHEL6]

2011-09-07 Thread Lon Hohberger
Signed-off-by: Lon Hohberger l...@redhat.com Tested-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/update-dbus.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/rgmanager/src/daemons/update-dbus.c b/rgmanager/src/daemons/update-dbus.c index

[Cluster-devel] [PATCH] rgmanager: Fix uninitialized variable [RHEL6]

2011-09-06 Thread Lon Hohberger
Resolves: rhbz#734730 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rgmanager/src/daemons/main.c b/rgmanager/src/daemons/main.c index 4e12c68..931d95e 100644 --- a/rgmanager/src/daemons

Re: [Cluster-devel] [PATCH] cman: allow init script to pass options to fenced

2011-08-16 Thread Lon Hohberger
if [ $? -ne 0 ]; then - errmsg=$( /sbin/fenced 21 ) || return 1 + errmsg=$( /sbin/fenced $FENCED_OPTS 21 ) || return 1 fi status dlm_controld /dev/null This looks fine by me. -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager

2011-08-11 Thread Lon Hohberger
, should we try to match that with the agents we've converted? Or should we just keep them as is? The only issue is that then we can't fully test the ocf_tester until after we install. This is fine -- testing from the source tree is a valid thing to do. -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager

2011-08-10 Thread Lon Hohberger
+ case $? in + $OCF_NOT_RUNNING) + clog_service_status $CLOG_FAILED $MYSL_pid_file Typo ... MYSQL (happens twice in your patch) Otherwise, good by me. -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [fence-virt PATCH 2/2] Add libvirt-qmf support to the libvirt-qpid plugin

2011-08-10 Thread Lon Hohberger
good, only question I have is should we use libvirt-qmf instead of libvirt-qpid in the config file? (Happy to do that work if needed). Merged. -- Lon Hohberger - Red Hat, Inc.

[Cluster-devel] [PATCH] Low: Improve netfs unmount when server is unavailable [RHEL6]

2011-08-08 Thread Lon Hohberger
Resolves: rhbz#678467 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/fs.sh.in|3 ++- rgmanager/src/resources/netfs.sh|3 ++- rgmanager/src/resources/utils/fs-lib.sh | 12 ++-- 3 files changed, 14 insertions(+), 4 deletions(-) diff

[Cluster-devel] [PATCH] rgmanager: Fix race in shutdown vs. notification [RHEL6]

2011-08-02 Thread Lon Hohberger
The check of db prior to taking the mutex was done as a tiny performance gain in the event that there was no dbus connection, but causes dbus_connection_get_is_connected() to crash the program if db is NULL. Resolves: rhbz#697446 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src

Re: [Cluster-devel] [fence-virt PATCH] Fix typo that broke multicast plugin

2011-08-02 Thread Lon Hohberger
On Wed, Jul 27, 2011 at 06:37:31PM +0200, Zane Bitter wrote: Signed-off-by: Zane Bitter zbit...@redhat.com Merged. -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH] Fix error getting status from libvirt-qpid plugin

2011-08-02 Thread Lon Hohberger
, state); } Merged -- Lon Hohberger - Red Hat, Inc.

[Cluster-devel] [PATCH] fence_kdump: Fix metadata

2011-08-01 Thread Lon Hohberger
Having duplicate verbose parameters is not valid. Signed-off-by: Lon Hohberger l...@redhat.com --- fence/agents/kdump/fence_kdump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fence/agents/kdump/fence_kdump.c b/fence/agents/kdump/fence_kdump.c index 8fdb681..2844a3e

[Cluster-devel] [PATCH] rgmanager: Add 'disabled' configuration option [RHEL6]

2011-08-01 Thread Lon Hohberger
The option turns off rgmanager, which will shut down if running and cause rgmanager to refuse to start if starting up. Resolves: rhbz#723925 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/main.c | 51 +- 1 files changed, 50

[Cluster-devel] [PATCH] config: Add 'disabled' flag to rm element [RHEL6]

2011-08-01 Thread Lon Hohberger
Related: rhbz#723925 Signed-off-by: Lon Hohberger l...@redhat.com --- config/tools/xml/cluster.rng.in.head |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/config/tools/xml/cluster.rng.in.head b/config/tools/xml/cluster.rng.in.head index f9606ad..7696533 100644

[Cluster-devel] [PATCH] rgmanager: Make handling of failed services consistent

2011-07-08 Thread Lon Hohberger
For RHEL6 branch. See bugzilla for what has changed specifically. Resolves: rhbz#673167 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/include/resgroup.h |1 + rgmanager/src/clulib/rg_strings.c |3 ++- rgmanager/src/daemons/rg_state.c | 24

[Cluster-devel] [PATCH] rgmanager: Fix bad passing of SFL_FAILURE up - RHEL5

2011-06-23 Thread Lon Hohberger
We were handling failures at the 'highest' independent subtree level instead of lowest; this patch fixes that. Resolves: rhbz#711521 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/restree.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified

2011-06-20 Thread Lon Hohberger
to the objdb only if value is not default */ if (ttl != 1) { ... as well as understanding the objdb_get_int() function. ACK. Reviewed-by: Lon Hohberger l...@redhat.com -- Lon Resolves: rhbz#713977 Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- cman/daemon/cman

[Cluster-devel] [PATCH] qdiskd: Make multipath issues go away

2011-05-09 Thread Lon Hohberger
-off-by: Lon Hohberger l...@redhat.com --- cman/qdisk/Makefile |2 +- cman/qdisk/disk.h|6 ++ cman/qdisk/iostate.c | 16 +--- cman/qdisk/iostate.h |4 +++- cman/qdisk/main.c| 45 ++--- 5 files changed, 65 insertions

Re: [Cluster-devel] [PATCH] resource-agents: Fix nfs mount contexts

2011-04-15 Thread Lon Hohberger
this approach is to guarantee that we don't need resource-agents to Requires those tools at packaging level and enforce them on a system. Understood. -- Lon Hohberger - Red Hat, Inc.

[Cluster-devel] [PATCH] resource-agents: Fix nfs mount contexts

2011-04-15 Thread Lon Hohberger
- check for SELinux enabled - grab the installed distribution's SELinux label for /var/lib/nfs/statd - chcon / restorecon using that label (restorecon should be enough, but it seems to not work across bind mounts) Resolves: rhbz#635828 Signed-off-by: Lon Hohberger l...@redhat.com

Re: [Cluster-devel] [PATCH] resource-agents: Fix nfs mount contexts

2011-04-14 Thread Lon Hohberger
Note - patch proposed for RHEL6 branch. -- Lon Hohberger - Red Hat, Inc.

[Cluster-devel] [PATCH] ras / RHEL5: Trim trailing slash for nfs clients

2011-04-07 Thread Lon Hohberger
The exportfs command and/or rpc.mountd trim the trailing slashes when reporting things in /var/lib/nfs/etab, causing mismatch problems for the nfsclient resource agent. Resolves: rhbz#592624 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/nfsclient.sh |2 ++ 1 files

[Cluster-devel] [PATCH] rhel5 rgmanager: Improve rgmanager's exclusive prioritization handling

2011-04-07 Thread Lon Hohberger
Resolves: rhbz#680256 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/default_event_script.sl | 72 ++- 1 files changed, 56 insertions(+), 16 deletions(-) diff --git a/rgmanager/src/resources/default_event_script.sl b/rgmanager/src/resources

[Cluster-devel] [PATCH] rhel5 cman: Clarify 'expected' option

2011-04-07 Thread Lon Hohberger
From: Shane Bradley sbrad...@redhat.com Resolves: rhbz#688701 Signed-off-by: Lon Hohberger l...@redhat.com --- cman/man/cman_tool.8 |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/cman/man/cman_tool.8 b/cman/man/cman_tool.8 index 554a316..71e1841 100644 --- a/cman

[Cluster-devel] [PATCH] resource-agents: Try force-unmount before fuser for netfs.sh

2011-03-21 Thread Lon Hohberger
RHEL5 only. A completely separate patch is needed for upstream and RHEL6 Resolves: rhbz#678494 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/netfs.sh |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/rgmanager/src/resources/netfs.sh b

Re: [Cluster-devel] [PATCH 2/2] fence_wti: Unable to parse output when splitted into several screens (2/2)

2011-03-16 Thread Lon Hohberger
) - conn.send(/S+\r\n) result = conn.log_expect(options, re_all, int(options[-Y])) listing = conn.before if result == (len(re_all) - 1): Ack -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH] cman init: increse the default timeout waiting for quorum

2011-03-16 Thread Lon Hohberger
On Wed, Mar 16, 2011 at 04:28:51PM +0100, Fabio M. Di Nitto wrote: not all clusters can achieve quorum in 20 seconds. Bump to 45 by default. Value is still tunable via sysconfig entry. ACK -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH] Allow fence_scsi to use any valid hexadecimal key

2011-03-15 Thread Lon Hohberger
On Tue, Mar 15, 2011 at 02:49:01PM -0500, Ryan O'Hara wrote: Signed-off-by: Jim Ramsay jim_ram...@dell.com Signed-off-by: Ryan O'Hara roh...@redhat.com Reviewed-by: Lon Hohberger l...@redhat.com ack -- Lon Hohberger - Red Hat, Inc.

Re: [Cluster-devel] [PATCH 1/2] ccs: Allow ccs_tool to use alternate base ports

2011-02-15 Thread Lon Hohberger
On Tue, 2011-02-15 at 06:17 +0100, Fabio M. Di Nitto wrote: Untested, looks sane to me, ACK. Fabio Test results are here: https://bugzilla.redhat.com/show_bug.cgi?id=656427#c8 -- Lon

[Cluster-devel] [PATCH] RHEL5 cman: Don't increment on LEAVING-MEMBER transition

2011-02-15 Thread Lon Hohberger
a LEAVING-MEMBER transition. Resolves: rhbz#649533 Signed-off-by: Lon Hohberger l...@redhat.com --- cman/daemon/commands.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/cman/daemon/commands.c b/cman/daemon/commands.c index 6ffe9e5..6c91d7a 100644 --- a/cman/daemon

[Cluster-devel] [PATCH] RHEL5: fence-agents: Regerate fence_ipmilan.8 man page

2011-02-15 Thread Lon Hohberger
Resolves: rhbz#671089 Signed-off-by: Lon Hohberger l...@redhat.com --- fence/man/fence_ipmilan.8 | 262 1 files changed, 167 insertions(+), 95 deletions(-) diff --git a/fence/man/fence_ipmilan.8 b/fence/man/fence_ipmilan.8 index 9b10198..3bca4d1

[Cluster-devel] [PATCH 1/2] ccs: Allow ccs_tool to use alternate base ports

2011-02-14 Thread Lon Hohberger
Patch only for RHEL5 branch. Resolves: rhbz#656427 Signed-off-by: Lon Hohberger l...@redhat.com --- ccs/ccs_tool/ccs_tool.c |2 +- ccs/ccs_tool/update.c | 64 ++- ccs/ccs_tool/update.h |1 + 3 files changed, 65 insertions(+), 2 deletions

[Cluster-devel] [PATCH 2/2] ccs: Update manual page for ccs_tool

2011-02-14 Thread Lon Hohberger
Patch only for RHEL5 branch. Resolves: rhbz#656427 Signed-off-by: Lon Hohberger l...@redhat.com --- ccs/man/ccs_tool.8 |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/ccs/man/ccs_tool.8 b/ccs/man/ccs_tool.8 index e8869c0..0d82248 100644 --- a/ccs/man/ccs_tool.8

[Cluster-devel] [PATCH] qdiskd: Fix auto-vote calculation loop

2011-02-04 Thread Lon Hohberger
Resolves: rhbz#663433 Signed-off-by: Lon Hohberger l...@redhat.com --- cman/qdisk/disk.c |1 + cman/qdisk/main.c | 31 --- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/cman/qdisk/disk.c b/cman/qdisk/disk.c index 1f646ce..9884ea7 100644

  1   2   3   >