[Cluster-devel] GFS2: Patches pulled, linux-gfs2.git for-next rebased

Hi, Linus has pulled the latest set of patches from the for-next branch of the linux-gfs2.git tree, so I rebased the tree from Linus's master. So the current tree is back to having no unmerged GFS2 patches (but a few still in the queue that haven't been pushed to the tree). Regards, Bob

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

t; include/linux/lockref.h | 1 + > lib/lockref.c | 28 > 3 files changed, 57 insertions(+), 19 deletions(-) > > -- > 2.14.3 Hi, The patches look good. The big question is whether to add them to this merge window while it's still open. Opinions? Acked-by: Bob Peterson <rpete...@redhat.com> Regards, Bob Peterson

[Cluster-devel] GFS2: Pull request (merge window)

Hi Linus, Please consider pulling the following changes for the GFS2 file system. Regards, Bob Peterson The following changes since commit 1b88accf6a659c46d5c8e68912896f112bf882bb: Merge tag 'for_linus' of git://git.kernel.org

[Cluster-devel] [PATCH 2/9] gfs2: Dirty source inode during rename

e lost. This happens in command sequences like: xfs_io -f -c 'pwrite 0 4096' -c 'fsync' foo mv foo bar xfs_io -c 'fsync' bar # power failure Fixes xfstests generic/322, generic/376. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.co

[Cluster-devel] [PATCH 5/9] gfs2: Improve gfs2_block_map comment

From: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs

[Cluster-devel] [PATCH 9/9] gfs2: time journal recovery steps accurately

hi Das <a...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/recovery.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c index b6b258998bcd..d8b622c375ab 100644 --- a/fs/gfs2/recovery.c +++ b/

[Cluster-devel] [PATCH 7/9] gfs2: Check for the end of metadata in punch_hole

he end of the inode's metadata. Fixes xfstest generic/476. Debugged-by: Bob Peterson <rpete...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 10 +- 1 file changed, 9 insertions(+), 1 dele

[Cluster-devel] [PATCH 8/9] gfs2: Zero out fallocated blocks in fallocate_chunk

bacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> Acked-by: Christoph Hellwig <h...@lst.de> --- fs/gfs2/bmap.c | 13 - fs/gfs2/file.c | 29 ++--- fs/gfs2/incore.h | 3 --- 3 files changed, 14 insertions(+), 31 delet

[Cluster-devel] [PATCH 1/9] gfs2: Fix fallocate chunk size

group won't spill over into another resource group. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/file.c | 5 +++-- fs/gfs2/quota.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/gfs2

[Cluster-devel] [PATCH 0/9] GFS2: Pre-pull patch posting (merge window)

set PageChecked for jdata page writes. Regards, Bob Peterson --- Abhi Das (1): gfs2: time journal recovery steps accurately Andreas Gruenbacher (6): gfs2: Fix fallocate chunk size gfs2: Dirty source inode during rename gfs2: Improve gfs2_block_map comment gfs2: gfs2_iomap_end tracepoint

[Cluster-devel] [PATCH 4/9] GFS2: Only set PageChecked for jdata pages

Before this patch, GFS2 was setting the PageChecked flag for ordered write pages. This is unnecessary. The ext3 file system only does it for jdata, and it's only used in jdata circumstances. It only muddies the already murky waters of writing pages in the aops. Signed-off-by: Bob Peterson <rp

[Cluster-devel] [PATCH 3/9] GFS2: Make function gfs2_remove_from_ail static

Function gfs2_remove_from_ail is only ever used from log.c, so there is no reason to declare it extern. This patch removes the extern and declares it static. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/log.c | 2 +- fs/gfs2/log.h | 1 - 2 files changed, 1 insertion

Re: [Cluster-devel] [PATCH] gfs2: time journal recovery steps accurately

d-off-by: Abhi Das <a...@redhat.com> > --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=5e86d9d122d0d6fae00d9dff41c22d6f4d09f566 Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Zero out fallocated blocks in fallocate_chunk

<agrue...@redhat.com> | --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=fffb64127adc3eea6a19ceefdc88d171f68b9d34 Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Check for the end of metadata in punch_hole

of the inode's metadata. | | Fixes xfstest generic/476. | | Debugged-by: Bob Peterson <rpete...@redhat.com> | Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> | --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [Cluster-devel] [PATCH] gfs2: gfs2_iomap_end tracepoint: log block address

-) Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=ee6ed857c8058177614b21a0efbf27e02c4e2a77 Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] GFS2: Please pull patch tagged gfs2-4.16.rc4.fixes

Hi Linus, Would you please pull this additional patch from Andreas Gruenbacher that fixes another unfortunate GFS2 regression? Thanks. Bob Peterson --- The following changes since commit 86f84779d8e92a690b2f281175ea06b884cb6fa4: Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm

Re: [Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups

any basic operations at all. So just make sure all the tools are tested for base functionality, if you haven't already. Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 18/20] libgfs2: Don't use buffer_heads in gfs2_quota_change_{in, out}

- Original Message - | Signed-off-by: Andrew Price | --- | gfs2/edit/gfs2hex.c| 2 +- | gfs2/libgfs2/libgfs2.h | 6 ++ | gfs2/libgfs2/ondisk.c | 20 | 3 files changed, 11 insertions(+), 17 deletions(-) Hi, Function

Re: [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out}

- Original Message - | Signed-off-by: Andrew Price | --- | gfs2/edit/gfs2hex.c| 2 +- | gfs2/edit/journal.c| 21 + | gfs2/libgfs2/libgfs2.h | 6 ++ | gfs2/libgfs2/ondisk.c | 15 ++- | 4 files changed, 18 insertions(+), 26

Re: [Cluster-devel] [PATCH] fsck.gfs2: Don't check lh_crc for older filesystems

- Original Message - | This fixes the case where fsck.gfs2 is built against v2 log headers but | the filesystem pre-dates them and so lh_crc is 0. | | Signed-off-by: Andrew Price <anpr...@redhat.com> | --- Hi, Yes, that looks right. ACK. Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Improve gfs2_block_map comment

ub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=b4be3a33a2dba81fd2b0d63f089c49f119d1000b Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map" (2)

it/commit/fs/gfs2?h=for-next=dc49cacbdc4eecae05713c03e3ab6ac0b7c06c1c Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Dirty source inode during rename

ged, 3 insertions(+), 20 deletions(-) Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=e49f900d6e610ba6c9e6138f132eb37e91bddb37 Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size

2?h=for-next=3fc7c7e1cfaac17cb7b0bfd54e5abf9b1ef2b819 Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Fsync parent directories

tories as well as files? Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] GFS2: Only set PageChecked for jdata pages

Hi, Before this patch, GFS2 was setting the PageChecked flag for ordered write pages. This is unnecessary. The ext3 file system only does it for jdata, and it's only used in jdata circumstances. It only muddies the already murky waters of writing pages in the aops. Signed-off-by: Bob Peterson

[Cluster-devel] GFS2: Don't assign b_private until we know it's safe

lse assigned the value after the proper locks have been restored. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/trans.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c index c75cacaa349b..32debf17c8

[Cluster-devel] GFS2: Please pull patch tagged gfs2-4.16.rc1.fixes

Hi Linus, Would you please pull this one-off patch from Andreas Gruenbacher that fixes a GFS2 regression? Thanks. Bob Peterson --- The following changes since commit 35277995e17919ab838beae765f440674e8576eb: Merge branch 'x86-pti-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git

Re: [Cluster-devel] [PATCH v2] mkfs.gfs2: Scale down journal size for smaller devices

ournal. Writing to a fragmented journal then becomes a slow-down because the journal extent map needed to reference it becomes complex, and it's used for every journal block written. Regards Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map"

://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=49edd5bf429c405b3a7f75503845d9f66a47dd4b Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] mkfs.gfs2: Scale down journal size for smaller devices

is 8MB that means we effectively get a hard minimum file | system size of 32MB (per journal). | | Signed-off-by: Andrew Price <anpr...@redhat.com> | --- Hi, Looks good to me. ACK. Bob Peterson Red Hat File Systems

[Cluster-devel] GFS2: Patches pulled, linux-gfs2.git for-next rebased (again)

Hi, Linus has pulled our second set of patches from the for-next branch of the linux-gfs2.git tree, so I rebased the tree from Linus's master again. So the current tree is back to having no unmerged GFS2 patches. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] GFS2: Second Pull request (merge window)

Hi Linus, Sorry to bother you with a second merge request for GFS2, but we found a couple regressions and want to get them fixed in this merge window. Please consider pulling the following changes for the GFS2 file system. Regards, Bob Peterson

Re: [Cluster-devel] [PATCH] gfs2: Fix the crc32c dependency

-by: Andreas Gruenbacher <agrue...@redhat.com> | --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs?h=for-next=dcb2cd55cf43fe06ada66265c1e088a4b08d3e3d Regards, Bob Peterson Red Ha

Re: [Cluster-devel] [PATCH] gfs2: Glock dump performance regression fix

it/fs?h=for-next=7ac07fdaf840f9b141c6d5c286805107227c0e68 I did change one small thing: "} else" to "} else {" ... "}" Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] GFS2: Patches pulled, linux-gfs2.git for-next rebased

Hi, Linus has pulled the latest set of patches from the for-next branch of the linux-gfs2.git tree, so I rebased the tree from Linus's master. So the current tree is back to having no unmerged GFS2 patches. Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] gfs2: Add a few missing newlines in messages

ged, 5 insertions(+), 5 deletions(-) Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=af38816e4801d2868258085831172a003d1634ff Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Remove inode from ordered write list in gfs2_write_inode()

. | | Signed-off-by: Abhi Das <a...@redhat.com> | --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=957a7acd46e64c52d2a1d59cd7273ed49455afb6 Regards, Bob Peterson Red Ha

[Cluster-devel] GFS2: Don't try to end a non-existent transaction in unlink

/gfs2/trans.c:117! This patch changes the goto so that it does not try to end a non-existent transaction. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 202819

[Cluster-devel] [PATCH 19/27] gfs2: Turn trunc_dealloc into punch_hole

edhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 179 ++--- 1 file changed, 120 insertions(+), 59 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 8fd42ae026dd..f6dbd2f400cc 100644 --- a/fs/gf

[Cluster-devel] [PATCH 25/27] GFS2: Introduce new gfs2_log_header_v2

for future expansion. This patch is based on a prototype from Steve Whitehouse. Signed-off-by: Bob Peterson <rpete...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> --- fs/gfs2/Kconfig | 2 ++ fs/gfs2/aops.c | 2 +- fs

[Cluster-devel] [PATCH 07/27] GFS2: Reduce code redundancy writing log headers

function and iomap rather than redundancy and block_map (and eventually we can maybe remove block_map). It also reduces our dependency on buffer_heads. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/log.c | 46 +- fs/gfs2/log.h

[Cluster-devel] [PATCH 21/27] gfs2: Typo fixes

From: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/aops.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/aops.c b/fs

[Cluster-devel] [PATCH 24/27] gfs2: Get rid of gfs2_log_header_in

letely useless. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/incore.h | 1 - fs/gfs2/log.c | 2 +- fs/gfs2/recovery.c | 44 3 files changed, 17 insertion

[Cluster-devel] [PATCH 05/27] gfs2: Add rindex fields to rgrp headers

mixed kernels, these fields could get zeroed after being set and this should not be treated as an error. Signed-off-by: Andrew Price <anpr...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 5 + include/uapi/linux/gfs2_ondisk.h |

[Cluster-devel] [PATCH 17/27] Turn gfs2_block_truncate_page into gfs2_block_zero_range

a hole in a file. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 1c964def34fd..c

[Cluster-devel] [PATCH 23/27] gfs2: Minor gfs2_page_add_databufs cleanup

ndreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/aops.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 38e403a9e543..ac4a1e89da1e 100644 --- a/fs/gfs2/aops.c ++

[Cluster-devel] [PATCH 12/27] gfs2: truncate: Remove unnecessary oldsize parameters

From: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/gfs2/bmap.

[Cluster-devel] [PATCH 14/27] gfs2: Clean up {lookup, fillup}_metapath

uenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 74 -- 1 file changed, 30 insertions(+), 44 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index de0c3e3c1374

[Cluster-devel] [PATCH 18/27] gfs2: Generalize truncate code

_rgrps, move the code for looking up the resource group descriptor of the current resource group out of the inner loop. The metatype check moves to trunc_dealloc. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs

[Cluster-devel] [PATCH 04/27] gfs2: Add a next-resource-group pointer to resource groups

cupied by the rg_reserved field would have resulted in the same problem as it is also explicitly zeroed, so unfortunately there is no other way around it. Signed-off-by: Andrew Price <anpr...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 6 ++

[Cluster-devel] [PATCH 03/27] gfs2: Remove unused gfs2_write_jdata_pagevec parameter

From: Andreas Gruenbacher <agrue...@redhat.com> As a follow-up to commit d2bc5b3c67a9, remove the end parameter which is now unused. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/aops.c | 5 ++---

[Cluster-devel] [PATCH 16/27] gfs2: Improve non-recursive delete algorithm

ndreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 51 +++ 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index e983b5872679..1c964def34

[Cluster-devel] [PATCH 27/27] GFS2: Fix minor comment typo

Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/lops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 4a60221c678f..4d6567990baf 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -162,7 +162,7 @@ u64 gfs2_log_bmap(

[Cluster-devel] [PATCH 09/27] gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use

eas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 2 +- fs/gfs2/rgrp.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index d5f0d96169c5..8b993e4d80b2 100644 --- a/f

[Cluster-devel] [PATCH 26/27] GFS2: Log the reason for log flushes in every log header

This patch just adds the capability for GFS2 to track which function called gfs2_log_flush. This should make it easier to diagnose problems based on the sequence of events found in the journals. Signed-off-by: Bob Peterson <rpete...@redhat.com> Reviewed-by: Andreas Gruenbacher

[Cluster-devel] [PATCH 01/27] GFS2: Combine gfs2_free_di with gfs2_free_uninit_di

did a quota-change operation and meta_wipe despite the error. This patch combines the two functions into one to make the code more readable and fixes the bug by returning from the combined function before it takes those next incorrect steps. Signed-off-by: Bob Peterson <rpete...@redhat.

[Cluster-devel] [PATCH 11/27] gfs2: Clean up trunc_start error path

From: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs

[Cluster-devel] [PATCH 20/27] gfs2: Implement fallocate(FALLOC_FL_PUNCH_HOLE)

From: Andreas Gruenbacher <agrue...@redhat.com> Implement the top-level bits of punching a hole into a file. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs

[Cluster-devel] [PATCH 22/27] gfs2: Add gfs2_max_stuffed_size

From: Andreas Gruenbacher <agrue...@redhat.com> Add a small inline function for computing the maximum size of a stuffed inode instead of open coding that in several places throughout the code. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Pet

[Cluster-devel] [PATCH 15/27] gfs2: Fix metadata read-ahead during truncate

m> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/bmap.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 1110aa9f6f31..e983b5872679 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2

[Cluster-devel] [PATCH 06/27] gfs2: Add a crc field to resource group headers

gnored (or updated with an accurate value). Signed-off-by: Andrew Price <anpr...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 5 + include/uapi/linux/gfs2_ondisk.h | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) di

[Cluster-devel] [PATCH 10/27] gfs2: Remove pointless BUG_ON

From: Andreas Gruenbacher <agrue...@redhat.com> The current transaction is being dereferenced before asserting that is not NULL; that isn't going to help. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/tra

[Cluster-devel] [PATCH 13/27] gfs2: Remove minor gfs2_journaled_truncate inefficiencies

loops through them. For each chunk of a hole, it creates a new transaction. At least avoid creating another transactions whe the current one is still empty. (An better fix would be to skip large holes, of course.) Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by:

[Cluster-devel] [PATCH 00/27] GFS2: Pre-pull patch posting (merge window)

that fixes incorrect error handling in function init_gfs2_fs. Regards, Bob Peterson --- Abhi Das (1): gfs2: Trim the ordered write list in gfs2_ordered_write() Andreas Gruenbacher (16): gfs2: Remove unused gfs2_write_jdata_pagevec parameter gfs2: Remove pointless BUG_ON gfs2: Clean up

[Cluster-devel] [PATCH 08/27] gfs2: Trim the ordered write list in gfs2_ordered_write()

n Whitehouse <swhit...@redhat.com> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/log.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 27e97d3de1e0..b9889ae5fd7c 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@

[Cluster-devel] [PATCH 02/27] gfs2: Fix wrong error handling in init_gfs2_fs()

-ker...@i-love.sakura.ne.jp> Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/main.c | 90 -- 1 file changed, 44 insertions(+), 46 deletions(-) diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index 0a89e6f7a314..2d55e2cc 10

Re: [Cluster-devel] [PATCH v2 0/3] gfs2: Add new resource group header fields

| gfs2: Add a crc field to resource group headers https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=850d2d915fa69011bef9bd668499cce889fdd8b3 So yes, they should go into the next merge window. Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [GFS2 PATCH 2/2] GFS2: Split gfs2_rgrp_congested into inter-node and intra-node cases

the reference to HZ from the first patch: good call. I still see no reason to throw away the second patch, at least while we work on a longer-term solution. Regards, Bob Peterson Red Hat File Systems nohup: ignoring input nohup: ignoring

Re: [Cluster-devel] [GFS2 PATCH 2/2] GFS2: Split gfs2_rgrp_congested into inter-node and intra-node cases

ses to share an rgrp while its glock is held in EXclusive mode. As always, I'm open to more ideas on how to improve this. Regards, Bob Peterson

[Cluster-devel] [GFS2 PATCH 2/2] GFS2: Split gfs2_rgrp_congested into inter-node and intra-node cases

in the intra-node sense. If there is not intra-node congestion, and the locking protocol is lock_dlm, we need to check the locking statistics to see if there is any inter-node congestion. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.

[Cluster-devel] [GFS2 PATCH 1/2] GFS2: Simplify gfs2_rgrp_used_recently

This patch simplifies function gfs2_rgrp_used_recently. Now it uses ktime functions to do its calculations. Also, it's called with the rgrp rather than the reservation, and the constant HZ rather than the hard-coded value 1000. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/

[Cluster-devel] [GFS2 PATCH 0/2] GFS2: Rework rgrp glock congestion functions for intra-node

ent better throughput with the patches. At 16 concurrent processes, the overall throughput is more than double, although that number may be skewed by the fact that I've got 2 sockets, each of which has 8 cores, and some of the cores are used by the driver and its monitoring. --- Bob Peterson (

Re: [Cluster-devel] [PATCH 00/12] gfs2: punch hole

into punch_hole 9da8249e14da Andreas Gruenbacher gfs2: Implement fallocate(FALLOC_FL_PUNCH_HOLE) Regards, Bob Peterson

Re: [Cluster-devel] [GFS2 PATCH 3/6] GFS2: Refactor function fast_to_acquire

? Bob - Original Message - | Hi, | | | On 10/01/18 20:42, Bob Peterson wrote: | > Function fast_to_acquire determines if a rgrp ought to be fast to | > acquire, but the logic was cryptic. This patch makes the logic more | > straightforward: | > | > 1. If the rgrp is o

Re: [Cluster-devel] [GFS2 PATCH 3/6] GFS2: Refactor function fast_to_acquire

Hi, - Original Message - | Hi, | | | On 10/01/18 20:42, Bob Peterson wrote: | > Function fast_to_acquire determines if a rgrp ought to be fast to | > acquire, but the logic was cryptic. This patch makes the logic more | > straightforward: | > | > 1. If the rgrp is one of

Re: [Cluster-devel] [GFS2 PATCH 2/6] GFS2: Check gfs2_rgrp_used_recently inside gfs2_rgrp_congested

Hi, - Original Message - | Hi, | | | On 10/01/18 20:42, Bob Peterson wrote: | > Function gfs2_rgrp_congested is called in two places: once before | > we acquire the rgrp glock, and once after. The first time, it checks | > to see if the rgrp was used recently because

[Cluster-devel] [GFS2 PATCH 4/6] GFS2: Simplify by checking fast_to_acquire in gfs2_rgrp_congested

, but not the second, and it applies equally to both calls. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 68 +- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index fa72e3

[Cluster-devel] [GFS2 PATCH 3/6] GFS2: Refactor function fast_to_acquire

to wait for another process to dequeue before we get our turn. 4. If the glock is being demoted, consider it slow. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/fs/gfs2/rgrp.c

[Cluster-devel] [GFS2 PATCH 1/6] GFS2: Simplify gfs2_rgrp_used_recently

This patch simplifies function gfs2_rgrp_used_recently. Now it uses ktime functions to do its calculations. Also, it's called with the rgrp rather than the reservation, and the constant HZ rather than the hard-coded value 1000. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/

[Cluster-devel] [GFS2 PATCH 2/6] GFS2: Check gfs2_rgrp_used_recently inside gfs2_rgrp_congested

, for the same reason. This patch simply moves function gfs2_rgrp_used_recently before function gfs2_rgrp_congested, and it's now called from there so it applies equally to both checks. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.

[Cluster-devel] [GFS2 PATCH 0/6] [resend] GFS2: Rework rgrp glock congestion functions for intra-node

I did find a minor problem with the previous version's logic, and fixed it. I retested iozone performance and fragmentation. It is pretty much the same as I documented for the previous patch: Bob Peterson (6): GFS2: Simplify gfs2_rgrp_used_recently GFS2: Check gfs2_rgrp_used_recen

[Cluster-devel] [GFS2 PATCH 6/6] GFS2: Add checks for intra-node congestion

reservation, we know it is for a different inode: if it was for ours, we would have been forced to use it and we would not be searching for a new one. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 43 --- 1 file changed, 40 insertions

[Cluster-devel] [GFS2 PATCH 5/6] GFS2: Split gfs2_rgrp_congested into dlm and non-dlm cases

gfs2_rgrp_congested. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/rgrp.c | 128 ++--- 1 file changed, 85 insertions(+), 43 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 9d5f35b01c1d..641bb4a8cf5b 100644 --- a/fs/gfs2/

Re: [Cluster-devel] [PATCH 10/12] gfs2: Generalize truncate code

inode_buffer here instead of just using the copy we already have in the metapath. It seems to me this method would be a lot less efficient. Can you explain? Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 05/12] gfs2: Remove minor gfs2_journaled_truncate inefficiencies

_trans_end does for determining whether the transaction was actually used. Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 03/12] gfs2: Clean up trunc_start error path

an error, it has released the | buffer_head already. | | Regards, | | Bob Peterson | Red Hat File Systems Never mind. It's not a double-brelse because dibh will still be NULL, and brelse(NULL) is a no-op. Bob Peterson

Re: [Cluster-devel] [PATCH 03/12] gfs2: Clean up trunc_start error path

this returns an error, we'll do double brelse in out. If gfs2_meta_inode_buffer returns an error, it has released the buffer_head already. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2 PATCH] [v2] GFS2: Log the reason for log flushes in every log header

and enhance that at a later time. Regards, Bob --- This patch just adds the capability for GFS2 to track which function called gfs2_log_flush. This should make it easier to diagnose problems based on the sequence of events found in the journals. Signed-off-by: Bob Peterson <rpete...@redhat.

[Cluster-devel] [GFS2 PATCH][v4] GFS2: Introduce new gfs2_log_header_v2

Hi, Here is a revised version 4 of the log_header_v2 patch. It incorporates changes suggested by Steve Whitehouse, namely, to pass the journal descriptor to write_log_header and also to record the destination journal's inode rather than the caller's journal inode number. Regards, Bob Peterson

Re: [Cluster-devel] [GFS2 PATCH][v3] GFS2: Introduce new gfs2_log_header_v2

from which we can deduce the journal's inode address based on the inode's mapping. But what was the original intent? I suppose we could keep both, since all nodes look up the inode of every journal. Thoughts? Bob Peterson

Re: [Cluster-devel] [GFS2 PATCH][v3] GFS2: Introduce new gfs2_log_header_v2

that has been | recovered. Otherwise though, the patch looks good, | | Steve. Good catch. Here is a revised patch that hopefully takes this into account. Regards, Bob Peterson --- This patch adds a new structure called gfs2_log_header_v2 which is used to store expanded fields into previously

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

the accepted Linux coding style document. See: | | https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings | | Regards, | | Bob Peterson | | Hm. I guess I stand corrected. The document reads: "However, never break user-visible strings such as printk mes

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings Regards, Bob Peterson

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Trim the ordered write list in gfs2_ordered_write()

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=1f23bc7869fffec40b8bd9333a74a18d1de54d98 Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2 PATCH][v2] GFS2: Introduce new gfs2_log_header_v2

, user space (gfs2-utils), or one of the log flush operations. Signed-off-by: Bob Peterson <rpete...@redhat.com> --- fs/gfs2/aops.c | 2 +- fs/gfs2/file.c | 3 ++- fs/gfs2/glops.c | 13 ++- fs/gfs2/log.c

[Cluster-devel] [GFS2 PATCH][v2] GFS2: Reduce code redundancy writing log headers

Hi, This is a new improved version of the patch I posted prematurely yesterday. I've found and fixed the bug I encountered, plus simplified things a lot. Bob Peterson --- Before this patch, there was a lot of code redundancy between functions log_write_header (which uses bio) and clean_journal

[Cluster-devel] [GFS2 PATCH] GFS2: Reduce code redundancy writing log headers

clean_journal() to use the new helper function and iomap rather than redundancy and block_map (and eventually we can maybe remove block_map). (2) It adds new error checking of the bio request, if told to wait for IO completion. (3) It reduces the dependency on buffer_heads. Signed-off-by: Bob

Re: [Cluster-devel] [PATCH v2 0/3] gfs2: Add new resource group header fields

=166725d96322473305e35f9d580591a01697ab29 gfs2: Add a crc field to resource group headersfor-next https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next=850d2d915fa69011bef9bd668499cce889fdd8b3 Regards, Bob Peterson Red Hat File Systems

<    5   6   7   8   9   10   11   12   13   14   >