Re: [cmake-developers] What is necessary for including fixes from current development branch to official release

2014-09-19 Thread Jiri Malak
On 09/19/2014 12:40 PM, Jiri Malak wrote: OK, but it was accepted before v3.0.0 was released. Do you know what rules are applied for selection what will be in new release and what cutoff date for it? On Feb. 19 2014 Brad announced the cutoff [1]. So everything that was in master before

Re: [cmake-developers] What is necessary for including fixes from current development branch to official release

2014-09-19 Thread Jiri Malak
On 09/19/2014 01:57 PM, Jiri Malak wrote: Thanks for info. It is clear, it was too late to be included to 3.0. Do you have any idea when version 3.1 first release candidate is planned? Mantis (the issue tracker) currently has 3.1 scheduled for 2014-11-01. For now I'd take it as a non

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Jiri Malak
I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text and as variable name. So this does what you expect for the moment: if

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Jiri Malak
Am Sonntag, 13. April 2014, 09:59:03 schrieb Jiri Malak: I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text

[cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-12 Thread Jiri Malak
Hi, I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. Regards JiriFrom e2a1f5490002c3479a1e637ae584d7c23a08561d Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sun, 13 Apr 2014 06:55:17 +0200 Subject: [PATCH] remove x

[cmake-developers] [PATCH] Use single quote for all file/path items in Watcom linker command

2014-04-04 Thread Jiri Malak
Hi, I enclosed patch to support correct quoting for Watcom linker. Single quote quoting is necessary also for target name, library names and libraries search path. This patch fix it. Regards JiriFrom 5bde9fa6aefe7560a07b188e522ef5305a8a6b20 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-04-01 Thread Jiri Malak
master. Regards Jiri From 9c9176806df26e5a7f6c9e839091434af3cbec0b Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Tue, 1 Apr 2014 21:20:41 +0200 Subject: [PATCH] cleanup Watcom Windows configuration remove Watcom linker caseexact options already defined in system definition

[cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
871c36f7d7cb42147ba5c9c5cb9bdf8d83384078 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Thu, 27 Mar 2014 15:20:23 +0100 Subject: [PATCH] cleanup Watcom Windows configuration remove Watcom linker caseexact options already defined in system definition use win_dll system for SHARED_LIBRARY and SHARED_MODULE use

Re: [cmake-developers] wlink command-line parsing

2014-03-27 Thread Jiri Malak
I did it. New patch is enclosed. Regards Jiri On 03/26/2014 06:38 PM, Jiri Malak wrote: It is correct version of patch. Thanks. + if( useSingleQuote) +{ +#if defined(_WIN32) !defined(__CYGWIN__) +result = '; +#else +result = \'; +#endif This quoting style is now very

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
OK. I will do it as soon as it will be possible. Jiri On 03/27/2014 10:47 AM, Jiri Malak wrote: I atached patch which cleanup Watcom Windows configuration Thanks. Since this touches Windows-wcl386.cmake it is tangled with the link line quoting change. Once that is in 'master' please

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
On Thu, Mar 27, 2014 at 7:47 AM, Jiri Malak malak.j...@gmail.com wrote: I atached patch which cleanup Watcom Windows configuration It includes following changes. remove Watcom linker caseexact options already defined in linker system definition what do you mean 'defined in linker system

Re: [cmake-developers] [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable

2014-03-26 Thread Jiri Malak
AM, Jiri Malak wrote: Sorry, previous patch has bug. I enclosed corrected version of patch. Thanks. I split the commit in two pieces to simplify review and applied them here: cmLocalUnixMakefileGenerator3: Re-organize ConvertToQuotedOutputPath http://cmake.org/gitweb?p=cmake.git

Re: [cmake-developers] [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable

2014-03-26 Thread Jiri Malak
If name contains space than it is not processed correctly by watcom linker. It must be single quoted. Jiri On 03/26/2014 01:06 PM, Jiri Malak wrote: I have a note to description Generate single-quoted linker lines for Watcom on Windows should be Generate single-quoted linker lines

Re: [cmake-developers] [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable

2014-03-26 Thread Jiri Malak
, Jiri Malak wrote: If name contains space than it is not processed correctly by watcom linker. It must be single quoted. Does that mean that on Linux one must use '/path with space/to/src.o' so that the linker literally sees single quotes in argv[] values? -Brad -- Powered

Re: [cmake-developers] wlink command-line parsing

2014-03-26 Thread Jiri Malak
Sorry for my English. I am not sure if I understand correctly. For unix like system cmdl is reconstruct from argv by aproximation one space as separator between each item. Next is processed as characters stream. Jiri On 03/26/2014 01:59 PM, Jiri Malak wrote: watcom linker have one cmdl syntax

Re: [cmake-developers] wlink command-line parsing

2014-03-26 Thread Jiri Malak
I enclosed fix for POSIX hosts, based on commit 13182cd6. Regards Jiri On 03/26/2014 03:39 PM, Jiri Malak wrote: You are right, I will sent next patch for POSIX platforms. Thanks. Please base work on commit 13182cd6 to make it easy for me to apply the patch. -Brad From

Re: [cmake-developers] wlink command-line parsing

2014-03-26 Thread Jiri Malak
It is correct version of patch. JiriFrom 9d0913c8b136c8ee6dd32c1bdc0e11f22e37b82f Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Wed, 26 Mar 2014 23:34:17 +0100 Subject: [PATCH] Correct single quote processing for Watcom linker on POSIX hosts. --- Source

Re: [cmake-developers] [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable

2014-03-25 Thread Jiri Malak
Sorry, previous patch has bug. I enclosed corrected version of patch. JiriFrom 8619dc83bda0232bfca970f66d0ff87c82dd7cd2 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Tue, 25 Mar 2014 07:17:45 +0100 Subject: [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable remove

[cmake-developers] [PATCH] remove useless quoting for linker flags if LDFLAGS environment variable is not setup

2014-03-24 Thread Jiri Malak
Hi, I enclosed patch for minor problem with useless quotes used in cache file. Regards JiriFrom 6b9ac1e6affe4233008e4f99decfe8fddc941466 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Mon, 24 Mar 2014 12:33:11 +0100 Subject: [PATCH] remove useless quoting for linker flags

[cmake-developers] [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable

2014-03-24 Thread Jiri Malak
this problem. Regards JiriFrom 7938361fb2e4cec813392aa441f31d1b7d1f608e Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Mon, 24 Mar 2014 15:50:26 +0100 Subject: [PATCH] remove CMAKE_NO_QUOTED_OBJECTS variable remove CMAKE_NO_QUOTED_OBJECTS from make file generator because it fix

[cmake-developers] Generator rule parameters question

2014-03-20 Thread Jiri Malak
Hi, Watcom linker need pass resource files (.res) as extra item. Is it possible to get in generator rules separated list of resource files (.res) and separate list of object files (.obj/.o)? Jiri -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

[cmake-developers] Request for comment [PATCH] add full cross-compile support for Open Watcom toolchain

2014-03-19 Thread Jiri Malak
Hi, I prepared first version of full cross-compile support for Open Watcom toolchain. It contains base C and C++ language support, not assembler and Windows/OS2 Resource support, it I will add later. First part includes only necessary changes to core CMake. Second part is new

[cmake-developers] Request for comment [PATCH] add full cross-compile support for Open Watcom toolchain

2014-03-19 Thread Jiri Malak
/definitions for support all target - DOS, OS2, Windows3x(16-bit), Windows(32-bit), Linux(32-bit x86). Thanks for any comments or hints. Regards JiriFrom 580c13027e032f182103080d06dccd472209eff9 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Wed, 19 Mar 2014 11:28:57 +0100 Subject

Re: [cmake-developers] Request for comment [PATCH] add full cross-compile support for Open Watcom toolchain

2014-03-19 Thread Jiri Malak
New corrected version of patches. JiriFrom d746502d866e85d62611265dce6237d829f780a3 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Wed, 19 Mar 2014 14:05:55 +0100 Subject: [PATCH 1/2] Add full cross-compile support for Open Watcom toolchain - code changes --- Modules

Re: [cmake-developers] [PATCH] Enable Wmake generator on Linux host

2014-03-17 Thread Jiri Malak
Brad, I attached corrected patch. Regards Jiri On 03/16/2014 07:43 AM, Jiri Malak wrote: I enclosed patch, which enable generation of wmake makefiles on Linux host. The CMake condition if(WIN32 OR UNIX AND NOT APPLE) and the preprocessor condition #if defined(_WIN32) || defined

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-17 Thread Jiri Malak
versions. I add for second patch more platforms. Regards Jiri On 03/14/2014 02:27 PM, Jiri Malak wrote: I enclosed both patches. Thanks. Here are some more comments. The version extraction logic is currently: + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ +# define

[cmake-developers] [PATCH] add one blank line to output Wmake makefile for better readability

2014-03-16 Thread Jiri Malak
I enclosed patch for cosmetic change of output Wmake makefiles. JiriFrom 2378bb8236317b610963c28af5d9bc41650f4042 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sun, 16 Mar 2014 12:35:18 +0100 Subject: [PATCH 1/2] add one blank line to makefile for better readability

[cmake-developers] [PATCH] Enable Wmake generator on Linux host

2014-03-16 Thread Jiri Malak
I enclosed patch, which enable generation of wmake makefiles on Linux host. Regards JiriFrom 7e3d5e03fe82ad48e404140314b6c1d81ad124ef Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sun, 16 Mar 2014 12:36:09 +0100 Subject: [PATCH 2/2] Enable WMake generator on Linux

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-14 Thread Jiri Malak
I enclosed patch to fix COMPILER_VERSION variable value for Open Watcom compilers to be real version, not internal number. [snip] + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ What do you think about changing the compiler id to OpenWatcom? Thanks, -Brad It can be changed, I am using

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-14 Thread Jiri Malak
I enclosed patch to fix COMPILER_VERSION variable value for Open Watcom compilers to be real version, not internal number. [snip] + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ What do you think about changing the compiler id to OpenWatcom? It can be changed, I am using Watcom as simple

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-14 Thread Jiri Malak
My concern is that we've reported CMAKE_C_COMPILER_ID as Watcom along with CMAKE_C_COMPILER_VERSION holding numbers like 12.x for a long time. Projects may have logic that switches off these version values when they see the id is Watcom. By changing to OpenWatcom we get a more accurate

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-14 Thread Jiri Malak
I enclosed both patches. Regards JiriFrom 64effa52febef30653e5c4deb6a6df114e543eb1 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Fri, 14 Mar 2014 18:42:58 +0100 Subject: [PATCH 1/2] Corrections for Open Watcom compiler version Add new compiler ID OpenWatcom for Open

[cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-13 Thread Jiri Malak
:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Thu, 13 Mar 2014 22:05:22 +0100 Subject: [PATCH] Correct platform related variables for Open Watcom compilers correct COMPILER_VERSION variable to hold real Open Watcom compiler version Fill ARCHITECTURE_ID and PLATFORM_ID variables for Open

[cmake-developers] [PATCH] fix incorrect handling of WMake verbose output

2014-03-09 Thread Jiri Malak
Hi, I enclosed patch to fix WMake verbose/silent output. Regards JiriFrom a581a7538bcbd749a0a704beabdc52665af07970 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sun, 9 Mar 2014 10:41:06 +0100 Subject: [PATCH] fix incorrect handling of WMake verbose output -e option has

[cmake-developers] [Patch] fix archive library build by Open Watcom

2014-03-05 Thread Jiri Malak
Hi, I enclosed fix for archive library (Utility) build by Open Watcom Regards JiriFrom 7bf955a4f1ffb5117063e17023d74fb11edf30a5 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Tue, 4 Mar 2014 16:35:44 +0100 Subject: [PATCH] fix archive library build by Open Watcom

Re: [cmake-developers] [Patch] Remove hard coded version of RTDLL for Open Watcom

2014-03-04 Thread Jiri Malak
On 03/03/2014 03:43 PM, Jiri Malak wrote: I enclosed new updated version of patch. It contains change of InstallRequiredSystemLibraries only. Thanks. The lines: set(_watcom_major ${_watcom_major} - 11) ... set(_watcom_minor ${_watcom_minor} / 10) should use math(EXPR) to do

Re: [cmake-developers] [Patch] Remove hard coded version of RTDLL for Open Watcom

2014-03-04 Thread Jiri Malak
On 03/04/2014 10:46 AM, Jiri Malak wrote: On 03/03/2014 03:43 PM, Jiri Malak wrote: should use math(EXPR) to do numerical computation. I fixed it now. Applied, thanks: Remove hard-coded version of RTDLL for Open Watcom http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ee01b7ee -Brad

Re: [cmake-developers] Question about cross-compilation concept in CMake

2014-03-03 Thread Jiri Malak
On 03/01/2014 08:53 AM, Jiri Malak wrote: I am working on full cross-compilation stuff for Open Watcom toolchain in CMake. I study CMake internals, but I am not sure what is prefered method for cross-compilation by CMake. I see two concept one for Microsoft compilers where each target

Re: [cmake-developers] [Patch] Remove hard coded version of RTDLL for Open Watcom

2014-03-03 Thread Jiri Malak
On 02/28/2014 09:47 PM, Jiri Malak wrote: remove hardcoded version number for RTDLL. It is derived from compiler version now Good, thanks. Just a couple comments: The patch seems to make some unrelated whitespace changes. Please factor those out into a separate commit. The WATCOMNN

[cmake-developers] [Patch] Update to documentation, variables description]

2014-03-01 Thread Jiri Malak
Hi, I enclosed patch with update to CMake documentation, correct HOST/TARGET system related variables description. Regards JiriFrom 7aae7428941581dd7199dfdb9325fd5cc599bed6 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sat, 1 Mar 2014 13:24:27 +0100 Subject: [PATCH

[cmake-developers] Question about cross-compilation concept in CMake

2014-03-01 Thread Jiri Malak
Hi, I am working on full cross-compilation stuff for Open Watcom toolchain in CMake. I study CMake internals, but I am not sure what is prefered method for cross-compilation by CMake. I see two concept one for Microsoft compilers where each target platform has own generator and second one is

Re: [cmake-developers] Cmake contribution for Open Watcom (patch)

2014-02-28 Thread Jiri Malak
Thanks! I've integrated the first change for testing here: Watcom: Fix static library name quoting for wlib http://cmake.org/gitweb?p=cmake.git;a=commitdiff;hb=5c5be193 with one tweak: -set(CMAKE_CXX_CREATE_STATIC_LIBRARY wlib ${CMAKE_LIB_QUIET} -c -n -b 'TARGET_UNQUOTED'

[cmake-developers] [Patch] Remove hard coded version of RTDLL for Open Watcom

2014-02-28 Thread Jiri Malak
Hi, I enclosed next patch for Open Watcom toolchain, which remove hardcoded version number for RTDLL. It is derived from compiler version now that it will be working with OW version above 1.9. Regards Jiri From d00ad6f72f48575e36a06949cead524f35f56de4 Mon Sep 17 00:00:00 2001 From: Jiri